mirror of
https://github.com/reactos/reactos.git
synced 2024-07-05 12:15:46 +00:00
8266f62ff6
The current _mbtowc_l code directly passes the string count size argument to cbMultiByte argument parameter to MultiByteToWideChar(). As the size of lpMultiByteStr expressed in bytes by cbMultiByte is dependent of the actual given string, the size of lpWideCharStr expressed in characters by cchWideChar is always 1. The resulting parameters to MultiByteToWideChar() will lead to a failure as lpWideCharStr cannot accommodate the converted string if the size pointed by lpMultiByteStr is larger than the buffer wide string to receive the converted output, a Win32 error code of ERROR_INSUFFICIENT_BUFFER in other words. The fact that _mbtowc_l never fails without WINE Gecko package installed is because the codepage pointed by lc_codepage is CP_ACP and the converted output is directly given to the destination wide string parameter thus never calling MultiByteToWideChar(). Installing WINE Gecko merely unhides this problem. As _mbtowc_l is imported from WINE and that they have updated their code (which at the same time this fixes the aforementioned problem), the following commit syncs the updated code from WINE. CORE-16885 |
||
|---|---|---|
| .. | ||
| conio | ||
| direct | ||
| except | ||
| float | ||
| include | ||
| locale | ||
| math | ||
| mbstring | ||
| mem | ||
| misc | ||
| printf | ||
| process | ||
| search | ||
| setjmp | ||
| signal | ||
| startup | ||
| stdio | ||
| stdlib | ||
| string | ||
| sys_stat | ||
| time | ||
| wine | ||
| wstring | ||
| CMakeLists.txt | ||
| crt.cmake | ||
| libcntpr.cmake | ||
| moldname-msvcrt.def | ||
| msvcrtex.cmake | ||
| oldnames-msvcrt.S | ||
| oldnames.cmake | ||
| precomp.h | ||
| README.txt | ||
Big chunks of this CRT library are taken from Wine's msvcrt implementation, you can find a list of synced files in README.WINE file. Notes: 1. When syncing, omit MSVCRT_ prefix where possible, Wine has to keep this because they are linking with *both* original crt, and ms crt implementation. ReactOS has the only CRT, so no need to make distinct functions. 2. ReactOS compiles two versions of the CRT library, one for usermode (called just "crt"), and one version for kernelmode usage (called "libcntpr"). In order to separate the code, you can use #ifdef _LIBCNT_ for libcntpr code.