mirror of
https://github.com/reactos/reactos.git
synced 2024-07-08 21:55:08 +00:00
14599b0a37
This makes ShellMessageBoxW use the correct implementation where the text buffer size is dynamic, instead of having a too small hardcoded size. Fixes CORE-17271. See also PR #3172 by Kyle Katarn, supplemented with some ideas from Mark Jansen. However we cannot straightforwardly implement ShellMessageBoxA around ShellMessageBoxW, by converting some parameters from ANSI to UNICODE, because there may be some variadic ANSI strings, associated with '%s' printf-like formatters inside the format string, that would also need to be converted; however there is no way for us to find these and perform the conversion ourselves. Therefore, we re-implement ShellMessageBoxA by doing a copy-paste ANSI adaptation of the shlwapi.ShellMessageBoxWrapW function. Note that, on Vista+ onwards, shlwapi implements both ShellMessageBoxA/W, and shell32 directly forwards these exports to shlwapi, thus avoiding these workarounds. [PSDK] Explicily use WINAPIV for the variadic ShellMessageBoxA/W functions. [INCLUDE/REACTOS] Add ShellMessageBoxWrapW in shlwapi_undoc.h . |
||
|---|---|---|
| .. | ||
| lang | ||
| assoc.c | ||
| clist.c | ||
| CMakeLists.txt | ||
| istream.c | ||
| msgbox.c | ||
| ordinal.c | ||
| path.c | ||
| precomp.h | ||
| reg.c | ||
| regstream.c | ||
| resource.h | ||
| rosordinal.c | ||
| shlwapi.rc | ||
| shlwapi.spec | ||
| shlwapi_main.c | ||
| shlwapi_ros.diff | ||
| stopwatch.c | ||
| string.c | ||
| thread.c | ||
| url.c | ||
| version.rc | ||
| wsprintf.c | ||