reactos/base/setup/lib/utils
Hermès Bélusca-Maïto 626c654a10
[SETUPLIB][USETUP] Code simplifications & fixes.
SETUPLIB:
=========

- Remove useless HiddenSectors member in PARTENTRY structure.
- InsertDiskRegion() helper returns a BOOLEAN success.
- CreateInsertBlankRegion() helper sets LogicalPartition.

- Simplify the InitializePartitionEntry() helper so that its PartEntry
  parameter is clearly the one that is being initialized (i.e. converted
  from a blank region to) an actual partition, and use the helper
  CreateInsertBlankRegion(). The calculations for the StartSector and
  SectorCount are exactly equivalent with the old version of this
  function. Also make it return a BOOLEAN success instead.
  + Add some extra validation checks.
  + Adjust CreatePrimaryPartition(), CreateExtendedPartition() and
    CreateLogicalPartition() in this regard.

- Better handling of "RAW"-mounted partitions: treat them as
  "Unformatted" only if they are RAW *AND* their PartitionType is one of
  those associated with FAT file-system. Otherwise we cannot decide
  whether they are indeed unformatted or have an unknown file-system on
  them, therefore treat them as the latter.
  In this regard, the IsSupportedActivePartition() helper should not
  look for FileSystem == RAW but instead only look whether the partition
  is Unformatted.

  This should help with situations similar to the one described in CORE-16274
  where a partition with a genuine file-system but not recognized by
  ReactOS (because we currently do not have the EXT2/3/4 filesystem
  driver loaded during 1st-stage setup due to commit 5a650f6b) and
  therefore mounted as RAW, was thought to be unformatted.

USETUP:
=======
- Use the "global" SystemPartition pointer: this is the "system"
  partition we will actually use. It can be different from the actual
  one of the computer, for example when we install ReactOS on a
  removable disk. This allows also to simplify the code.

- Remove the single-used DestinationDriveLetter variable.

- Remove BuildInstallPaths() helper and use InitDestinationPaths()
  directly instead.

- Always mention the disk where the partition being formatted is.
- Cleanup old code comments, add assertions here & there...
2019-08-25 02:38:52 +02:00
..
arcname.c [REACTOS] Fix SIZE_T related warnings 2019-08-15 14:20:00 +02:00
arcname.h
arcname_tests.c [SETUPLIB][USETUP] Use NT RTL String Safe functions instead of Win32-oriented ones (and remove usage of HRESULT too). 2018-10-28 00:58:46 +02:00
bldrsup.c [SETUPLIB] Improve the Freeldr timeout INI setting hack-fix. Dedicated to Mark Jansen ;-) CORE-15193 2018-11-24 02:45:03 +01:00
bldrsup.h
filesup.c [SETUPLIB][USETUP] Move the remaining (directory-creation) functions from usetup's filesup to setuplib. 2018-10-28 18:17:34 +01:00
filesup.h [SETUPLIB][USETUP] Move the remaining (directory-creation) functions from usetup's filesup to setuplib. 2018-10-28 18:17:34 +01:00
genlist.c [SETUPLIB][USETUP] Remove the deprecated GenericListHasSingleEntry() function and use instead GetNumberOfListEntries(). 2018-10-28 15:04:33 +01:00
genlist.h [SETUPLIB][USETUP] Remove the deprecated GenericListHasSingleEntry() function and use instead GetNumberOfListEntries(). 2018-10-28 15:04:33 +01:00
inicache.c [SETUP] Silence some noisy DPRINT1 2019-01-01 10:08:02 +01:00
inicache.h
linklist.h
ntverrsrc.c
ntverrsrc.h
osdetect.c [SETUPLIB][USETUP] Minor improvements. 2019-03-10 15:41:20 +01:00
osdetect.h [SETUPLIB] Retrieve and store the machine (architecture) ID of the discovered NTOS installations. Will be used later. 2018-11-06 00:09:13 +01:00
partlist.c [SETUPLIB][USETUP] Code simplifications & fixes. 2019-08-25 02:38:52 +02:00
partlist.h [SETUPLIB][USETUP] Code simplifications & fixes. 2019-08-25 02:38:52 +02:00
regutil.c [SETUPLIB] Properly cleanup the temporary registry keys created for setting up the registry. 2018-10-28 14:42:01 +01:00
regutil.h [SETUPLIB] Properly cleanup the temporary registry keys created for setting up the registry. 2018-10-28 14:42:01 +01:00