mirror of
https://github.com/reactos/reactos.git
synced 2024-08-14 23:49:49 +00:00
![Hermès Bélusca-Maïto](/assets/img/avatar_default.png)
CORE-12149 VIDEOPRT: ========= Improve interfacing with INBV, so as to detect when an external module acquired INBV display ownership, and whether ownership is being released later on. (This does NOT rely on hooking!) For this purpose we improve the IntVideoPortResetDisplayParameters(Ex) callback that gets registered with an InbvNotifyDisplayOwnershipLost() call during initialization, and we add a monitoring thread. The callback is called whenever an external module calls InbvAcquireDisplayOwnership(), for example the bugcheck code or the KDBG debugger in SCREEN mode. When this happens, a flag that tells the monitoring thread to start monitoring INBV is set (ReactOS-specific), and the display adapters get reset with HwResetHw() (as done on Windows). Due to the fact that this INBV callback can be called at *ANY* IRQL, we cannot use dispatcher synchronization mechanisms such as events to tell the INBV monitoring thread to start its operations, so we need to rely instead on a flag to be set. And, since INBV doesn't provide with any proper callback/notification system either, we need to actively monitor its state by pooling. To reduce the load on the system the monitoring thread performs 1-second waits between each check for the flag set by the INBV callback, and during checking the INBV ownership status. When the INBV ownership is detected to be released by an external module, the INBV callback is re-registered (this is *MANDATORY* since the external module has called InbvNotifyDisplayOwnershipLost() with a different callback parameter!), and then we callout to Win32k for re-enabling the display. This has the virtue of correctly resetting the display once the KDBG debugger in SCREEN mode is being exited, and fixes CORE-12149 . The following additional fixes were needed: VIDEOPRT & WIN32K: ================== Remove the registration with INBV that was previously done in a ReactOS- specific hacked IRP_MJ_WRITE call; it is now done correctly during the video device opening done by EngpRegisterGraphicsDevice() in the VIDEOPRT's IRP_MJ_CREATE handler, as done on Windows. WIN32K: ======= - Stub the VideoPortCallout() support, for VIDEOPRT -> WIN32 callbacks. This function gets registered with VIDEOPRT through an IOCTL_VIDEO_INIT_WIN32K_CALLBACKS call in EngpRegisterGraphicsDevice(). - Only partially implement the 'VideoFindAdapterCallout' case, that just re-enables the primary display by refreshing it (using the new function UserRefreshDisplay()). VIDEOPRT: ========= - PVIDEO_WIN32K_CALLOUT is an NTAPI (stdcall) callback. - In the IntVideoPortResetDisplayParameters(Ex) callback, reset all the "resettable" adapters registered in the HwResetAdaptersList list. We thus get rid of the global ResetDisplayParametersDeviceExtension. - Make the IntVideoPortResetDisplayParameters(Ex) callback slightly more robust (using SEH) against potential HwResetListEntry list corruption or invalid DriverExtension->InitializationData.HwResetHw() that would otherwise trigger a BSOD, and this would be disastrous since that callback is precisely called when INBV is acquired, typically when the BSOD code initializes the display for displaying its information... Extras: - Validate the IrpStack->MajorFunction in IntVideoPortDispatchDeviceControl() and implement IRP_MJ_SHUTDOWN handling. Stub out the other IOCTLs that are handled by VIDEOPRT only (and not by the miniports). - VIDEOPRT doesn't require IRP_MJ_INTERNAL_DEVICE_CONTROL (unused). - Implement IOCTL_VIDEO_PREPARE_FOR_EARECOVERY that just resets the display to standard VGA 80x25 text mode.
36 lines
742 B
CMake
36 lines
742 B
CMake
|
|
include_directories(${REACTOS_SOURCE_DIR}/ntoskrnl/include)
|
|
add_definitions(-D_VIDEOPORT_)
|
|
spec2def(videoprt.sys videoprt.spec ADD_IMPORTLIB)
|
|
|
|
list(APPEND SOURCE
|
|
agp.c
|
|
child.c
|
|
ddc.c
|
|
dispatch.c
|
|
dma.c
|
|
event.c
|
|
funclist.c
|
|
int10.c
|
|
interrupt.c
|
|
registry.c
|
|
resource.c
|
|
services.c
|
|
spinlock.c
|
|
stubs.c
|
|
timer.c
|
|
videoprt.c
|
|
videoprt.h)
|
|
|
|
add_library(videoprt MODULE
|
|
${SOURCE}
|
|
guid.c
|
|
videoprt.rc
|
|
${CMAKE_CURRENT_BINARY_DIR}/videoprt.def)
|
|
|
|
set_module_type(videoprt kernelmodedriver)
|
|
target_link_libraries(videoprt ${PSEH_LIB})
|
|
add_importlibs(videoprt ntoskrnl hal)
|
|
add_pch(videoprt videoprt.h SOURCE)
|
|
add_cd_file(TARGET videoprt DESTINATION reactos/system32/drivers FOR all)
|