Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-22 08:25:03 +00:00
Code Issues Projects Releases Packages Wiki Activity
reactos/dll/win32/shell32
History
Joachim Henze a08b83a90b
[SHELL32] Fix 2 compiler warnings for the rls-cfg 'unused variable' (#6539) 
I noticed it on releases/0.4.10 with the RosBEWin2.1.6 GCC4.7.2 *rls* configuration:

C:/0410rls/reactos/dll/win32/shell32/dialogs/filetypes.cpp: In function 'BOOL FileTypesDlg_InsertToLV(HWND, LPCWSTR, INT, LPCWSTR)':
C:/0410rls/reactos/dll/win32/shell32/dialogs/filetypes.cpp:663:9: warning: variable 'iLargeImage' set but not used [-Wunused-but-set-variable]
C:/0410rls/reactos/dll/win32/shell32/dialogs/filetypes.cpp: In function 'BOOL EditTypeDlg_UpdateEntryIcon(HWND, PEDITTYPE_DIALOG, LPCWSTR, INT)':
C:/0410rls/reactos/dll/win32/shell32/dialogs/filetypes.cpp:1040:9: warning: unused variable 'iLargeImage' [-Wunused-variable]

But I do assume, that MSVC compilers would also complain about that in *rls* cfg.

Please notice that before 0.4.10-dev-202-g 698cbc6184 which did splitup and restructure the code
this function was placed within the file folder_options.cpp and was named
InsertFileType(HWND hDlgCtrl, WCHAR * szName, PINT iItem, WCHAR * szFile)
and not yet within file_types.cpp with the new name
FileTypesDlg_InsertToLV(HWND hListView, LPCWSTR szName, INT iItem, LPCWSTR szFile)
Back then it did not have the iLargeImage variable yet, and it also didn't warn upon rls-cfg-compilation.
Therefore 0.4.10-dev-202-g 698cbc6184 from (#582) is indeed the *guilty revision* (2018-06-06).
It was done in the very first commit of that PR 2fe0eab721
It's bad practice to move and refactor/extend code in functionality within the very same commit, as it makes reviewing the changes much harder.

That assert never fired for the last 6 years, therefore it would have been okay also to strip it together with the variable, but using DBG_UNREFERENCED_LOCAL_VARIABLE(iLargeImage); allows to keep the assert for master.
2024-02-26 13:42:13 +01:00
..
dialogs [SHELL32] Fix 2 compiler warnings for the rls-cfg 'unused variable' (#6539) 2024-02-26 13:42:13 +01:00
droptargets [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
folders [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
lang [SHELL32] Update Romanian (ro-RO) translation (#6441) 2024-02-11 23:09:32 +01:00
res [SHELL32][CONTROL] Added basic IOpenControlPanel support (#6248) 2024-01-17 17:07:21 +01:00
shelldesktop [SHELL32][SDK] Implement SHIsTempDisplayMode (#5523) 2023-08-07 09:50:30 +09:00
shellmenu [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
shellrecyclebin
wine [SHELL32] Sync HCR_RegGetIconW() function to Wine 9.1 (#6418) 2024-02-02 18:10:36 +03:00
avi_res.rc
bitmap_res.rc
CActiveDesktop.cpp
CActiveDesktop.h
CCopyMoveToMenu.cpp [SHELL32] Commonize CCopyToMenu and CMoveToMenu (#5873) 2023-11-04 21:56:15 +09:00
CCopyMoveToMenu.h [SHELL32] Commonize CCopyToMenu and CMoveToMenu (#5873) 2023-11-04 21:56:15 +09:00
CDefaultContextMenu.cpp [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
CDefView.cpp [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
CDefViewBckgrndMenu.cpp
CDefViewDual.cpp
CDropTargetHelper.cpp
CDropTargetHelper.h
CEnumIDListBase.cpp [SHELL32][SHELLEXT] IEnumIDList::Next must handle pceltFetched and memory errors correctly (#5820) 2023-11-13 16:31:37 +01:00
CEnumIDListBase.h
CExtractIcon.cpp
CFileSysBindData.cpp
CFolder.cpp
CFolder.h
CFolderItems.cpp
CFolderItems.h
CFolderItemVerbs.cpp
CFolderItemVerbs.h
CFolderOptions.cpp
CFolderOptions.h
changenotify.cpp [SHELL32] SHChangeRegistrationReceive just returns FALSE 2023-09-21 12:09:28 +09:00
CIDLDataObj.cpp
CMakeLists.txt [SHELL32] Commonize CCopyToMenu and CMoveToMenu (#5873) 2023-11-04 21:56:15 +09:00
CNewMenu.cpp
CNewMenu.h
COpenWithMenu.cpp [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
COpenWithMenu.h
CQueryAssociations.cpp
CQueryAssociations.h
CSendToMenu.cpp
CSendToMenu.h
CShellDispatch.cpp [SHELL32] ShellDispatch::ShellExecute must default to displaying the window (#6143) 2023-12-17 15:48:24 +03:00
CShellDispatch.h
CShellItem.cpp
CShellItem.h
CShellLink.cpp [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
CShellLink.h
CUserNotification.cpp
CUserNotification.h
debughlp.cpp
debughlp.h
folders.cpp
icon_res.rc
iconcache.cpp [SHELL32] Move SheRemoveQuotesA/W to utils.cpp (#5535) 2023-08-06 13:07:39 +02:00
precomp.h [SHELL32] Commonize CCopyToMenu and CMoveToMenu (#5873) 2023-11-04 21:56:15 +09:00
rgs_res.rc
shell32.cpp [SHELL32][CONTROL] Added basic IOpenControlPanel support (#6248) 2024-01-17 17:07:21 +01:00
shell32.rc
shell32.spec [SHELL32][SDK] Implement CopyStreamUI (#5848) 2023-10-31 22:32:02 +09:00
shell32_shldisp.idl
shell32_version.h
shell32_version.rc
shfldr.h
shldataobject.cpp
shlexec.cpp [SHELL32] Fix for shlexec.cpp regressions (#5282) 2023-09-24 20:35:28 +00:00
shlfileop.cpp [SHELL32] Improve error message on copying files (#6290) 2024-01-12 16:01:21 +09:00
shlfolder.cpp [SHELL32] Tweak formatting and logging 2024-02-20 02:08:56 +01:00
shobjidl_local.idl
shresdef.h [SHELL32] Handle HotKey and ShowCmd on the shortcut property page (#5638) 2023-09-02 21:16:22 +03:00
stubs.cpp [SHELL32][SHELL32_APITEST][SDK] Implement PathIsEqualOrSubFolder (#5714) 2023-11-29 22:50:01 +09:00
systray.cpp
utils.cpp [SHELL32][SHELL32_APITEST][SDK] Implement PathIsEqualOrSubFolder (#5714) 2023-11-29 22:50:01 +09:00
vista.c