reactos/reactos/base
Dmitry Chapyshev 01bab59e21 [WHOAMI]
[ARP]
[TRACERT]
- Incorrect to compare the variable of BOOL type with TRUE. Any non-zero value is considered to be "true".

[FREELDR]
- Variable is assigned values twice
- The 'strlen' function was called multiple times inside the body of a loop
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0

[NTOBJSHEX]
[SLAYER]
[CMICONTROL]
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0

[SHELL32]
- There is no sense in testing the pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error 
- Verifying that a pointer value is not NULL is not required. The 'if (ptr != NULL)' check can be removed
- Fix copy-paste error in CMenuFocusManager::PlaceHooks()

[SRCLIENT]
- Remove unneeded check. A part of conditional expression is always false.

[DISK]
[ATAPI]
- Variable is assigned values twice

* All bugs found by PVS-Studio

svn path=/trunk/; revision=72059
2016-07-30 16:00:10 +00:00
..
applications [WHOAMI] 2016-07-30 16:00:10 +00:00
services [DHCPSVC]: It's a service, move it in the correct directory. 2016-06-07 23:14:58 +00:00
setup [USETUP] 2016-07-21 20:53:43 +00:00
shell [EXPLORER] Fix the Explore all users/open all users menu items. Patch by Jared Smudde. CORE-11146 #resolve #comment Thanks! 2016-07-16 17:49:27 +00:00
system Ooops! These were not meant to be committed! 2016-07-16 17:41:44 +00:00
CMakeLists.txt [SHELL/EXPERIMENTS] 2014-02-02 19:37:27 +00:00