reactos/dll/win32/msi
Joachim Henze 864e20b881 [MSI] setup should not enumerate read-only CDRoms as install-targets CORE-14432
We decided to check a bit different than Wine currently does.
Wine checks for
if (GetVolumeInformationW(ptr, NULL, 0, NULL, 0, &flags, NULL, 0) && flags & FILE_READ_ONLY_VOLUME)
to exclude read-only-media while we (for now) check for
if (GetDriveTypeW(ptr) == DRIVE_CDROM)

For now this gives us the benefit of covering also CDROM drives, that do not have
a CD put into it.
That does not work properly for us with the Wine patch yet, but it does for Wine!
So this maybe points to some other bug in ros, maybe in our CDROM(FS)-drivers?

In the future we should also test this on other read-only-media in Windows e.g.
a read-only USB stick to decide whether we want to stick with our current solution
or whether we want to switch to Wines solution or whether we want to logically OR
both conditions!

Thanks to Doug Lyons for providing what *currently* does work best for us!

VBox https://reactos.org/testman/compare.php?ids=77537,77546 (no change)
KVM https://reactos.org/testman/compare.php?ids=77531,77541 (no change)
2021-06-05 21:27:40 +02:00
..
lang [TRANSLATION] indonesian add and update apps/shell translation 2021-05-05 11:34:28 +02:00
action.c
alter.c
appsearch.c
assembly.c
automation.c
classes.c
CMakeLists.txt [CMAKE] Properly generate all Bison and Flex files at build time 2021-04-03 21:50:08 +03:00
cond.y
create.c
custom.c
database.c
delete.c
dialog.c [MSI] setup should not enumerate read-only CDRoms as install-targets CORE-14432 2021-06-05 21:27:40 +02:00
distinct.c
drop.c
files.c
font.c
format.c
handle.c
insert.c
instabsent.bmp
instadvert.bmp
install.c
instlocal.bmp
media.c
msi.c
msi.rc
msi.spec
msi_main.c
msi_ros.diff
msipriv.h
msiquery.c
msiserver.idl
msiserver.rgs
msiserver_dispids.h
msiserver_r.rgs
msiserver_t.rgs
msvchelper.h
package.c
patch.c
precomp.h
query.h
record.c
registry.c
resource.h
rsrc.rc [TRANSLATION] indonesian add and update apps/shell translation 2021-05-05 11:34:28 +02:00
script.c
select.c
source.c
sql.y
storages.c
streams.c
string.c
suminfo.c
table.c
tokenize.c
update.c
upgrade.c
version.rc
where.c