Whindmar Saksit 51a89791c1 [RAPPS] Validate DisplayIcon value and support icon index (#5664) ... - If the DisplayIcon value points to an invalid path, ExtractIconW() can return 1! ExtractIconExW() does not have this problem nor the -1 issue. Reference: https://devblogs.microsoft.com/oldnewthing/20050526-07/?p=35533 - Use the icon index from PathParseIconLocationW(). Addendum to c6c7fc1. CORE-19317 Test to reproduce: ``` @echo off reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex1 /v DisplayName /d "Ex1 Normal" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex1 /v DisplayIcon /d "%windir%\explorer.exe" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex1 /v UninstallString /d "calc.exe" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex2 /v DisplayName /d "Ex2 Bad icon path" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex2 /v DisplayIcon /d "%windir%\DoesNotExist.exe" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex2 /v UninstallString /d "calc.exe" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex3 /v DisplayName /d "Ex3 Resource index" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex3 /v DisplayIcon /d "%windir%\explorer.exe,4" /f reg add HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Ex3 /v UninstallString /d "calc.exe" /f start appwiz.cpl ```		2023-11-20 20:50:42 +03:00
..
applications	[RAPPS] Validate DisplayIcon value and support icon index (#5664)	2023-11-20 20:50:42 +03:00
services	[W32TIME] Remember date/time sync settings (#5866)	2023-11-03 22:56:58 +09:00
setup	[USETUP] Don't error out in case one tries to "delete" empty partition space.	2023-11-19 16:44:34 +01:00
shell	[CMD] Use correct console input mode in ConInString()	2023-11-16 21:58:54 +01:00
system	[SERVICES][SETUPLIB][UMANDLG][USETUP] Add missing \n to DPRINT() calls (#5983)	2023-11-16 22:22:12 +00:00
CMakeLists.txt