/* * ReactOS Explorer * * Copyright 2014 Giannis Adamopoulos * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2.1 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ #include "shellmenu.h" #include "CMergedFolder.h" WINE_DEFAULT_DEBUG_CHANNEL(CStartMenu); //#define TEST_TRACKPOPUPMENU_SUBMENUS /* NOTE: The following constants *MUST NOT* be changed because they're hardcoded and need to be the exact values in order to get the start menu to work! */ #define IDM_RUN 401 #define IDM_LOGOFF 402 #define IDM_UNDOCKCOMPUTER 410 #define IDM_TASKBARANDSTARTMENU 413 #define IDM_LASTSTARTMENU_SEPARATOR 450 #define IDM_DOCUMENTS 501 #define IDM_HELPANDSUPPORT 503 #define IDM_PROGRAMS 504 #define IDM_CONTROLPANEL 505 #define IDM_SHUTDOWN 506 #define IDM_FAVORITES 507 #define IDM_SETTINGS 508 #define IDM_PRINTERSANDFAXES 510 #define IDM_SEARCH 520 #define IDM_SYNCHRONIZE 553 #define IDM_NETWORKCONNECTIONS 557 #define IDM_DISCONNECT 5000 #define IDM_SECURITY 5001 /* * TODO: * 1. append the start menu contents from all users * 2. implement the context menu for start menu entries (programs, control panel, network connetions, printers) * 3. filter out programs folder from the shell folder part of the start menu * 4. showing the programs start menu is SLOW compared to windows. this needs some investigation */ class CShellMenuCallback : public CComObjectRootEx, public IShellMenuCallback { private: HWND m_hwndTray; CComPtr m_pShellMenu; CComPtr m_pBandSite; CComPtr m_pDeskBar; CComPtr m_pTrayPriv; CComPtr m_psfPrograms; LPITEMIDLIST m_pidlPrograms; HRESULT OnInitMenu() { HMENU hmenu; HRESULT hr; if (m_pTrayPriv.p) return S_OK; hr = IUnknown_GetSite(m_pDeskBar, IID_PPV_ARG(ITrayPriv, &m_pTrayPriv)); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = IUnknown_GetWindow(m_pTrayPriv, &m_hwndTray); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = m_pTrayPriv->AppendMenu(&hmenu); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = m_pShellMenu->SetMenu(hmenu, NULL, SMSET_BOTTOM); if (FAILED_UNEXPECTEDLY(hr)) { DestroyMenu(hmenu); return hr; } return hr; } HRESULT OnGetInfo(LPSMDATA psmd, SMINFO *psminfo) { int iconIndex = 0; switch (psmd->uId) { // Smaller "24x24" icons used for the start menu // The bitmaps are still 32x32, but the image is centered case IDM_FAVORITES: iconIndex = -IDI_SHELL_FAVOTITES; break; case IDM_SEARCH: iconIndex = -IDI_SHELL_SEARCH1; break; case IDM_HELPANDSUPPORT: iconIndex = -IDI_SHELL_HELP2; break; case IDM_LOGOFF: iconIndex = -IDI_SHELL_LOGOFF1; break; case IDM_PROGRAMS: iconIndex = -IDI_SHELL_PROGRAMS_FOLDER1; break; case IDM_DOCUMENTS: iconIndex = -IDI_SHELL_RECENT_DOCUMENTS1; break; case IDM_RUN: iconIndex = -IDI_SHELL_RUN1; break; case IDM_SHUTDOWN: iconIndex = -IDI_SHELL_SHUTDOWN1; break; case IDM_SETTINGS: iconIndex = -IDI_SHELL_CONTROL_PANEL1; break; case IDM_MYDOCUMENTS: iconIndex = -IDI_SHELL_MY_DOCUMENTS; break; case IDM_MYPICTURES: iconIndex = -IDI_SHELL_MY_PICTURES; break; case IDM_CONTROLPANEL: iconIndex = -IDI_SHELL_CONTROL_PANEL; break; case IDM_NETWORKCONNECTIONS: iconIndex = -IDI_SHELL_NETWORK_CONNECTIONS2; break; case IDM_PRINTERSANDFAXES: iconIndex = -IDI_SHELL_PRINTER2; break; case IDM_TASKBARANDSTARTMENU: iconIndex = -IDI_SHELL_TSKBAR_STARTMENU; break; //case IDM_SECURITY: iconIndex = -21; break; //case IDM_SYNCHRONIZE: iconIndex = -21; break; //case IDM_DISCONNECT: iconIndex = -21; break; //case IDM_UNDOCKCOMPUTER: iconIndex = -21; break; default: return S_FALSE; } if (iconIndex) { if ((psminfo->dwMask & SMIM_TYPE) != 0) psminfo->dwType = SMIT_STRING; if ((psminfo->dwMask & SMIM_ICON) != 0) psminfo->iIcon = Shell_GetCachedImageIndex(L"shell32.dll", iconIndex, FALSE); if ((psminfo->dwMask & SMIM_FLAGS) != 0) psminfo->dwFlags |= SMIF_ICON; #ifdef TEST_TRACKPOPUPMENU_SUBMENUS if ((psminfo->dwMask & SMIM_FLAGS) != 0) psminfo->dwFlags |= SMIF_TRACKPOPUP; #endif } else { if ((psminfo->dwMask & SMIM_TYPE) != 0) psminfo->dwType = SMIT_SEPARATOR; } return S_OK; } void AddOrSetMenuItem(HMENU hMenu, UINT nID, INT csidl, BOOL bExpand, BOOL bAdd = TRUE, BOOL bSetText = TRUE) const { MENUITEMINFOW mii = { sizeof(mii), MIIM_ID | MIIM_SUBMENU }; mii.wID = nID; SHFILEINFOW fileInfo = { 0 }; if (bAdd || bSetText) { LPITEMIDLIST pidl; if (SHGetSpecialFolderLocation(NULL, csidl, &pidl) != S_OK) { ERR("SHGetSpecialFolderLocation failed\n"); return; } SHGetFileInfoW((LPWSTR)pidl, 0, &fileInfo, sizeof(fileInfo), SHGFI_PIDL | SHGFI_DISPLAYNAME); CoTaskMemFree(pidl); mii.fMask |= MIIM_TYPE; mii.fType = MFT_STRING; mii.dwTypeData = fileInfo.szDisplayName; } if (bExpand) mii.hSubMenu = ::CreatePopupMenu(); if (bAdd) InsertMenuItemW(hMenu, GetMenuItemCount(hMenu), TRUE, &mii); else SetMenuItemInfoW(hMenu, nID, FALSE, &mii); } BOOL GetAdvancedValue(LPCWSTR pszName, BOOL bDefault = FALSE) const { return SHRegGetBoolUSValueW( L"Software\\Microsoft\\Windows\\CurrentVersion\\Explorer\\Advanced", pszName, FALSE, bDefault); } HMENU CreateRecentMenu() const { HMENU hMenu = ::CreateMenu(); BOOL bAdded = FALSE; // My Documents if (!SHRestricted(REST_NOSMMYDOCS) && GetAdvancedValue(L"Start_ShowMyDocs", TRUE)) { BOOL bExpand = GetAdvancedValue(L"CascadeMyDocuments", FALSE); AddOrSetMenuItem(hMenu, IDM_MYDOCUMENTS, CSIDL_MYDOCUMENTS, bExpand); bAdded = TRUE; } // My Pictures if (!SHRestricted(REST_NOSMMYPICS) && GetAdvancedValue(L"Start_ShowMyPics", TRUE)) { BOOL bExpand = GetAdvancedValue(L"CascadeMyPictures", FALSE); AddOrSetMenuItem(hMenu, IDM_MYPICTURES, CSIDL_MYPICTURES, bExpand); bAdded = TRUE; } if (bAdded) AppendMenuW(hMenu, MF_SEPARATOR, 0, NULL); return hMenu; } void UpdateSettingsMenu(HMENU hMenu) { BOOL bExpand; bExpand = GetAdvancedValue(L"CascadeControlPanel"); AddOrSetMenuItem(hMenu, IDM_CONTROLPANEL, CSIDL_CONTROLS, bExpand, FALSE, FALSE); bExpand = GetAdvancedValue(L"CascadeNetworkConnections"); AddOrSetMenuItem(hMenu, IDM_NETWORKCONNECTIONS, CSIDL_NETWORK, bExpand, FALSE, FALSE); bExpand = GetAdvancedValue(L"CascadePrinters"); AddOrSetMenuItem(hMenu, IDM_PRINTERSANDFAXES, CSIDL_PRINTERS, bExpand, FALSE, FALSE); } HRESULT AddStartMenuItems(IShellMenu *pShellMenu, INT csidl, DWORD dwFlags, IShellFolder *psf = NULL) { CComHeapPtr pidlFolder; CComPtr psfDesktop; CComPtr pShellFolder; HRESULT hr; hr = SHGetFolderLocation(NULL, csidl, 0, 0, &pidlFolder); if (FAILED_UNEXPECTEDLY(hr)) return hr; if (psf) { pShellFolder = psf; } else { hr = SHGetDesktopFolder(&psfDesktop); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = psfDesktop->BindToObject(pidlFolder, NULL, IID_PPV_ARG(IShellFolder, &pShellFolder)); if (FAILED_UNEXPECTEDLY(hr)) return hr; } hr = pShellMenu->SetShellFolder(pShellFolder, pidlFolder, NULL, dwFlags); if (FAILED_UNEXPECTEDLY(hr)) return hr; return hr; } HRESULT OnGetSubMenu(LPSMDATA psmd, REFIID iid, void ** pv) { HRESULT hr; CComPtr pShellMenu; hr = CMenuBand_CreateInstance(IID_PPV_ARG(IShellMenu, &pShellMenu)); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = pShellMenu->Initialize(this, 0, ANCESTORDEFAULT, SMINIT_VERTICAL); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = E_FAIL; switch (psmd->uId) { case IDM_PROGRAMS: { hr = AddStartMenuItems(pShellMenu, CSIDL_PROGRAMS, SMSET_TOP, m_psfPrograms); break; } case IDM_FAVORITES: case IDM_MYDOCUMENTS: case IDM_MYPICTURES: case IDM_CONTROLPANEL: case IDM_NETWORKCONNECTIONS: case IDM_PRINTERSANDFAXES: { hr = AddStartMenuItems(pShellMenu, CSIDLFromID(psmd->uId), SMSET_TOP); break; } case IDM_DOCUMENTS: { HMENU hMenu = CreateRecentMenu(); if (hMenu == NULL) ERR("CreateRecentMenu failed\n"); hr = pShellMenu->SetMenu(hMenu, NULL, SMSET_BOTTOM); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = AddStartMenuItems(pShellMenu, CSIDL_RECENT, SMSET_BOTTOM); break; } case IDM_SETTINGS: { MENUITEMINFOW mii = { sizeof(mii), MIIM_SUBMENU }; if (GetMenuItemInfoW(psmd->hmenu, psmd->uId, FALSE, &mii)) { UpdateSettingsMenu(mii.hSubMenu); hr = pShellMenu->SetMenu(mii.hSubMenu, NULL, SMSET_BOTTOM); if (FAILED_UNEXPECTEDLY(hr)) return hr; } break; } default: { MENUITEMINFOW mii = { sizeof(mii), MIIM_SUBMENU }; if (GetMenuItemInfoW(psmd->hmenu, psmd->uId, FALSE, &mii)) { hr = pShellMenu->SetMenu(mii.hSubMenu, NULL, SMSET_BOTTOM); if (FAILED_UNEXPECTEDLY(hr)) return hr; } } } if (FAILED(hr)) return hr; hr = pShellMenu->QueryInterface(iid, pv); pShellMenu.Detach(); return hr; } INT CSIDLFromID(UINT uId) const { switch (uId) { case IDM_PROGRAMS: return CSIDL_PROGRAMS; case IDM_FAVORITES: return CSIDL_FAVORITES; case IDM_DOCUMENTS: return CSIDL_RECENT; case IDM_MYDOCUMENTS: return CSIDL_MYDOCUMENTS; case IDM_MYPICTURES: return CSIDL_MYPICTURES; case IDM_CONTROLPANEL: return CSIDL_CONTROLS; case IDM_NETWORKCONNECTIONS: return CSIDL_NETWORK; case IDM_PRINTERSANDFAXES: return CSIDL_PRINTERS; default: return 0; } } HRESULT OnGetContextMenu(LPSMDATA psmd, REFIID iid, void ** pv) { INT csidl = CSIDLFromID(psmd->uId); if (!csidl) return S_FALSE; TRACE("csidl: 0x%X\n", csidl); if (csidl == CSIDL_CONTROLS || csidl == CSIDL_NETWORK || csidl == CSIDL_PRINTERS) FIXME("This CSIDL %d wrongly opens My Computer. CORE-19477\n", csidl); CComHeapPtr pidl; SHGetSpecialFolderLocation(NULL, csidl, &pidl); CComPtr pSF; LPCITEMIDLIST pidlChild = NULL; HRESULT hr = SHBindToParent(pidl, IID_IShellFolder, (void**)&pSF, &pidlChild); if (FAILED(hr)) return hr; return pSF->GetUIObjectOf(NULL, 1, &pidlChild, IID_IContextMenu, NULL, pv); } HRESULT OnGetObject(LPSMDATA psmd, REFIID iid, void ** pv) { if (IsEqualIID(iid, IID_IShellMenu)) return OnGetSubMenu(psmd, iid, pv); else if (IsEqualIID(iid, IID_IContextMenu)) return OnGetContextMenu(psmd, iid, pv); return S_FALSE; } HRESULT OnExec(LPSMDATA psmd) { WCHAR szPath[MAX_PATH]; // HACK: Because our ShellExecute can't handle CLSID components in paths, we can't launch the paths using the "open" verb. // FIXME: Change this back to using the path as the filename and the "open" verb, once ShellExecute can handle CLSID path components. if (psmd->uId == IDM_CONTROLPANEL) ShellExecuteW(NULL, NULL, L"explorer.exe", L"::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{21EC2020-3AEA-1069-A2DD-08002B30309D}", NULL, SW_SHOWNORMAL); else if (psmd->uId == IDM_NETWORKCONNECTIONS) ShellExecuteW(NULL, NULL, L"explorer.exe", L"::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{21EC2020-3AEA-1069-A2DD-08002B30309D}\\::{7007ACC7-3202-11D1-AAD2-00805FC1270E}", NULL, SW_SHOWNORMAL); else if (psmd->uId == IDM_PRINTERSANDFAXES) ShellExecuteW(NULL, NULL, L"explorer.exe", L"::{20D04FE0-3AEA-1069-A2D8-08002B30309D}\\::{21EC2020-3AEA-1069-A2DD-08002B30309D}\\::{2227A280-3AEA-1069-A2DE-08002B30309D}", NULL, SW_SHOWNORMAL); else if (psmd->uId == IDM_MYDOCUMENTS) { if (SHGetSpecialFolderPathW(NULL, szPath, CSIDL_PERSONAL, FALSE)) ShellExecuteW(NULL, NULL, szPath, NULL, NULL, SW_SHOWNORMAL); else ERR("SHGetSpecialFolderPathW failed\n"); } else if (psmd->uId == IDM_MYPICTURES) { if (SHGetSpecialFolderPathW(NULL, szPath, CSIDL_MYPICTURES, FALSE)) ShellExecuteW(NULL, NULL, szPath, NULL, NULL, SW_SHOWNORMAL); else ERR("SHGetSpecialFolderPathW failed\n"); } else PostMessageW(m_hwndTray, WM_COMMAND, psmd->uId, 0); return S_OK; } public: DECLARE_NOT_AGGREGATABLE(CShellMenuCallback) DECLARE_PROTECT_FINAL_CONSTRUCT() BEGIN_COM_MAP(CShellMenuCallback) COM_INTERFACE_ENTRY_IID(IID_IShellMenuCallback, IShellMenuCallback) END_COM_MAP() void Initialize( IShellMenu* pShellMenu, IBandSite* pBandSite, IDeskBar* pDeskBar) { m_pShellMenu = pShellMenu; m_pBandSite = pBandSite; m_pDeskBar = pDeskBar; } ~CShellMenuCallback() { } HRESULT _SetProgramsFolder(IShellFolder * psf, LPITEMIDLIST pidl) { m_psfPrograms = psf; m_pidlPrograms = pidl; return S_OK; } HRESULT STDMETHODCALLTYPE CallbackSM( LPSMDATA psmd, UINT uMsg, WPARAM wParam, LPARAM lParam) { switch (uMsg) { case SMC_INITMENU: return OnInitMenu(); case SMC_GETINFO: return OnGetInfo(psmd, reinterpret_cast(lParam)); case SMC_GETOBJECT: return OnGetObject(psmd, *reinterpret_cast(wParam), reinterpret_cast(lParam)); case SMC_EXEC: return OnExec(psmd); case SMC_SFEXEC: m_pTrayPriv->Execute(psmd->psf, psmd->pidlItem); break; case 0x10000000: // _FilterPIDL from CMenuSFToolbar if (psmd->psf->CompareIDs(0, psmd->pidlItem, m_pidlPrograms) == 0) return S_OK; return S_FALSE; } return S_FALSE; } }; HRESULT BindToDesktop(LPCITEMIDLIST pidl, IShellFolder ** ppsfResult) { HRESULT hr; CComPtr psfDesktop; *ppsfResult = NULL; hr = SHGetDesktopFolder(&psfDesktop); if (FAILED(hr)) return hr; hr = psfDesktop->BindToObject(pidl, NULL, IID_PPV_ARG(IShellFolder, ppsfResult)); return hr; } static HRESULT GetMergedFolder(int folder1, int folder2, IShellFolder ** ppsfStartMenu) { HRESULT hr; LPITEMIDLIST pidlUserStartMenu; LPITEMIDLIST pidlCommonStartMenu; CComPtr psfUserStartMenu; CComPtr psfCommonStartMenu; CComPtr pasf; *ppsfStartMenu = NULL; hr = SHGetSpecialFolderLocation(NULL, folder1, &pidlUserStartMenu); if (FAILED(hr)) { WARN("Failed to get the USER start menu folder. Trying to run with just the COMMON one.\n"); hr = SHGetSpecialFolderLocation(NULL, folder2, &pidlCommonStartMenu); if (FAILED_UNEXPECTEDLY(hr)) return hr; TRACE("COMMON start menu obtained.\n"); hr = BindToDesktop(pidlCommonStartMenu, ppsfStartMenu); ILFree(pidlCommonStartMenu); return hr; } #if MERGE_FOLDERS hr = SHGetSpecialFolderLocation(NULL, folder2, &pidlCommonStartMenu); if (FAILED_UNEXPECTEDLY(hr)) #else else #endif { WARN("Failed to get the COMMON start menu folder. Will use only the USER contents.\n"); hr = BindToDesktop(pidlUserStartMenu, ppsfStartMenu); ILFree(pidlUserStartMenu); return hr; } TRACE("Both COMMON and USER statr menu folders obtained, merging them...\n"); hr = BindToDesktop(pidlUserStartMenu, &psfUserStartMenu); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = BindToDesktop(pidlCommonStartMenu, &psfCommonStartMenu); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = CMergedFolder_CreateInstance(IID_PPV_ARG(IAugmentedShellFolder, &pasf)); if (FAILED_UNEXPECTEDLY(hr)) { *ppsfStartMenu = psfUserStartMenu.Detach(); ILFree(pidlCommonStartMenu); ILFree(pidlUserStartMenu); return hr; } hr = pasf->AddNameSpace(NULL, psfUserStartMenu, pidlUserStartMenu, 0xFF00); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = pasf->AddNameSpace(NULL, psfCommonStartMenu, pidlCommonStartMenu, 0); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = pasf->QueryInterface(IID_PPV_ARG(IShellFolder, ppsfStartMenu)); pasf.Release(); ILFree(pidlCommonStartMenu); ILFree(pidlUserStartMenu); return hr; } static HRESULT GetStartMenuFolder(IShellFolder ** ppsfStartMenu) { return GetMergedFolder(CSIDL_STARTMENU, CSIDL_COMMON_STARTMENU, ppsfStartMenu); } static HRESULT GetProgramsFolder(IShellFolder ** ppsfStartMenu) { return GetMergedFolder(CSIDL_PROGRAMS, CSIDL_COMMON_PROGRAMS, ppsfStartMenu); } extern "C" HRESULT WINAPI RSHELL_CStartMenu_CreateInstance(REFIID riid, void **ppv) { CComPtr pShellMenu; CComPtr pBandSite; CComPtr pDeskBar; HRESULT hr; IShellFolder * psf; LPITEMIDLIST pidlProgramsAbsolute; LPITEMIDLIST pidlPrograms; CComPtr psfPrograms; hr = CMenuBand_CreateInstance(IID_PPV_ARG(IShellMenu, &pShellMenu)); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = CMenuSite_CreateInstance(IID_PPV_ARG(IBandSite, &pBandSite)); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = CMenuDeskBar_CreateInstance(IID_PPV_ARG(IDeskBar, &pDeskBar)); if (FAILED_UNEXPECTEDLY(hr)) return hr; CComObject *pCallback; hr = CComObject::CreateInstance(&pCallback); if (FAILED_UNEXPECTEDLY(hr)) return hr; pCallback->AddRef(); // CreateInstance returns object with 0 ref count */ pCallback->Initialize(pShellMenu, pBandSite, pDeskBar); hr = pShellMenu->Initialize(pCallback, (UINT) -1, 0, SMINIT_TOPLEVEL | SMINIT_VERTICAL); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = GetStartMenuFolder(&psf); if (FAILED_UNEXPECTEDLY(hr)) return hr; /* psf is a merged folder, so now we want to get the pidl of the programs item from the merged folder */ { hr = SHGetSpecialFolderLocation(NULL, CSIDL_PROGRAMS, &pidlProgramsAbsolute); if (FAILED_UNEXPECTEDLY(hr)) { WARN("USER Programs folder not found\n"); hr = SHGetSpecialFolderLocation(NULL, CSIDL_COMMON_PROGRAMS, &pidlProgramsAbsolute); if (FAILED_UNEXPECTEDLY(hr)) return hr; } LPCITEMIDLIST pcidlPrograms; CComPtr psfParent; STRRET str; TCHAR szDisplayName[MAX_PATH]; hr = SHBindToParent(pidlProgramsAbsolute, IID_PPV_ARG(IShellFolder, &psfParent), &pcidlPrograms); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = psfParent->GetDisplayNameOf(pcidlPrograms, SHGDN_FORPARSING | SHGDN_INFOLDER, &str); if (FAILED_UNEXPECTEDLY(hr)) return hr; StrRetToBuf(&str, pcidlPrograms, szDisplayName, _countof(szDisplayName)); ILFree(pidlProgramsAbsolute); /* We got the display name from the fs folder and we parse it with the merged folder here */ hr = psf->ParseDisplayName(NULL, NULL, szDisplayName, NULL, &pidlPrograms, NULL); if (FAILED_UNEXPECTEDLY(hr)) return hr; } hr = GetProgramsFolder(&psfPrograms); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = pCallback->_SetProgramsFolder(psfPrograms, pidlPrograms); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = pShellMenu->SetShellFolder(psf, NULL, NULL, SMSET_TOP); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = pDeskBar->SetClient(pBandSite); if (FAILED_UNEXPECTEDLY(hr)) return hr; hr = pBandSite->AddBand(pShellMenu); if (FAILED_UNEXPECTEDLY(hr)) return hr; return pDeskBar->QueryInterface(riid, ppv); }