A very old regression. The visible symptom for us was, that the Apply button in our
desk.cpl was always visible, even in case no user input was done in the dlg yet.
I am still a bit afraid, because this patch is quite new and
it might unhide issues otherwhere, but since it fixes a regression,
I decided to take that risk.
This patch is a backport of 0.4.13-dev-908-g
344d559935
Multiple invocations of ImageList_Destroy() could lead to double-free and
would crash applications since 0.4.12-RC-27-g
89f3036245
Many Thanks to patches author Mark Jansen.
Master is also affected by this bug but did not receive the fix yet.
We unintentionally introduced CORE-16299 by
0.4.12-RC-47-g
625a5a0780
Thx to author Doug Lyons for this patch!
Master is also affected, but will be serviced later.
v6 comboboxes default to displaying up to 30entries and
give a bad user experience in 2nd stage
where we usually have low vertical screen resolution.
Therefore limit the height of the expanded boxes to
bring us close to how they were drawn before 0.4.12-dev-882-g
e3e173ffaa
Adding CBS_NOINTEGRALHEIGHT gives similar result for both:
comctl32 v5 and v6 comboboxes.
Similar commit went into 0.4.13-dev-740-g
8b67edd8fa
Fixes "STDU Viewer 1.6.375 crashing"
A regression of 0.4.12-dev-933-g
7143e411c4
Proposed changes of author Baruch Rutman aka "peterooch" peterooch@gmail.com:
- Use the total extent (width) and font metrics (height) as values
to put in the lpSize variable instead of calling ScriptString_pSize()
in the LpkGetTextExtentExPoint() function.
- Use GetTextExtentExPointWPri in more cases as another effort to get the data.
Many thanks for that prompt fix!
Master got fixed similar in 0.4.13-dev-445-g
22064d7787
Pressing Next-button in setup of "1C Enterprise (training version) 8.3.10.2252"
did not have any effect anymore. Setup could not be completed anymore.
The regession was introduced to ros by 0.4.8-dev-739-g
f8b992f2d3
and was confirmed being a Wine-regression in
https://bugs.winehq.org/show_bug.cgi?id=45445
Thanks to Fabian Maurer for communicating to Wine and thanks to
Thomas Faber for regenerating cond.tab.c from the fixed source file cond.y
using BISON.
I also committed the same fix to master during 0.4.13-dev.
Most likely not correct, as it breaks comctl32:buttonv6 tests
https://reactos.org/testman/compare.php?ids=68146,68147
But greatly improves perceived flickering when hovering
with the mouse about buttons in unthemed mode.
We still fear that this workaround could break buttons that
intend to change their appearance when being hovered.
We workaround only the RC, but will leave master affected for now.
The problems began when we committed the two SxS commits
0.4.8-dev-502-g
7000fe2340
and
0.4.8-dev-503-g
f318a25e10
Since then incompatible comctl32 v5/v6 imagelist were in mixed usage.
The new comctl32 patch fixes the following regressions:
- CORE-14433 MSVCPP 6 installer browseForFolder-dlg lacked icons
- CORE-14433 MS Word Viewer 2003 open-dlg lacked icons
- CORE-15118 OCR CuneiForm 12 lacked icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacked checkboxes
- CORE-15529 Bulk Rename utility lacked icons
Fixing comctl32 directly was applied to 0.4.12RC for the first time.
Older releases always used a partial SxS revert instead.
Master is still unpatched to date.
The fix is a combination of the first 4 commits of PR#1211 and
the attached is_valid.diff. Thanks to everyone involved:
Giannis Adamopoulos, Mark Jansen and Andreas Maier!
The patch was not committed to master yet. Currently is still under review in PR-1599.
The patch also improves the rendering of disabled menubar buttons for SumatraPDF CORE-10601.
Even after the patch we are not perfect at deciding when to draw masked
and when to draw desaturated in 32bpp, but it definitely improves end users experience.
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
This avoids at startup of Instant Messenger "QIP 2005 8095"
a message-box with "OLE Error 8004001".
The issue is a subtask of CORE-11537
Many Thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
Note you still need to install Gecko 2.40 and Samba 1.3 from rapps for QIP.
cherry picked from commit 0.4.13-dev-327-g
bc3eed68ca
The regression was unhidden by MSI-winesync 1.5.10 almost 7years ago:
8939969e21
Finally we can fix it by adding MS enumerator extension to Jscript.
Many thanks to the patches author
Andreas Maier <staubim@quantentunnel.de>
JIRA-nick: andy-123
The patch is WIP and was not committed to master yet.
https://reactos.org/testman/compare.php?ids=67482,67485
This reverts 0.4.12-RC-2-g
f57e9ed926
and therefore brings the SxS state back to master. It allows many SxS-dependent apps to run again that broke by the new 0.4.12-workaround.
e.g: Miranda 0.10.48
Unfortunately this will expose many issues for the first time in the 0.4.12release (same way like in master),
that I could properly hide in all past releases by a different workaround (that we can not longer use due to heavy 0.4.12-dev SxS works)
This commit reintroduces:
- CORE-14433 MSVCPP 6 installer open-dlg, MS Word Viewer 2003 open-dlg lacks icons
- CORE-15118 OCR CuneiForm 12 lacks icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacks checkboxes
We think that all those issues are caused by incompatible comctl32 v5/v6 imagelists actually.
If time will allow it, I might experiment with some macros later to hide the comctl32-issue leaving SxS intact.
After the DC work is done while before releasing the DC flush the GDI batch.
See CORE-15905. Someone may need to notify wine about this change.
cherry picked from commit 0.4.13-dev-7-g
84d518b190
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.
Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).
Thanks to patches author Doug Lyons.
The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.
like in last release
(cherry picked from commit b906163dc1)
This brings us back to before commit 0.4.10-dev-55-g
7af3969e9f
and therefore downgrades D3D8,D3D9,DDRAW,WINED3D to 3.3 for this rls.
This is same versions as we had in 0.4.10rls (I used same revert then)
Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
DxDiag crashed when switching to fullscreen,
Diablo II crashed immediately,
Monster-Truck-Madness 2 demo crashed after main menu
Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.
This will be the interim fix, which I will keep for rls at least
until someone manages to fix CORE-14955 properly in master with current Wine.
analog to 0.4.10-RC-17-g
bb4c55d650
By reverting just commit 0.4.8-dev-502-g
7000fe2340.
It fixes:
- CORE-14433 MSVCPP 6 installer open-dlg, MS Word Viewer 2003 open-dlg lacks icons
- CORE-15118 OCR CuneiForm 12 lacks icons in the menubar
- CORE-15892 DosBOX 0.74.2 NSIS-installer lacks checkboxes
We think that all those issues are caused by incompatible comctl32 v5/v6
imagelists actually.
Please notice, that in the past ros-releases, I used to revert additionally
0.4.8-dev-503-g
f318a25e10
but since a lot of LDR work was done during 0.4.12-dev I was forced to
minimize the needed revert this time in order to not threaten
recent LDR-work done by Mark & Thomas
This fixes the following compiler error:
../dll/win32/advapi32/service/eventlog.c:658:59: error: passing argument 3 of 'ElfrChangeNotify' makes integer from pointer without a cast [-Werror=int-conversion]
dll/win32/advapi32/eventlogrpc_c.h:391:20: note: expected 'ULONG {aka long unsigned int}' but argument is of type 'HANDLE {aka void *}'
There is no need to compile our DLLs as shared libraries since we are
managing symbols exports and imports through spec files.
On my system, this reduces the configure-time by a factor of two.
The previous implementation used the resume_handle parameter to return a pointer to the active enumeration context, but resume_handle is a DWORD. To support 64 bit pointers, the enumeration context is inserted into a global linked list and given a unique 32 bit value as identifier for later lookup.
The way the function is implemented, leaking a data structure while the MSDN description does not indicate that, seems a little questionable in general, but that is something that I leave to the original author to investigate.
The Reserved field is ULONG and we need ULONG_PTR. ClassInstallReserved was unused so far. I have no idea whether this is correct, but it cannot be more incorrect than what we had.
