Commit graph

60790 commits

Author SHA1 Message Date
Thomas Faber 07232c5dd8 [SHELL32]
- Show a confirmation dialog when emptying the recycle bin. Patch by Robert Naumann, with some modifications by me.
CORE-9006 #resolve

svn path=/trunk/; revision=66222
2015-02-11 11:06:12 +00:00
Timo Kreuzer 4b22cb6483 [GDI32_APITEST]
Add more tests for MaskBlt

svn path=/trunk/; revision=66221
2015-02-10 22:33:19 +00:00
Timo Kreuzer 95d5773b2e [GDI32_APITEST]
Add more helper code

svn path=/trunk/; revision=66220
2015-02-10 22:31:17 +00:00
Daniel Reimer bd1dc3f8ca [BROWSEUI]
Fix german layout to... look better.

svn path=/trunk/; revision=66219
2015-02-10 21:02:11 +00:00
Thomas Faber a7c7e5b7cf [GDI32_APITEST]
- Fix flakiness in GetDIBits test

svn path=/trunk/; revision=66218
2015-02-10 20:29:54 +00:00
Hermès Bélusca-Maïto 9c52a6c77b [CONSRV]: Fix a DPRINT.
svn path=/trunk/; revision=66217
2015-02-10 18:27:34 +00:00
Aleksandar Andrejevic 7ffd32d418 [FAST486]
Implement Fast486FpuMultiply properly.


svn path=/trunk/; revision=66216
2015-02-10 17:29:26 +00:00
Daniel Reimer fdc2ad5b23 [BROWSEUI]
German update.
(Is it possible that our browseui is not even similar to the one from Win 5.2?)

svn path=/trunk/; revision=66215
2015-02-10 02:03:35 +00:00
Daniel Reimer ab2c8401b7 [BROWSEUI]
Sync all languages with the once more not synced English one... Every language has a different state and no one sees that if the new strings are not added in there. At least add the English original. Thx for understanding.
DIALOG -> DIALOGEX

svn path=/trunk/; revision=66214
2015-02-09 23:25:49 +00:00
Giannis Adamopoulos 791bd8a318 Fix build on unix hosts
svn path=/trunk/; revision=66213
2015-02-09 22:31:53 +00:00
Giannis Adamopoulos bb9cc13c1f [BROWSEUI]
- Implement CProgressDialog based on wine
- Patch by Huw Campbell, improved by me
CORE-4476

svn path=/trunk/; revision=66212
2015-02-09 22:29:23 +00:00
Thomas Faber fd227cda35 [INCLUDE]
- Fix CListView::HitTest. Fixes stack corruption when dragging files on the desktop.
CORE-9143 #resolve

svn path=/trunk/; revision=66211
2015-02-09 19:59:59 +00:00
Thomas Faber c066cbd438 [USER32]
- In ICO_ExtractIconExW, don't try to return two icons if only one was requested. Fixes stack corruption.
CORE-9142 #resolve

svn path=/trunk/; revision=66210
2015-02-09 19:04:42 +00:00
Giannis Adamopoulos 7b2c9d42ef [COM_APITEST]
- Test the interfaces exposed by CLSID_ProgressDialog
CORE-4476

svn path=/trunk/; revision=66209
2015-02-08 23:47:11 +00:00
Thomas Faber 3df35a13be [DDK]
- Add additional list entry checks that can be optionally enabled by defining EXTRA_KERNEL_LIST_ENTRY_CHECKS. These checks warn against attempts to remove items from an empty list, which can easily be an error (and is trivial to avoid where it's not).
- Enable these checks by default for ReactOS code
CORE-8419 #resolve

svn path=/trunk/; revision=66208
2015-02-08 14:22:26 +00:00
Thomas Faber 5a1de25f17 [NTOS]
- Avoid removing list entry if the list is empty in IopUnQueueIrpFromThread
CORE-8419

svn path=/trunk/; revision=66207
2015-02-08 14:15:45 +00:00
Thomas Faber a5667eedbc [DDK]
- Add list entry security checks equivalent to those in current WDKs. This is useful for ROS because it detects memory corruption very quickly.
CORE-8419

svn path=/trunk/; revision=66206
2015-02-08 13:22:06 +00:00
Eric Kohl f2772f2806 [NTOSKRNL]
Implement NtSaveMergedKeys and its backend CmSaveMergedKeys.

svn path=/trunk/; revision=66205
2015-02-08 11:49:58 +00:00
Thomas Faber f142ee5329 [DDK]
- Add RtlFailFast and FAST_FAIL_* codes
CORE-8419

svn path=/trunk/; revision=66204
2015-02-08 10:57:47 +00:00
Johannes Anderwald 89896f9912 [PORTCLS]
- fix crash / assert triggered with cwawdm driver
- fix irp leak
- CORE 7822

svn path=/trunk/; revision=66203
2015-02-08 08:11:51 +00:00
Hermès Bélusca-Maïto 3d3bdc5873 [WINSRV]: Remove some deprecated code, keep other parts for reusage later on; cleanup SrvExitWindowsEx. If you enable the NotifyAndTerminateProcess call, you get a basic win32 process termination. This is now where the real work starts: do not kill CSRSS nor Winlogon, do not kill processes from other sessions, etc... Deal with console apps; display timeout dialog, and focus on the app that blocks shutdown by switching to the correct desktop. And we MUST NOT use user32 desktop APIs for switching to the different desktops, but we need to directly call win32k!! (for reasons that will appear later on; not implemented at the moment). Giannis, I will need your help for that!
Part 10/X
CORE-8322

svn path=/trunk/; revision=66202
2015-02-08 00:54:22 +00:00
Thomas Faber 683c14c278 [SPEC2DEF]
- Don't warn about symbols that should be private on MSVC builds. Link already does this.
CORE-8445

svn path=/trunk/; revision=66201
2015-02-08 00:00:30 +00:00
Thomas Faber b8808ef996 [CMAKE]
- Support NO_PRIVATE_WARNINGS parameter when invoking spec2def to suppress warnings about symbols that should be private
- Disable such warnings for msxml3, ole32 and rsaenh
CORE-8445

svn path=/trunk/; revision=66200
2015-02-07 23:54:15 +00:00
Hermès Bélusca-Maïto 41180fb6b0 [SPEC2DEF]: Display the -private exports warning *only* when making import libs.
CORE-8445 #comment -private warning only displayed for import libs.

svn path=/trunk/; revision=66199
2015-02-07 21:42:26 +00:00
Thomas Faber cfcdf14cef [SPEC2DEF]
- Remove space before colon in error messages

svn path=/trunk/; revision=66198
2015-02-07 21:20:15 +00:00
Hermès Bélusca-Maïto 38bb64ba24 [WINLOGON]
- Add DPRINTs to monitor how shutdown goes on (obviously they will go away when shutdown on ROS will be working).
- Add dumb handler for LN_LOGOFF_CANCELED message (unused for now...)

[WIN32K]: DPRINTs added for monitoring shutdown.

[WINSRV]: Start to plugin the whole thing (using pieces of Alex' shutdown patch):
- We need to use a "shutdown" loop (for UserThreadInitiateShutdown win32k call) for being able to cancel shuts down (not implemented yet).
- Add the "magic" call to CsrShutdownProcesses that calls the Shutdown callback of each CSR server for each Win32 process (these are those callbacks that do the real job of terminating the apps, displaying the "Kill the app" dialog, etc...). In few words, the old (disabled) code of InternalExitReactos need to go into those shutdown callbacks (but this is for other commits!).

Part 9/X

CORE-8322 #comment Continue plugging in the shutdown code (from Alex' patch) in WINSRV with adaptations into WINLOGON (+ adding DPRINTs for controlling the whole thing).

svn path=/trunk/; revision=66197
2015-02-07 20:46:27 +00:00
Amine Khaldi aeaff2bf59 [WIN32K:INCLUDES] Some formatting fixes. NFC.
svn path=/trunk/; revision=66196
2015-02-07 19:14:42 +00:00
Timo Kreuzer 981aafb792 [WIN32K]
Fix the ROP code passed to IntEngStretchBlt from NtGdiStretchDIBitsInternal. Fixes crash of Nimbus Notes installer.
CORE-9048 #resolve

svn path=/trunk/; revision=66195
2015-02-07 17:51:20 +00:00
Hermès Bélusca-Maïto 159c00fe95 [WIN32k:includes] Whitespace fixes.
svn path=/trunk/; revision=66194
2015-02-07 16:19:57 +00:00
Timo Kreuzer 880a4bf3de [FREELDR]
- #ifdef DBG -> #if DBG
- #if 0 DbgDumpMemoryMap()

svn path=/trunk/; revision=66193
2015-02-07 15:52:18 +00:00
Hermès Bélusca-Maïto b8d8fbdc9d [WINLOGON][WIN32K]
Move the shutdown privilege check from winlogon to win32k (function "UserInitiateShutdown") as it should be done.

[WIN32K]
- Introduce the pair of UserInitiateShutdown/UserEndShutdown calls that should be called when WINSRV starts a shutdown (and when it finishes it). In particular it is in UserInitiateShutdown that we need to check whether the caller has the rights to perform a shutdown (it should also have a valid window station).
- Remove the ROS-specific TWOPARAM_ROUTINE_EXITREACTOS call that is traded for Win2k3-compatible call to UserInitiateShutdown.

[WINSRV]
Hackfix our current ExitWindowsEx functionality (based on a patch by Alex made against r46050 for win32csr) to make it "compatible" with the improvements in win32k: impersonate the caller and call the UserInitiateShutdown win32k system call (instead of the TWOPARAM_ROUTINE_EXITREACTOS). More will come later on.

[USER32]
Win32k can require performing shutdown in an asynchronous way (needed also on WINSRV side) so we need to put all the code in a worker thread.

Part 8/X (part 6 was r65693 and part 7 was r66186).

CORE-8322 #comment Start to add Alex' win32csr shutdown patch in WINSRV; fixes for winlogon and additions to win32k.

svn path=/trunk/; revision=66192
2015-02-07 15:26:42 +00:00
Timo Kreuzer 8e988cc2f3 [MKHIVE]
Add back CmpAllocate prototype. Fixes MSVC warnings.

svn path=/trunk/; revision=66191
2015-02-07 15:05:04 +00:00
Giannis Adamopoulos 42554e6098 [SHELL32]
- Get rid of IDD_FILE_COPY dialog. It was never used, never completed and windows don't really have such a dialog.
- Remove SHShowFileOperationDialog which was never completed. This will be replaced shortly with a working solution by Huw Davies 

svn path=/trunk/; revision=66190
2015-02-07 14:42:39 +00:00
Thomas Faber f3b718e042 [RTL]
- Implement RtlIpv4StringToAddressW. Dedicated to Jérôme. Thanks to the countless reviewers.
CORE-6490

svn path=/trunk/; revision=66189
2015-02-07 13:24:29 +00:00
Thomas Faber 008adec92d [WIN32K]
- Do not use an uninitialized variable in UserSetProcessWindowStation. Feel free to fix this properly

svn path=/trunk/; revision=66188
2015-02-07 11:11:37 +00:00
Thomas Faber 16c8f0601d [RTL]
- Implement RtlIpv4StringToAddressA and RtlIpv4StringToAddressExA using their -W counterparts
CORE-6490

svn path=/trunk/; revision=66187
2015-02-07 10:07:24 +00:00
Hermès Bélusca-Maïto 3e714d22fb [WINLOGON][WIN32K]: Tend towards Win2k3-compatible winlogon logoff/shutdown messaging. Something that needs to be fixed is that it is not winlogon that checks whether the app requesting the shutdown has the correct rights, but it is win32k. I temporarily disable this check in winlogon (it's not as if we introduced a security breach in ReactOS ^^)
svn path=/trunk/; revision=66186
2015-02-07 01:18:40 +00:00
Hermès Bélusca-Maïto 94c27d3aeb [WINSRV]: Remove a long standing hack (added 4 years ago) that is now useless.
CORE-5138 #comment Hack from r51460 finally removed.

svn path=/trunk/; revision=66185
2015-02-06 23:29:09 +00:00
James Tabor cc48a3494b [User32]
- Patch by Huw Davies : Merge the blitting of the centered and non-centered cases.

svn path=/trunk/; revision=66184
2015-02-06 21:17:10 +00:00
James Tabor e0152471f9 [WineTests|User32]
- Sync Combo to wine head. Patch by Huw Davies : Make the combo's listbox a topmost window. See CORE-5186 for prior report.

svn path=/trunk/; revision=66183
2015-02-06 21:07:59 +00:00
James Tabor 4cb4ee6326 [User32]
- Patch by Piotr Caban : Only store dialog focus when window is hidden or inactive. Only use DIALOGINFO-> hwndFocus to store last focus of inactive windows.

svn path=/trunk/; revision=66182
2015-02-06 20:57:45 +00:00
James Tabor d783274010 [WineTests|User32]
- Sync Dialog to wine head.

svn path=/trunk/; revision=66181
2015-02-06 20:56:57 +00:00
Jérôme Gardou fcddf62f18 [KMTEST/TCPIP]
- Add tests checking for TDI_CONNECT behaviour.

svn path=/trunk/; revision=66180
2015-02-06 10:49:04 +00:00
Hermès Bélusca-Maïto 51d68a3329 [FREELDR]
- For now, only activate custom ReactOS boot on non-x86 builds.
- Fix INI section item list initialization before using it! Fixes custom ReactOS boots (ie. remove an invalid heap free). Now custom ReactOS boots work!

svn path=/trunk/; revision=66179
2015-02-06 01:21:45 +00:00
Hermès Bélusca-Maïto 149e5e961a [SHELL32]
- Fix registry value retrieval with RegGetValue (RRF_RT_REG_EXPAND_SZ has a non-obvious functioning: it should be used with NO_EXPAND flag. Otherwise use RRF_RT_REG_SZ to retrieve REG_SZ values, or REG_EXPAND_SZ values with automatic expansion as expected). CORE-9001 #resolve #comment Fixed, thanks for reporting!
- Fix whitespace.

svn path=/trunk/; revision=66178
2015-02-06 00:07:23 +00:00
James Tabor b07541cc5d [Win32ss]
- Validate the parent window before locking it. Attempt to fix CORE-9117.

svn path=/trunk/; revision=66177
2015-02-05 23:46:57 +00:00
Amine Khaldi bff824b2ca [DLLs] Revert r66167 (Privatize the exports that should be so). Fixes MSVC build. Of course the glorious GCC toolchain is oblivious to this.
svn path=/trunk/; revision=66176
2015-02-05 22:12:55 +00:00
James Tabor 4f897d6aa9 [User32]
- Return timeout if the count and wait time is zero. This is a wine hack and fixes two related mgs:test_MsgWait* tests. Attempt to fix CORE-9117. Not sure if MsgWaitForMultipleObjects is the problem.

svn path=/trunk/; revision=66175
2015-02-05 21:31:05 +00:00
Hermès Bélusca-Maïto d511783a3c [FREELDR]: Remove some extra newlines at the end of error messages that are displayed via message boxes, and also for few of them, use the fact that our message boxes implement printf-like features.
svn path=/trunk/; revision=66174
2015-02-05 21:24:26 +00:00
Hermès Bélusca-Maïto 927ab9996d [FREELDR]: Fix initialization of BootPath variable, and add some explanation comment as requested long time ago by Pierre.
svn path=/trunk/; revision=66173
2015-02-05 21:17:35 +00:00