Commit graph

77055 commits

Author SHA1 Message Date
Katayama Hirofumi MZ
0a626dedf8
[SHELL32] Set read-only for some shell folders and delete Desktop.ini of Desktop and Program Files (#2385)
Set read-only attribute instead of system attribute for some shell folders that has a folder icon.
Delete desktop.ini files in Desktop and Program Files. CORE-16711
2020-02-25 10:07:58 +09:00
Thomas Faber
80296be1eb
[CMAKE] When disabling C4101, explicitly remove the error flag.
Fixes VC2010 build.
Addendum to 11ecf5c969.
2020-02-24 22:29:33 +01:00
Colin Finck
5d8c39753e
[GDI32] GdiConvertToDevmodeW: Import WINE commit 32393796bb534e9cf11dd988dce88722c67f7906 ("gdi32: GdiConvertToDevmodeW should not refer to unintialized name bytes.")
This makes our GdiConvertToDevmodeW equivalent to the WINE counterpart again.
2020-02-24 19:17:56 +01:00
Bișoc George
b77008a709
[TIMEDATE] Remove lpszSyncStatus member entirely (#2383)
And directly pass the formatted string to SetDlgItemTextW(). Addendum to 5a81a5b.
2020-02-24 16:59:11 +01:00
Katayama Hirofumi MZ
fe39760206
[SHELL32_APITEST] Add SHChangeNotify testcase (#2378)
Add a testcase for shell32!SHChangeNotify function to investigate the shell notification mechanism. CORE-13950
2020-02-25 00:45:44 +09:00
Bișoc George
5a81a5bc14
[TIMEDATE] Implement the dynamic NTP status notification (#2352)
Time/Date control panel applet displays the status of the NTP server synchronization with the system informing the user the actual condition of the said sync, if it has failed or suceeded. The commit also implements IDS_INETTIMEWELCOME which serves as a placeholder as Time/Date loads the last successful attempt of NTP synchronization which I don't know how the CPL remembers it. With that said, IDS_INETTIMEWELCOME will stay for a while until someone figures out how timedate.cpl works internally.
CORE-16684
2020-02-24 19:56:02 +09:00
Thomas Faber
11ecf5c969
[CMAKE] Enable C4101 (unreferenced local variable) for MSVC builds.
This is already an error in GCC builds, so will make it harder for the
MSVC crowd to accidentally break GCC build.
2020-02-24 11:01:43 +01:00
Thomas Faber
cdb6af05a7
[TRAVIS] Disable code format checker in CI.
The configuration is not final yet and we have a lot of files that don't
follow the suggested style. At this point, having it active in CI means
builds are essentially always red, and we miss actual compilation errors.
2020-02-24 11:01:09 +01:00
Katayama Hirofumi MZ
d1ac13c64b [MSVCRT_WINETEST] Fix build by adding '-Wno-format'
ed909ba broke build.
2020-02-24 09:43:58 +09:00
Stanislav Motylkov
dbeaef63c1
[HAL] Fix debug prints in ShowSize() and its caller (#2377) 2020-02-23 23:02:40 +01:00
Mark Jansen
60e89359c1
More very serious issue pointed out by gcc 2020-02-23 22:41:42 +01:00
Hermès Bélusca-Maïto
1d3fb3e370
[CONSRV] Fix setting the default screenbuffer and console view sizes when creating a new screenbuffer.
For more information, see:
https://docs.microsoft.com/en-us/windows/console/createconsolescreenbuffer#remarks
2020-02-23 22:43:02 +01:00
Mark Jansen
309f7e9443
gcc is crying again 2020-02-23 22:36:03 +01:00
Eric Kohl
482eb909fe [NTOS:CONFIG] Fix NtSetValueKey data probing
Probe the data before allocating a copy buffer. Otherwise NtSetValueKey returns an unexpected status code in case of too large data size.

This fixes the NtSetValueKey ntdll api tests.
2020-02-23 21:35:57 +01:00
Mark Jansen
dee771817e
[RAPPS] Allow tabbing trough controls in the main window 2020-02-23 17:52:05 +01:00
Serge Gautherie
2eed38eb5f [OLEACC_WINETEST] Re-enable MSVC warning C4477
Follow-up to 3ee20de95f.
2020-02-23 17:50:58 +01:00
Serge Gautherie
ed909ba9d9 [MSVCRT_WINETEST] Re-enable MSVC warning C4477
Follow-up to ce2df64a06.

Also, remove '-Wno-format' for other compilers.
2020-02-23 17:50:58 +01:00
Doug Lyons
4e721f780e
[SHELL32] Fix unneeded error Popup with Git for Windows. (#1854)
* Fix unnecessary error popup when installing Git for Windows.
* Add reasons for return value of 42.
2020-02-23 17:47:48 +01:00
Oleg Dubinskiy
b749501976 [APPCOMPAT][ACCPAGE][SDB][ROSTESTS] Implement compatibility modes for Windows 10, Server 2016 and 2019 2020-02-23 17:43:40 +01:00
Hermès Bélusca-Maïto
c6058bca24
[ATL] Import Wine upstream patch 3043ab3e62
Author: Puetz Kevin A <PuetzKevinA@JohnDeere.com>
atlbase.h: Fix some declarations on win64.

Signed-off-by: Jacek Caban <jacek@codeweavers.com>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-23 16:52:03 +01:00
Hermès Bélusca-Maïto
b4b0728684
[ATL30] Addendum to commit e410a122: Import Wine upstream patch 5608682dc9
atl: Fix the ATL_WNDCLASSINFOW::m_szAutoName member definition and construction.

Signed-off-by: Hermes Belusca-Maito <hermes.belusca@sfr.fr>
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2020-02-23 16:51:58 +01:00
Joachim Henze
820dbfccd0 [NTUSER] Fix regression CORE-11828
Fixes symptom "mouse pointer vanishes when closing
applications via x in title-bar"

The bug in WIN32SS was unhidden by SVN r65496 == git
5c1a8109c8
, when we introduced explorer_new. The old explorer
had a workaround built within.

Many thanks to patches author James Tabor.
I intend to backport into 0.4.13RC as well.
2020-02-23 13:56:05 +01:00
Serge Gautherie
02327ed665 [CODEOWNERS] Add ending '/' to '/dll/shellext' 2020-02-23 12:36:42 +01:00
Serge Gautherie
1a83762ccc [REACTOS] Fix '\n.' typos 2020-02-23 12:35:50 +01:00
Joachim Henze
99ba7ea95f [FREETYPE] Fix regression fonts in Adobe Photoshop CS2 menu CORE-16694
By Reverting beginnings of raster-fonts-works (*.fnt and *.fon)
Thanks Katayama Hirofumi MZ for helping with this revert.

The regression was introduced by 0.4.13-dev-681-g
ae99df1675

I will also port this revert back into 0.4.13-RC
2020-02-23 12:23:05 +01:00
Eric Kohl
c11491b750 [UMPNPMGR] Improve PNP_DeviceInstanceAction
- Rename parameters according to [MS_PNPR] (no longer available for download).
- Remove unsupported PNP_DEVINST_MOVE and PNP_DEVINST_DISABLE actions.
- Implement most of the PNP_DEVINST_SETUP action.
2020-02-23 10:44:43 +01:00
Hermès Bélusca-Maïto
90d795b0bf
[CONSRV] Keep a count of input events in the console queue + code simplifications.
- Update the documentation of members of CONSOLE_INPUT_BUFFER.
- Simplify ConDrvGetConsoleNumberOfInputEvents().
- Simplify ConDrvFlushConsoleInputBuffer().
- Use also GetConsoleInputBufferMode() more often.
2020-02-22 23:27:42 +01:00
Hermès Bélusca-Maïto
570eba2a52
[KERNEL32][CONSRV] Use more often the internal ConioRectHeight/Width() and ConioIsRectEmpty() macros. 2020-02-22 21:15:58 +01:00
Hermès Bélusca-Maïto
05053b6f18
[CONSRV] ConDrvScrollConsoleScreenBuffer() fixes. (#2278)
- Reimplement ConDrvScrollConsoleScreenBuffer() with separate copy and
  fill helper functions and calculate rectangles in such a way as to
  never use X-Y coordinates pointing outside of the screen buffer.

- Add X-Y coordinates assertions in ConioCoordToPointer().
2020-02-22 19:50:18 +01:00
Hermès Bélusca-Maïto
d46e054368
[CONSRV] Miscellaneous console fixes for CJK support and screenbuffer iteration. (#2278)
+ popup.c!DrawBox(): Factor out setting the attribute value.
2020-02-22 19:50:17 +01:00
Hermès Bélusca-Maïto
ce3a0af4f0
[KERNEL32_APITEST] Add extra test cases for the 'ConsoleCP' test. (#2278) 2020-02-22 19:50:12 +01:00
Joachim Henze
feb7df42b4 [WIN32SS] Fix a typo in dbg print 2020-02-22 19:40:52 +01:00
Mark Jansen
6b0ddf6813 [LOG2LINES] Remove SVN leftovers 2020-02-22 13:48:18 +01:00
Thomas Faber
754e175d12
[NTOS:MM] Use MI_ZERO_PTES as the number of usable zeroing PTEs, not the total allocated. CORE-11856
We'll now have 32 usable zeroing PTEs instead of 31.
MP kernels will (some day) zero up to 32 pages at a time.
2020-02-22 12:33:54 +01:00
Bișoc George
61c8d3432c
[MSGINA] Be sure to always initialize the cached DLG_DATA GINA context (#2360)
The ReactOS logo banner is loaded from the GINA context whereas the animation bar is loaded from the main application instance. However, the aforementioned context is not initialized when WM_INITDIALOG occurs hence DlgData_LoadBitmaps() would fail on proceeding at loading the remaining bitmaps to be loaded.

This fixes the regression introduced by commit 623dd26c (PR #2353).
2020-02-20 00:20:01 +01:00
Katayama Hirofumi MZ
623dd26cce
[MSGINA] Make DLG_DATA object-oriented (#2353)
- Rename hBitmap as hLogoBitmap of DLG_DATA structure.
- Add DlgData_Create. DlgData_LoadBitmaps, and DlgData_Destroy functions.
CORE-16697
2020-02-18 14:35:44 +09:00
Serge Gautherie
b326312d52 [KS] KsQueryInformationFile(): Fallback to IRP if FastIO failed
Or, if it succeeded, return the actual NTSTATUS, not an unrelated BOOLEAN.

Addendum to commit 4725a4fd9c (r42117).

CORE-16618
2020-02-17 19:08:57 +03:00
Serge Gautherie
7405dc36b6 [KS] KsQueryInformationFile(): Merge IoStatus and StatusBlock
Addendum to commit 9061b8ee40 (r42334).
2020-02-17 19:08:57 +03:00
Eric Kohl
774a4252b9 [UMPNPMGR] Improve some DPRINTS and PNP_CreateKey
PNP_CreateKey creates the 'Device Parameters' key for a given device in the enum key
2020-02-16 22:08:34 +01:00
Andreas Maier
8b0cfa1d3c
[MSV1_0] Improve LogonUserEx2 (#2356)
- Improve traces, using %wZ for UNICODE_STRING;
- Fix UNICODE_STRING validation.
2020-02-16 16:55:31 +01:00
Eric Kohl
00a47324f2 [UMPNPMGR] Replace magic values and improve DPRINTS in exported function 2020-02-16 16:29:44 +01:00
Eric Kohl
f9160f7637 [UMPNPMGR] Implement PNP_RegisterDriver() 2020-02-16 11:13:10 +01:00
Thomas Faber
696cdc635b
[ACPICA] Update to version 20200214. CORE-16696 2020-02-15 20:45:53 +01:00
Thomas Faber
81e6846e06
[ACPICA] Update to version 20200110 (Copyright update only). CORE-16696 2020-02-15 20:45:48 +01:00
Thomas Faber
5e891f727f
[NTOS:WMI] WMIP_GUID_OBJECT must start with an event object, as it is waitable.
The initializer for WmipGuidObjectType does not set UseDefaultObject,
and it's possible for user mode to obtain a handle to a GUID object
with SYNCHRONIZE access. Therefore that handle can be passed to
NtWaitForSingleObject, which means it must start with a DISPATCHER_HEADER.
2020-02-15 20:43:26 +01:00
Oleg Dubinskiy
7075bdacb2
[SHELL32] Don't hardcode My Documents path for My Music/Pictures/Videos folders in some translations (#2354)
Don't hardcode My Documents path in some translations of My Music, My Pictures and My Videos folders in Shell32. It fixes incorrect location of that folders when install ReactOS as Workstation.
Currently they are located in one more My Documents subfolder, which is, in its turn, in the correct My Documents directory. After this fix, they are directly in the 2nd one, as they should be.

CORE-16698
2020-02-15 20:06:16 +01:00
Victor Perevertkin
0d6e522c6a
[SDK][CRT] Correct stdbool.h and remove an unused one 2020-02-15 18:39:01 +03:00
Victor Perevertkin
1d069269f5
[FREELDR] Fix build by adding a missing header 2020-02-15 18:25:57 +03:00
Eric Kohl
4f23b0c3df [W32TIME] Rename ServiceMain to W32TmServiceMain 2020-02-15 15:08:19 +01:00
Katayama Hirofumi MZ
9da842a647 [CPL][ACCESS] Japanese translation more 2020-02-15 11:09:04 +09:00