Intravision/reactos

78005 commits 85 branches 274 tags 1.1 GiB

Author	SHA1	Message	Date
Bișoc George	8ec05f5fa1	[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() (#2113 ) ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found. PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures. CORE-16535	2019-12-12 08:24:20 +09:00
Colin Finck	c2c66aff7d	Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.	2017-10-03 07:45:34 +00:00

Author

SHA1

Message

Date

Bișoc George

8ec05f5fa1

[SHELL32] Do not return -1 if a file is not valid or not found - ExtractIconEx() (#2113 )

ExtractIconEx() returns the number of successfully extracted icons from a file. The routine may return 0 in case no icons could be extracted but it could also return 0 if the file is not a valid PE image file or the file couldn't be found.

PrivateExtractIcons and the internal USER32 routine, ICO_ExtractIconExW(), return -1 in such scenarios. The behaviour is correct however we do not want that ExtractIconEx() returns -1 as well as it doesn't comply with the general documentation. In such cases, simply return 0 as no successful icons have been extracted due to related file failures.

CORE-16535

2019-12-12 08:24:20 +09:00

Colin Finck

c2c66aff7d

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

Renamed from reactos/dll/win32/shell32/iconcache.cpp (Browse further)

2 commits