Commit graph

45 commits

Author SHA1 Message Date
Claudiu Mihail ec47e5b8d5 [shell32.dll]
[FORMATTING]
- Second wave of formatting. At least now we won't have any tabs and spaces mixed in.

svn path=/branches/shell32_new-bringup/; revision=53651
2011-09-08 22:43:43 +00:00
Claudiu Mihail 13df60a8ec [shell32.dll]
- Fix bug 6336 of shell32_new. The bug was caused by not properly verifying the return value of ShellExecuteExW.
[FORMATTING]
- First wave of accidental formatting (sorry again about mixing code and formatting heh).

svn path=/branches/shell32_new-bringup/; revision=53650
2011-09-08 22:42:01 +00:00
Claudiu Mihail 29ca67f252 [shell32.dll]
- Make sure the ParseDisplayName functions make the ppidle parameter NULL whenever that's possible. Scores a wine test. Spotted by Victor Martinez.

svn path=/branches/shell32_new-bringup/; revision=53641
2011-09-08 14:07:02 +00:00
Claudiu Mihail 261ee4dd58 [shell32.dll]
- Initialize uninitialized variables.
- Add code to guard against potential NULL pointer dereferencing.
Thanks to Amine Khaldi for pointing out all these.

svn path=/branches/shell32_new-bringup/; revision=53633
2011-09-07 23:21:02 +00:00
Claudiu Mihail ea0da4a0a3 [shell32.dll]
- More uninitialized value fixing. Again Amine Khaldi spotting them with his magical powers.
- I took the liberty to convert tabs I found to spaces. Normally I shouldn't mix formatting with coding changes but I forgot. Sorry.

svn path=/branches/shell32_new-bringup/; revision=53629
2011-09-07 20:00:32 +00:00
Claudiu Mihail 34529d672c [shell32.dll]
- Attempt at fixing bug 6315 (it doesn't completely work yet). Original patch by Edijs Kolesnikovics.

svn path=/branches/shell32_new-bringup/; revision=53628
2011-09-07 19:00:26 +00:00
Claudiu Mihail aee0ef5405 [shell32.dll]
- Fix bug 6317. Patch by Edijs Kolesnikovics.

svn path=/branches/shell32_new-bringup/; revision=53624
2011-09-07 17:41:56 +00:00
Claudiu Mihail 5291d19b25 [shell32.dll]
- Fix bug 6316. Patch by Edijs Kolesnikovics.

svn path=/branches/shell32_new-bringup/; revision=53623
2011-09-07 17:10:45 +00:00
Claudiu Mihail 9f5333c3dc [shell32.dll]
- Fix bug #6301 . Patch by Edijs Kolesnikovics.

svn path=/branches/shell32_new-bringup/; revision=53622
2011-09-07 16:58:22 +00:00
Claudiu Mihail 2c7fb01198 [shell32.dll][FORMATTING]
- No code changes. Make the code more readable in preparation for investigating some failing wine tests.

svn path=/branches/shell32_new-bringup/; revision=53617
2011-09-07 13:39:13 +00:00
Claudiu Mihail 7a20b6f2bb [shell32.dll]
- Another round of fixing badly initialized variables. Again Amine Khaldi being the hero.

svn path=/branches/shell32_new-bringup/; revision=53613
2011-09-07 01:33:31 +00:00
Claudiu Mihail 270842aeb0 [shell32.dll]
- Initialize uninitialized variables in constructors.
[atl]
- Initialize uninitialized variables in constructors.
All spotted by Amine Khaldi.

svn path=/branches/shell32_new-bringup/; revision=53612
2011-09-06 23:52:38 +00:00
Giannis Adamopoulos 6cc65f4e4f [shell32]
- Add missing initialization. Fixes the problem where explorer fails to show the child window at the first attempt to open a folder

svn path=/branches/shell32_new-bringup/; revision=53610
2011-09-06 20:20:54 +00:00
Amine Khaldi 26f6b8c7f7 [FORMATTING]
* No code changes.

svn path=/branches/shell32_new-bringup/; revision=53546
2011-09-03 15:37:09 +00:00
Claudiu Mihail 8af812d602 [shell32.dll]
- Fix bug related to correct error code returning in delete_files. The value of 1026 was revealed to be returned by windows 2003 server. Score several passed winetests.
- Fix a bug in ShellLink::SetShowCmd and score one more passed winetest

svn path=/branches/shell32_new-bringup/; revision=53543
2011-09-03 14:20:03 +00:00
Claudiu Mihail 833aa3ffef [shell32.dll]
- Don't do some parameter checks, even if MSDN says they're incompatible. Winetests with windows 2003 server as reference tells us msdn lies. (Spotted by Victor Martinez)

svn path=/branches/shell32_new-bringup/; revision=53541
2011-09-03 10:55:51 +00:00
Claudiu Mihail 71fb1022d3 [shell32.dll]
[FORMATTING]
- Don't use tabs, use spaces.

svn path=/branches/shell32_new-bringup/; revision=53538
2011-09-03 00:13:22 +00:00
Claudiu Mihail b815342563 [shell32.dll]
[FORMATTING]
- Format the code to a more acceptable level. This is just for my sanity while sifting through it.

svn path=/branches/shell32_new-bringup/; revision=53537
2011-09-03 00:08:11 +00:00
Claudiu Mihail 5beaebef93 [shell32.dll]
- replace DbgPrints with TRACE.

svn path=/branches/shell32_new-bringup/; revision=53534
2011-09-02 19:56:58 +00:00
Claudiu Mihail 18d876cbf2 [shell32.dll]
- rewrite the parser to handle command line argument parsing
- include basic description of what the rules for parsing are
- some minor formatting here and there (couldn't be helped)

svn path=/branches/shell32_new-bringup/; revision=53533
2011-09-02 19:29:30 +00:00
Amine Khaldi fc902e6f58 * Sync to trunk HEAD (r53473).
svn path=/branches/shell32_new-bringup/; revision=53475
2011-08-27 19:26:31 +00:00
Amine Khaldi cce9b8224b [SHELL32]
Claudiu Mihail:
* Return ERROR_FILE_NOT_FOUND when a file isn't found. Similar to r53373.

svn path=/branches/shell32_new-bringup/; revision=53378
2011-08-22 16:32:16 +00:00
Amine Khaldi a3621e43e3 [SHELL32]
Claudiu Mihail:
* Formatting fixes.
* autocomplete test fix.

svn path=/branches/shell32_new-bringup/; revision=53376
2011-08-22 16:28:51 +00:00
Amine Khaldi efa1f39fbc * Merge r53373 from trunk.
svn path=/branches/shell32_new-bringup/; revision=53374
2011-08-22 15:31:21 +00:00
Amine Khaldi 56f6314a44 * Somehow these got missed in the sync, even though they were marked as committed...
svn path=/branches/shell32_new-bringup/; revision=53339
2011-08-20 13:55:31 +00:00
Amine Khaldi 178300c8a6 * Sync to trunk HEAD (r53318).
* Fix PCH use in shell32.

svn path=/branches/shell32_new-bringup/; revision=53319
2011-08-19 17:45:34 +00:00
Kamil Hornicek 4cf027e1a0 [SHELL32_NEW]
Fix building with CMake. Had to turn PCH off as Amine suggested, it needs more work.

svn path=/branches/shell32_new-bringup/; revision=52021
2011-05-31 16:55:10 +00:00
Ged Murphy 2b229750a4 [SHELL32_NEW]
- Merge 51783
- The final revision to merge from the existing shell32 code.
- The C++ shell32 module is now fully up to date and ready for testing.

svn path=/branches/shell32_new-bringup/; revision=51941
2011-05-26 22:04:22 +00:00
Ged Murphy 175a443bf4 [SHELL32_NEW]
- Merge 51729
Implement SHGetImageList
9db87f13d3
Fixes explorer++ main window

svn path=/branches/shell32_new-bringup/; revision=51940
2011-05-26 22:01:05 +00:00
Ged Murphy f90c74df0d [SHELL32_NEW]
Merge 51602, 51604, 51701, 51702

svn path=/branches/shell32_new-bringup/; revision=51939
2011-05-26 21:53:16 +00:00
Ged Murphy 574b76d09f [SHELL32_NEW]
- Merge 51586, 51592, 51596

svn path=/branches/shell32_new-bringup/; revision=51938
2011-05-26 21:43:27 +00:00
Ged Murphy c09e3bd756 [SHELL32_NEW]
- Merge 51436, 51448 and 51526

- Properly support WM_SYSCOLORCHANGE in ShellView window. Changing system colors in ReactOS works perfectly now :)

svn path=/branches/shell32_new-bringup/; revision=51937
2011-05-26 21:36:39 +00:00
Ged Murphy b0ebdd8ffe [SHELL32_NEW]
- Merge 51423, 51426 and 51435

- Remove "Play" and "Preview" translations - they shouldn't be in shell32
- Pass an argument array to FormatMessage to insert the filename details into error messages (instead of failing)

svn path=/branches/shell32_new-bringup/; revision=51934
2011-05-26 21:11:36 +00:00
Ged Murphy 83c347aaef [SHELL32_NEW]
- Merge 51322 and 51323
- Return 1 in WM_ERASEBKGND when desktop is painted
- Fix background for desktop icons and their labels
- Moreover fixes explorer_new background
- Properly arrange icons in explorer shell view window. This also fixes navigating in files with keyboard arrows

svn path=/branches/shell32_new-bringup/; revision=51915
2011-05-25 21:28:27 +00:00
Ged Murphy 4324e5e4e1 [SHELL32_NEW]
- Merge 51309
- Fix control style of property dialogs

svn path=/branches/shell32_new-bringup/; revision=51914
2011-05-25 21:16:20 +00:00
Ged Murphy 5dbb8d0d8f [SHELL32_NEW]
Merge 51133, 51199, 51206, 51285, 51294

svn path=/branches/shell32_new-bringup/; revision=51913
2011-05-25 21:13:50 +00:00
Ged Murphy 1ce880c731 Fix a warning, it builds warning free now.
svn path=/branches/shell32_new-bringup/; revision=51912
2011-05-25 21:07:25 +00:00
Ged Murphy 21ef201af1 [SHELL32_NEW]
- Merge 51127
- Sync RunFileDlg to wine

svn path=/branches/shell32_new-bringup/; revision=51911
2011-05-25 21:05:22 +00:00
Ged Murphy 4c01e6ced5 [SHELL32_NEW]
- Merge 50899, 50941, 50957, 50964, 51053

- Check the correct pidl instead of the free one
- Found by the amazing DPH!
- Return the icon index, not the icon id
-Fix missing "Open" menu entry on right click for All Users desktop shortcuts.

svn path=/branches/shell32_new-bringup/; revision=51910
2011-05-25 20:36:21 +00:00
Ged Murphy 0026704626 [SHELL32_NEW]
- Merge 50114 and 50144

- Add NULL checks in IShellView and IDropTarget implementations. Should fix bug #5780.
- Bug 5756: TRANSLATION: multiple modules: Bulgarian by CCTAHEB

svn path=/branches/shell32_new-bringup/; revision=51909
2011-05-25 20:25:42 +00:00
Ged Murphy c95b75e6f3 [SHELL32_NEW]
- Merge 49969, refactored to use CComPtr's thanks to the new C++ model (it's sooo much cleaner now)

- Implement copy / paste for files when tree view is present
- Don't add shortcuts / executables to recent file list

svn path=/branches/shell32_new-bringup/; revision=51908
2011-05-25 20:12:34 +00:00
Ged Murphy 3be178928d [SHELL32_NEW]
- Merge 48792 and 49372
- Fix rbuild file, it really will build now.

svn path=/branches/shell32_new-bringup/; revision=51897
2011-05-24 19:14:42 +00:00
Ged Murphy ef6fc48a38 [SHELL32_NEW]
- Rename the cpp based directory

svn path=/branches/shell32_new-bringup/; revision=51895
2011-05-24 19:04:11 +00:00
Ged Murphy 839070eea6 [SHELL32_NEW]
- Remove the old C based dll.

svn path=/branches/shell32_new-bringup/; revision=51894
2011-05-24 19:02:10 +00:00
Ged Murphy 4019caae75 This really needs to go in a branch. It needs heavy testing and can't coincide with the current shell32 due to PSDK interface changes
svn path=/branches/shell32_new-bringup/; revision=51893
2011-05-24 18:40:34 +00:00