Wait for the LSA server to complete its initialization before initializing the GINA dll. This change is required because future changes to MSGINAs logon code will require access to the LSA.
svn path=/trunk/; revision=59002
- Use new helpers ConsoleAllocHeap and ConsoleFreeHeap instead of RtlAllocateHeap and RtlFreeHeap, to be able to use also debug heaps etc...
- Initialize completely CONSOLE and CONSOLE_SCREEN_BUFFER structures to avoid using unitializing fields, that can be prone to bugs.
- Do not unnecessarily lock the per-process IO handles table.
- Validate the console pointers when calling SrvCloseHandle / SrvVerifyConsoleIoHandle / SrvDuplicateHandle (so that we are sure to do valid operations for console applications, and fail properly for GUI ones).
- Fix a bug caught by [TheFlash] which unveiled only on livecds (why??) as random CSR heap corruptions. It was caused by corrupting the heap by freeing invalid IO handles when freeing the handles table inherited by default when starting a console application. I reworked the initialization code a bit and the freeing code to fix this problem.
This bug was diagnosed with the help of Thomas Faber's debug heap (see http://www.reactos.org/wiki/User:ThFabba/Debug_Heap ), that I've augmented a bit (with dumping functions when a heap block was found invalid).
- Now reenable the CSR heap usage.
CORE-7157 #resolve #comment Resolved in revision 59001. Thanks for your help :D
svn path=/trunk/; revision=59001
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58990
* Fix the mismatch between sizeof and countof quantities in CdfsMakeFCBFromDirEntry.
* Properly account for '\\' and '\0'.
* Fix one more debug print specifier.
svn path=/trunk/; revision=58988
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58987
Fix a bug in size calculation that causes memory corruption on 64 bit
Fix some MSVC/x64 warnings
[UNIATA]
Fix some MSVC/x64 warnings
svn path=/trunk/; revision=58985
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58982
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58981
Allow only readonly, hidden, system and archive files attributes to be set for a new file. Other file attributes must be ignored.
This fixes several tests.
svn path=/trunk/; revision=58976
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
svn path=/trunk/; revision=58975
- FreeLdr is able now to load personalized Kernel Debugger Transport DLLs by reading at the kernel command line and interpreting the /DEBUGPORT=xxx entry (--> loads KDxxx.DLL dll in \SystemRoot\System32\).
Therefore we can not only load the "default" kdcom.dll, but also 3rd-party ones such as kdbazis.dll from VirtualKD (from revision 58902).
- The GCC-compiled-only version of kdcom, containing legacy COM code, was removed and put directly along KDBG. It remains only a stub / template for future kdcom-like dlls. The MSVC-version remains untouched.
- Make those functions ^ use directly the CPORTLIB library.
svn path=/trunk/; revision=58974
- Fix dprints (be careful when "Status" variables are booleans).
- Don't fail when trying to load an non-existent KD transport dll.
svn path=/branches/kd++/; revision=58971
* Mark SelectTimeout as a KDEFERRED_ROUTINE and fix its calling convention. This fixes a potential stack corruption.
* Brought to you by Nikolay Borisov and the MSVC static analyzer ;)
CORE-7171 #resolve
svn path=/trunk/; revision=58969
* Add some function annotations.
* Fix several debug print specifiers.
* Properly mark some unreferenced parameters as such.
* This fixes several warnings emitted by the MSVC static analyzer.
* Brought to you by Nikolay Borisov, with minor consistency styling changes by me.
CORE-7171
svn path=/trunk/; revision=58966
In fact, the kdcom used for KDBG (in GCC builds) is really a thin layer atop of CPORTLIB.
Remove extra code (remove also the KD_PORT_INFORMATION type) and replace it with calls to CPORTLIB functions.
Next step is to put all that thing into KDBG directly, as helper functions. Then, if one wants to make a really kdcom (as we have for MSVC builds), one has to refactor all KDBG.
svn path=/branches/kd++/; revision=58964
Finally reenable RtlAcquirePrivilege and RtlReleasePrivilege now that they are fixed.
[KERNEL32]
Remove the hacks in SetSystemTime() and SetLocalTime() now that RtlAcquirePrivilege is working properly.
[SYSSETUP]
Remove the hack for privileges in SetSystemLocalTime() now that SetLocalTime() can properly acquire needed privilege.
CORE-7168 #comment Fixed with r58960 #resolve
svn path=/trunk/; revision=58960
When we are impersonating, also set the flag, so that on release, we can kill it.
This hopefully fixes 2nd stage and the whole mess it was causing in privileges.
svn path=/trunk/; revision=58959
Place the (unimplemented) real KD functions into a dedicated file and isolate ReactOS-specific port functions. They can go into a libary along KDBG !
svn path=/branches/kd++/; revision=58958
Comment that part too, because it was in KdPortInitialize and here, it reported an invalid port. KdPortInUse is initialized by KDBG.
svn path=/branches/kd++/; revision=58957
Also "fix" hack of RtlAcquirePrivilege in SetSystemTime(). Spotted by Thomas.
Note for syssetup/rtl/kernel32 devs:
Make it crystal clear that this is a hack and has to be deleted once RAP is fine.
Also note that for SetLocalTime() and 2nd stage, syssetup acquires the privilege itself
in SetSystemLocalTime() before calling SetLocalTime().
This will also have to be deleted once RAP is working fine. Otherwise it will keep failing:
it is not possible to acquire a privilege already held.
svn path=/trunk/; revision=58953
