Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-12-28 18:15:11 +00:00
Code Issues Projects Releases Packages Wiki Activity
86088 commits 96 branches 276 tags 1 GiB
Commit graph

72 commits

Author SHA1 Message Date
Timo Kreuzer
34586814ab [GDI32][NTUSER] Demote noisy debug prints 2024-08-30 16:06:41 +03:00
Tomáš Veselý
a9bdd62d84
[GDI32] SetBkMode: Avoid invalid input. CORE-19656 (#7089) 
Fixes a bug in Midori 0.5.11 installer which caused bad rendering
that was making the text hard to read (no background).
In Windows it's visible as FillRect(0x89011a1f, 0x0019f87c, 0xabababab),
and in ReactOS as SetBkMode(0xb5010fce, -1546139919).

After a number of attempts to get the same behavior, I haven't found a way
to fix it without a hack to make the installer look identical to Windows.

At least I added handling for the incorrect value in SetBkMode.
This shouldn't matter anywhere. It may not look the same as on Windows,
but the text will at least be readable.
 2024-07-08 21:34:36 +03:00
Jose Carlos Jesus
c3a45b679d
Fix return value from GetObject gdi32_apitest (#7046) 2024-07-06 22:55:06 +02:00
Hermès Bélusca-Maïto
e4c4894564
[GDI32] CreateDIBSection: Remove erroneous assignation (#5502) 
bmBits is only used and assigned on output. It points (holds the address)
to the array of DIB bit values. The "Bits" parameter is however a pointer
to a variable that will receive the address of that array.
So it makes no sense to initially assign bmBits to the value of the Bits
parameter...
 2023-08-06 17:35:23 +02:00
Doug Lyons
12e1919e5e
[NTGDI][GDI32] Icon fixes for Office 2000, VB6, and Hoyle Cards (#5227) 
Many thanks for Simone Lombardo for pointing to the code needing attention
and providing a working proof-of-concept solution.

CORE-12377
CORE-18084
CORE-13889
 2023-07-02 13:24:15 +02:00
Thomas Faber
8b19b6ec5a [GDI32] Fix memory leak in case of public DC. CORE-18498 2023-01-27 22:30:35 -05:00
Thamatip Chitpong
dd75ae8eca
[WIN32SS] Use GDI_HANDLE_* macros for readability (#4797) 2022-10-26 02:17:01 +02:00
Hermès Bélusca-Maïto
58740bfbc1
[GDI32][USER32] Order the set_module_type arguments the usual way ("UNICODE" before the entrypoint). 
+ Harmonize the entrypoints as well.
 2022-10-06 15:37:23 +02:00
Mark Jansen
d84b76a69e
[GDI32] Fix ExtTextOutA with ETO_GLYPH_INDEX 
CORE-18365
 2022-09-18 20:51:12 +02:00
Victor Martinez Calvo
b57be0a746
[GDI32] Fix GetObjectW() GDI_OBJECT_TYPE_BRUSH handling. (#4394) 
This fixes the last GetObjectW apitest case:
ok_long(GetObjectA(hBrush, 0, &TestStruct), 0);

- When "cbSize" is "0", GetObjectW shouldn't return "sizeof(LOGBRUSH)" but 0.
- Rely in BRUSH::cjGetObject behavior which returns 0 when cjSize is 0.

Co-authored-by: Víctor Martínez Calvo <victormartinez@alub.io>
 2022-05-03 16:00:21 +02:00
Thomas Faber
49bb853b24
[GDI32_VISTA] Move D3DKMT functions out of gdi32. CORE-17433 2022-01-01 12:42:04 -05:00
James Tabor
e98684ed8b [GDI32] Fix rectangle flag issues. 
Fix CORE-17815. Remove dumb dumb code breakers.
 2021-10-16 11:16:43 -05:00
James Tabor
8767aada75 [GDI32] Fix IV msvc build. 2021-09-27 19:08:43 -05:00
James Tabor
be4540821a [GDI32] Fix III msvc build. 2021-09-27 18:19:49 -05:00
Hermès Bélusca-Maïto
e6306db0c3
[GDI32] Fix build errors~~ 2021-09-28 00:48:24 +02:00
James Tabor
d4b2c97b67 [GDI32] Fix msvc build errors. 2021-09-27 17:30:40 -05:00
James Tabor
fc16259faf [GDI32] Update Wine Metafile Code 
Sync/Port: Metafile code from wine.

Patches by Jacek Caban, Daniel Lehman, Zhiyi Zhang. Gabriel Ivancescu, Michael Stefaniuc, Francois Gouget, Nikolay Sivov Dmitry Timoshkov, Andrew EiKum, Piotr Caban and Alexandre Julliard.

This commit is dedicated to George Bisoc!
 2021-09-27 16:18:20 -05:00
James Tabor
970344bd16 [Win32SS|GDI] Implement seldom used API and update types for local DC's. 
Two working in house application require these API. Known as FolCOL and Reach.
 2021-09-25 11:57:26 -05:00
Hermès Bélusca-Maïto
9393fc320e
[FORMATTING] Remove trailing whitespace. Addendum to 34593d93. 
Excluded: 3rd-party code (incl. wine) and most of the win32ss.
 2021-09-13 03:52:22 +02:00
James Tabor
a022dc8eaf [GDI32] Fix Meta file packing recursion issues. 
TextOut was looping back adding additional EMR packet to the meta file.
 2021-09-06 18:37:24 -05:00
Oleg Dubinskiy
58daf942fe
[GDI32] Fix wrong ordering of parameters in NtGdiDdGetDC call (#3637) 
It allows to properly pass the surface handle (and palette entry pointer) from MS ddraw into win32k.
Otherwise, they are passing into the wrong parameters of actual NtGdi* function, and due to this,
since they're detected as invalid, they become NULL, and that function does not work correctly.

See https://docs.microsoft.com/en-us/windows/win32/devnotes/-dxgkernel-ntgdiddgetdc for the reference
(and confirmed by our headers).

Required by MS DirectDraw stack (ddraw.dll & dxg.sys).
CORE-17561
 2021-05-03 18:11:18 +02:00
Jérôme Gardou
e470b58376 [REACTOS] Explicitly link against pseh & include pseh headers in a few places 2021-04-28 13:10:23 +02:00
Jérôme Gardou
b96e88894a [CMAKE] Turn import libs into regular C static libs 
Embed msvcrtex into libmsvcrt

Idea taken from Thomas Faber
 2020-12-28 12:13:30 +01:00
Timo Kreuzer
cef57d3c44 [GDI32] Fix up GdiFixUpHandle 2020-10-31 14:24:09 +01:00
Mark Jansen
7ed0f25b64 [GDI32] Prevent double initialization in GdiProcessSetup 
Found with Application Verifier :)
 2020-10-11 16:30:39 +02:00
James Tabor
8313483202 [GDI32] Force Return if other Type of Device Requested 
Fix CORE-17241 assert.
 2020-09-08 12:52:28 -05:00
Doug Lyons
7624a98706
[GDI32] Fix double cx's in call to HANDLE_METADC in win32ss painting.c (#3137) 
Fix copy-paste error.
 2020-09-06 18:08:03 +02:00
Serge Gautherie
5f076e5558
[GDI32] MirrorRgnByWidth(): Fix 'phrgn' parameter handling 
Detected by Cppcheck: uselessAssignmentPtrArg.
Addendum to 794e7aa (r31523) and e647530 (r65893).
 2020-06-18 10:33:35 +02:00
Tibor Lajos Füzi
6020af2014
[GDI32] Allow BI_BITFIELDS compression in CreateDIBitmap (#2448) 
CORE-16750, CORE-15960
 2020-03-30 12:11:38 +02:00
Thomas Faber
72c51aabba
[NTOS:IO][GDI32][CMD] Fix some under-sized variables. CORE-14922 
Fixes x64 boot with RTC.
 2020-03-13 20:45:06 +01:00
Colin Finck
5d8c39753e
[GDI32] GdiConvertToDevmodeW: Import WINE commit 32393796bb534e9cf11dd988dce88722c67f7906 ("gdi32: GdiConvertToDevmodeW should not refer to unintialized name bytes.") 
This makes our GdiConvertToDevmodeW equivalent to the WINE counterpart again.
 2020-02-24 19:17:56 +01:00
jimtabor
c89e111c6a [GDI32] Use Gdi Flush for SetViewportOrgEx. 
Fixes offset in combo texts and menu highlights. See CORE-16644 & CORE-16656.
 2020-02-13 17:05:38 -06:00
jimtabor
5214a38fd0 [Win32SS] Fix Opaque Text Fade while in Desktop Startup 
See CORE-16498.
 2019-12-09 11:18:32 -06:00
jimtabor
333b8f19a4 [GDI32] Update Gdi Driver Header. 
Patch by : Akihiro Sagawa : Implement GetCharWidthInfo().

1128587fd2
 2019-10-18 23:49:13 -05:00
jimtabor
665871527b [GDI32] Allow functions to access printing support. 
Reapplying lost committed code.
 2019-07-27 14:15:42 -05:00
jimtabor
4563ca28d3 [GDI32] Add more to Local DC structure. 
Make the two structures identical. These are used for printing and
enhanced metafile support.
 2019-07-27 14:13:14 -05:00
James Tabor
9f57320175 [GDI32] Meta File Fix Ups 
Remove pointer hack. Safer since using wines Enhanced Meta headers with
unknown wine magic information.
 2019-06-03 15:49:14 -05:00
jimtabor
da264743e1 [Win32SS] Support Clipboard Metafile 
Major fix ups and plugging in missing code changes. Handle code is from
another project currently being developed for ReactOS.
See CORE-12143
 2019-05-31 21:44:17 -05:00
jimtabor
e229b3eea7 [GDI32] Support Clipboard Metafile 
Metafile patch from Katayama Hirofumi MZ. See CORE-12143.
 2019-05-30 16:33:23 -05:00
jimtabor
5418f394ab [Gdi32] Batch Type Select Mode for Testing 
Do not allow setting hdc if no batch type is found.
See CORE-15988.
 2019-05-11 11:22:06 -05:00
jimtabor
dc7f4f682f [Win32SS] Plug in Last Batch 
Plugging in last batch after 12 years.
 2019-05-09 12:35:21 -05:00
James Tabor
9d00413754 [GDI32] Add batch flag for Text Out 
Set batch flag for Text Out with font and attributes change sets.
 2019-05-01 23:24:53 -05:00
James Tabor
44b11ad6a9 [GDI32] Fix MS build 
Fix old uncovered code.
 2019-05-01 20:53:06 -05:00
James Tabor
b751c31c74 [GDI32] Update signal flags for batch. 
Add removed flags for batch signaling. This will allow syncing of
changed Xfroms after batched drawing. Disable calls to kernel mode since
the code is closely identical. Kernel calls are for init time when
PDCATTR is normally zero. ReactOS seems to work better keeping this from
NULL.
While making code changes add Xform state flags from:
https://www.reactos.org/archives/public/ros-diffs/2019-May/070693.html

Test BOT results:
https://reactos.org/testman/compare.php?ids=67251,67254
https://reactos.org/testman/compare.php?ids=67253,67255
 2019-05-01 20:33:09 -05:00
Katayama Hirofumi MZ
8bdfdd5c17
[WIN32SS][NTGDI][GDI32] Fix DPtoLP and NtGdiTransformPoints etc. (#1540) 
Fix NtGdiTransformPoints, gdi32!DPtoLP, gdi32!LPtoDP and gdi32!SetMapMode functions. Fix CORE-15983. CORE-15983
 2019-04-29 14:45:44 +09:00
Pierre Schweitzer
610cc5a6b6
[GDI32] Reduce verbosity on debug builds 2019-04-20 11:24:54 +02:00
jimtabor
7fabc51d73 [GDI] Fixup attribute support for Regions 
Start to fix CORE-13817 when GDI batch is turn on for SelectClipRgn.
 2019-04-17 14:09:58 -05:00
Hermès Bélusca-Maïto
7334567211
[GDI32] Do not 'hard-assert' during the font-unit-test. 2019-04-14 01:17:15 +02:00
Katayama Hirofumi MZ
bc9f3ed887
[GDI32][NTGDI] Avoid integer overflow (follow-up of #1492) (#1495) 
Follow up of #1492. CORE-15755
- Use RtlULongMult function to check integer overflows.
 2019-04-11 17:57:57 +09:00
Katayama Hirofumi MZ
811faed421
[GDI32][NTGDI][SETUP] Fix font enumeration part 2 (#1492) 
Eliminate some bugs about font enumeration. CORE-15755

- Add "Microsoft Sans Serif" font substitution.
- Fix and improve the treatment of the nominal font names.
- Split IntGetFontFamilyInfo function from NtGdiGetFontFamilyInfo.
- Add DoFontSystemUnittest function for font system unittest to GDI32.
- Call DoFontSystemUnittest function at CreateFontIndirectW first call.
 2019-04-11 11:46:52 +09:00