Commit graph

52160 commits

Author SHA1 Message Date
Eric Kohl 6097ae49f8 [LSASRV]
Implement lookup of accounts in the account domain of the SAM database. The advapi32 security winetest shows proper domain and account names for the administrator and guest SIDs.

svn path=/trunk/; revision=57517
2012-10-07 18:33:48 +00:00
Eric Kohl 3c50db37b6 [SAMSRV]
Implement SamIFree_SAMPR_RETURNED_USTRING_ARRAY and SamIFree_SAMPR_ULONG_ARRAY.
These functions are used to free structures that were allocated by calls to Samr-functions.

svn path=/trunk/; revision=57516
2012-10-07 17:38:16 +00:00
Hermès Bélusca-Maïto 9050f658d1 [APITEST:NTDLL]
Add a parameter for displaying the current test number when something fails.

svn path=/trunk/; revision=57515
2012-10-07 14:17:37 +00:00
Hermès Bélusca-Maïto ee0de5e843 [NTOSKRNL]
In NtQuerySystemEnvironmentValue :
- Use a fixed-length buffer size for holding a temporary variable.
- Correct the pool TAG.

svn path=/trunk/; revision=57514
2012-10-07 14:16:13 +00:00
Hermès Bélusca-Maïto 02affbb318 [APITEST:NTDLL]
Improve the code.

svn path=/trunk/; revision=57513
2012-10-07 12:46:44 +00:00
Hermès Bélusca-Maïto f527bc83ef [APITEST:NTDLL]
Add a test for the NtQuerySystemEnvironmentValue API.
Tested successfully under Win2k3 SP1 and Win7.

svn path=/trunk/; revision=57512
2012-10-07 12:31:13 +00:00
Eric Kohl 1c7cd63a6f [LSASRV]
- Store the names and SIDs of the built-in and account domains in global vaiables.
- Move the lookup code for isolated names to a separate function.

svn path=/trunk/; revision=57511
2012-10-07 12:10:45 +00:00
Timo Kreuzer 4bebb78d5e [WIN32K]
Fix missing colorTriple increment when creating the color table in GreGetDIBitsInternal.

svn path=/trunk/; revision=57510
2012-10-07 10:03:31 +00:00
Timo Kreuzer 35de366b5b [GDI32]
Use a struct do define the combined DIBSECTION/BITMAPINFO buffer in CreateCompatibleBitmap, to make it more clear how it works. See CID 716216

svn path=/trunk/; revision=57509
2012-10-07 09:35:32 +00:00
Eric Kohl 31f030ee98 [LSASRV]
Implement LsaIOpenPolicyTrusted as described in http://code.google.com/p/mimikatz/source/browse/trunk/librairies/sekurlsa/secrets.cpp?r=24.

svn path=/trunk/; revision=57508
2012-10-07 09:18:23 +00:00
Timo Kreuzer 0c4428ca06 [WIN32K][USER32]
Chnge return type of ClientLoadLibrary to BOOL. Previously it returned HMODULE in both the load and unload case, being a meaningless value in the latter case. All users of this function were using it as a boolean parameter only.

svn path=/trunk/; revision=57507
2012-10-07 08:43:54 +00:00
Hermès Bélusca-Maïto 9c2bfc5ecd [NTOSKRNL]
Some ExFreePool -> ExFreePoolWithTag

CORE-6725 #resolve #comment Committed in r57506.

svn path=/trunk/; revision=57506
2012-10-06 21:42:19 +00:00
Timo Kreuzer dfbde4a0d6 [WIN32K]
Use ExAllocatePoolWithTag instead of ExAllocatePool

svn path=/trunk/; revision=57505
2012-10-06 20:15:36 +00:00
Hermès Bélusca-Maïto 83f3d18dee [NTOSKRNL]
Rearrange the NtQuerySystemEnvironmentValue code to have successive logical checks.

svn path=/trunk/; revision=57504
2012-10-06 19:50:17 +00:00
Eric Kohl d59abae163 [LSASRV]
- Make LsarLookupNames, LsarLookupNames2 and LsarLookupNames4 call LsapLookupNames and convert the results where this is needed.
- Split the lookup code in LsapLookupSids into separate functions.

svn path=/trunk/; revision=57503
2012-10-06 19:37:10 +00:00
Timo Kreuzer 39cb83bab8 [WIN32K]
Use ExFreePoolWithTag instead of ExFreePool in SpiNotifyNCMetricsChanged.
Fixes CID 716644

svn path=/trunk/; revision=57502
2012-10-06 19:24:14 +00:00
Timo Kreuzer 56a85aba5e [WIN32K]
- Keep an additional reference while processing the message list of a message queue
- CID 716808

svn path=/trunk/; revision=57501
2012-10-06 19:04:36 +00:00
Hermès Bélusca-Maïto 5ff7896120 [NTOSKRNL]
Use TAG_FSTUB instead of 'BtsF'

svn path=/trunk/; revision=57500
2012-10-06 18:49:23 +00:00
Hermès Bélusca-Maïto ebd10c73a3 [NTOSKRNL]
Fix Coverity defects : CID 716579, 716580 and 716582.

svn path=/trunk/; revision=57499
2012-10-06 18:46:13 +00:00
Hermès Bélusca-Maïto ae50229cb5 [NTDLL_APITEST]
Initialize Length to default value.

svn path=/trunk/; revision=57498
2012-10-06 14:50:18 +00:00
Timo Kreuzer de6d388331 [BMFD]
- Remove a pointless check (CID 731583)
- Add a comment
- Simplify code

svn path=/trunk/; revision=57497
2012-10-06 14:35:52 +00:00
Timo Kreuzer 9d29067d15 [WIN32K]
- Fix detection of trivial clipping region
- CID 731584

svn path=/trunk/; revision=57496
2012-10-06 14:23:22 +00:00
Timo Kreuzer cfa6623328 [WIN32K]
Disable APCs when acquiring the pushlock.

svn path=/trunk/; revision=57495
2012-10-06 12:21:41 +00:00
Timo Kreuzer fcbab8b1a3 [WIN23K]
- Make LFONTs (for some incomprehensible reason called TEXTOBJ in ros) shared objects, as they are supposed to be. Since that conflicts with our totally broken font code that happily messes with the LFONT's contents, an additional push lock is aquired to get exclusive ownership.

svn path=/trunk/; revision=57494
2012-10-06 12:16:06 +00:00
Timo Kreuzer f380457089 [NTOSKRNL]
Add missing break in KdpServiceDispatcher

svn path=/trunk/; revision=57493
2012-10-06 09:47:15 +00:00
Timo Kreuzer ca41d88df3 [GDI32]
- Use GdiAllocBatchCommand in DeleteObject instead of doing all manually

svn path=/trunk/; revision=57492
2012-10-06 08:33:17 +00:00
James Tabor e71dbbe6f4 [NtUser]
- Tested wine win test_scrollwindow, test_scrollvalidate, test_scrolldc, and test_scroll plus ReactOS API tests. Pass all but three region tests in test_scrollvalidate.
- Dedicated to Víctor Martínez Calvo.

svn path=/trunk/; revision=57491
2012-10-06 02:36:46 +00:00
Hermès Bélusca-Maïto 7114e59e63 [REGEDIT]
- Re-number some resource IDs.
- Add key exportation message-box error (thus removing some fwprintf calls).
- Use IDS_MY_COMPUTER localized string instead of hardcoded one.

svn path=/trunk/; revision=57490
2012-10-05 20:08:16 +00:00
Eric Kohl 7989048604 [LSASRV]
- Change LsapLookupSids to match LsarLookupSids2 and LsarLookupSids3.
- Implement LsarLookupSids2 and LsarLookupSids3.
- Update the call to LsapLookupSids in LsarLookupSids and convert the translated names list after calling LsapLookupSids.

svn path=/trunk/; revision=57489
2012-10-05 19:41:14 +00:00
Eric Kohl bc733f3d0a [LSASRV]
- Move most of the code from LsarLookupSids into LsapLookupSids.
- Use the code from LsapLookupNames to handle the referenced domains list in LsapLookupSids. 

svn path=/trunk/; revision=57488
2012-10-05 17:34:23 +00:00
Alex Ionescu f6573a4432 [RTL]: Fix typo in RtlValidAcl.
svn path=/trunk/; revision=57487
2012-10-05 15:20:10 +00:00
Thomas Faber 60049c9aa5 [SHELL32]
- Fix yet another missing "this->", spotted by Igor Sudarikov
CORE-6722 #resolve #comment Good catch, thanks.

svn path=/trunk/; revision=57486
2012-10-05 10:51:54 +00:00
Thomas Faber 19fd89e40f [SHELL32]
- Fix what might finally be the last missing "this->" instances left over from the C++ conversion (used a regex this time)

svn path=/trunk/; revision=57485
2012-10-04 23:46:59 +00:00
Eric Kohl e88d815fef [LSASRV]
Implement LsarEnumerateAccountRights. It is still WIP (Work In Progress).

svn path=/trunk/; revision=57484
2012-10-04 21:59:23 +00:00
James Tabor b6e579b65a [NtUser]
- Fix all but one DCE scroll test.
- Old patch at least two year old or more.

svn path=/trunk/; revision=57483
2012-10-04 20:00:28 +00:00
Alex Ionescu 61d7f64ce7 [RTL]: Implement and half-plement the Object Security APIs. In most cases, ultimately forward to an internal (unimplemented) worker function, but some APIs were implemented fully. Also add missing RtlCreateAndSetSD and export it (unimplemented).
svn path=/trunk/; revision=57482
2012-10-04 19:32:18 +00:00
Alex Ionescu 3e8f4222f0 [RTL]: Add all the missing Rtl*Security*Object APIs and put them all in security.c. Move privilege functions into a new file, priv.c. No functional/code changes, just more stubs/exports and moving things around.
svn path=/trunk/; revision=57481
2012-10-04 18:48:15 +00:00
Eric Kohl f6686c1c81 [LSASRV]
LsapLookupNames: If a name was found, add its domain SID to the domains list and set the domain index accordingly.

svn path=/trunk/; revision=57480
2012-10-04 18:22:55 +00:00
Alex Ionescu b4266b3394 [NDK]: forgot this ,sorry.
svn path=/trunk/; revision=57479
2012-10-04 17:08:51 +00:00
Alex Ionescu ebf8367f44 [RTL]: Cleanup, comment, and fix SID functions. For example, RtlEqualPrefixSid actually checks only the prefix, not the entire SID.
svn path=/trunk/; revision=57478
2012-10-04 16:55:53 +00:00
Jérôme Gardou 8dafc1da92 [APITESTS/USER32]
Improve GetIconInfo tests:
 -Stop leaking each handle we create
 -Show Icons sensitivity to screen bit depth

svn path=/trunk/; revision=57477
2012-10-04 13:38:26 +00:00
Alex Ionescu 7b8f6ee98f [RTL]: CORE-6713 #resolve #time 10m #comment Use explicit checks when checking for present and default flags, just like Windows. Fixes winetest regressions.
svn path=/trunk/; revision=57476
2012-10-04 06:28:58 +00:00
Alex Ionescu ecf46ebc82 [NTOSKRNL]: CORE-6698 #resolve #time 5m #comment Add correct error handling during session space view mapping.
svn path=/trunk/; revision=57475
2012-10-04 06:19:42 +00:00
Alex Ionescu 2552915ae3 [NTOS]: CORE-6204 #resolve #time 10m #comment Do not touch NextEntry after removing it, instead restart the scan at the head of the list (checked against w2k3sp1).
svn path=/trunk/; revision=57474
2012-10-04 06:16:53 +00:00
Hermès Bélusca-Maïto 11d8e8dbdc [REGEDIT]
... and this line of code (I'm sorry for the generated noise :-( )

svn path=/trunk/; revision=57473
2012-10-03 22:51:53 +00:00
Hermès Bélusca-Maïto 85a2326f87 [REGEDIT]
- Forgot to remove a comment

svn path=/trunk/; revision=57472
2012-10-03 22:50:06 +00:00
Hermès Bélusca-Maïto c23873e5cb [REGEDIT]
- Convert the application's code to UNICODE
- But the regproc.c's code is untouched (apart from the pseudo-error messages issued with fprintf)

svn path=/trunk/; revision=57471
2012-10-03 22:42:34 +00:00
Hermès Bélusca-Maïto 70e6572e30 [CLB]
- Code cleaning

svn path=/trunk/; revision=57470
2012-10-03 21:58:28 +00:00
Thomas Faber c18b6ae104 [KMTEST:KE]
- Show that Mutexes disable APCs when acquired, while Mutants don't

svn path=/trunk/; revision=57469
2012-10-03 20:52:33 +00:00
Mike Nordell 9e555a84d5 [NTOSKERNEL] Stop KeRundownThread from bugchecking on at least CTRL_C for console app.
svn path=/trunk/; revision=57468
2012-10-03 19:51:22 +00:00