Commit graph

31998 commits

Author SHA1 Message Date
Cameron Gutman 85672737e6 - Handle AllocatedResources and AllocatedResourcesTranslated separately
- Fix a memory leak
 - Fix a handle leak

svn path=/branches/aicom-network-fixes/; revision=35964
2008-09-05 19:51:18 +00:00
Cameron Gutman 16427a1482 - Fix cleanup code
- We could possibly end up there with a NULL FileHandleObject and return a garbage FileHandle or crash
 - Now we always return a NULL FileHandle when we fail and free FileHandleObject if it has been allocated

svn path=/branches/aicom-network-fixes/; revision=35946
2008-09-04 19:08:08 +00:00
Cameron Gutman 4ff5fc5caa - Fix 2 memory leaks
- Set ParameterValue to NULL on failure

svn path=/branches/aicom-network-fixes/; revision=35944
2008-09-04 18:42:49 +00:00
Cameron Gutman 14d8dfbd90 - Accept STATUS_SUCCESS also as done in config.c
svn path=/branches/aicom-network-fixes/; revision=35919
2008-09-03 23:37:09 +00:00
Cameron Gutman 8d622c2821 - Fail if PrepareARPPacket returned NULL
- Fixes another possible crash

svn path=/branches/aicom-network-fixes/; revision=35899
2008-09-02 23:47:05 +00:00
Cameron Gutman f398b8d6eb - Move the NULL check immediately after the memory is allocated
svn path=/branches/aicom-network-fixes/; revision=35898
2008-09-02 23:36:46 +00:00
Cameron Gutman fe270e9c66 - Fail if we didn't successfully add the header
svn path=/branches/aicom-network-fixes/; revision=35897
2008-09-02 23:26:32 +00:00
Cameron Gutman d75a5f4d04 - Set UDPInitialized to FALSE at the end of UDPShutdown
svn path=/branches/aicom-network-fixes/; revision=35896
2008-09-02 23:15:28 +00:00
Cameron Gutman 26b1ba0f02 - Initially set NdisProtocolHandle to NULL
svn path=/branches/aicom-network-fixes/; revision=35889
2008-09-02 18:38:42 +00:00
Cameron Gutman 87315e4ac4 - STATUS_SUCCESS -> NDIS_STATUS_SUCCESS
svn path=/branches/aicom-network-fixes/; revision=35868
2008-09-01 22:59:04 +00:00
Cameron Gutman ae2f6e5543 - Set Status
svn path=/branches/aicom-network-fixes/; revision=35867
2008-09-01 22:48:03 +00:00
Cameron Gutman 480dd52090 - Initially set Packet to NULL
svn path=/branches/aicom-network-fixes/; revision=35856
2008-09-01 13:12:34 +00:00
Cameron Gutman bbf9cb252c - Don't return NDIS_STATUS_SUCCESS when we really failed
svn path=/branches/aicom-network-fixes/; revision=35849
2008-09-01 03:58:34 +00:00
Cameron Gutman 1443f6833b - Initially set PoolHandle, ConfigurationHandle, KeyHandle, and Filter to NULL
- Initially set PortOffset to 0
 - Fix 4 memory leaks
 - Remove a useless if

svn path=/branches/aicom-network-fixes/; revision=35848
2008-09-01 03:13:35 +00:00
Cameron Gutman 954aed91f2 - Change the status to STATUS_SUCCESS if TdiReceive returns STATUS_PENDING
svn path=/branches/aicom-network-fixes/; revision=35787
2008-08-30 03:29:41 +00:00
Cameron Gutman 1cc8981800 - Check if TdiBuildNullConnectionInfo completed successfully
- Add a comment
 - Fail if we can't allocate Qelt

svn path=/branches/aicom-network-fixes/; revision=35786
2008-08-30 02:53:20 +00:00
Cameron Gutman b8a0800ce6 - FCB->State gets set to SOCKET_STATE_CONNECTED in MakeSocketIntoConnection
svn path=/branches/aicom-network-fixes/; revision=35785
2008-08-30 02:40:26 +00:00
Cameron Gutman 60899277f8 - Check if MakeSocketIntoConnection succeeded
- Check if TaCopyTransportAddress succeeded

svn path=/branches/aicom-network-fixes/; revision=35784
2008-08-30 02:30:27 +00:00
Cameron Gutman 17c1d9b828 - Check that we successfully allocated memory
- Return TDI_NO_RESOURCES instead of STATUS_NO_MEMORY

svn path=/branches/aicom-network-fixes/; revision=35783
2008-08-30 02:04:30 +00:00
Cameron Gutman ac9f7a78b0 - Returning STATUS_BUFFER_OVERFLOW is ok also since we're only trying to get DriverKeyLength
svn path=/branches/aicom-network-fixes/; revision=35761
2008-08-29 14:33:42 +00:00
Cameron Gutman b4b79146c7 - Revert my last commit
- Looks like this is meant to fail
 - I added a comment so no one does this again

svn path=/branches/aicom-network-fixes/; revision=35745
2008-08-29 04:23:10 +00:00
Cameron Gutman cf392f00f6 - Fix a code typo resulting in calls to MiQueryResources to return early
svn path=/branches/aicom-network-fixes/; revision=35744
2008-08-29 03:59:25 +00:00
Cameron Gutman 8fa497277d - Free the address we've previously allocated if needed
svn path=/branches/aicom-network-fixes/; revision=35743
2008-08-29 02:19:16 +00:00
Cameron Gutman 976fe9f031 - Set Handle to NULL so we don't try to close it later
svn path=/branches/aicom-network-fixes/; revision=35741
2008-08-29 01:08:55 +00:00
Cameron Gutman 906dfdd979 - Don't handle OSK_EINPROGRESS since TCPTranslateError already has done the conversion to STATUS_PENDING
svn path=/branches/aicom-network-fixes/; revision=35714
2008-08-27 21:45:45 +00:00
Cameron Gutman 92073dfb72 - Fix many memory leaks
- Complete with the correct status

svn path=/branches/aicom-network-fixes/; revision=35656
2008-08-26 02:57:12 +00:00
Cameron Gutman d4296ce6a5 - Fix a memory leak
svn path=/branches/aicom-network-fixes/; revision=35653
2008-08-26 00:47:22 +00:00
Cameron Gutman abd660f2dc - Revert my whole ASSERT mess
- This fixes Qemu

svn path=/branches/aicom-network-fixes/; revision=35611
2008-08-24 19:53:16 +00:00
Cameron Gutman 0a84b51976 - Apply the same change in my branch as I did to trunk in r35602
svn path=/branches/aicom-network-fixes/; revision=35610
2008-08-24 19:28:25 +00:00
Cameron Gutman 7a30e67498 - Add another missing PollReeval
svn path=/branches/aicom-network-fixes/; revision=35609
2008-08-24 19:21:41 +00:00
Cameron Gutman 63ba865297 - Revert r35601
- This should always be set if FCB->CurrentThread is non-NULL

svn path=/branches/aicom-network-fixes/; revision=35607
2008-08-24 18:32:19 +00:00
Cameron Gutman d70ad469a8 - Set FCB->Locked to TRUE after we increment the lock count
svn path=/branches/aicom-network-fixes/; revision=35601
2008-08-24 16:20:14 +00:00
Cameron Gutman a66142aff9 - Add some missing calls to PollReeval
- Move an existing PollReeval to always be called

svn path=/branches/aicom-network-fixes/; revision=35597
2008-08-24 13:56:35 +00:00
Cameron Gutman e4a04351f2 - Fail if DatagramRecv->Address is NULL
svn path=/branches/aicom-network-fixes/; revision=35596
2008-08-24 13:25:19 +00:00
Cameron Gutman 963205e8b8 - Set *ConnectionInfo to NULL if we can't allocate memory for ConnInfo
svn path=/branches/aicom-network-fixes/; revision=35589
2008-08-24 02:55:26 +00:00
Cameron Gutman 4f54a68190 - Skip ObReferenceObjectByHandle if HandleArray[i].Handle is NULL
- Fail if ObReferenceObjectByHandle didn't succeed
 - Remove a bad ASSERT I added in my last commit

svn path=/branches/aicom-network-fixes/; revision=35583
2008-08-24 01:34:17 +00:00
Cameron Gutman 98c2a1ea67 - Fail if MmProbeAndLockPages doesn't succeed
- Fail if IoAllocateMdl returns NULL
 - Add some ASSERTs

svn path=/branches/aicom-network-fixes/; revision=35582
2008-08-24 01:09:48 +00:00
Cameron Gutman e2c0738526 - Make sure IPAddr is non-NULL
- Change STATUS_UNSUCCESSFUL to STATUS_INVALID_PARAMETER

svn path=/branches/aicom-network-fixes/; revision=35579
2008-08-23 22:06:49 +00:00
Cameron Gutman 055139fc07 - Code cleanup
- Make sure FCB->RemoteAddress is non-NULL

svn path=/branches/aicom-network-fixes/; revision=35578
2008-08-23 21:53:37 +00:00
Cameron Gutman 2d966ffcfb - Make sure FCB->AddressFrom is non-NULL
svn path=/branches/aicom-network-fixes/; revision=35577
2008-08-23 21:41:10 +00:00
Cameron Gutman fb0a6601f9 - More STATUS_UNSUCCESSFUL to STATUS_INVALID_PARAMETER changes
svn path=/branches/aicom-network-fixes/; revision=35538
2008-08-22 19:35:20 +00:00
Cameron Gutman f337da0bfb - Handle STATUS_INVALID_PARAMETER
svn path=/branches/aicom-network-fixes/; revision=35537
2008-08-22 19:30:33 +00:00
Cameron Gutman e233f4f784 - Return a more accurate status (STATUS_INVALID_PARAMETER) than STATUS_UNSUCCESSFUL when a parameter is NULL
svn path=/branches/aicom-network-fixes/; revision=35536
2008-08-22 19:26:30 +00:00
Cameron Gutman 3b1ae0bb37 - Replace MmMapLockedPages with MmGetSystemAddressForMdlSafe
- Add a check to UnlockRequest
 - Enclose MmProbeAndLockPages in SEH
 - Fixes bug 3672

svn path=/branches/aicom-network-fixes/; revision=35507
2008-08-21 14:46:03 +00:00
Cameron Gutman 3b40e9b047 - Reapply r35481
svn path=/branches/aicom-network-fixes/; revision=35486
2008-08-20 19:06:43 +00:00
Cameron Gutman df19533df7 - Fix IRP cancellation issues
- Ping doesn't hang anymore

svn path=/branches/aicom-network-fixes/; revision=35485
2008-08-20 18:50:26 +00:00
Cameron Gutman 67fae61a27 - Revert 35477-35481
svn path=/branches/aicom-network-fixes/; revision=35484
2008-08-20 18:46:38 +00:00
Cameron Gutman 9b492699af - Fix handling of cancelled IRPs
svn path=/branches/aicom-network-fixes/; revision=35481
2008-08-20 17:29:01 +00:00
Cameron Gutman 6159e6d129 - Don't forget about ConnectIrp (This fix was lost in the merge)
- Don't destroy the same socket twice
 - Don't unlock the same socket twice
 - Don't destroy a socket with pending IRPs

svn path=/branches/aicom-network-fixes/; revision=35480
2008-08-20 14:56:12 +00:00
Cameron Gutman 3def13f731 - Fix build
svn path=/branches/aicom-network-fixes/; revision=35479
2008-08-20 14:48:42 +00:00