[ARP]
[TRACERT]
- Incorrect to compare the variable of BOOL type with TRUE. Any non-zero value is considered to be "true".
[FREELDR]
- Variable is assigned values twice
- The 'strlen' function was called multiple times inside the body of a loop
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0
[NTOBJSHEX]
[SLAYER]
[CMICONTROL]
- It is inefficient to identify an empty string by using 'strlen(str) > 0' construct. A more efficient way is to check: str[0] != 0
[SHELL32]
- There is no sense in testing the pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error
- Verifying that a pointer value is not NULL is not required. The 'if (ptr != NULL)' check can be removed
- Fix copy-paste error in CMenuFocusManager::PlaceHooks()
[SRCLIENT]
- Remove unneeded check. A part of conditional expression is always false.
[DISK]
[ATAPI]
- Variable is assigned values twice
* All bugs found by PVS-Studio
svn path=/trunk/; revision=72059
34803 (sserapion)
Fix more warnings.
Convert pciidex to use spec file.
34864 (tkreuzer) // checkme vielleicht schon gemerged?
[NDIS]
fix some ULONG to pointer casts
34870 (tkreuzer)
[TCPIP]
- fix some pointer to ULONG casts
34874 (tkreuzer)
class2: fix ULONG to pointer cast
34877 (tkreuzer)
- fix LARGE_INTEGER to pointer cast
35781 (tkreuzer)
[NDIS]
define some fastcall functions to the normal functions on amd64
36011 (tkreuzer)
[NDIS]
Fix a ULONG to pointer cast.
36012 (tkreuzer)
[SCSIPORT]
more ulong <-> pointer fixes
svn path=/trunk/; revision=46422
