Commit graph

33342 commits

Author SHA1 Message Date
Gregor Schneider
ec00886a23 Check for NULL before using the DC.
Fixes Coverity CID 680.

svn path=/trunk/; revision=36579
2008-09-28 19:44:58 +00:00
Gregor Schneider
f1f31fe9f2 Handle PALETTE_LockPalette returning NULL.
Fixes Coverity CIDs 486 and 487.

svn path=/trunk/; revision=36578
2008-09-28 19:42:03 +00:00
Gregor Schneider
b3b0519142 A msvcrt test shouldn't test ntdll functions for correctness. Now people don't need to fix nonexistant "hidden" msvcrt bugs anymore.
svn path=/trunk/; revision=36577
2008-09-28 18:40:38 +00:00
Hervé Poussineau
aac6354d3b Remove a hack, and link with C++ libraries only when required
Patch by Cecill Etheredge ( ijsf at gmx dot net )

svn path=/trunk/; revision=36576
2008-09-28 14:17:45 +00:00
Eric Kohl
f8998c9c84 Ooops, forgot to disable these [handle] attributes.
svn path=/trunk/; revision=36575
2008-09-28 13:49:47 +00:00
Eric Kohl
527202ad87 Cast returned handle values correctly.
svn path=/trunk/; revision=36574
2008-09-28 13:48:31 +00:00
Aleksey Bragin
5ee91c9c36 - Fix uninitialized variable usage. Fixes Coverity CID: 1293.
svn path=/trunk/; revision=36573
2008-09-28 11:16:41 +00:00
Aleksey Bragin
24430aea89 - Ports are counted starting from 1, with 0 being an invalid port index. Remove memory corruption by actually allocating MAX_ROOT_PORTS + 1 sized array. Fixes Coverity CID: 601.
svn path=/trunk/; revision=36572
2008-09-28 11:05:18 +00:00
Aleksey Bragin
faf94f044e - It's meaningless to try to complete the IRP if irp == NULL. Fixes Coverity CID: 398
svn path=/trunk/; revision=36571
2008-09-28 10:57:59 +00:00
Aleksey Bragin
6eb2f69158 - Remove redundant NULL-check. Fixes Coverity CID: 761.
svn path=/trunk/; revision=36569
2008-09-28 10:54:22 +00:00
Johannes Anderwald
862b1b1c46 - Query Name, Icon Attributes for each call of INetConnection_GetProperties
- Update Taskbar Notifications Icons on a network adapter change
- Sync remaining resources

svn path=/trunk/; revision=36568
2008-09-28 10:50:10 +00:00
Hervé Poussineau
0970d7b76e Replace .def file by a .spec file
svn path=/trunk/; revision=36563
2008-09-28 09:09:57 +00:00
Dmitry Chapyshev
f610f642b1 - Sync ddstream.idl with wine head
- Add qedit.idl from wine

svn path=/trunk/; revision=36560
2008-09-28 06:04:47 +00:00
Cameron Gutman
12604c6f99 - Merge aicom-network-fixes up to r36558
svn path=/trunk/; revision=36559
2008-09-27 21:25:27 +00:00
Cameron Gutman
1d8b2f1556 - Set MiniportBusy to TRUE if a request is pending
- Hold spin lock when setting MiniportBusy (forgot one from last time)

svn path=/branches/aicom-network-fixes/; revision=36558
2008-09-27 19:54:58 +00:00
Cameron Gutman
63ed3d8b4f - Don't add the protocol to the protocol list if binding failed
svn path=/branches/aicom-network-fixes/; revision=36557
2008-09-27 19:26:17 +00:00
Cameron Gutman
72f9da2665 - Protect MiniportBusy with a spin lock
- Adapter is PLOGICAL_ADAPTER not PNDIS_MINIPORT_BLOCK
 - Make sure memory allocation was successful
 - Cleanup code in ProRequest

svn path=/branches/aicom-network-fixes/; revision=36556
2008-09-27 19:00:47 +00:00
Stefan Ginsberg
b4d8244133 - Fix 2 typos
svn path=/trunk/; revision=36554
2008-09-27 18:45:23 +00:00
Cameron Gutman
a4c5f0d79c - Call ResetHandler directly
svn path=/branches/aicom-network-fixes/; revision=36552
2008-09-27 18:30:11 +00:00
Cameron Gutman
9826b2ad04 - Queue a work item in MiniReset if the adapter is currently busy
- Handle NdisWorkItemResetRequested in MiniportWorker
 - Remove a fixme

svn path=/branches/aicom-network-fixes/; revision=36551
2008-09-27 18:00:08 +00:00
Eric Kohl
1b0251574d - Disable [handle] and [context_handle] attributes in order not to break ReactOS when WIDL is updated to Wine-0.9.59.
- Fix typos in svcctl.idl.

svn path=/trunk/; revision=36550
2008-09-27 17:37:34 +00:00
Gregor Schneider
a26186ece3 Don't read and copy 32 Bit blocks, but only 24 Bit according to
24BPP_Put_/Get_Pixel.
Fixes NtGdiAlphaBlend in 24 Bit mode, see bug #3708.

svn path=/trunk/; revision=36548
2008-09-27 16:56:14 +00:00
Stefan Ginsberg
d9a95f3658 - Add PsGetThreadTeb prototype
svn path=/trunk/; revision=36542
2008-09-27 16:24:50 +00:00
Stefan Ginsberg
2e75e632d0 - Fix a couple of bugcodes with incorrect MessageId
- Add SYSTEM_THREAD_EXCEPTION_NOT_HANDLED make use of it

svn path=/trunk/; revision=36541
2008-09-26 22:11:10 +00:00
Eric Kohl
e7b8601c22 Fix lock handle typecasts.
svn path=/trunk/; revision=36540
2008-09-26 20:25:47 +00:00
Cameron Gutman
337a43d553 - Remove dead code
- Fixes coverity error 85

svn path=/branches/aicom-network-fixes/; revision=36538
2008-09-26 18:10:50 +00:00
Aleksey Bragin
a3767e4fc3 - Remove an excessive ASSERT (there is a real one below in the function).
svn path=/trunk/; revision=36534
2008-09-26 11:48:54 +00:00
Aleksey Bragin
c31a4dabe1 - Apply Art's bitmap patch from the branch, and change the other 2 functions similarly (bit set & clear).
svn path=/trunk/; revision=36533
2008-09-26 09:42:15 +00:00
Christoph von Wittich
5da1fe223d set eol-style:native
svn path=/trunk/; revision=36532
2008-09-26 05:05:59 +00:00
Christoph von Wittich
463ea79dae set eol-style:native
svn path=/trunk/; revision=36531
2008-09-26 05:03:14 +00:00
Christoph von Wittich
5367db78ec set eol-style:native
svn path=/trunk/; revision=36530
2008-09-26 04:55:25 +00:00
Christoph von Wittich
5e060cca56 set eol-style:native
svn path=/trunk/; revision=36529
2008-09-26 04:51:32 +00:00
Cameron Gutman
82e25f4548 - Fix a typo
- Fixes coverity error 388

svn path=/branches/aicom-network-fixes/; revision=36528
2008-09-26 03:43:07 +00:00
Cameron Gutman
0820ee7a4e - Return early if there aren't any packets to be sent
- Fixes coverity error 458

svn path=/branches/aicom-network-fixes/; revision=36527
2008-09-26 03:35:56 +00:00
Cameron Gutman
d9db39f82d - Return early if NBAddNeighbor or RouterAddRoute fails
- Fixes coverity error 389

svn path=/branches/aicom-network-fixes/; revision=36526
2008-09-26 03:23:56 +00:00
Cameron Gutman
9023e12475 - Return early if ProtocolNumber is too large
- Fixes coverity error 600

svn path=/branches/aicom-network-fixes/; revision=36525
2008-09-26 03:12:18 +00:00
Cameron Gutman
d8398cc719 - Fail if From is NULL
- Fixes Coverity error 652

svn path=/branches/aicom-network-fixes/; revision=36524
2008-09-26 03:03:55 +00:00
Timo Kreuzer
7f11e7e296 Simplify and fix InitMetrics. Fixes Coverity error 33.
svn path=/trunk/; revision=36523
2008-09-25 22:44:36 +00:00
Timo Kreuzer
7a71237648 Some cleanup
svn path=/trunk/; revision=36522
2008-09-25 22:17:51 +00:00
Timo Kreuzer
5148823f59 Update SM_XXX constants
svn path=/trunk/; revision=36521
2008-09-25 22:04:20 +00:00
KJK::Hyperion
445a482d8d Only apply C++ compiler flags to the C++ compiler. Fixes useless build warnings.
svn path=/trunk/; revision=36520
2008-09-25 19:44:38 +00:00
Timo Kreuzer
01dd1a7431 Allocate size of structure, not size of pointer to the structure. Fixes Coverity errors 767, 768, 769, 770
svn path=/trunk/; revision=36519
2008-09-25 19:26:09 +00:00
Stefan Ginsberg
b1a8e2b3fd - CmpOpenHiveFiles: If "Extension" is false then we won't have allocated any buffer, so there will never be a buffer to free
- Fix for Coverity Error CID: 29

svn path=/trunk/; revision=36518
2008-09-25 18:49:27 +00:00
Christoph von Wittich
ac376c0adb formatting fix
svn path=/trunk/; revision=36514
2008-09-25 18:10:23 +00:00
Christoph von Wittich
7d57e70f0d set eol-style:native
svn path=/trunk/; revision=36513
2008-09-25 17:53:05 +00:00
James Tabor
44b6f107bd - Add Defer Window Position Handle type for multiple-window ? position structure.
svn path=/trunk/; revision=36510
2008-09-25 15:39:33 +00:00
Stefan Ginsberg
ccd25605a6 - Implement and export PsIsSystemProcess and add it to the NDK
svn path=/trunk/; revision=36509
2008-09-25 14:39:38 +00:00
Stefan Ginsberg
d2abe18c98 - Implement IoGetPagingIoPriority and fix its export
svn path=/trunk/; revision=36508
2008-09-25 14:29:11 +00:00
Stefan Ginsberg
cb267e1fdf - Add WmiQueryTraceInformation, WmiTraceMessage and WmiTraceMessageVa stubs and exports
svn path=/trunk/; revision=36507
2008-09-25 14:25:22 +00:00
Aleksey Bragin
94b893abac - Fix one more totally "out of ideas how to create sections" MmCreateSection usage. Not only the MaximumSize is mandatory for file-backed sections, but an allocation type must be specified (SEC_COMMIT, and it's not the same as some humble "0" passed there as a value).
- Fix ReactOS's MmCreateDataFileSection to ignore 0 value in the MaximumSize (it has an additional check for MaximumSize being non-NULL, but this should be removed in future).

svn path=/trunk/; revision=36506
2008-09-25 11:24:51 +00:00