Commit graph

949 commits

Author SHA1 Message Date
Giannis Adamopoulos 6aa52a76c8 [COMCTL32_APITESTS] -Add toolbar tests for TB_SETBUTTONSIZE, TB_SETPADDING, TB_GETBUTTONSIZE, TB_GETMETRICS.
svn path=/trunk/; revision=75462
2017-07-31 13:04:09 +00:00
David Quintana 30a8a02f54 [APITESTS]
MSVCRT_CRT_APITEST: Remove getmainargs tests from X64 build.
DELAYIMP: Fix callback prototype.
CComHeapPtr: Fix implementation of IMallocSpy to match the actual interface.

[WINETESTS]
ntdll: Disable 'generated' tests when not i386 platform, since they were generated for x86 and not x64 or ARM.


Fixes x64 compilation for tests.

svn path=/trunk/; revision=75397
2017-07-24 15:09:22 +00:00
Hermès Bélusca-Maïto 73375485df [MSVCRT_APITEST]: Commit a simple test for popen(), by Andreas Maier.
CORE-11568

svn path=/trunk/; revision=75364
2017-07-17 15:27:40 +00:00
Mark Jansen 39596fae98 [APPHELP_APITEST] Convert test_match_ex to a data driven test + fix a bug in the apitest.
svn path=/trunk/; revision=75342
2017-07-14 20:35:11 +00:00
Giannis Adamopoulos 3841692020 [COMCTL32_APITEST] - Log the dwDrawStage when the NM_CUSTOMDRAW is received to make the test slightly more descriptive.
svn path=/trunk/; revision=75320
2017-07-12 12:17:05 +00:00
Mark Jansen 85dde2e51b [USER32_APITEST] Add tests to validate the messages sent during MDI window creation. CORE-12052
The test passes from 2k3 - 10.

svn path=/trunk/; revision=75274
2017-07-03 20:33:36 +00:00
Colin Finck ef0ae276af [NETAPI32_APITEST]
Fix GCC build

svn path=/trunk/; revision=75209
2017-06-26 15:43:58 +00:00
Colin Finck e5654cce9f [NETAPI32_APITEST]
Add a simple API Test for netapi32.dll, only covering DsRoleGetPrimaryDomainInformation so far.
It succeeds in ReactOS, but outputs a heap error in the debug log. In real world applications, this later leads to a heap assertion failure.

svn path=/trunk/; revision=75208
2017-06-26 15:19:07 +00:00
Colin Finck 1525fa31fc [PRINTING]
- Create the actual generic handle in _LocalOpenPrinterHandle.
- Fix _RpcClosePrinter call.
- Enable many more tests in winspool_apitest, GetPrinterData.
- Bail out with ERROR_INVALID_PARAMETER for empty strings in _MakePrinterSubKey as well.
- Add the Name registry value for "Dummy Printer on LPT1" to make a test succeed.

This fixes many basic things.. which only got unnoticed, because Printing is only used in the form of API Tests so far.

CORE-13458
CORE-13459

svn path=/trunk/; revision=75207
2017-06-26 15:16:46 +00:00
Colin Finck 2bd66111fc [ADVAPI32_APITEST]
Fix copy-paste mistakes in messages.

svn path=/trunk/; revision=75206
2017-06-26 15:10:27 +00:00
Mark Jansen 54d38174b1 [APPHELP_APITEST] Add tests for SdbGetMatchingExe, to test matching on version resources. CORE-13284
svn path=/trunk/; revision=75205
2017-06-26 14:58:08 +00:00
Mark Jansen 5c59bd330a [APPHELP_APITEST:db] Fix the test for Win10, use WCHAR for data paths
svn path=/trunk/; revision=75201
2017-06-26 10:26:57 +00:00
Giannis Adamopoulos 7dea13d496 [USER32_APITEST] -Initial tests for desktop reference numbers.
svn path=/trunk/; revision=75153
2017-06-20 19:25:10 +00:00
Thomas Faber e7e6f2ec5f [NTOS:MM]
- In MiDeletePte, check the ReferenceCount of transition PTEs, not the ShareCount (which is actually u2.Blink, since the page is in a modified/standby list). Also don't reset the PageLocation, since MiDecrementReferenceCount expects it to be anything but ActiveAndValid.
Fixes physical page leaks when using DPH, or other code that sets PAGE_NOACCESS.
CORE-13311 #resolve

svn path=/trunk/; revision=75150
2017-06-20 15:51:47 +00:00
Hermès Bélusca-Maïto b17ce9c805 [NTDLL_APITEST]: Temporarily disable part of the NtLoad/UnloadKey test (related to force-unload a hive while some handles to subkeys are still opened), because this creates memory corruptions, due to the fact we currently don't perform force-unloads correctly.
CORE-13448

svn path=/trunk/; revision=75138
2017-06-19 19:50:49 +00:00
Mark Jansen 8f2f019415 [APPSHIM_APITEST] Addendum to r75041, add a missed line.
svn path=/trunk/; revision=75131
2017-06-19 15:24:05 +00:00
Colin Finck a82d7577b3 [PRINTING]
- Implement GetPrinterDataA, GetPrinterDataExA, GetPrinterDataExW, GetPrinterDataW, SetPrinterDataA, SetPrinterDataExA, SetPrinterDataExW, SetPrinterDataW.
  They support all features for Print Server and Printer Handles (minus security checks!)
  I've also added tests for them.
- Store Printer data in SOFTWARE\Microsoft\Windows NT\CurrentVersion\Print\Printers instead of SYSTEM\CurrentControlSet\Control\Print\Printers and create a registry symlink from the former path to the new one just like Windows does.
  According to https://social.technet.microsoft.com/Forums/windowsserver/en-US/a683ab54-c43c-4ebe-af8f-1f7a65af2a51, this is needed when having >900 printers to work around a size limit of the SYSTEM registry hive. And if Windows has both locations, we need both for compatibility anyway.
- Add several settings which are queried by the new Printer Data APIs when working with Print Server Handles.
- Store the job directory in the Windows-compatible "DefaultSpoolDirectory" setting and make use of it.
- Revert the ASSERTs in LocalEnumPrinters again to let us verify the NULL pointer exceptions in localspl_apitest (thanks Serge! CORE-13433)
- Translate ERROR_INVALID_NAME to ERROR_INVALID_PRINTER_NAME in all cases in OpenPrinterW (thanks Victor! CORE-13412)
- Make EnumMonitorsW and EnumPortsW in spoolss more robust against failing Print Monitors.
- Remove the wrong !phPrinter check in OpenPrinterW to make Print Server Handles work for real.
- Fix error handling when memory allocation fails: HeapAlloc doesn't set last error, so it's just wrong to query or return it.

One more item done from https://reactos.org/wiki/Printing !
This is all still a big Work-in-Progress, with many subtle bugs deep down in ReactOS, for which I need to open additional tickets. But I didn't want to make this commit even bigger..

svn path=/trunk/; revision=75125
2017-06-19 14:18:19 +00:00
Thomas Faber d88cd4165d [PSDK]
- Properly add NTSTATUS code

svn path=/trunk/; revision=75081
2017-06-17 20:26:53 +00:00
Hermès Bélusca-Maïto 7f8dc7dfcc Just use REG_FORCE_UNLOAD since we're at it.
svn path=/trunk/; revision=75079
2017-06-17 20:13:17 +00:00
Hermès Bélusca-Maïto 9808e1ee19 [NTDLL_APITEST]: Add tests for NtLoadKey and NtUnloadKey.
CORE-13448

svn path=/trunk/; revision=75078
2017-06-17 20:08:48 +00:00
Mark Jansen 272bc3ef9f [APITEST] Move RedirectIat into it's own header so that it can be used from multiple tests.
svn path=/trunk/; revision=75041
2017-06-14 15:25:04 +00:00
Mark Jansen 3a302c5330 [APPHELP_APITEST] Addendum to r74986, make the test work on win7. CORE-13284
svn path=/trunk/; revision=75004
2017-06-11 13:09:43 +00:00
Mark Jansen b8ea78efa1 [WIN32NT_APITEST] Do not assert on a driver without DirectX support.
svn path=/trunk/; revision=75001
2017-06-11 11:47:41 +00:00
Mark Jansen 7583b2b298 [WIN32KNT_APITEST] Do not assert on the result of an unimplemented function.
svn path=/trunk/; revision=74996
2017-06-11 08:51:36 +00:00
Mark Jansen be0666cf16 [APPHELP_APITEST] Add tests for ApphelpCheckRunApp[Ex], SdbGetMatchingExe, Sdb[Un]PackAppCompatData. CORE-13284
svn path=/trunk/; revision=74986
2017-06-10 20:31:58 +00:00
Mark Jansen 1b27b462ec [SHLWAPI_APITEST] Add PathFindOnPath tests. Patch by Katayama Hirofumi MZ. ROSTESTS-283 #comment Thanks!
svn path=/trunk/; revision=74984
2017-06-10 19:41:31 +00:00
Mark Jansen d4db41b968 Addendum to r74982, remove some debugging code.
svn path=/trunk/; revision=74983
2017-06-10 17:47:56 +00:00
Mark Jansen 20cbe80c85 [SHELL32_APITEST] Add tests for PathResolve. Patch by Katayama Hirofumi MZ. CORE-12665 #comment Thanks!
svn path=/trunk/; revision=74982
2017-06-10 17:46:11 +00:00
Hermès Bélusca-Maïto 7384a6a1d5 [GDI32_APITEST]: Fix the "missing braces around initializer" GCC error that I've introduced in r74962.
svn path=/trunk/; revision=74966
2017-06-08 19:09:01 +00:00
Hermès Bélusca-Maïto 72c5e65e8c [GDI32_APITEST]: Fix compilation under MSVC 2010.
svn path=/trunk/; revision=74962
2017-06-08 17:00:55 +00:00
Giannis Adamopoulos 759a452d44 [COMCTL32_APITEST] -Make comctl32v5.manifest really point to the v5 library.
svn path=/trunk/; revision=74929
2017-06-05 21:50:21 +00:00
Giannis Adamopoulos 3767fcf5cc Fix gcc build.
svn path=/trunk/; revision=74924
2017-06-05 14:40:48 +00:00
Giannis Adamopoulos 0cfb73fce3 [COMCTL32_APITEST] -Add tests for CCM_GETVERSION and CCM_SETVERSION for the v5 and v6 toolbar control.
svn path=/trunk/; revision=74923
2017-06-05 14:25:37 +00:00
Hermès Bélusca-Maïto 93cfc03633 [SETUPAPI]: Fix a 9-year old bug in the SETUP_CreateClassKey() logic, introduced in r31860, that set a wrong Class name value if the corresponding registry key already existed. The bug was unveiled by my commit r74761.
[SETUPAPI_APITEST]: When selecting another test_class_guid and test_class_name couple via SetupDiClassNameFromGuidA(), check whether this function actually succeeds. Also, improve some error output.

svn path=/trunk/; revision=74916
2017-06-04 18:16:24 +00:00
Thomas Faber 440e3c69e4 [KERNEL32_APITEST]
- Add tests for IsDBCSLeadByteEx. Patch by Katayama Hirofumi MZ.
ROSTESTS-281 #resolve

svn path=/trunk/; revision=74758
2017-06-03 07:05:31 +00:00
Mark Jansen 9a54d4a3a0 [KERNEL32_APITEST] Add test to show that we should not spoil TEB->StaticUnicodeString in CreateProcessA. CORE-10368
svn path=/trunk/; revision=74701
2017-05-30 20:55:15 +00:00
Mark Jansen 440290e1cb [USER32_APITEST] Add more tests to validate messages sent during window creation / modifying of styles. CORE-12052
svn path=/trunk/; revision=74691
2017-05-28 17:40:48 +00:00
Mark Jansen 9386daa570 [USER32_APITEST] Add tests to validate messages sent during window creation / modifying of styles. CORE-12052
svn path=/trunk/; revision=74689
2017-05-28 13:55:05 +00:00
Peter Hater 1c9d856e91 [WS2_32_APITESTS] Add close tests ROSTESTS-279
svn path=/trunk/; revision=74672
2017-05-26 14:02:25 +00:00
Peter Hater a6a53b4231 [WS2_32_APITESTS] Fix broadcast test ROSTESTS-278
svn path=/trunk/; revision=74671
2017-05-26 14:00:47 +00:00
Peter Hater a09e47fe40 [WS2_32_APITESTS] Fix broadcast test ROSTESTS-278
svn path=/trunk/; revision=74667
2017-05-26 10:31:50 +00:00
Peter Hater 92ccd9c174 [WS2_32_APITESTS] Add rebind and bind to broadcast tests ROSTESTS-278
svn path=/trunk/; revision=74666
2017-05-26 09:02:08 +00:00
Peter Hater b2ba90c6b5 [WS2_32_APITESTS] Fix GCC build ROSTESTS-278
svn path=/trunk/; revision=74664
2017-05-26 07:11:13 +00:00
Peter Hater 4214877a10 [WS2_32_APITESTS] Improve bind test output ROSTESTS-278
svn path=/trunk/; revision=74663
2017-05-26 07:08:06 +00:00
Peter Hater 27fe85a2cb [WS2_32_APITESTS] Set the size of addr when calling getsockname ROSTESTS-278
svn path=/trunk/; revision=74655
2017-05-25 15:57:38 +00:00
Peter Hater a569e0aa3a [WS2_32_APITESTS] Remove compile warning disable for GCC. Thanks Thomas. ROSTESTS-278
svn path=/trunk/; revision=74653
2017-05-25 15:12:40 +00:00
Peter Hater 44ac5bf123 [WS2_32_APITESTS] Add some bind API tests
svn path=/trunk/; revision=74651
2017-05-25 14:43:57 +00:00
Mark Jansen f64b823282 [GDI32_APITEST] Improve GetFontResourceInfoW tests. Patch by Katayama Hirofumi MZ. ROSTESTS-269 #resolve #comment Thanks!
svn path=/trunk/; revision=74602
2017-05-19 20:26:49 +00:00
Thomas Faber 10e08033ca [NTDLL_APITEST]
- Add a test for RTL handle tables
CORE-13271

svn path=/trunk/; revision=74598
2017-05-19 18:05:12 +00:00
Colin Finck a366e71f50 [PRINTING]
SetDefaultPrinterW needs to fail with ERROR_INVALID_PRINTER_NAME if the input parameter is invalid. Also add a test for that.

svn path=/trunk/; revision=74518
2017-05-10 13:03:08 +00:00