Commit graph

36 commits

Author SHA1 Message Date
Katayama Hirofumi MZ bb297bc351
[BROWSEUI] Use STDMETHOD macro and keyword override (#6569)
For simplicity and short typing.
JIRA issue: CORE-19469
- Replace "virtual HRESULT 
  STDMETHODCALLTYPE m"
  with "STDMETHOD(m)"
  (m is a method name).
- Replace "virtual t
  STDMETHODCALLTYPE m"
  with "STDMETHOD_(t, m)"
 (t is a type. m is a method name).
- Use "override" keyword as possible.
2024-03-05 00:53:11 +09:00
Hermès Bélusca-Maïto 46ab34662d
[BROWSEUI] Some parenthesizing clarification around "xxx & YYY" expressions in conditionals 2023-10-28 17:56:55 +02:00
Katayama Hirofumi MZ b4e946f5b0
[BROWSEUI] Fix pos of taskbar toolbar right-click menu (#5421)
Don't call ClientToScreen in handling NM_RCLICK message because NMMOUSE.pt is already in screen coordinates.
CORE-18966
2023-07-11 05:28:50 +09:00
Katayama Hirofumi MZ 337cbf5888 [BROWSEUI] Follow-up of 2e67c18 (#4767); Also check 'MenuText'
CORE-18394
2022-10-13 11:07:03 +09:00
Katayama Hirofumi MZ 2e67c18d2b
[BROWSEUI][INCLUDE] Localize 'Address' on CBandSiteMenu (#4767)
- Add IDS_ADDRESSMENUTEXT resource string (whose ID matchs the string of addressband.rgs).
- Add SHLoadRegUIStringA/W function prototype to <shlwapi_undoc.h>.
- Use SHLoadRegUIStringW to load MenuTextPUI.
CORE-18394
2022-10-11 06:15:28 +09:00
Hermès Bélusca-Maïto 9393fc320e
[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.
Excluded: 3rd-party code (incl. wine) and most of the win32ss.
2021-09-13 03:52:22 +02:00
Victor Perevertkin 74ec94e12c [CMAKE] Some options are only supported by GCC, don't use them for clang
These are (so far):
-Wno-format-overflow
-Wno-nonnull-compare
-Wno-old-style-declaration
-Wno-unused-but-set-variable
2021-04-09 03:58:19 +03:00
Jérôme Gardou 907025a018 [CMAKE] Introduce the atl_classes interface library
This takes care of adding the relvant include directory and the _ATL_NO_EXCEPTIONS define, if needed
2020-10-20 21:44:54 +02:00
Jérôme Gardou d6ea8659c8 [CMAKE] Get rid of the set_cpp macro
Instead of messing with global variables and the like, we introduce two target properties:
 - WITH_CXX_EXCEPTIONS: if you want to use C++ exceptions
 - WITH_CXX_RTTI: if you need RTTI in your module
You can use the newly introduced set_target_cpp_properties function, with WITH_EXCEPTIONS and WITH_RTTI arguments
We also introduce two libraries :
 - cpprt: for C++ runtime routines
 - cppstl: for the C++ standard template library

NB: On GCC, this requires to create imported libraries with the related built-in libraries:libsupc++, limingwex, libstdc++

Finally, we manage the relevant flags with the ad-hoc generator expressions

So, if you don't need exceptions, nor RTTI, nor use any runtime at all: you simply have nothing else to do than add your C++ file to your module
2020-10-20 21:44:54 +02:00
Thomas Faber 185591368d [SHELLBARS] Add missing psdk dependency. 2020-06-06 23:02:35 +02:00
Victor Perevertkin 7e069ccdb2
[CMAKE] Replace custom functions to built-in ones
add_target_compile_definitions -> target_compile_definitions
add_target_compile_flags -> target_compile_options
add_target_include_directories -> target_include_directories
2020-04-16 15:59:38 +03:00
Serge Gautherie 92e5fabb55
[BROWSEUI] Fix SHEnumClassesOfCategories() parameter validation. (#1622)
Addendum to fdfef818. CORE-11711
2019-06-08 20:05:54 +02:00
Hermès Bélusca-Maïto fdfef818ef
[BROWSEUI] Fix CSHEnumClassesOfCategories::Initialize() parameters validation. (#1559)
CORE-11711
2019-06-06 17:07:38 +02:00
Mark Jansen 9824a0154e
[ATL] Retire atlnew 2019-04-18 19:21:37 +02:00
Mark Jansen f9e50f5471 [ATL] Add GET_X_LPARAM and GET_Y_LPARAM to atlwin.h
Remove all local definitions
2019-01-15 14:34:53 +02:00
Giannis Adamopoulos a0c5cafce5 [BROWSEUI] Implement toggling the folders and search band with the toolbar and make their buttons appear pressed when they are shown.
CBaseBarSite: Ask the CBaseBar to close itself when the x button is pressed.
CBaseBar: Hide the bar and inform its site that it is closing when it gets the close command.
CShellBrowser: Cache the guid of the current vertical bar and use it to report correct command status to the toolbar.
Also implement toggling the Folders, Favorites, History and search commands.
CInternetToolbar: Query the Folders and Search command status from the site so that they can be properly be shown as pressed.
2018-10-27 15:08:24 +03:00
Thomas Faber 0aed0fd167
[BROWSEUI][SHELL32] Treat OnWinEvent's result parameter as optional. CORE-14443
Windows's explorer can call it with NULL.
2018-03-08 12:21:24 +01:00
Giannis Adamopoulos 6d4a091b4a [BROWSEUI] CBandSite: Implement SetBandSiteInfo and GetBandSiteInfo
Only BSIS_LOCKED, BSIS_NOGRIPPER, BSIS_ALWAYSGRIPPER and BSIS_NOCAPTION supported so far.
2018-02-28 17:20:46 +02:00
Giannis Adamopoulos 6785192fe6 [BROWSEUI] CBandSite: Style fixes 2018-02-28 17:20:44 +02:00
Giannis Adamopoulos 4c23b78b5e [BROWSEUI] CISFBand: Handle DBID_SETWINDOWTHEME. CORE-14176 2018-01-16 11:50:51 +02:00
Amine Khaldi b3544fd00b [BROWSEUI/SHELLBARS] Add a PCH. 2017-12-09 20:46:40 +01:00
Giannis Adamopoulos d163627319 [BROWSEUI] Move _ILIsDesktop to a shared header to avoid having 3 instances of it 2017-12-07 23:26:30 +02:00
Amine Khaldi 09c06a2f45 [CLANG-CL] Initial commit that allows us to compile ReactOS with clang-cl. 2017-11-23 14:09:57 +01:00
Stanislav Motylkov e12763d5bc [BROWSEUI] CISFBand: Add "Open Folder" feature
CORE-13996 #resolve
2017-11-18 12:08:16 +02:00
Stanislav Motylkov f01e6ed6c5 [BROWSEUI] CBandSiteMenu: Show Toolbar error on failure 2017-11-18 11:40:58 +02:00
Stas'M 484f33f0d3 [BROWSEUI] CBandSiteMenu
- Move SHGetFolder code to CreateBuiltInISFBand
- Get rid of CSIDL_FLAG_CREATE (Windows doesn't create Quick Launch
directory)
- Use ILFree since variables are reused now
2017-11-05 14:06:47 +02:00
Giannis Adamopoulos 2875a70c0a [BROWSEUI] Add a todo comment block in CISFBand.cpp and CBandSite.cpp regarding some problems and missing features when using the quick launch toolbar. These two lists are not complete but cover most important problems of quick launch. There is no need to create bug reports for these. 2017-11-02 19:52:02 +02:00
Giannis Adamopoulos 143c306006 [BROWSEUI] CBandSiteMenu: Use CSimpleArray and CComHeapPtr. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 3bfdbf3b2c [BROWSEUI] Improve CBandSiteBase::OnWinEvent to forward messages correctly to the child bands. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos bab9a54039 [BROWSEUI] Add a hack and abuse ISFB_STATE_QLINKSMODE to make the quick launch band to be aligned to left and show no text 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos ee3b732043 [BROWSEUI] CISFBand: Misc fixes
- Slightly improve the implementation of IShellFolderBand
- Show both folders and files in the toolbar
- Use the name of the folder shown as the name of the band
2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 37e6151b40 [BROWSEUI] CBandSiteMenu: Implement the Desktop, Quick Launch and New Toolbar menu items 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 0ed80264f9 [BROWSEUI] CBandSiteMenu: Fix two broken loops 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos 8a52080dcc [BROWSEUI] Rename CISFBand_CreateInstance and add a CISFBand_CreateInstance macro that makes easy to switch between the system implementation or the local one. 2017-10-22 20:03:32 +03:00
Giannis Adamopoulos f0f1e5ffdb [QCKLNCH] Remove qcklnch (#61)
- Move CIFSBand to the shellbars static lib which is linked to browseui and rshell.
- Move CQuickLaunchBand to rshell.
- Make nescessary adjustments so that they can both be registered and instantiated.
2017-10-16 23:56:34 +03:00
Colin Finck c2c66aff7d Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00