Commit graph

2546 commits

Author SHA1 Message Date
Kyle Katarn c1fad34755
[WINNLS] Fix of GetCurrencyFormatW to handle "32" grouping format (#2719) 2020-05-10 08:34:35 +02:00
Charles Ambrye e978ec6125
[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted (#2703)
Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.
2020-05-09 21:54:15 +09:00
Jared Smudde e2fdfae24f
[COMDLG32] Add some more places to the places bar in the open file dialog. (#2732)
Add Recent Documents and My Network Places to the places bar in the open file dialog.

NOTE: Technically this "places bar" can be customized:
https://www.tenforums.com/tutorials/126153-change-places-bar-items-common-dialog-box-windows.html
https://www.sevenforums.com/tutorials/85487-common-file-dialog-box-customize-places-bar.html
2020-05-09 21:50:20 +09:00
Kyle Katarn 295ba62820
Fix of comdlg32 Treeview undue handling of WM_SYSKEYDOWN (#2731)
Remove WM_SYSKEYDOWN handling at component level, in consistency with other components (ListView,...)
Early embodiement of the fix proposed to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=49097 in order to remove functionnal limitation in ReactOS. CORE-17020
2020-05-09 21:37:26 +09:00
Katayama Hirofumi MZ 0ea110cda9 [RSAENH][MSXML3][OLE32] Revert PRIVATE commits (cbe8a9f and 38b438b) 2020-05-09 17:55:37 +09:00
Katayama Hirofumi MZ 38b438b0f6 [MSXML3][OLE32] DllGetClassObject should be PRIVATE 2020-05-09 17:02:08 +09:00
Katayama Hirofumi MZ cbe8a9f997 [RSAENH] DllRegisterServer should be PRIVATE 2020-05-09 16:59:59 +09:00
Katayama Hirofumi MZ 413d722628
Revert "Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)" (#2758)
This reverts commit 66b0a48a75.
2020-05-09 15:32:15 +09:00
Katayama Hirofumi MZ 66b0a48a75
Revert "[COMCTL32][USER32] Fix radio button regression (#2146)" (#2753)
This reverts commit 2d4d3f5fce.

Reverts #2146. I think #2135 (e329e83) and #2146 (2d4d3f5) are my mistakes.
CORE-16552, CORE-16747
2020-05-09 11:30:11 +09:00
Serge Gautherie 02825c20e4
[APISETS] api-ms-win-core-winrt-l1-1-0: Ro*() are NT8+ (#2739)
(Supersedes PR #2374.)
CORE-16707
2020-05-07 13:00:10 +02:00
Kyle Katarn d635ce0cc0
[SYSDM][DESK] Fix GetDC/ReleaseDC error management (#2707)
## Purpose
[SYSDM]
- When closing System Properties page, log show
(win32ss/user/ntuser/windc.c:749) err: [00060138] GetDC() without ReleaseDC()!
because GetDC() is called (multiple times) without properly calling ReleaseDC() as required in order to release a device context.
- This module also lacks some error management in case null DC are provided (on error).
- LiveCD Userinit, based on SYSDM is affected too.

[DESK]
- Fix missing ReleaseDC related to the spectrum (color depth)

## Proposed changes
- ReleaseDC() added.
- Error management in case of null DC.
- Overall alignement of LiveCD Userinit and SYSDM.
2020-05-07 12:57:46 +02:00
Katayama Hirofumi MZ 1f3cb13fb9
[SHELL32] Distinguish floppy and removable drives (#2645)
Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221
2020-05-06 00:35:01 +09:00
Serge Gautherie 9634a31589
[ADVAPI32] Remove now-redundant comment (#2735)
Addendum to 5dfe345.
2020-05-05 11:37:09 +03:00
Kyle Katarn 5dfe3455db
[ADVAPI32] Fix undue debug print in nominal case (#2734)
In current implementation, when regedit opens HKCR root key, an error is logged
err:(dll/win32/advapi32/reg/hkcr.c:964) Returning 259.
This is not correct as the code 259 is ERROR_NO_MORE_ITEMS which is the nominal return value when end of enumeration is reached.
2020-05-04 23:30:36 +03:00
Serge Gautherie 8f5b0d8890
[APISETS] *_seh_filter_*() are NT6+ (#2729)
Addendum to 65fd292. CORE-16700
2020-05-04 23:26:38 +03:00
Adam Stachowicz 4da611ad4b
[NETID] Update Polish translation (#2709)
Addendum to c276681.
2020-05-04 23:20:04 +03:00
Victor Perevertkin 8bd9450da8
[HTTPAPI] Convert httpapi.dll to a stub-only library
Wine's implementation relies on http.sys driver, which we don't have
anyway. Function declarations are taken from Wine 5.7

CORE-16963
2020-05-04 11:37:16 +03:00
Katayama Hirofumi MZ 11b6f973b7 [SHELL32] Follow-up 2 of #2659
Add TODO comments.
Make CreateAPCThread static.
CORE-13950
2020-05-04 16:22:38 +09:00
Katayama Hirofumi MZ 7980f40911 [SHELL32] Follow-up of #2659
Add CreateAPCThread function and use it. CORE-13950
2020-05-04 15:28:16 +09:00
Katayama Hirofumi MZ 5c589b5537
[SHELL32] Notify filesystem changes (#2659)
Notify filesystem change notifications by using ReadDirectoryChangesW function. Creating/Deleting files/folders will be responsive in Explorer. CORE-13950
2020-05-04 14:53:23 +09:00
Jared Smudde 5b7be1572b
[SHELL32] Set the Run dialog to use the newer style browse for file dialog. (#2728)
Apply the OFN_EXPLORER flag to the Run dialog so the dialog uses the newer style browse dialog.
2020-05-04 12:53:35 +09:00
Kyle Katarn 033a317d06
[SYSDM] Fix the missing TABSTOP style on Startup and Recovery dialog (#2722)
Now the OS choice and the debug info selection combo-boxes can be selected via keyboard navigation.
2020-05-03 12:16:45 +02:00
Eric Kohl 8c4b0c9142 [NETID] Disable the 'Network ID' and 'Change' buttons and show the admin note when the current user is not an administrator 2020-05-01 22:34:01 +02:00
Eric Kohl 226878563f [NETID] Fix a typo in NetworkDlg_OnOK 2020-05-01 22:00:32 +02:00
Eric Kohl b25fe54f29 [NETID] Fix the left margin on the Computer Name dialog 2020-05-01 20:00:12 +02:00
Eric Kohl c276681ef4 [NETID] Improve the 'Computer name' property page
- Check for changes of the host and domain name.
- Use NetGetJoinInformation to retrieve the join status.
- Implement the SyncDomainWithMembership setting.
- Disable the administrator warning temporarily.
2020-05-01 19:44:09 +02:00
Kyle Katarn 8bd6b9b6c2
[OLE32][WINESYNC] Fix Wine's implementation of IMalloc.DidAlloc based from Wine 5.7 (#2662)
CORE-15262

This fixes the exceptions raised when calling "Scan folder" a second time in SUMo 5.10.16.
The problem was reported to WineHQ : https://bugs.winehq.org/show_bug.cgi?id=48941

Import Wine commits by Nikolay Sivov, with the help of Doug Lyons:
- 08f4b6ee0a
  ole32: Fix IMalloc::DidAlloc() return value to reflect block validity.
- 1e3bc9f3a6
  ole32: Improve thread safety in DidAlloc().
- 06d36b1adf
  ole32: Fix spy callback arguments for IMalloc::GetSize().
2020-05-01 15:01:19 +02:00
Kyle Katarn 3bee3b92ab
[SYSDM] Virtual Memory panel : Complementary fix from PR #2597 (#2706)
Fix all lang resources in order to reflect main changes from PR #2597 (16MB>2MB).
To translators: Please sync the respective translations!

CORE-12486
2020-05-01 14:47:04 +02:00
Oleg Dubinskiy b0e995728a
[SYSSETUP] Improve SetupQueryRegisteredOsComponent export (#2702)
CORE-16784

Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
2020-05-01 13:45:19 +03:00
Katayama Hirofumi MZ 77b8505393
[SHELL32] Delete IDM_RECENTMENUHEAD resource menu (#2705)
Follow-up of #2648. Reduce translation cost and resource data.
CORE-3588, CORE-11483
2020-05-01 15:58:58 +09:00
Katayama Hirofumi MZ d62b1a9ce5 [CPL][HOTPLUG] Add Japanese translation 2020-05-01 10:52:19 +09:00
Katayama Hirofumi MZ 0bf4cc4304 [TIMEDATA] Improve Japanese translation 2020-05-01 10:37:46 +09:00
Katayama Hirofumi MZ 7812c537de [MYDOCS] Add Japanese translation 2020-05-01 10:25:47 +09:00
Kyle Katarn cd6e1c73c0
[SHELL32] Fix "Open With..." spamming registry MRU keys. (#2685)
CORE-16981

The problem:
============

- When opening "Open With..." dialog for a given file format, multiple MRU items are appended to registry : 2 items written, even if dialog is closed "cancel".
- Expected behavior : 1 MRU item if execute is selected and 0 MRU if cancel is selected.

Fix:
====

- MRU item to be added when "Execute" is selected only.
- Once added, set the presence flag to avoid multiple MRU items being added later.
2020-04-30 23:03:10 +02:00
Mark Jansen 190c1b86ec
[ZIPFLDR] Set correct access time on file extraction 2020-04-30 20:38:43 +02:00
Jose Carlos Jesus 534710a6d5 [SHELLEXT] Fixed some typos in Portuguese translation 2020-04-30 20:29:21 +02:00
Stanislav Motylkov 79f5de2a73
[TIMEDATE] Update Russian translation
Addendum to 5a81a5b. CORE-16684
2020-04-30 20:58:59 +03:00
Stanislav Motylkov da9f43e76f
[HOTPLUG] Add Russian translation
Also made some cosmetic fixes and added missing menu in Indonesian translation

Addendum to 2125fec, bfdd626 and b8dd046.
2020-04-30 20:58:33 +03:00
Stanislav Motylkov 1dd70d306f
[POWERCFG] Update Russian translation
Addendum to 535b8dd and 52cd931. CORE-12565 CORE-16893
2020-04-30 20:58:08 +03:00
Stanislav Motylkov f956c962f0
[DESK] Update Russian translation
Addendum to d05f621 and e157468. CORE-14537 CORE-16923
2020-04-30 20:57:42 +03:00
Stanislav Motylkov f0e22d15c9
[INTL] Add Russian translation
Also improve other translations. Addendum to 216b702. CORE-16951
2020-04-30 20:56:50 +03:00
Stanislav Motylkov fefe9736ac
[SENDMAIL] Update Russian translation
Addendum to a48aa21. CORE-16924
2020-04-30 20:56:22 +03:00
Stanislav Motylkov 44e2b6fdd9
[BOOTDATA][THEMEUI] Add Russian translation
Addendum to 94e4c69 and a2f5283. CORE-16934
2020-04-30 20:55:56 +03:00
Stanislav Motylkov d3e94b4cec
[MYDOCS] Add Russian translation
Addendum to 4efff7f. CORE-12562
2020-04-30 20:55:28 +03:00
Mas Ahmad Muhammad 7895704952 [COMDLG32] enlarge list area in CHOOSE_FONT 2020-04-30 18:15:48 +02:00
Adam Stachowicz bd33e6b26f
[SHELL32] Update Polish translation (#2700)
Addendum to 8f3079c.
2020-04-30 13:37:31 +03:00
Jared Smudde 96e6cee044
[DESK] Set some flags for Browse for Wallpaper dialog (#2699)
* [DESK] Add initial directory flag and set it to My Pictures. Also set OFN_EXPLORER style.

* Use CSIDL_MYPICTURES instead of environment variable concoction.

* Fix formatting.
2020-04-30 11:10:40 +03:00
Katayama Hirofumi MZ 8f3079c67f
[SHELL32][EXPLORER] Improve Recent Documents of Start Menu (#2648)
Improve Recent Documents of Start Menu. Add items of "My Documents" and "My Pictures" into Recent menu item.
CORE-3588, CORE-11483
2020-04-30 17:09:14 +09:00
Jose Carlos Jesus 6d739cb2ce
[APPWIZ] Make shortcut name selected on creation (#2184) 2020-04-30 09:02:33 +03:00
Serge Gautherie a9161650ad
[MSVCRT][APISETS] Update spec files for __DestructExceptionObject() (#2682)
- [MSVCRT] __DestructExceptionObject(): Remove '-version=0x600+'
- [APISETS] __DestructExceptionObject(): Forward it to msvcrt

CORE-15135
2020-04-30 00:36:44 +03:00