Commit graph

72973 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto 7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed.
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings()
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981
2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto 41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine.
- Adjust the code with respect to:
  "shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
  4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)

- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
  ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)

- "shell32: Assume that system directory always contains a drive letter."
  54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)

- "shell32: Use ARRAY_SIZE macro."
  612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)

- "shell32: Fix a trace message."
  bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)

- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
  f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)

- "shell32: Pass correct buffer length to RegQueryValueExW()."
  0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)

- "shell32: Remove unused string (Clang)."
  8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)

- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
  730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
2018-09-23 00:16:02 +02:00
Bișoc George 983b4c9f94 [MSCONFIG_NEW] Do not assign an access key to a letter with diacritic 2018-09-22 21:51:14 +02:00
Paweł Cholewa 13045d50ed [DWNL] Add Polish translation 2018-09-22 14:53:13 +02:00
Eric Kohl de08785ade [SETUPAPI] SetupDiCreateDevRegKeyW / SetupDiOpenDevRegKey: Create or open the 'Device Parameters' subkey of the given devices enum key when we try to access its hardware key.
This creates the PortName value in the proper location for serial ports.
2018-09-22 14:43:43 +02:00
Eric Kohl e32a2cc026 [NTOSKRNL] IoGetDeviceProperty: Add support for the DevicePropertyRemovalPolicy property.
This could probably fix CORE-15068.
2018-09-22 11:22:22 +02:00
Abdulganiev Rafael 2a6aa7770e [BTHCI] Add a bluetooth icon (#871)
[BTHCI] Add a bluetooth icon
2018-09-21 23:42:27 +02:00
Pierre Schweitzer 82a7f08363
[DWNL] Add French translation 2018-09-21 22:36:10 +02:00
Eric Kohl e1b82b5b91 [NTOSKRNL] Create the 'Device Parameters' subkey and add the 'FirmwareIdentified' value for all ACPI-enumerated devices. 2018-09-21 15:37:34 +02:00
Eric Kohl 2550325577 [NTOSKRNL] Fix the indentation of some pnp manager functions. 2018-09-21 15:08:43 +02:00
Pierre Schweitzer 351ae6b2b4
[KMTESTS:CC] Add tests for CcCopyRead that reproduce CORE-15067
CORE-15067
2018-09-21 08:37:20 +02:00
Pierre Schweitzer 15a3ca08b0
[NTOSKRNL] Avoid integer overflow when computing VACB read/write size
This could be triggered when attempting to read/write to really big
files. It was causing an attempt to read 0 bytes in Cc, leading to
asserts failure in the kernel (and corrupted file).

CORE-15067
2018-09-21 08:37:20 +02:00
Joachim Henze ef016bfe0a [WIN32K:NTUSER] Fix WIN32K BSOD mentioned in CORE-15027
Fixes accessing nullptr / invalid handle in Window->SystemMenu
I could trigger this occasionally when moving Opera 12.18 window
in front of Spotify 1.0.29.92 window.

Fix was:
authored by Thomas Faber (Thank you!)
tested by me
reviewed by James Tabor
2018-09-21 03:04:31 +02:00
Eric Kohl f8f83d4d4d [BTHCI] Add a bluetooth class installer stub.
Now we really need a tango-compatible bluetooth icon!
2018-09-20 17:53:08 +02:00
Eric Kohl 1ac5f1ab89 [INF] Add german translation to the bluetooth class inf file. 2018-09-20 13:52:03 +02:00
Robert Naumann 3aeae65e08 [DWNL] forgot this file 2018-09-20 09:20:14 +02:00
Robert Naumann abdd8bf2df [DWNL] German translation 2018-09-20 09:16:22 +02:00
Joachim Henze 2114a2fb5f [SCHEDSVC] Fix a typo in debug print that was introduced in 0.4.10-dev-544-g
0d13bb1015
2018-09-19 22:52:48 +02:00
Eric Kohl 5e2fe08918 [WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service.
The Logoff-Handler might try to notify the scheduler service which might already have been shut down. We need to fix the shutdown sequence, so that the service manager stops all running services.

Might fix CORE-14521.
2018-09-19 16:35:12 +02:00
Eric Kohl 76588be0d1 [ADVAPI32][SERVICES] Use the session key provided by SystemFunction028 to encrypt and decrypt the service passwords. 2018-09-19 12:30:33 +02:00
Stanislav Motylkov 9f87785e96 [DWNL] Improve print date 2018-09-19 12:16:23 +02:00
Stanislav Motylkov e283f4f72b [DWNL] Add russian translation 2018-09-19 12:16:23 +02:00
Eric Kohl 4114dcad46 [ADVAPI32] Implement SystemFunction028 to always return the default session key. 2018-09-19 00:20:11 +02:00
Lee Schroeder 08be1648f9 [DWNL] Localize the File Download utility (#853)
Also, changed header string to include a start time stamp similar to the one in wget.
CORE-14498
2018-09-18 23:55:44 +02:00
Pierre Schweitzer 108991a6fb
[NTOSKRNL] Stub IoInitializeCrashDump()
Also call it from NtCreatePagingFile() when we have successfully created
a paging file on the system boot partition.
2018-09-18 21:59:59 +02:00
Eric Kohl e5fcda922b [ADVAPI32][SERVICES] Pass encrypted passwords to the service manager.
- Encrypt passwords before passing them to the service manager. Right now, we are using a fixed encryption key. This will be fixed later.
- Replace the calls to ZeroMemory which are used to wipe the password buffers by calls to SecureZeroMemory.
2018-09-18 21:33:29 +02:00
Eric Kohl da73c81259 [IDL][LSASRV] Improve the credentials interface a little and update the lsa server code accordingly. 2018-09-18 15:55:18 +02:00
Eric Kohl 47854962ac [ADVAPI32_WINETEST] Fix the STATUS issues 2018-09-18 00:24:36 +02:00
Eric Kohl 6c0d9c01e2 [ADVAPI32] SystemFunction004 and SystemFunction005 must return the required output buffer size via out->Length when the buffer is too small. 2018-09-17 23:19:02 +02:00
Eric Kohl ffd1293f99 [ADVAPI32_WINETEST] Add tests for SystemFunction004 and SystemFunction005.
These tests show that the required output buffer size it returned in out.Length field when STATUS_BUFFER_TOO_SMALL is returned.

This patch will be sent upstream.
2018-09-17 23:12:16 +02:00
Eric Kohl 5e2c4657ca [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager 2018-09-17 16:34:48 +02:00
Hermès Bélusca-Maïto a631e31c86
[RPCSS] During the setup phase, the RPCSS service, initially running under the LocalSystem account, should re-configure itself to run under the NetworkService account.
This will also fix MS Office 2010 installation, where the installation
expects the NetworkService account profile to be already loaded (this
condition is always verified on Windows since RPCSS and other services
also run under this account).

CORE-14988, CORE-14989
2018-09-17 01:23:03 +02:00
Hermès Bélusca-Maïto 9d43950db7
[SERVICES] Add basic support for setting lpServiceStartName via RChangeServiceConfigW(). 2018-09-17 01:22:59 +02:00
Hermès Bélusca-Maïto a987856e71
[SERVICES] Minor code style fixes; replace wcslen(xxx) ==/!= 0 and strcpy(string, 'empty-string') calls. 2018-09-17 01:22:55 +02:00
Eric Kohl 47714b25a9 [NETAPI32] Add more DFS stubs 2018-09-16 21:11:16 +02:00
Bișoc George 29603e7291 [MSCONFIG_NEW] Small Romanian translation update 2018-09-16 19:55:46 +02:00
Bișoc George 577d5347f1 [CHARMAP_NEW] Update the E-mail header string 2018-09-16 19:55:46 +02:00
Extravert-ir d0e29db1cb [FREELDR] Fix MSVC warnings C4146 (#863) 2018-09-16 16:14:07 +02:00
BieHDC 6458e12ffe [GITIGNORE] Ignore [boot|live|hybrid]cd_extras (#866)
Exclude [boot|live|hybrid]cd_extras from git as well since they are not part of the source code itself.
2018-09-16 16:05:15 +02:00
Pierre Schweitzer 8c5b0fbff3
[KERNEL32_VISTA] Make SleepConditionVariableSRW fail when it times out
This fixes a few newly added winetests.
2018-09-16 14:50:01 +02:00
Pierre Schweitzer 58853297dc
[KERNEL32_VISTA] Make SleepConditionVariableCS fail when it times out
This fixes a few newly added winetests.
2018-09-16 14:42:43 +02:00
Pierre Schweitzer d69a00e039
[KERNEL32_WINETEST] Enable ConditionVariable and SRW lock tests
If we cannot find the functions in kernel32, try to get them from
kernel32_vista. This will allow testing our own implementation, while
still failing in W2K3 (no implementation available).
2018-09-16 12:05:42 +02:00
Bernhard Feichtinger 9d1ee2400a [RAMDISK] Implement missing IOCTLs 2018-09-16 11:46:24 +02:00
Mark Jansen 12654d2852
[KERNEL32] Ensure the PebLock is always released in FlsFree 2018-09-15 17:56:03 +02:00
Mark Jansen b6e3cf3c03
[KERNEL32_APITEST] Test FLS locking & exception behavior. 2018-09-15 17:56:03 +02:00
Mark Jansen 06eb99edef
[NTDLL][KERNEL32] Implement FLS callbacks. 2018-09-15 17:56:03 +02:00
Mark Jansen f0f8f1c7d9
[KERNEL32_APITEST] Add test exposing FLS internals. 2018-09-15 17:55:57 +02:00
Eric Kohl e13ff1470e [DESK] Add MonitorClassInstaller 2018-09-15 14:11:04 +02:00
Pierre Schweitzer 71ac5e6c65
[SHELLBTRFS] Fix GCC build
CORE-15048
2018-09-15 10:54:00 +02:00