Commit graph

56655 commits

Author SHA1 Message Date
Pierre Schweitzer
05e2f0e9db [DISKPART]
Fix leak

CID #716329

svn path=/trunk/; revision=62624
2014-04-05 15:26:12 +00:00
Hermès Bélusca-Maïto
e9cd63fb67 [RTL]
Some fixes for RtlGetFullPathName_U(str):
- Start to polish RtlpCollapsePath (Work in progress)
- Correctly zero-out the path destination buffer

They fix the following tests:
* ntdll:RtlGetFullPathName_U (2 failures to full success)
* ntdll:RtlGetFullPathName_UstrEx (2 failures to full success)

svn path=/trunk/; revision=62623
2014-04-05 14:56:41 +00:00
Timo Kreuzer
9ad09cfd87 [PSEH3]
Simplify some code

svn path=/trunk/; revision=62622
2014-04-05 14:38:42 +00:00
Pierre Schweitzer
578a9174d9 [BASESRV]
Properly call RtlFillMemory in BaseSrvNLSInit. This fixes incomplete NlsUserInfo init

CID #1102265

svn path=/trunk/; revision=62621
2014-04-05 14:30:22 +00:00
Timo Kreuzer
2afcfa6dbd [PSEH2_TEST}
Use the tests with C++, too.

svn path=/trunk/; revision=62620
2014-04-05 14:24:16 +00:00
Pierre Schweitzer
34eddff2f1 [ACPI]
Disable PCH as it breaks build (when globally enabled)

svn path=/trunk/; revision=62619
2014-04-05 14:11:03 +00:00
Pierre Schweitzer
283ab16ed6 [RTL]
Properly check for total length in LdrpGetProcedureAddress().
It contains more than just a name.
Fixes a buffer overrun.

CID #716122

svn path=/trunk/; revision=62618
2014-04-05 13:13:01 +00:00
Pierre Schweitzer
9d713d990a [RAPPS]
Don't leak handle

CID #716310

svn path=/trunk/; revision=62617
2014-04-05 12:58:10 +00:00
Pierre Schweitzer
f71529c32e [RTL]
Prevent buffer overflow on copy: provide the correct copy size

CID #731655

svn path=/trunk/; revision=62616
2014-04-05 12:44:27 +00:00
Pierre Schweitzer
b929ccd22f [RTL]
--MagicValues;

svn path=/trunk/; revision=62615
2014-04-05 10:02:32 +00:00
Pierre Schweitzer
a98a284868 [EPSAPI]
Fix double free in PsaCaptureSystemModules()
CID #1106329

svn path=/trunk/; revision=62614
2014-04-05 09:17:21 +00:00
James Tabor
15f4004f9f [Win32k]
- Fix wine win.c test_CreateWindow line 5470, pass all those tests.

svn path=/trunk/; revision=62613
2014-04-05 05:06:48 +00:00
James Tabor
785a8b7ebe [Win32k]
- Notify FIXME HACK Alert! Are we setting parent to early?

svn path=/trunk/; revision=62612
2014-04-04 17:52:23 +00:00
James Tabor
6dfbda58e8 [User32]
- Add more to GetInsideRect NC.
- Sync port from wine with modifications.

svn path=/trunk/; revision=62611
2014-04-04 14:59:19 +00:00
James Tabor
82b5418f45 [User32]
- Patch by Piotr Caban : Make it possible to activate a window with parent and no WS_CHILD flag in WS_NCLBUTTONDOWN function.
- Sync port from wine with modifications and addons.

svn path=/trunk/; revision=62610
2014-04-04 14:49:22 +00:00
James Tabor
2fce3630ab [User32]
- Patch by Javier Cantero : Fix side effect in SubtractRect().
- Sync port from wine with modifications

svn path=/trunk/; revision=62609
2014-04-04 14:40:51 +00:00
Hermès Bélusca-Maïto
1f753ef84f [ACPICA][ACPI]
Finally...
- Specify that we use MUTEXes instead of binary semaphores,
- Change two interface names in our code: ACPI_DEVICE_ID_LIST --> ACPI_PNP_DEVICE_ID_LIST and acpi_device_id --> acpi_pnp_device_id (only those names were changed in ACPICA).
- Implement AcpiOsPhysicalTableOverride which doesn't any table override (same behaviour as AcpiOsTableOverride).
- Latest ACPICA versions introduce the AcpiOsWaitEventsComplete API, which is used to wait for all asynchronous events to complete. But we do nothing at the moment ("inspired" from the behaviour from http://ftp.netbsd.org/pub/NetBSD/NetBSD-current/src/sys/dev/acpi/acpica/OsdSchedule.c , but I'm sure ReactOS ACPI specialists know better than me whether or not it is judicious to do so !!!)
- Extend AcpiOsRead/WriteMemory to be able to read/write 64-bit values, as required by the ACPICA implementation.

Fix the build. Now, only warnings from our code (not ACPICA) need to be fixed.

Real HW testers, please retest your real HW with this revision (or above) !!

CORE-8044 #comment Everything updated in revisions 62604 to 62608.

svn path=/trunk/; revision=62608
2014-04-03 23:44:20 +00:00
Hermès Bélusca-Maïto
97ab12262b [ACPICA]
Addendum to revision 62606 : because of typedefs redefinitions (we, after, include acpi.h and co. together with DDK in other acpi bus drivers), we hackishly needed to disable them in actypes.h, and now we need to include ntddk *inside* acpi.h ...
Everything would be nice only if ACPICA would not have the "clever" (read: dumb) idea to define a ACPI_BIOS_ERROR macro, which is (you guessed it) already defined.... in the DDK via the standard bugcheck code macros.
So we introduce two hacks: the firs one right after the inclusion of ntddk.h *in* acpi.h to first undefine the macro (coming from bugcheck.h), *then*, we re-undefine it *after* the inclusion of acpi.h (in the precompiled header) so that drivers that need to use acpi (via the header) can after, include the ntddk.h ...

What a hack :DD

Part 2bis of our modifications to ACPICA code.
CORE-8044

svn path=/trunk/; revision=62607
2014-04-03 23:32:58 +00:00
Hermès Bélusca-Maïto
ba1329cf88 [ACPICA]
Disable redundant typedefs that we already got from the inclusion of ntddk.h from elsewhere (and it was done like that in our old modifications of ACPICA).
Personally I don't like this way to go, but for the moment just apply something that (seemed to) worked before...

Part 2 of our modifications to ACPICA code.
CORE-8044

svn path=/trunk/; revision=62606
2014-04-03 22:09:20 +00:00
Hermès Bélusca-Maïto
7ffce2077e [ACPICA]
Do not assume that, when compiling from Windows, we cannot use GCC. In fact we can, and this is what we did before...
Move asm-specific code to where it should belong.
I've checked that: MSVC_asm_code(old_acpica_version) == MSVC_asm_code(new_acpica_version), so that I took its GCC equivalent from our old version of ACPICA and placed it there.

Part 1 of our modifications to ACPICA code.
CORE-8044

svn path=/trunk/; revision=62605
2014-04-03 22:03:14 +00:00
Hermès Bélusca-Maïto
3661d0d700 [ACPI]
Update ACPICA library from 20110922 to 20140325.
Currently breaks build. Fixes are comming.
CORE-8044

svn path=/trunk/; revision=62604
2014-04-03 21:12:09 +00:00
Dmitry Gorbachev
9062d1b58a Improve config.cmake slightly.
svn path=/trunk/; revision=62599
2014-04-01 08:58:08 +00:00
Dmitry Gorbachev
98c3dfa408 [BUGCODES]
- Add an error message for Proprietary Software Execution Prevention 
feature supported by recent CPUs.
- TODO: Implement this feature in the kernel.

svn path=/trunk/; revision=62598
2014-04-01 08:57:58 +00:00
Hermès Bélusca-Maïto
7f4064a788 Resurrect MSVC 2008 builds.
ACHTUNG! ACHTUNG! Even if you can build ROS with MSVC 2008, you cannot boot it (see the below-mentioned JIRA report) ACHTUNG! ACHTUNG!
CORE-8023 #comment MSVC 2008 build resurrected in revision 62595.

svn path=/trunk/; revision=62595
2014-03-31 20:59:32 +00:00
Hermès Bélusca-Maïto
68f7270ce5 [HOST-TOOLS]
For host-tools, including stdint.h when using MSVC is not reliable, so use a tried-&-tested solution (see mkshelllink & geninf tools): include stdint.h if we don't use MSVC, otherwise define just what's needed.
Another solution would be to create a include/host/stdint.h which does this same job, and in the host-tools, include this file.
CORE-8023

svn path=/trunk/; revision=62594
2014-03-31 20:38:05 +00:00
Thomas Faber
059daa9d85 [ADVAPI32]
- Fix buffer handling in CredMarshalCredential/CredUnmarshalCredential. Fixes stack corruption during advapi32:cred
CORE-7242 #resolve

svn path=/trunk/; revision=62593
2014-03-31 20:11:32 +00:00
Hermès Bélusca-Maïto
e2359b3724 [CMLIB][MKHIVE]
Move some defines where they belong (they are used in mkhive because they are employed in cmlib functions, and cmlib itself uses them too).

svn path=/trunk/; revision=62592
2014-03-31 20:05:44 +00:00
Thomas Faber
b7737eacf1 [RTL]
- Fix buffer overrun in RtlNumberOfSetBits

svn path=/trunk/; revision=62591
2014-03-31 19:57:42 +00:00
Thomas Faber
ba3759fb6b [NTOS:KE]
- Verify valid IRQL in KeDelayExecutionThread, just like in KeWait*
- Return from KeDelayExecutionThread after yielding execution

svn path=/trunk/; revision=62590
2014-03-30 21:10:04 +00:00
Pierre Schweitzer
b6aa0990cd [TUNNELTEST]
Reshuffle the test a bit so that it clearly fails on ReactOS:
- Gather creation timestamp right after the first creation and always compare to it. This is to workaround the move = copy + delete hack from ReactOS which is resetting the timestamps (and thus making the test pass ;-)).
- Wait more than 20ms (1s). If Microsoft FastFAT has a creation resolution of 10ms, we don't. So it would hide the thing as well.

With such changes, the test still works on Windows, whereas it fails on ReactOS

CORE-7272 

svn path=/trunk/; revision=62589
2014-03-30 18:25:13 +00:00
Timo Kreuzer
f6d147a5e1 [W32KDLL]
Use new macro based syscall mechanism for w32kdll_xpsp2. Fix exports

svn path=/trunk/; revision=62588
2014-03-30 17:34:56 +00:00
Thomas Faber
5f0ac6952a [CRT]
- Use PeekConsoleInput in kbhit because the input buffer should not be affected. Patch by Roy Tam
CORE-8030 #resolve

svn path=/trunk/; revision=62587
2014-03-30 15:46:02 +00:00
Thomas Faber
7528e5d671 [VIDEOPRT]
- Add missing newlines to debug prints

svn path=/trunk/; revision=62586
2014-03-30 09:53:29 +00:00
Thomas Faber
a083c95ceb [NTOS]
- Try compiling before committing, Arch!

svn path=/trunk/; revision=62585
2014-03-30 09:44:02 +00:00
Thomas Faber
3548a3cacb [NTOS:IO]
- Fix some incredibly useless debug prints

svn path=/trunk/; revision=62584
2014-03-30 09:35:50 +00:00
Thomas Faber
ea28c6ea42 [PCI]
- Silence some noisy debug prints

svn path=/trunk/; revision=62583
2014-03-30 09:17:28 +00:00
Thomas Faber
2d721bca08 [USBEHCI]
- Fix some debug prints and some whitespace issues

svn path=/trunk/; revision=62582
2014-03-30 09:17:18 +00:00
Pierre Schweitzer
12268a1b66 [ROSTESTS]
Add notifications test application.
It is: http://msdn.microsoft.com/en-us/library/windows/desktop/aa365261%28v=vs.85%29.aspx
It properly works in ReactOS since r62446

CORE-2582

svn path=/trunk/; revision=62581
2014-03-29 21:12:17 +00:00
Eric Kohl
385b37aba7 [SYSSETUP]
Extend the maximum password length to 127 characters for unattended setup too.

CORE-7762 #comment Fixed it! Thanks a lot!

svn path=/trunk/; revision=62580
2014-03-29 20:39:50 +00:00
Pierre Schweitzer
3b44e882cb [ROSTESTS]
Add a usermode test application for tunnel cache.
It is based on MS article at: http://support.microsoft.com/?kbid=172190

Tested successfully on Windows 7 & NTFS. Feel free to test on w2k3 NTFS or FAT/FAT32.

svn path=/trunk/; revision=62579
2014-03-29 18:50:36 +00:00
Eric Kohl
414a438bc5 [SAMSRV]
Add a note for translators to keep the administrator account name string resources in syssetup.dll and samsrv.dll synchonized.

svn path=/trunk/; revision=62578
2014-03-29 17:28:47 +00:00
Eric Kohl
79ca3bfc7f [SYSSETUP]
- Store the administrator account name as the default user name.
- Extend the maximum password length to 127 characters.
CORE-7762 #resolve

svn path=/trunk/; revision=62577
2014-03-29 17:18:14 +00:00
Hermès Bélusca-Maïto
2101c5afd7 Addendum to rev 62573: simplify my story, thanks Amine ;)
svn path=/trunk/; revision=62576
2014-03-29 17:09:46 +00:00
Thomas Faber
fc714e32cf [COMP]
- Silence warnings

svn path=/trunk/; revision=62575
2014-03-29 14:59:13 +00:00
Hermès Bélusca-Maïto
ff83d33f52 Addendum to revision 62571: those SAL v2 annotations exist also in MSVC 2008 (but still not in MSVC <= 2005).
svn path=/trunk/; revision=62573
2014-03-28 02:43:29 +00:00
Hermès Bélusca-Maïto
6e64e3e58f [MSVC]
Turns C4163: "'identifier' : not available as an intrinsic function" into an error.

svn path=/trunk/; revision=62572
2014-03-28 01:35:32 +00:00
Hermès Bélusca-Maïto
a7116b25de [CMLIB][MKHIVE]
(For host tools compilation only)
Refine the #ifndefs, because SAL v2 annotations do not exist in MSVC < 2010.

svn path=/trunk/; revision=62571
2014-03-28 01:05:55 +00:00
Thomas Faber
0b12bc780b [COMCTL32][RAPPS]
- Mark Str* functions as private in comctl32, they should be imported from shlwapi instead
- Remove the associated hack in rapps
CORE-7786 #resolve

svn path=/trunk/; revision=62570
2014-03-26 20:15:54 +00:00
Thomas Faber
2cc0229ae2 [WINETESTS]
- Remove unnecessary use of allow_warnings
- Do not hide warnings that indicate actual problems in setuapi (non-Wine test, should move to apitests) and winmm (Wine bugs, fixed upstream)

svn path=/trunk/; revision=62569
2014-03-26 12:15:55 +00:00
Thomas Faber
9375945c22 [NTDLL_APITEST]
- Fix -Wformat warnings and enable -Wformat where possible

svn path=/trunk/; revision=62568
2014-03-26 12:07:25 +00:00