Commit graph

936 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto
7ee298bbfc
[SHELL32] In _SHExpandEnvironmentStrings(), fall back to SHExpandEnvironmentStringsForUserW() if the simplified code paths failed.
This allows the code to give a last chance for expanding the string.
And if it still fails, we bail out as expected and the caller will
take appropriate actions.

As a by-product, this commit (together with the previous one e2960914)
fixes the regression CORE-14981 (Quick-Launch bar couldn't be opened
in LiveCD).
2018-09-23 00:18:57 +02:00
Hermès Bélusca-Maïto
e29609147b
[SHELL32] In _SHGetUserShellFolderPath(), check the return value of _SHExpandEnvironmentStrings()
and bail out if it failed. That way we won't use and cache in the registry an invalid-expanded string.

CORE-14981
2018-09-23 00:16:06 +02:00
Hermès Bélusca-Maïto
41a5b11fcd
[SHELL32] Partially synchronize wine/shellpath.c with Wine.
- Adjust the code with respect to:
  "shell32: Re-add support for expanding ALLUSERSPROFILE for backward compatibility."
  4a6855a575c02aa1569aab8b2e96720fc02f3f26 (Alexandre Julliard)

- "shell32: Avoid infinite loop in _SHExpandEnvironmentStrings."
  ceea5bda14ecf4c8ce262fc7ab88df49e500bc38 (Alexandre Julliard)

- "shell32: Assume that system directory always contains a drive letter."
  54530bc4933ae1014c3697c95e22b8ca5a275bc4 (Alexandre Julliard)

- "shell32: Use ARRAY_SIZE macro."
  612a1941331485725952d34f3dcd5866fc318dc2 (Nikolay Sivov)

- "shell32: Fix a trace message."
  bb09bb5750d617047aa23635731519a2f9486159 (Nikolay Sivov)

- "shell32: Fix SHGetFolderPathAndSubDir() trace message."
  f75d5625966933562b974540a3f29dfcd720ad50 (Nikolay Sivov)

- "shell32: Pass correct buffer length to RegQueryValueExW()."
  0bfb97dcba29552b51d8609fcc6e7bbc04bb8320 (Nikolay Sivov)

- "shell32: Remove unused string (Clang)."
  8d50a8a246960749afba21eac117b4fcbbf2c79d (André Hentschel)

- "shell32: Use E_NOT_SUFFICIENT_BUFFER definition."
  730e744e3bd6b706612fe0f90a7efb2e600f114f (Nikolay Sivov)
2018-09-23 00:16:02 +02:00
Eric Kohl
de08785ade [SETUPAPI] SetupDiCreateDevRegKeyW / SetupDiOpenDevRegKey: Create or open the 'Device Parameters' subkey of the given devices enum key when we try to access its hardware key.
This creates the PortName value in the proper location for serial ports.
2018-09-22 14:43:43 +02:00
Abdulganiev Rafael
2a6aa7770e [BTHCI] Add a bluetooth icon (#871)
[BTHCI] Add a bluetooth icon
2018-09-21 23:42:27 +02:00
Eric Kohl
f8f83d4d4d [BTHCI] Add a bluetooth class installer stub.
Now we really need a tango-compatible bluetooth icon!
2018-09-20 17:53:08 +02:00
Eric Kohl
5e2fe08918 [WLNOTIFY] Disable the Logoff-Handler routine for the scheduler service.
The Logoff-Handler might try to notify the scheduler service which might already have been shut down. We need to fix the shutdown sequence, so that the service manager stops all running services.

Might fix CORE-14521.
2018-09-19 16:35:12 +02:00
Eric Kohl
76588be0d1 [ADVAPI32][SERVICES] Use the session key provided by SystemFunction028 to encrypt and decrypt the service passwords. 2018-09-19 12:30:33 +02:00
Eric Kohl
4114dcad46 [ADVAPI32] Implement SystemFunction028 to always return the default session key. 2018-09-19 00:20:11 +02:00
Eric Kohl
e5fcda922b [ADVAPI32][SERVICES] Pass encrypted passwords to the service manager.
- Encrypt passwords before passing them to the service manager. Right now, we are using a fixed encryption key. This will be fixed later.
- Replace the calls to ZeroMemory which are used to wipe the password buffers by calls to SecureZeroMemory.
2018-09-18 21:33:29 +02:00
Eric Kohl
da73c81259 [IDL][LSASRV] Improve the credentials interface a little and update the lsa server code accordingly. 2018-09-18 15:55:18 +02:00
Eric Kohl
6c0d9c01e2 [ADVAPI32] SystemFunction004 and SystemFunction005 must return the required output buffer size via out->Length when the buffer is too small. 2018-09-17 23:19:02 +02:00
Eric Kohl
5e2c4657ca [ADVAPI32][SERVICES] Add (dummy) password encryption/decryption functions to CreateServiceA/W and ChangeServiceConfigA/W in order to prepare to pass encrypted passwords to the service manager 2018-09-17 16:34:48 +02:00
Eric Kohl
47714b25a9 [NETAPI32] Add more DFS stubs 2018-09-16 21:11:16 +02:00
Pierre Schweitzer
8c5b0fbff3
[KERNEL32_VISTA] Make SleepConditionVariableSRW fail when it times out
This fixes a few newly added winetests.
2018-09-16 14:50:01 +02:00
Pierre Schweitzer
58853297dc
[KERNEL32_VISTA] Make SleepConditionVariableCS fail when it times out
This fixes a few newly added winetests.
2018-09-16 14:42:43 +02:00
Mark Jansen
12654d2852
[KERNEL32] Ensure the PebLock is always released in FlsFree 2018-09-15 17:56:03 +02:00
Mark Jansen
06eb99edef
[NTDLL][KERNEL32] Implement FLS callbacks. 2018-09-15 17:56:03 +02:00
Eric Kohl
e13ff1470e [DESK] Add MonitorClassInstaller 2018-09-15 14:11:04 +02:00
Pierre Schweitzer
71ac5e6c65
[SHELLBTRFS] Fix GCC build
CORE-15048
2018-09-15 10:54:00 +02:00
Thomas Faber
0f47f27829
[SHELLBTRFS] Add exports according to upstream .def file. CORE-15048 2018-09-15 09:43:31 +02:00
Pierre Schweitzer
f4da2bab03
[MPR] Import Wine commit: 93fb279f4f3e150eee329b02ca5fb0251d8a239d
Properly handle device-less connections.

CORE-15012
2018-09-14 22:34:02 +02:00
Stanislav Motylkov
8d6c519a95 [SYSDM.CPL] Fixup control positions after font metrics fix 2018-09-14 11:15:26 +02:00
Stanislav Motylkov
877dffa918 [DESK.CPL] Settings: Fixup control positions 2018-09-14 11:15:26 +02:00
Stanislav Motylkov
8df45999f2 [DESK.CPL] Screensaver: Fixup control positions 2018-09-14 11:15:26 +02:00
Stanislav Motylkov
36bebe7427 [DESK.CPL] Background: Fixup control positions after font metrics fix 2018-09-14 11:15:26 +02:00
Stanislav Motylkov
432788b59f [DESK.CPL] Appearance: Fixup control positions after font metrics fix
CORE-14274
2018-09-14 11:15:26 +02:00
Katayama Hirofumi MZ
31019e8c0c [TRANSLATION] Update Romanian translation (#851)
Translation from Stefan Fulea.
CORE-15023
2018-09-14 11:04:36 +02:00
Pierre Schweitzer
62f79fae93
[MPR] Import Wine commit: 0799550075654094a3bed080aac722b9bea01307
Implement WNetClearConnections().

CORE-15012
2018-09-14 08:08:57 +02:00
Mark Jansen
8642654a00
[KERNEL32] Do not embed binary data inside a string resource.
CORE-14948
2018-09-12 21:31:55 +02:00
Mark Jansen
25d143dd20
[DBGHELP] Prevent crashing on a malformed PE file.
CORE-15030
2018-09-12 21:30:49 +02:00
Eric Kohl
ee4ee2fc1d [NETAPI32] Remove the obsolete file group.c 2018-09-12 17:53:49 +02:00
Eric Kohl
221cdeafe2 [NETAPI32] Rename ENUM_CONTEXT to GROUP_ENUM_CONEXT and fix a use of the wrong type 2018-09-12 17:38:18 +02:00
Eric Kohl
4d9425d123 [NETAPI32] Implement NetGroupSetUsers 2018-09-12 17:11:52 +02:00
Eric Kohl
e0b5050089 [NETAPI32] Implement NetLogonGetTimeServiceParentDomain 2018-09-11 15:02:19 +02:00
Pierre Schweitzer
cf0112a6e6
[MPR] Implement WNetClearConnections()
This has been submitted upstream.

CORE-15012
2018-09-11 08:30:23 +02:00
Eric Kohl
74620c94d3 [NETAPI32] Implement NetGroupGetUsers 2018-09-10 22:05:49 +02:00
Baruch Rutman
ab5fdcc01f
[LPK] Make GetCharacterPlacement caret positions respect bidi. (#842)
- Try to make use of ScriptStringCPtoX when trying to fill the lpCaretPos struct member;
  if USP10 error happens fallback to the unreorder method.
- Remove now incorrect debug print.
2018-09-09 18:03:45 +02:00
Katayama Hirofumi MZ
a244e4f6dd [WIN32SS][COMCTL32] Fix button text Y positioning (#766)
Fixes the vertical position of button text.
CORE-14906
2018-09-09 17:37:37 +02:00
Eric Kohl
2d645f62fe [NETAPI32] Implement NetGroupAddUser and NetGroupDelUser 2018-09-09 17:35:18 +02:00
Eric Kohl
df0137a169 [NETAPI32] Implement NetGroupSetInfo 2018-09-09 13:39:01 +02:00
Eric Kohl
c48d09d19a [NETAPI32] Implement NetGroupAdd and NetGroupDel 2018-09-09 11:52:44 +02:00
Eric Kohl
a9da3c50be [NETAPI] Implement NetGroupGetInfo 2018-09-09 09:40:11 +02:00
Eric Kohl
033146ca23 [NETAPI] Implement NetGroupEnum 2018-09-08 20:55:13 +02:00
Eric Kohl
0e69bc3bce [SAMSRV] Fix SamrQueryInformationGroup
- Use the registry value AdminComment for admin comments instead of Description. Fix SamrSetInformationGroup as well.
- Add some TRACEs.
- Do not fail if the Members value does not exist.
2018-09-08 19:24:13 +02:00
Abdulganiev Rafael
25f4ed75a0 [CPL][DESK] Update monitor resource (#816)
[DESK.CPL] Update monitor resource
2018-09-07 08:43:36 +01:00
Pierre Schweitzer
000bbe074e
[LIBTIRPC] Fix CVE-2018-14622 by backporting its fix
CORE-15005
2018-09-05 22:06:30 +02:00
Eric Kohl
df053b7d16 [MSV1_0] LsaApLogonUser: Update the logon time/count and bad password time/count 2018-09-05 00:10:54 +02:00
Eric Kohl
97382dee46 [MSV1_0] Use the account expiration time and check account expiration on logon 2018-09-04 23:15:15 +02:00
Eric Kohl
e25cbeba2f [IDL] Implement parts of SamrSetInformationUser.UserInternal2Information 2018-09-04 22:42:49 +02:00