Commit graph

54268 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto
c268c87586 [KERNEL32]
- Add brackets around "case XXX:" so that I'm able to (un)fold regions of code when debugging and reading.
- Temporarily skip AppCompat functionality added by Alex, in order to "fix" (read: hack-fix) launch of .bat/.cmd files. Indeed, when .bat/.cmd files get started with the CreateProcess function, a call to NtCreateSection fails with status STATUS_INVALID_IMAGE_NOT_MZ, as expected (line 2952). But the new AppCompat code (lines 3028 and 3031-3033 and following, and 3114), executed whenever the status code from NtCreateSection is STATUS_SUCCESS or STATUS_INVALID_IMAGE_NOT_MZ or something else, overwrites the status code by other values, so that, after we return to the main code path (lines 3174 and following), the status code isn't STATUS_INVALID_IMAGE_NOT_MZ anymore but STATUS_SUCCESS or whatever, and then, we fail to run the .bat/.cmd file (that should be done at lines 3314-3316 and following).
To Alex_Ionescu: Have a look at this and fix it properly!!

svn path=/trunk/; revision=59855
2013-08-28 13:23:09 +00:00
Amine Khaldi
0a425e697c [CMAKE]
* Add the proper subsystem version when using a recent MSVC toolchain.

svn path=/trunk/; revision=59854
2013-08-28 12:32:09 +00:00
Amine Khaldi
94d5de635f [CRT]
* Annotate timeb_s.h.

svn path=/trunk/; revision=59853
2013-08-28 11:52:25 +00:00
Amine Khaldi
47a9785c7e [PSDK]
* Annotate imm.h.

svn path=/trunk/; revision=59852
2013-08-28 11:25:44 +00:00
Amine Khaldi
9aa6a42782 [SVCHOST]
* Fix a typo.

svn path=/trunk/; revision=59851
2013-08-28 11:08:28 +00:00
Hermès Bélusca-Maïto
13fa3680e5 [SVCHOST]
Fix debug prints.

svn path=/trunk/; revision=59850
2013-08-28 10:19:54 +00:00
Hermès Bélusca-Maïto
b96d93332b [KERNEL32]
Cut a very loong DPRINT1 into pieces, to workaround the length limitation of debug strings I get.

svn path=/trunk/; revision=59849
2013-08-28 10:08:41 +00:00
Alex Ionescu
08dac57791 [SVCHOST]: Use ReactOS Linux-build compatible cases in the header files, which are incompatible with Windows, and don't even matter on Windows, but hey, <3 Reactos + Linux.
svn path=/trunk/; revision=59848
2013-08-28 08:34:41 +00:00
Alex Ionescu
3acd542293 [SVCHOST]: Implement a Windows-compatible (5.2 SP1) SvcHost.exe process, which can load Windows services according to the information at http://www.geoffchappell.com/studies/windows/win32/services/svchost/index.htm, using the same callbacks and registry settings, including support for RPC over NPIPE, NetBIOS and COM, with correct handling of Security, Threading, Locking and Stop Callbacks. Tested with the current BITS and DHCP services, which still work (although they don't take advantage of the new functionality).
svn path=/trunk/; revision=59847
2013-08-28 08:32:27 +00:00
Alex Ionescu
bbf30d28f7 It wants an EOF?
svn path=/trunk/; revision=59846
2013-08-28 07:42:09 +00:00
Alex Ionescu
7e7db0b831 [UUID]: Add IID_IGlobalOptions and CLSID_GlobalOptions.
svn path=/trunk/; revision=59845
2013-08-28 07:39:58 +00:00
Alex Ionescu
a66ef80e54 [IDL]: Sync Objidl with http://www.winehq.org/pipermail/wine-patches/2012-November/120299.html, which adds IGlobalOptions.
svn path=/trunk/; revision=59844
2013-08-28 07:15:12 +00:00
Alex Ionescu
d78172a8cd [ADVAPI32/SERVICES]: Windows services (as per MSDN and testing) must always get at least one parameter -- the service name, in the argument vector. However, in ReactOS, unless optional custom parameters were sent (when starting a service), services got 0 parameters and a NULL argument vector. Since services on Windows know this is impossible, many dereference the vector without checking for NULL (including Windows Svchost.exe). Either way, it's bogus for us not ever sending the name as the first parameter. So I fixed ScBuildUnicodeArgsVector to always either pre-pend the service name (if the caller gave us some parameters already), or do use the name as the sole parameter (if the caller sent none). This now works as on Windows, and should greately help with 3rd party service compatibility.
***NOTE THAT I ONLY DID THIS FOR UNICODE. I DID NOT BOTHER TO FIX THE ANSI VERSION. ERIC KOHL, PLEASE REVIEW & FIX AS APPROPRIATE***

svn path=/trunk/; revision=59843
2013-08-28 05:04:36 +00:00
Eric Kohl
05f3a7e599 [ADVAPI32]
GetSidSubAuthority and GetSidSubAuthorityCount: Set last error code to ERROR_SUCCESS before calling the Rtl function.

svn path=/trunk/; revision=59842
2013-08-27 20:58:29 +00:00
Amine Khaldi
d317c64bae [COM_APITEST]
* Fix build.

svn path=/trunk/; revision=59841
2013-08-27 19:16:41 +00:00
Alex Ionescu
37fb2862f3 [PSDK]: Add a bunch of missing RTL_ macros.
svn path=/trunk/; revision=59840
2013-08-27 18:28:47 +00:00
Amine Khaldi
003dacb551 [KERNEL32]
* Check more parameters in MultiByteToWideChar() and WideCharToMultibyte(). By Marcus Boillat.
* Fixes 4 kernel32:codepage tests.
CORE-7411 #resolve #comment Committed in r59839 with formatting fixes. Thanks.

svn path=/trunk/; revision=59839
2013-08-26 21:36:16 +00:00
Alex Ionescu
08c5f648ed [SACDRV]: Implement DoCrashCommand.
[SACDRV]: Cleanups and fixes. You can now use "Shutdown", "crashdump" and "restart" in the !SAC and the commands work as expected.
[SACDRV]: Implement GetTListInfo and DoTlistCommand. PrintTListInfo is next to actually show the output.

svn path=/trunk/; revision=59838
2013-08-26 19:45:16 +00:00
Hermès Bélusca-Maïto
12796b070e [BOOTDATA]
[CMD]
The default command prompt is $p$g. But still keep the information line by setting a system environment variable "PROMPT" set to $i$p$g. Therefore, if you are tired of it, either remove the environement variable or redefine it to whatever you want. In a current command-line session, to restore the default command prompt, enter "prompt" without any other parameter.

svn path=/trunk/; revision=59837
2013-08-26 18:35:29 +00:00
Amine Khaldi
77377b7e9b [PSDK]
* Annotate winsplp.h.

svn path=/trunk/; revision=59836
2013-08-26 14:14:47 +00:00
Amine Khaldi
758ca8be1d [MMC]
* Fix MSVC build.

svn path=/trunk/; revision=59835
2013-08-26 14:10:59 +00:00
Hermès Bélusca-Maïto
fb760d1e93 [HELP]
Fix a typo.

svn path=/trunk/; revision=59834
2013-08-26 13:19:31 +00:00
Hermès Bélusca-Maïto
d19d23f8aa [CMD]
Remove the help resources moved to the help utility.
@ gigaherz (a.k.a. David Quintana): Don't worry! Your changes to fr-FR.rc were already moved to help.exe in the previous commit :D

svn path=/trunk/; revision=59833
2013-08-26 13:12:46 +00:00
Hermès Bélusca-Maïto
51e2a35e96 [CMD-HELP]
Add a help.exe utility to replace the old built-in command "help" in cmd.exe (i.e. do it the Win2k3 way).
This way, if somebody runs a personalized command-line environment which provides its own help command, one can use the personalized help command and not the standard one (e.g. the "help" command of RosBE).

Adapted by myself from a patch by Lee Schroeder.
CORE-5701 #resolve #comment Committed in revision 59832, thanks :) I use a trick to be able to compile the utility (use: ninja cmd_help) because doing "ninja help" has a signification in ninja (signaled by AmineKhaldi).

svn path=/trunk/; revision=59832
2013-08-26 12:45:34 +00:00
Alex Ionescu
fc47517694 [SACDRV]: SAC expects its memory allocations to be zeroed out.
[SACMSG]: Re-commit the .mc file with CRLF endings, this is essential for correct output.
[SACDRV]: Fix bug in VTUTF8ChannelAnsiDispatch (freeing stack memory with pool API).
[SACDRV]: Fix the way in which the cell buffer was being computed. This way works (tm) and is also much easier to read.
[SACDRV]: Fix bug in VTUTF8ChannelIRead (incorrect char vs byte sizing).
VT-UTF8 output and input works now in the !SAC channel. There's still some lurking bugs, however, such as when hitting the 24th row (probably an off-by-one memcpy).

svn path=/trunk/; revision=59831
2013-08-26 10:40:31 +00:00
Alex Ionescu
368ae5f2ec [SACDRV]: Implement VTUTF8ChannelProcessAttributes and VTUTF8ChannelOFlush, since these are also needed for output. Time to test for real now.
svn path=/trunk/; revision=59830
2013-08-26 08:12:52 +00:00
Alex Ionescu
30f0e5cc98 [SACDRV]: Switch !SAC back to VT-UTF8 and remove the previous hacks.
[SACDRV]: We need VTUTF8ChannelOEcho. Implement VTUTF8ChannelAnsiDispatch in anticipation.

svn path=/trunk/; revision=59829
2013-08-26 07:16:10 +00:00
Alex Ionescu
aa7497361a [SACDRV]: Implement VTUTF8ChannelOWrite2. Time to try out the !SAC on VT-UTF8 mode now.
svn path=/trunk/; revision=59828
2013-08-26 06:25:41 +00:00
Alex Ionescu
93883d01d6 [SACDRV]: Last WIP pass at VTUTF8ChannelConsumeEscapeSequence. Document the last few commands, and comment the entire parser so that it makes sense (within MS's definition of making sense). The erase/clear commands need cleanup/implementation, will take a pass at those later.
svn path=/trunk/; revision=59827
2013-08-25 23:44:13 +00:00
Alex Ionescu
02ed8a9b93 [SACDRV]: A few more ANSI commands. Also now that I grok ANSI, CursorX and CursorY were actually back/fore colors. Also define cursor flags/attributes that SAC supports (bold, inverted, blinking).
WANTED: The fact that the SAC developers cherry-picked *which* ANSI standard and VT standard they were going to follow, threw in ANSI.SYS compatibility, and then added a bunch of bugs, makes me wonder if real people use SAC on Windows...

svn path=/trunk/; revision=59826
2013-08-25 23:13:00 +00:00
Alex Ionescu
5027e45444 [SACDRV]: Start adding definitions/macros/etc based on my reading of ANSI standards (which MS-DOS ANSI.sys of course doesn't respect...). Still WIP. Sources (URLs) listed as appropriate.
svn path=/trunk/; revision=59825
2013-08-25 22:49:32 +00:00
Alex Ionescu
e84d7ea634 [SACDRV]: Implement VTUTF8ChannelScanForNumber.
[SACDRV]: Implement VTUTF8ChannelOEcho.
[SACDRV]: WIP-lement VTUTF8ChannelConsumeEscapeSequence. Have to do some reading up on ANSI to get this right.

svn path=/trunk/; revision=59824
2013-08-25 21:56:20 +00:00
Eric Kohl
abedd40dd8 [MMC]
- Fix all bugs that keep MMC from starting and terminating properly.
- Implement an MDI client window.
- Add menuitem "File/New" in order to create a new console window (MDI child).
- Add a "large" menu that is used when console windows are visible.

svn path=/trunk/; revision=59823
2013-08-25 21:43:46 +00:00
Sylvain Petreolle
360451830b [NEWDEV]
Fix controls positions in French.
Spotted by gigaherz.

svn path=/trunk/; revision=59822
2013-08-25 16:36:04 +00:00
Amine Khaldi
cb3adb53f5 [CRT]
* Annotate search_s.h.

svn path=/trunk/; revision=59821
2013-08-25 15:53:31 +00:00
Amine Khaldi
abce7035cb [PSDK]
* Add a missing inclusion in wincrypt.h.

svn path=/trunk/; revision=59820
2013-08-25 15:11:58 +00:00
Amine Khaldi
4728da4c06 [TRANSLATIONS]
* Turkish translation update and improvements by Erdem Ersoy.
CORE-7395

svn path=/trunk/; revision=59818
2013-08-25 13:10:32 +00:00
Amine Khaldi
2dc8971f36 [CRT]
* Annotate search.h.

svn path=/trunk/; revision=59817
2013-08-25 12:53:12 +00:00
Sylvain Petreolle
12e38303a3 [CMD]
Fix MSVC warning and Visual Studio 2013 build.
Path by David Quintana (gigaherz)


svn path=/trunk/; revision=59815
2013-08-24 22:07:27 +00:00
Eric Kohl
80c67bbde7 [USRMGR]
Implement the set password function.

svn path=/trunk/; revision=59813
2013-08-24 20:50:21 +00:00
Eric Kohl
4c96bd997e [SAMLIB]
NetUserSetInfo: Use the proper access rights to open the domain object.

svn path=/trunk/; revision=59812
2013-08-24 20:22:05 +00:00
Hermès Bélusca-Maïto
47f00dba5f [CONSRV]
Fix "Select All" functionality.

svn path=/trunk/; revision=59811
2013-08-24 17:44:19 +00:00
Amine Khaldi
04c2922307 [CRT]
* Apply a consistent annotation to wcstombs_s(), _splitpath_s() and _wsplitpath_s().

svn path=/trunk/; revision=59809
2013-08-24 11:13:44 +00:00
Amine Khaldi
75daa9b8e6 [CRT]
* Apply a consistent annotation to wcsncpy_s().

svn path=/trunk/; revision=59808
2013-08-24 11:05:35 +00:00
Hermès Bélusca-Maïto
a6315c0206 [CMD]
Fix some French conjugation.

svn path=/trunk/; revision=59807
2013-08-24 10:20:47 +00:00
Hermès Bélusca-Maïto
550e521dbc [BOOTDATA]
Add system.ini into C:\ReactOS.
Patch by Lee Schroeder.
CORE-7402 #resolve #comment Committed in revision 59806, thanks :)

svn path=/trunk/; revision=59806
2013-08-24 09:21:08 +00:00
Amine Khaldi
7a5d147c3f [PSDK]
* Add some missing definitions to winspool.h.

svn path=/trunk/; revision=59805
2013-08-24 00:37:30 +00:00
Amine Khaldi
1cc4d8885c [WINSPOOL.DRV]
* Correct the FindNextPrinterChangeNotification() stub.
[PSDK]
* Annotate winspool.h.

svn path=/trunk/; revision=59804
2013-08-23 22:58:29 +00:00
Hermès Bélusca-Maïto
0f375710aa [NTOSKRNL]
We aim at being compatible with Windows Server 2003... Do it better! Use the \GLOBAL?? dos-devices object directory instead of \??, as used in Windows NT and 2000 (which becomes per-session in Windows >= XP), but add a temporary hack (i.e. create a symbolic link \?? <---> \GLOBAL??) since we don't support yet Ob device mappings which are needed for this mapping, in particular.
As a side-effect, fix starting of DeviceTree v2.30 on ReactOS. Now it works correctly, as on Win2k3 :)

CORE-6572 #resolve #comment Finally fix loading of the objinfo driver, which failed at creating a symbolic link in \GLOBAL??\ for its device.

svn path=/trunk/; revision=59803
2013-08-23 21:18:46 +00:00
Hermès Bélusca-Maïto
7efba3bbfc [NTOSKRNL]
Don't hardcode L"\\Driver\\" but use the #define DRIVER_ROOT_NAME instead (2/2)

svn path=/trunk/; revision=59802
2013-08-23 21:03:37 +00:00