Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-07-04 11:44:33 +00:00
Code Issues Packages Projects Releases Wiki Activity
81590 commits 88 branches 274 tags 1 GiB
Commit graph

61 commits

Author SHA1 Message Date
Mark Jansen 6304059721
[SHELL32] Add extra information when encountering an unexpected pidl 
In addition, make pdump slightly less unusable
 2022-02-22 19:43:05 +01:00
Mark Jansen f6f5490ab4
[SHELL32] ShellExecute: Implement SEE_MASK_INVOKEIDLIST 
CORE-18035
Also simplify some error handling by using smart pointers
 2022-02-07 20:56:21 +01:00
Jesús Sanz del Rey 9c6f1958d9
[SHELL32] Implement Recycler Bin icons (#4221) 
CORE-3938

Icon extraction from the recycle bin was not possible due to the partial absence of IExtractIcon interface support.
Adding it inside the RecycleBinFile's QueryInterface private implementation, and then calling it from CRecycleBin, now allows retrieving and displaying the files' icons.
 2022-01-17 00:20:07 +01:00
Jesús Sanz del Rey 47f6745bcd
[SHELL32] Fix folders on recycle bin and adjust the column size (#4234) 
CORE-11000

- Now, folders can be sent to recycle bin (fixed a bug inside the implementation).
- Adjust column size of the RecycleBin virtual folder in details mode.
 2022-01-11 00:40:25 +01:00
Jesús Sanz del Rey dae6035b3b
[SHELL32] Fix recycle bin handle reference leaking (#4222) 
CORE-13730

There was a handle reference leak in the recycler bin and the bin wasn't removing the copied file after restoring it.
Close the handle were the memory leak was and move the file when restoring it.
 2022-01-11 00:20:23 +01:00
Hermès Bélusca-Maïto 83be315abf
[SHELL32] Use wide char string literals. 
Import parts of Wine commit b215536852dc5a132108db92c90a41c70b738e50
shell32: Use wide char string literals.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
 2022-01-09 22:39:29 +01:00
Katayama Hirofumi MZ f153b52dbb [SHELL32] Use IDI_SHELL_DOCUMENT for broken non-exe icons 
CORE-16287
 2021-12-24 02:47:31 +09:00
Scott Maday 83335d3a81
[SHELL32] Control panel context menu semantic bugfix (#4078) 2021-11-18 22:41:53 +01:00
Katayama Hirofumi MZ 9078e34f3c
[SHELL32] Don't smartass-renaming on LNK files (#4020) 
Renaming .LNK files had a bug that the selection won't include the extension-like filename part.
CORE-17807
 2021-10-11 13:33:43 +09:00
Mark Jansen 9276b3f1bf
[SHELL32] CFSFolder: Add fallback for failing shell extension 
CORE-17673
 2021-09-21 21:42:25 +02:00
Hermès Bélusca-Maïto 9393fc320e
[FORMATTING] Remove trailing whitespace. Addendum to 34593d93. 
Excluded: 3rd-party code (incl. wine) and most of the win32ss.
 2021-09-13 03:52:22 +02:00
Timo Kreuzer 5d8e834897 [REACTOS] Fix a number of MSVC warnings 2021-07-23 22:03:48 +02:00
Mark Jansen 9fcdc68182
[SHELL32] Include the folder path in logging 2021-05-22 16:34:54 +02:00
Kyle Katarn aad9bb8e8a
[TRANSLATION][SHELL32] Localization of "System Folder" in My Computer types (#3168) 
Co-authored-by: Adam Stachowicz <saibamenppl@gmail.com>
Co-authored-by: JoseSanchezz <67137372+JoseSanchezz@users.noreply.github.com>
 2020-09-13 23:16:19 +02:00
Joachim Henze 35dbdaaa0e [SHELL32] Fix regression CORE-12364 
The sorting in explorer broke by
SVN r73128 == git
24fcf531e7

Thanks to Doug Lyons for providing this patch.
I do intend to port it back into 0.4.14RC.
 2020-09-11 02:24:42 +02:00
Joachim Henze f363c27ab4 [SHELL32] Demote 2 noisy goodpath loggings to TRACE CORE-17216 
Those 2 did spam heavily when browsing folders with
many .zip files within. Mark Jansen confirmed that
this is good-path-logging and was just forgotten
to be disabled earlier.
 2020-08-23 00:35:02 +02:00
Mark Jansen 679c95597c
[SHELL32] Fix sorting on size for big files 
CORE-17205
 2020-08-17 18:17:24 +02:00
Katayama Hirofumi MZ 1d1bb53321
[SHELL32] Fix regression #2703 CORE-17041 (trial) (#3046) 
CORE-17041
 2020-08-16 11:16:44 +09:00
Mark Jansen 83a9f71690
[SHELL32] Allow creation of an empty CFileSysEnum 
CORE-16908
 2020-05-19 20:35:52 +02:00
Mark Jansen f379a29606
[SHELL32] Properly enumerate virtual shell folders (on files) as fake folders 
CORE-16908
 2020-05-17 17:09:04 +02:00
Mark Jansen b1003ae909
[SHELL32] Update CFileSysEnum to be maintaineable 
CORE-16908
 2020-05-17 17:09:04 +02:00
Katayama Hirofumi MZ 62e59652a0
[SHELL32] Don't hardcode C: drive again (#2777) 
- Avoid buffer overrun.
- Don't hardcode C: drive.
CORE-13235
 2020-05-15 16:36:13 +09:00
Katayama Hirofumi MZ 711f631849
[SHELL32] Don't hardcode C: drive (#2768) 
CORE-13235
 2020-05-11 11:43:07 +09:00
Charles Ambrye e978ec6125
[SHELL32] Return ERROR_INVALID_DRIVE if the drive type is unknown or there is no volume mounted (#2703) 
Return ERROR_INVALID_DRIVE if the drive is either unknown or unmounted.
 2020-05-09 21:54:15 +09:00
Katayama Hirofumi MZ 1f3cb13fb9
[SHELL32] Distinguish floppy and removable drives (#2645) 
Distinguish floppy drive and non-floppy removable drive in icon and description. CORE-10221
 2020-05-06 00:35:01 +09:00
Ioannis Adamopoulos 0d077c3068 [SHELL32] CDesktopFolder::GetUIObjectOf: fix crash when requested to create a IID_IContextMenu for 0 items. 
* Tests show that we should return a valid object even in this case.
 2020-04-20 17:37:03 +03:00
Mark Jansen d2b91deb33 [SHELL32] CMyDocsFolder: Ensure the object can be used without calling Initialize 2020-04-20 17:36:44 +03:00
Katayama Hirofumi MZ bc1519dd87
Shell Folders: Reject invalid characters (#2328) 
Reject invalid input filename characters by using shell32!SHLimitInputEdit function and IItemNameLimits interface. Improve SHLimitInputEdit to sanitize paste.
CORE-11701
 2020-02-12 09:18:24 +09:00
Katayama Hirofumi MZ 2fad488a85
[SHELL32] Add 'm_' prefix to CFSFolder members (#2129) 
CORE-7585
 2019-12-05 05:35:25 +09:00
Katayama Hirofumi MZ 5734570a15
[BOOT][SHELL32][INCLUDE] Support 'SuperHidden' files (#2102) 
PR #2101 shows desktop.ini files on Desktop. I want to hide them.
- Add "ShowSuperHidden" setting to Explorer.
- Add SHCONTF_INCLUDESUPERHIDDEN flag.
- Support SHCONTF_INCLUDESUPERHIDDEN in Explorer.
CORE-10045
 2019-11-29 15:14:18 +09:00
Katayama Hirofumi MZ cfdbccf937
[SHELL32] Follow-up of #2076 (#2091) 
Fix EXE and SCR file icons. CORE-16533
 2019-11-26 21:45:58 +09:00
Katayama Hirofumi MZ 399854ce31
[SHELL32] Set default exe icon (#2076) 
The default icon of an exe file was empty if no icon available from exe.
CORE-10480
 2019-11-24 19:26:32 +09:00
Serge Gautherie 0f92924a99 [REACTOS] Use explicit StringCb*W() (#2069) 2019-11-21 00:47:06 +01:00
Katayama Hirofumi MZ aedba8441a
[SHELL32] Improve UI of drive formatting (#2048) 
- Add stub window (StubWindow32) to the drive formatting dialog to avoid locked.
- Separate the thread of drive formatting.
- Move CStubWindow32 codes.
CORE-12756
 2019-11-20 10:00:26 +09:00
Mark Jansen c31327114b
[SDK][SHELL32] Augment the internally used IDataObject with some extra formats 
This is needed because our code seems to use CF_HDROP a lot, instead of HIDA...
 2019-10-20 17:10:12 +02:00
Mark Jansen 5d54b65ceb
[SHELL32] Add support for custom View objects defined with UICLSID 
CORE-16271
 2019-10-19 18:42:15 +02:00
Thomas Faber a66bee2837
[SHELLFOLDERS] Gracefully handle NULL pidl in CDrivesFolder::BindToObject. CORE-16403 
Fixes one of many crashes in shell32_winetest:shlfolder.
 2019-09-29 12:42:26 +02:00
Thomas Faber b2992e7a5e
[SHELL] IShellExtInit::Initialize uses PCIDLIST_ABSOLUTE. CORE-16385 2019-09-29 12:09:02 +02:00
Thomas Faber 6b0d2c2a2c
[SHELL] Fix more IPersistFolder::Initialize prototypes. CORE-16385 
Addendum to c2b476bd77.
 2019-09-29 12:07:43 +02:00
Thomas Faber c2b476bd77
[SHELL] IPersistFolder::Initialize takes a PCIDLIST_ABSOLUTE. CORE-16385 2019-09-22 16:19:11 +02:00
Thomas Faber b90c24d640
[SHELL] IPersistFolder2::GetCurFolder takes a PIDLIST_ABSOLUTE*. CORE-16385 2019-09-22 16:19:09 +02:00
Serge Gautherie cb77f1701f [SHELL32][STOBJECT] Enforce ShellExecuteW(..., file, parameters, ...) 
CORE-16299
 2019-08-19 13:01:08 +02:00
Katayama Hirofumi MZ 944aba1fcc
[SHELL32] Fix Desktop Properties menu item action (#1833) 
1. Right Click the Desktop.
2. Choose "Properties" menu item.
3. "Properties for Display" dialog must be shown.

The parameters of ShellExecuteW were wrong. The execution parameters must be separated from the file parameter.
CORE-16299
 2019-08-15 23:10:06 +09:00
Hermès Bélusca-Maïto 8a30801516
[SHELL32] Recycle-Bin: Minor code enhancements. 
- Use _countof() and ZeroMemory().
- Fix case of 'BitBucket' registry key (Windows-compatible).
- Simplify code.
- Minor code formatting.
 2019-07-07 17:56:51 +02:00
Katayama Hirofumi MZ d04b4e65d6
[SHELL32] Implement Explorer background image (Retrial of #801) (#1463) 
IconArea_Image, IconArea_Text and IconArea_TextBackground values in desktop.ini in a folder will be supported. It denies network paths. CORE-5516
 2019-04-05 07:59:35 +09:00
Timo Kreuzer 52ea7d39db [SHELL32] Fix 64 bit issues 2018-08-04 19:19:34 +02:00
Katayama Hirofumi MZ 55469633cf [SHELL32] Add 'Properties' menu item in My Computer (#647) 
- Add a Shell_DefaultContextMenuCallBack() helper function.
- Implement the IContextMenuCB interface in CDrivesFolder.
CORE-12509
 2018-07-08 17:01:12 +02:00
Katayama Hirofumi MZ c74bd5d662 [SHELL32] Enable custom CD/DVD icons (#639) 
Properly show the custom icon specified in "autorun.inf" file in CDs/DVDs.
CORE-14766
 2018-06-27 23:06:54 +02:00
Russell Johnson 6a683dc6d8 [SHELL32] Fixed TRASH_CanTrashFile() sending the wrong path string to GetVolumeInformationW() (#635) 
Function TRASH_CanTrashFile() would always fail because GetVolumeInformationW() requires only the base root path. The path (stored in buffer wszRootPathName) was not being stripped correctly.

CORE-12340
 2018-06-24 20:29:57 +02:00
Katayama Hirofumi MZ 1829f5fed7 [SHELL32] Fix desktop.ini folder icon again (retrial of #595) (#632) 
#595 failed at non-Desktop folder. We should use ILGetDisplayNameExW instead of SHGetPathFromLDList to get path from psf and pidl.
CORE-9196
 2018-06-24 19:59:03 +02:00