Hermès Bélusca-Maïto
9f59e28a23
[WMI]: Gather all the user-mode components of WMI inside base/wmi/, as part of the ReactOS source code tree restructure. This gives an idea how this can be done for other ReactOS components.
...
CORE-9111
svn path=/trunk/; revision=73869
2017-02-20 23:28:09 +00:00
Hermès Bélusca-Maïto
5ccb049790
[SECUR32]: As an interim step towards a proper NTLM implementation that is done by Samuel Serapion, I temporarily commit Wine's NTLM code layer around Samba's "ntlm_auth" utility. In addition I add the kerberos & negotiate stubs too.
...
This is not a problem on Wine, because they run on Linux distributions, most of which have Samba available. But this is not the case on Windows / ReactOS, so few adaptations were needed: in the dispatcher.c code, the fork_helper function was partially rewritten around CreateProcess to start the ntlm_auth utility (I try to use maximally the CRT to not have to rewrite other functions). This works great.
But then, to make this NTLM layer working on ReactOS, one has to find a Windows build of Samba. Here is one: http://smithii.com/samba . This is a Samba 3.0.23c build. You need to follow *exactly* the manual installation steps to make it work (actually, everything up to "Step 6" included, i.e. running smbsetup.cmd). This means in particular to copy Samba into C:\Program Files\samba, as this path is also hardcoded into the executables.
As the Wine's NTLM layer expects Samba 3.0.25+, I manually downgraded the expected version, which appears to still work nice for the needs of Office 2010 installation.
You can now play with it and try to install Office 2010.
CORE-12601 #comment Wine's NTLM layer committed in r73868 as an interim step towards a proper implementation.
CORE-12279
svn path=/trunk/; revision=73868
2017-02-20 22:28:07 +00:00
Hermès Bélusca-Maïto
08a509daee
[MOFCOMP]: Add the MOF compiler stub from Wine, which allows fixing the very last step in the installation of Office 2010.
...
CORE-12811 #resolve
CORE-12279
svn path=/trunk/; revision=73867
2017-02-20 20:47:42 +00:00
Giannis Adamopoulos
f4c6543a49
[SHLWAPI]: Stub SHPropertyBag_WriteLONG and SHPropertyBag_WriteStr. Patch by Jared Smudde. CORE-12805
...
svn path=/trunk/; revision=73866
2017-02-20 20:18:10 +00:00
Giannis Adamopoulos
9abeb0d9b0
[SHELL32] -Cleanup CFSFolder::_LoadDynamicDropTargetHandlerForKey. Inspired by patch by Victor Martinez Calvo. CORE-12799. CID 1401249
...
svn path=/trunk/; revision=73865
2017-02-20 20:13:22 +00:00
Giannis Adamopoulos
7b0de0e982
[MSGINA] -Make ShellIsFriendlyUIActive export a non fatal stub. CORE-12805
...
svn path=/trunk/; revision=73864
2017-02-20 19:51:12 +00:00
Thomas Faber
837d7e9292
[MSWSOCK]
...
- Eliminate dead code in NSP_LookupServiceNextW. Patch by Víctor Martínez Calvo. CID 1400942
CORE-12806 #resolve
svn path=/trunk/; revision=73863
2017-02-20 19:32:12 +00:00
Thomas Faber
ea43e3d3dc
[USER32][UXTHEME]
...
- Make API hooks type-safe. Fixes stack pointer corruption when calling ThemeGetScrollInfo. Powered by /RTC1
svn path=/trunk/; revision=73862
2017-02-20 17:31:50 +00:00
Thomas Faber
2475975c7d
[WS2_32]
...
- Re-apply null termination fix in GetProtoGetNextEnt, which was lost in ws2_32_new work. CID 716700
CORE-11218
svn path=/trunk/; revision=73861
2017-02-20 16:33:44 +00:00
Thomas Faber
e2e12caf2a
[BROWSEUI]
...
- Correctly pass the buffer size to RegQueryValueW in CAutoComplete::Init. Patch by Víctor Martínez Calvo. CID 1401255
CORE-12795 #resolve
svn path=/trunk/; revision=73860
2017-02-20 16:07:05 +00:00
Hermès Bélusca-Maïto
5da9304c6d
[FREELDR]: Update the FreeLdr's startup notes.
...
svn path=/trunk/; revision=73859
2017-02-20 15:45:01 +00:00
Kamil Hornicek
dba6b1c35c
[EVENTLOG]
...
- Silence some debug prints. This commit bears the "Hermès' seal of approval".
svn path=/trunk/; revision=73858
2017-02-20 14:45:03 +00:00
Thomas Faber
6cea30d6fe
[WINPRINT]
...
- Avoid uninitialized hPrintMonitor in PrintRawJob failure case. Patch by Víctor Martínez Calvo
CORE-12792 #resolve
svn path=/trunk/; revision=73857
2017-02-20 12:00:13 +00:00
Thomas Faber
d920d6c30a
[KS]
...
- Avoid leaking AllocatorFraming in KsCreateDefaultAllocatorEx. Patch by Sebastian Gasiorek
CORE-12797 #resolve
svn path=/trunk/; revision=73856
2017-02-20 11:35:24 +00:00
Kamil Hornicek
ca4c2640e7
[WIN32K]
...
- Don't try to delete the pattern bitmap in UserInitialize.
- Set the correct owner before deleting the update region in co_UserFreeWindow.
- Fixes some "Trying to delete global object" debug prints.
svn path=/trunk/; revision=73855
2017-02-20 10:10:37 +00:00
Giannis Adamopoulos
ef483f95f7
[blackshade.msstyles] -Add a skeleton for a theme based on a mockup by David Quintana
...
svn path=/trunk/; revision=73854
2017-02-19 20:40:45 +00:00
Eric Kohl
b96144bbbd
[COMCTL32]
...
Update a tool buttons tooltip rectangle when the button gets hidden.
Patch will be sent upstream!
CORE-12667 #resolve
svn path=/trunk/; revision=73853
2017-02-19 20:39:11 +00:00
Eric Kohl
5b17f6949b
[DEVMGR]
...
- NEVER EVER use single line if statements!!!!
- Fix indentation and coding style.
svn path=/trunk/; revision=73852
2017-02-19 19:40:04 +00:00
Eric Kohl
bb85fef52f
[DEVMGR]
...
Hide "HTREE\ROOT\0" from the device tree.
CORE-12670 #resolve #comment Thanks a lot!
svn path=/trunk/; revision=73851
2017-02-19 19:13:41 +00:00
Eric Kohl
dd588d8bb2
[DEVMGR]
...
Select a treeview item on a right click.
svn path=/trunk/; revision=73850
2017-02-19 18:31:52 +00:00
Thomas Faber
f78f7b3f31
[MSAFD][WS2_32]
...
- Properly return error codes from WSPConnect
CORE-12787 #resolve
svn path=/trunk/; revision=73849
2017-02-19 17:50:34 +00:00
Pierre Schweitzer
3499311e18
[EVENTVWR]
...
Don't attempt to free random address
CID 1401231
svn path=/trunk/; revision=73848
2017-02-19 17:24:13 +00:00
Giannis Adamopoulos
3df13bc41a
[UXTHEME] Fix the conversion from color id to theme metric and don't pass the metric id to GetSysColor. CORE-11086
...
svn path=/trunk/; revision=73847
2017-02-19 16:32:44 +00:00
Eric Kohl
27c1e20f13
[ACPI]
...
Generate a proper device id string for processor devices.
svn path=/trunk/; revision=73846
2017-02-19 15:13:49 +00:00
Pierre Schweitzer
7fb841c839
[SHELL32]
...
For the input string, WideCharToMultiByte takes a char count and not a buffer size.
CID 1401096, 1401088
svn path=/trunk/; revision=73845
2017-02-19 13:22:02 +00:00
Pierre Schweitzer
e78b6c5179
[SHELL32]
...
Don't attempt to dereference a pointer after having freed it
CID 1401297
svn path=/trunk/; revision=73844
2017-02-19 13:00:12 +00:00
Pierre Schweitzer
23733b7867
[WS2_32]
...
Remove duplicated if
CID 1400935
svn path=/trunk/; revision=73843
2017-02-19 12:52:14 +00:00
Pierre Schweitzer
f772b72e3e
[DNSAPI]
...
Properly check for domain name being set
CID 1401070
svn path=/trunk/; revision=73842
2017-02-19 12:42:08 +00:00
Thomas Faber
e4bf71987b
[WSHTCPIP]
...
- Fix incorrect sizeof in SHIoctl_GetInterfaceList. CID 1401188
svn path=/trunk/; revision=73841
2017-02-19 12:21:06 +00:00
Thomas Faber
8b8c1c7e5a
[WS2_32]
...
- Fix ridiculous over-casting
svn path=/trunk/; revision=73840
2017-02-19 12:05:48 +00:00
Thomas Faber
c60757b725
[WS2_32]
...
- Fix wrong ServLength in getnameinfo, again, since it got lost in the ws2_32_new work. CID 716150
CORE-11214
svn path=/trunk/; revision=73839
2017-02-19 11:44:18 +00:00
Giannis Adamopoulos
64c9bc0eba
[UXTHEME] -Set cbSize field of WINDOWINFO before calling GetWindowInfo. CORE-12776
...
svn path=/trunk/; revision=73838
2017-02-19 11:41:23 +00:00
Pierre Schweitzer
c7a2132d63
[DNSAPI]
...
Properly check for domain name being set
CID 1401080
svn path=/trunk/; revision=73837
2017-02-19 11:34:00 +00:00
Pierre Schweitzer
3a8d6379b1
[FASTFAT]
...
Avoid uninit variable usage.
CID 1401257, 1401259
svn path=/trunk/; revision=73836
2017-02-19 11:22:21 +00:00
Thomas Faber
0ba77df60d
[LOCALMON]
...
- Avoid a potential double free in InitializePrintMonitor2. CID 1401299
- Avoid a use after free in LocalmonClosePort. CID 1401298
svn path=/trunk/; revision=73835
2017-02-19 10:31:37 +00:00
Giannis Adamopoulos
cf3310e4e9
[UXTHEME] -The code to draw the classic style borders was copied from win32k, so imitate what it does and restore two bits that got removed in the copy. CORE-9667
...
svn path=/trunk/; revision=73834
2017-02-19 10:23:26 +00:00
Giannis Adamopoulos
8e371f8e7f
[SHELL32] -Try to fix themes when opening the control panel applet from the control panel.
...
svn path=/trunk/; revision=73833
2017-02-19 09:10:03 +00:00
Mark Jansen
099a790594
[KS] Cleanup in the failure path of KsCreateDefaultClock. Patch by Sebastian Gasiorek. CID 1322124 CORE-12784 #resolve #comment Thanks!
...
svn path=/trunk/; revision=73832
2017-02-18 22:54:31 +00:00
Pierre Schweitzer
590c4dcc8c
[FASTFAT]
...
Get rid of the ENTRY_DELETED2, ENTRY_VOLUME2 and ENTRY_END2 macros.
svn path=/trunk/; revision=73831
2017-02-18 21:37:56 +00:00
Pierre Schweitzer
1dc27a26be
[FASTFAT]
...
Modify ReadVolumeLabel() so that it is able to read the volume label, even without using the VCB, the root FCB, Cc, the universe.
This is important, because in case of device verifying, you cannot rely on these elements anylonger, but you need to read the label.
A readme has been attached to the function, to indicate how to call it (I wish I could have put more asserts!). It's ugly, I know.
This allows fixing a FIXME in VfatVerify(): we can also check the volume label for FATX volumes.
The FIXME comment was misleading: MS FastFAT doesn't make any checksum or whatever of FAT root. Let's not do it.
svn path=/trunk/; revision=73830
2017-02-18 21:24:31 +00:00
Pierre Schweitzer
9c5c0b479a
[FASTFAT]
...
Move ReadVolumeLabel() to fsctl.c close to functions that need it
svn path=/trunk/; revision=73829
2017-02-18 18:35:48 +00:00
Giannis Adamopoulos
9a213745ca
[DESK.CPL] -Apparently the second parameter of ApplyTheme is not a string. One case is that it is not a pointer and another case that it is a pointer to a struct. What I'm sure of is that as it is now the position of the string in the binary affects the behavior of ApplyTheme. Thankfully 0 works great on windows.
...
svn path=/trunk/; revision=73828
2017-02-18 18:14:32 +00:00
Thomas Faber
e4b71d31f9
[KMTESTS:MM]
...
- Add some stricter checks and improved error handling in NtCreateSection_user
svn path=/trunk/; revision=73827
2017-02-18 14:22:44 +00:00
Thomas Faber
8056edf828
[USBSTOR]
...
- Fix a broken assert (yes, calling NTOHL is wrong, ContiguousLogicBlocksByte0 is the MSB). CID 701077
svn path=/trunk/; revision=73826
2017-02-18 11:47:40 +00:00
Mark Jansen
29631b02e2
[GDI32_APITEST] Add tests for GetFontResourceInfoW. Patch by Katayama Hirofumi MZ. CORE-6621
...
svn path=/trunk/; revision=73825
2017-02-18 11:25:31 +00:00
Thomas Faber
5d76039958
[PSDK]
...
- Fix KsFilterFactoryGetDevice
CORE-11794
svn path=/trunk/; revision=73824
2017-02-18 09:30:59 +00:00
Kamil Hornicek
67e4aa500e
[SHELL32]
...
- Make the "Open with" dialog start in Program Files as is done in Windows (doesn't really changes anything because comdlg32 doesn't expand environment variables).
svn path=/trunk/; revision=73823
2017-02-17 23:39:39 +00:00
Pierre Schweitzer
1f58ae3a5d
[FASTFAT]
...
Generalize the usage of functions pointers for FatX vs Fat specific code (direntry).
This should also help speeding up FastFAT.
svn path=/trunk/; revision=73822
2017-02-17 22:25:03 +00:00
Pierre Schweitzer
41f23cace3
[FASTFAT]
...
In the FCB, get rid of the FCB_IS_FATX_ENTRY flag. It makes no sense to have it on each and every file as the VCB already has such flag
svn path=/trunk/; revision=73821
2017-02-17 21:24:12 +00:00
Pierre Schweitzer
36bd380f3a
[FASTFAT]
...
Fix a typo brought in r73819
svn path=/trunk/; revision=73820
2017-02-17 18:06:38 +00:00