Commit graph

54547 commits

Author SHA1 Message Date
Alex Ionescu
b483aad5f9 [NTOSKRNL]: Make MiCreateImageSection return STATUS_SUCCESS, not some fucked-up ROS-specific status code.
[NTOSKRNL]: Make MmCreateSection do the correct access checks and parameter checks, just like ARM3 does. For example, asking for PAGE_EXECUTE on a non-image file no longer requests SYNCHRONIZE and FILE_READ_DATA...it asks... FILE_EXECUTE. Cause you know... that's what the caller..wants. Anyway, this, among other things, fixes LdrValidateImageChecksum (and those annoying errors 0xC0000022 in the logs). SMSS is now checking the checksums of Known DLLs just like before (in Win7 they stopped doing this to improve boot performance, lol). It also makes Windows' SMSS happy.

svn path=/trunk/; revision=60055
2013-09-12 06:01:52 +00:00
James Tabor
558e78421b Attempt to fix CORE-6024
svn path=/trunk/; revision=60054
2013-09-12 02:26:36 +00:00
Hermès Bélusca-Maïto
e1e93ee7dd Fix other _SEH2_YIELD() issues, spotted for most of them by Pigglesworth, the other by myself.
I'm wondering how much remaining ones are in our code. Only the Lord knows...

svn path=/trunk/; revision=60053
2013-09-12 00:41:24 +00:00
Hermès Bélusca-Maïto
7af0cfc398 [NPFS_NEW]
Use _SEH2_YIELD when exiting from a _SEH2 block via a return or a goto (otherwise --> bug in the stack).
This limitation will be removed in SEH3, but it's not used at the moment.

svn path=/trunk/; revision=60052
2013-09-12 00:16:42 +00:00
Hermès Bélusca-Maïto
479489298b [NPFS_NEW]
Don't hardcode the first parameter of the bugchecks. Instead, I introduce a NpBugCheck macro and file identifiers
(their names conform to the existing name convention of the driver) so that, when bugchecking, we report as the
first parameter of the NPFS_FILE_SYSTEM bugcheck the file ID (in the high word) and the line (in the low word)
where the bugcheck was emitted.
See the MSDN article "Bug Check 0x25: NPFS_FILE_SYSTEM" - http://msdn.microsoft.com/en-us/library/windows/hardware/ff557436(v=vs.85).aspx
for more information.

Inspired from the existing ext2 driver.

Should be done for the other filesystems (FAT, NTFS, CDFS, Redirector, Mailslot, etc...).

svn path=/trunk/; revision=60051
2013-09-12 00:05:54 +00:00
Thomas Faber
9a9573505b [KERNEL32]
- Fix access rights when using CreateFile with FILE_FLAG_DELETE_ON_CLOSE

svn path=/trunk/; revision=60048
2013-09-11 23:31:11 +00:00
Hermès Bélusca-Maïto
a9b62ec084 [NPFS_NEW]: Add file header info.
svn path=/trunk/; revision=60047
2013-09-11 23:19:20 +00:00
Amine Khaldi
e7ced8199e [NTOSKRNL]
* Fix a copy pasted typo.

svn path=/trunk/; revision=60046
2013-09-11 22:09:41 +00:00
Amine Khaldi
a1dd5cf574 [NTOSKRNL]
* Break down the checks as suggested by Alex. Brought to you by David Quintana.

svn path=/trunk/; revision=60045
2013-09-11 21:50:15 +00:00
Thomas Faber
eb435bcc01 [NTOS:IO]
- Fix pool corruption resulting form a combination of r60038 and dubious SEH programming patterns

svn path=/trunk/; revision=60044
2013-09-11 21:23:23 +00:00
Amine Khaldi
c433d59c31 [NTOSKRNL]
* Silence some debug prints.

svn path=/trunk/; revision=60043
2013-09-11 19:59:59 +00:00
Alex Ionescu
29cacf4e53 [NPFS-NEW]: ntdll_winetest pipe : 107 tests executed (0 marked as todo, 0 failures), 0 skipped.
svn path=/trunk/; revision=60042
2013-09-11 19:36:51 +00:00
Thomas Faber
f5b3510fa4 [CMAKE]
- Improve MSVC warning settings

svn path=/trunk/; revision=60041
2013-09-11 19:25:48 +00:00
Hermès Bélusca-Maïto
7ebaa360b9 [SAC]: Don't return things from a VOID function (MSVC_warning--;)
svn path=/trunk/; revision=60040
2013-09-11 19:23:20 +00:00
Thomas Faber
08aa7a2432 [SPEC2DEF]
- Allow C++ redirects aka fix MSVC build

svn path=/trunk/; revision=60039
2013-09-11 19:19:11 +00:00
Alex Ionescu
e4b198bc97 [NTOSKRNL]: Fix a literal metric fuckton of missing parameter checks in IoCreateFile. I know for a fact this fixes two ntdll pipe tests, it probably fixes a bunch of other tests too.
[NTOSKRNL]: Fix OPEN_PACKET definition. Also, allocate it from the pool in IoCreateFile, instead of the stack (Windows does too).
[NTOSKRNL]: IoCreateFile should only be setting IO_STATUS_BLOCK Information/Status if EA Buffer validation *Fails*, not if it succeeds!

svn path=/trunk/; revision=60038
2013-09-11 18:50:28 +00:00
Thomas Faber
14fc5d4748 [FRAMEDYN]
- Fix MSVC build
- Fix some name mangling issues
- Add stub libraries to make the dll actually usable. The GCC alias library is still broken though.

svn path=/trunk/; revision=60037
2013-09-11 18:36:27 +00:00
Amine Khaldi
9ec7c23c83 [SVCHOST]
* CMake file improvements.

svn path=/trunk/; revision=60036
2013-09-11 18:33:36 +00:00
Amine Khaldi
eba1490a01 [SVCHOST]
* Use the DbgPrintEx based SvchostDbgPrint macro. We no longer have traces enabled by default here.

svn path=/trunk/; revision=60035
2013-09-11 18:20:30 +00:00
Alex Ionescu
e25b46f43d [NPFS-NEW]: Use locking and IRP completion macros from NPFS snippet at "Common Driver Reliability Issues - Microsoft
download.microsoft.com/download/5/7/7/577a5684-8a83.../drvqa.doc". Fix a few incorrect exclusive vs shared lock acquires.

svn path=/trunk/; revision=60034
2013-09-11 17:10:30 +00:00
Amine Khaldi
cd1307c71a [SCRRUN]
* Import from Wine 1.7.1.

svn path=/trunk/; revision=60033
2013-09-11 12:44:58 +00:00
Amine Khaldi
c6cea14cef [KERNEL32_WINETEST]
* Sync with Wine 1.7.1.

svn path=/trunk/; revision=60032
2013-09-11 11:32:57 +00:00
Amine Khaldi
5424614ddc [WINE/INCLUDES]
* Update Wine's atlbase.h.

svn path=/trunk/; revision=60031
2013-09-11 11:09:23 +00:00
Amine Khaldi
76a0d6d73e [COMDLG32]
* Move the resource files to the appropriate folders.

svn path=/trunk/; revision=60030
2013-09-11 10:46:07 +00:00
Amine Khaldi
e2e89189ab [ATL]
* Add _ATL_VER definition.

svn path=/trunk/; revision=60029
2013-09-11 10:20:46 +00:00
Alex Ionescu
529ec2cb68 [NPFS-NEW]:
NpfsCreate: 339 tests executed (0 marked as todo, 0 failures), 0 skipped.
NpfsConnect: 679 tests executed (0 marked as todo, 0 failures), 0 skipped.
NpfsReadWrite: 7154 tests executed (0 marked as todo, 0 failures), 0 skipped.
NpfsReadWriteAsync: 1176 tests executed (0 marked as todo, 0 failures), 0 skipped.
'Nuff said.

svn path=/trunk/; revision=60028
2013-09-11 07:05:15 +00:00
Alex Ionescu
a8e4859598 [NPFS-NEW]: Multiple code fixes to almost all code paths. Mainly a collection of small bugs, structural errors, logic flaws, off-by-ones, etc. But they were enough to make the driver essentially useless. Now Thomas's kmtests NpfsCreate and NpfsConnect return absolutely zero failures. On to NpfsReadWrite....
svn path=/trunk/; revision=60027
2013-09-11 02:04:17 +00:00
Amine Khaldi
f2664a3227 [ADVPACK_WINETEST]
* Sync with Wine 1.7.1.

svn path=/trunk/; revision=60026
2013-09-11 00:08:28 +00:00
Amine Khaldi
8516d91fba [ADVPACK]
* Sync with Wine 1.7.1.

svn path=/trunk/; revision=60025
2013-09-11 00:07:58 +00:00
Amine Khaldi
2d51bcc269 [CREDUI]
* Move the resource files to the appropriate folders.

svn path=/trunk/; revision=60024
2013-09-10 23:38:33 +00:00
Amine Khaldi
2f66f47d0c [DDK]
* Annotate swenum.h.

svn path=/trunk/; revision=60023
2013-09-10 23:31:39 +00:00
Amine Khaldi
54f807af0c [WINE/TEST]
* Add winetest_{get,add}_failures().

svn path=/trunk/; revision=60022
2013-09-10 23:30:54 +00:00
Amine Khaldi
1abc05ae78 [NTOSKRNL]
* Fix the locking in MiQueryBasicInformation to cover ARM3 too, not just RosMm. This makes sure we don't change the address space while querying it (or vice-versa).
* Don't attempt to query information for a terminated process (fixes some kernel32 loader winetests, matches Windows behavior).
* Brought to you by Alex Ionescu.

svn path=/trunk/; revision=60021
2013-09-10 22:21:52 +00:00
Amine Khaldi
a56630f977 [DDK]
* Annotate ntddpcm.h and apply some formatting consistency to it.

svn path=/trunk/; revision=60020
2013-09-10 22:20:09 +00:00
Amine Khaldi
074c447003 [AVIFIL32]
* Move the resource files to the lang folder.

svn path=/trunk/; revision=60019
2013-09-10 22:17:59 +00:00
Kamil Hornicek
0baa230380 [CALC]
Fix two more misaligned buttons in Czech resources.

svn path=/trunk/; revision=60018
2013-09-10 22:10:14 +00:00
Hermès Bélusca-Maïto
ec9cdf3b8a [CSR]: Fix header information ;)
svn path=/trunk/; revision=60017
2013-09-10 22:06:25 +00:00
Amine Khaldi
0fdb692a1f [NTOSKRNL]
* Return the proper status when we attempt to illegally commit non-ARM3 section. We hit this assert with some kernel32 winetests (mainly loader and virtual). Brought to you by Alex Ionescu.

svn path=/trunk/; revision=60016
2013-09-10 21:57:52 +00:00
Hermès Bélusca-Maïto
961f5fcef6 [ADVAPI32]
Use a correct control pipe sharing policy.

svn path=/trunk/; revision=60015
2013-09-10 21:38:15 +00:00
Hermès Bélusca-Maïto
e7603b96f7 [USERENV][USER32]
Use a correct return variable for RtlCreateUnicodeStringFromAsciiz. Advice: read the documentation before using functions...

svn path=/trunk/; revision=60014
2013-09-10 21:26:37 +00:00
Eric Kohl
13abedbf7a [LSASRV]
- Allocate buffers for account and domain names in the well-known sid list instead of using pointers to strings.
- Add a string load routine and convert all hard-coded SID names to resources.
A german translation will follow soon.

svn path=/trunk/; revision=60013
2013-09-10 21:20:22 +00:00
Hermès Bélusca-Maïto
179f3eb806 [BASESRV]
- Fix header formatting plus windows headers inclusion.
- RtlCreateUnicodeString returns booleans, not ntstatuses, so fix the code appropriately.

svn path=/trunk/; revision=60012
2013-09-10 20:45:53 +00:00
Thomas Faber
f50a1754a6 [CMAKE]
- Correctly escape error message. Spotted & tested by David Quintana

svn path=/trunk/; revision=60010
2013-09-10 20:06:05 +00:00
Thomas Faber
3ae1db0c81 [KERNEL32]
- Improve a DPRINT in CreateProcessInternalW. Patch by Víctor Martínez Calvo
CORE-7452 #resolve

svn path=/trunk/; revision=60009
2013-09-10 17:12:21 +00:00
Daniel Reimer
ecfb4a3bf3 Woops, modified the Description to be a bit more helpful.
svn path=/trunk/; revision=60008
2013-09-10 16:59:13 +00:00
Amine Khaldi
ac467dd40b [NTDLL_WINETEST]
* Sync with Wine 1.7.1.

svn path=/trunk/; revision=60007
2013-09-10 16:49:44 +00:00
Daniel Reimer
515b54ee2a Commit some Rapps Database regarding patches.
CORE-7312 #resolve #comment Committed in r60006. Thank you.
CORE-7352 #resolve #comment Committed in r60006. Thank you.
ROSAPPS-284 #resolve #comment Committed in r60006. Thank you.
ROSAPPS-283 #resolve #comment Committed in r60006. Thank you.

svn path=/trunk/; revision=60006
2013-09-10 16:49:30 +00:00
Amine Khaldi
5301954920 [PSDK]
* Import Wine's (broken) winioctl.h.
* Remove FILE_FS_VOLUME_INFORMATION from winternl.h. It doesn't belong there.
[NTDLL_WINETEST]
* Be more specific about winioctl.h inclusion.

svn path=/trunk/; revision=60005
2013-09-10 16:39:37 +00:00
Amine Khaldi
5d8d612453 [USER32]
* Be more specific about the commctrl.h inclusion.
* We no longer need to add include/reactos/wine as a global inclusions folder.

svn path=/trunk/; revision=60004
2013-09-10 16:28:05 +00:00
Pierre Schweitzer
bd3ccd4826 [NTOSKRNL]
Fix string size to store GPT GUIDs.
This was causing a buffer overflow (with ending null char) and thus a stack corruption.
The side effect of the stack corruption was that the debug code (display) was looping
forever while attempting to read partition table making ntoskrnl unable to boot with
a machine where there's a GPT disk.
Kernel is now able again to handle GPT disks (and they can be used again in user-land).

This was magically hidding before r59923 or by disabling NDEBUG. Lovely Heisenbugs :-).

svn path=/trunk/; revision=60003
2013-09-10 13:42:34 +00:00