Commit graph

1174 commits

Author SHA1 Message Date
Katayama Hirofumi MZ 5f692ed1f0
[EXPLORER][INCLUDE] Fix wrong title on taskbar about ampersand (&) (#2266)
Co-authored-by: Mark Jansen <mark.jansen@reactos.org>
Based on @learn-more's CORE-11619.patch. CORE-11619
2020-01-22 09:58:43 +09:00
Bișoc George 2bf4180c80 [USETUP] Implement resource ID text based strings for MUI (#2193)
CORE-12683

Supersedes PR #612.

* [USETUP] Implement the internal MUI routines for text manipulation based on its ID and implement text resource based IDs

USETUP (the 1st stage text mode setup module) bases upon MUI (Multilingual User Interface) sub-component of USETUP which is responsible for the ability into translating the MUI pages (each page having corresponding properties like X, Y coordinates, text flags and text string buffer) in various languages.
The only problem, as of now, is that whenever you want to modify a certain property of a page, such as removing a text from the said page in the screen, you've got to rely on using CONSOLE_* specific functions and calling with hardcoded parameters, namely the coordinates.

This can become a problem as not every localized (translated) MUI page has the same properties for each language and this could lead to various issues. Therefore, assigning each entry with an ID you can remove a text by only giving its ID (and the entry page number) without having the need to specify the coordinates
as the internal MUI routine, MUIGetEntry(), automatically retrieves the entry with respective data fields.

The following commit implements:

- MUIGetEntry()
- MUIClearText()
- MUIClearStyledText()
- MUISetText()
- MUISetStyledText()
- Now the X and Y coordinate members of MUI_ENTRY are of SHORT integer type, for the sake of the general code as most of the coordination values, even the COORD structure itself, has the coordination points as SHORTs and not BYTEs.

The following MUI functions will be used to manipulate text based resources depending on their ID from the corresponding MUI entry.

* [USETUP] Make CONSOLE_ClearTextXY function public so that we can use across other files.

* [USETUP] Implement the IDs for each text MUI entry in locale files.

This mechanism follows the same principle of resource IDs in Win32 applications. Static text is merely a resource that doesn't get changed programmatically for whole of its lifetime whereas dynamic resources can change during the lifetime of the program depending on the algorithm (for example, hide that piece of text and set another one, etc.).

* [USETUP] Remove the "Press ENTER to continue" message prompt when the partition formatting begins.
2020-01-19 17:58:13 +01:00
Eric Kohl 07d48d8808 [SERVICES] Use the local system account to run all services on a LiveCD
This fixes CORE-16589.
2020-01-08 00:15:52 +01:00
Eric Kohl 17f932d78e [DNSRSLVR] R_ResolverFlushCache should only flush cached records which were not read from the hosts file 2020-01-06 00:46:37 +01:00
Timo Kreuzer e084a7ae83 [SETUP] Don't free a DLL that is still in use by a different thread 2020-01-03 11:32:07 +01:00
Hermès Bélusca-Maïto 771b87dc8f
[CMD] If the prompt displays the information line on top of the screen, ensure that the prompt won't be hidden below it.
CORE-16193
2019-12-29 19:14:03 +01:00
Hermès Bélusca-Maïto 0bede0062a
[CMD] Code formatting; don't hardcode the string buffer sizes in function calls. 2019-12-29 19:13:59 +01:00
Katayama Hirofumi MZ be40a0e296
[MSPAINT] Revert LoadDIBFromFile for workaround (#2186)
CORE-16566
2019-12-28 22:30:21 +09:00
Hermès Bélusca-Maïto 51cb3cc6b2
[SETUPLIB] Register the \DosDevices\?: drive letter from installation time in the correct SYSTEM\MountedDevices registry key, i.e. the one of the ReactOS being currently installed.
CORE-15575

However I now hit a separate bug (see the report) that still prevent the
drive letter to be correctly assigned at reboot.
2019-12-26 17:16:14 +01:00
Katayama Hirofumi MZ 3fa95ab912
[MSPAINT] Fix memory leak of SelectionModel (#2169)
- Initialize all members in SelectionModel's ctor.
- Add SelectionModel's dtor.
2019-12-25 15:46:29 +09:00
Katayama Hirofumi MZ 8ef878a87f [MSPAINT] Use '%ld x %ld' rather than '%d x %d' 2019-12-24 13:29:29 +09:00
Katayama Hirofumi MZ d9b2edcc59 [MSPAINT] Add const to SelectionModel::SetSrcAndDestRectFromPoints parameters 2019-12-24 13:08:35 +09:00
Katayama Hirofumi MZ cf64f121f2 [MSPAINT] Refactor updateCanvasAndScrollbars 2019-12-24 04:30:25 +09:00
Katayama Hirofumi MZ a32212d96a [MSPAINT] Simplify choosecolor initialization 2019-12-24 04:18:40 +09:00
Katayama Hirofumi MZ 3a8c25d7f3 [MSPAINT] Simplify lfTextFont initialization 2019-12-24 04:17:02 +09:00
Katayama Hirofumi MZ 2acc689c58 [MSPAINT] Use hProgInstance for LoadImage 2019-12-24 04:13:43 +09:00
Katayama Hirofumi MZ 9879776950 [MSPAINT] Use correct type for custColors 2019-12-24 04:11:33 +09:00
Amine Khaldi 3cfeed64b1 [REG] Sync with Wine Staging 4.18. CORE-16441 2019-12-23 00:58:26 +01:00
Amine Khaldi e87b3957e4 [CSCRIPT][WSCRIPT] Sync with Wine Staging 4.18. CORE-16441 2019-12-23 00:58:01 +01:00
Eric Kohl 6c7878f35e [DNSAPI][DNSRSLVR] Implement DnsGetCacheDataTable() 2019-12-22 11:21:04 +01:00
Eric Kohl 6499cf9e1a [DNSRSLVR] Set proper flags for the hosts file entries 2019-12-21 22:12:55 +01:00
Eric Kohl 7908e2e41f [NETAPI32][WKSSVC] Implement NetGetJoinInformation using the workstation service 2019-12-15 19:53:23 +01:00
Hermès Bélusca-Maïto bfd8a84865
[BLUE] Improve initialization and interfacing with INBV.
CORE-15901

This fixes display reset transition when an external module acquired
INBV ownership and then released it, similarly to what was done in
commit 0ad65796 for VIDEOPRT.

For this a backup screenbuffer is used to store the contents of the
screen just before an INBV screen acquire transition, and these contents
are restored when it is detected that INBV ownership has been released.
Also, the active text font associated with the active console code-page
is restored, as well as the cursor state and shape.

In addition, any user of BLUE.SYS is now required to explicitly issue
a new IOCTL_CONSOLE_RESET_SCREEN to either enable or disable the screen.
This allows avoiding nasty unwanted screen mode switches when a handle
to the \Device\BlueScreen device is opened but no screen mode switch was
actually wanted - This "fixes" this annoyance on ReactOS and Windows,
when these are running witha VGA-compatible video driver and one wants
to look at properties of the \Device\BlueScreen device using
Sysinternals' WinObj.

Following this, we don't need to check anymore for explicit INBV
ownership by issuing calls to InbvCheckDisplayOwnership(), but instead
we check whether the screen has beeen manually enabled using the
aforementioned IOCTL. This partly supersedes commit 8b553a4b, and allows
fixing the second bug, namely that if we start ReactOS without the
/NOGUIBOOT option (and thus, INBV is active during boot), USETUP would
not show up anything because BLUE.SYS wouldn't display anything on screen.
See CORE-15901.

[USETUP][CONSRV] Call IOCTL_CONSOLE_RESET_SCREEN to tell BlueScreen device to enable the screen.
2019-12-15 03:37:52 +01:00
Bișoc George 14ebc0ba3d [OSK] Refactor the registry configuration code (#2096)
Rewrite LoadDataFromRegistry() and SaveDataToRegistry() as function helpers. With these, we'll be able to load and save data to registry on our choice.
2019-12-12 08:25:55 +09:00
Serge Gautherie 99f8ccdc7f [SETUPLIB] Fix 'MAX_USHORT' typo in a comment (#2144) 2019-12-10 13:16:46 +01:00
Serge Gautherie f6ad093801 [CMD] Fix 'MAX_ULONG' typo in a comment (#2143) 2019-12-10 13:16:26 +01:00
Tibor Lajos Füzi 74ec76df08 [TRANSLATION] Fix hungarian translation for usetup & syssetup to use formal addressing / conjugation (#2138) 2019-12-09 02:09:31 +01:00
Eric Kohl 989ee70d9d [WKSSVC] Implement parts of NetrJoinDomain2 to join a work group
NOTE: We can not connect to a work group yet!
2019-12-08 19:19:27 +01:00
Hermès Bélusca-Maïto 40db385716
[WINLOGON] Start the screensaver on the user desktop, since support for secure screensaver desktop is not completely implemented in Winlogon. CORE-16548 2019-12-08 02:27:21 +01:00
Katayama Hirofumi MZ 4c5b21f06c
[REGEDIT] Improve arrow button visual (#2133)
Add IDI_ARROW resource icon and use it for the arrow button.
2019-12-07 10:09:44 +09:00
Eric Kohl c35ebdfeb6 [DNSRSLVR] Add support for IP6 hosts file entries 2019-12-01 17:18:47 +01:00
Katayama Hirofumi MZ 6bf099a662 [ATTRIB] Delete unused variable 'szText' 2019-11-29 20:08:46 +09:00
Katayama Hirofumi MZ 189f648584
[CMDUTILS][ATTRIB] Support folder attributes (#2103)
CORE-16538
2019-11-29 20:03:19 +09:00
Serge Gautherie 3d84e25ac0 [CHARMAP] LoadSettings(): Properly use RegQueryValueEx() 2019-11-29 10:45:02 +03:00
Serge Gautherie 1fa2780796 [NETSTAT] Fix output formats and more (#1709)
* [NETSTAT] Restore expected output formats

"Revert" parts of bd3c852012.

CORE-16119

* [NETSTAT] Improve default and ICMPv4 output formats

* [NETSTAT] Fix a few typos, in output strings

* [NETSTAT] Output usage to StdErr

* [NETSTAT] Be more explicit about unimplemented -b/-t/-v options
2019-11-29 08:26:19 +01:00
Mas4hmad 9d1ce7c35c [TRANSLATION] Update Indonesian translation (#2037)
Update Indonesian translation for AVIFILE, CLIPBRD and USERENV.
2019-11-27 01:40:51 +01:00
Serge Gautherie 3bc93e9353 [MMC] DoSaveFileAs(): Respect szPath size (#2068)
CORE-11688
2019-11-27 07:24:51 +09:00
Eric Kohl 630f34a0d0 [DNSAPI][DNSRSLVR] Parse the hosts file when the resolver is initializing
- Move the hosts file handling from dnsapi.dll to the resolver service. Now, the hosts file is no longer parsed on each query.
- Add support for DNS_QUERY_WIRE_ONLY and DNS_QUERY_NO_WIRE_QUERY flags to R_ResolverQuery.
- GetCurrentTimeInSeconds() should return DWORD instead of DNS_STATUS.
2019-11-23 17:13:51 +01:00
Katayama Hirofumi MZ 34947add79 Revert [NOTEPAD] Add SBS_SIZEGRIP to status bar CORE-16528 2019-11-22 10:53:26 +09:00
Katayama Hirofumi MZ 1f2d4a78a1 [NOTEPAD] Add SBS_SIZEGRIP to status bar CORE-16528 2019-11-22 09:26:01 +09:00
Serge Gautherie 0f92924a99 [REACTOS] Use explicit StringCb*W() (#2069) 2019-11-21 00:47:06 +01:00
Serge Gautherie f3af9cfcf1 [NOTEPAD] StringCbPrintf() need sizeof(), not ARRAY_SIZE() (#2067) 2019-11-20 18:42:04 +01:00
Bișoc George 48d81f845d [OSK] Validate the registry value data on query (#2050)
Ensure that the value data we query on loading the registry configuration settings matches with its data size
2019-11-18 21:25:51 +01:00
Bișoc George 411a599610 [OSK] Reduce the delay when redrawing LED keyboard resources (#1385)
200 ms would mean that the LEDs redraw each 0,2 second and this adds a slight delay. This can be seen if you press the Num lock key (for example) many times in a row and the LED resources won't update instantly. Therefore reducing the value of uElapse should significantly decrease the delay and the LEDs should update in a realistic way. Furthermore, before invalidating the LED resource check the toggle state of the keys.
2019-11-18 21:24:45 +01:00
Eric Kohl 50605143f6 [IPCONFIG] Display missing record types and record names 2019-11-17 13:24:25 +01:00
Katayama Hirofumi MZ fa9145d305 [RAPPS] Improve Japanese translation 2019-11-17 19:46:56 +09:00
Katayama Hirofumi MZ 120457665c [NOTEPAD] Improve Japanese translation 2019-11-17 19:34:44 +09:00
Eric Kohl e196149b71 [IPCONFIG] Display non-zero type records only and improve error messages 2019-11-16 20:29:44 +01:00
Katayama Hirofumi MZ 1b7732093c
[CMD] Unquote string at pushd (#2031)
pushd command of cmd.exe didn't treat the quoted parameter correctly.
- Call StripQuotes in SetRootPath function.
- Fix typo of FEATURE_DIRECTORY_STACK.
This PR will enable "Command Prompt" here. CORE-12150
2019-11-15 11:51:58 +09:00
Tibor Lajos Füzi a3398a8e80 [USETUP] Hungarian translation fix (#2026) 2019-11-10 23:36:51 +01:00