Fix the explanations of how Windows/ReactOS should shut down (it's winlogon itself that calls NtShutdownSystem, not something else; that story about "SMSS API #1" concerns the SMSS API SmpSessionCompleteApi called by the helper function SmSessionComplete which is in turn called by CSRSS function CsrDereferenceNtSession, when all win32 processes are gone, as it should).
The webpage http://www.reactos.org/wiki/ShutdownProcess should be corrected for.
[USER32]
Whitespace fixes for winstation code.
svn path=/trunk/; revision=66275
Demote the "HACK: RemainingAccess = 0x%08lx DesiredAccess = 0x%08lx\n" from DPRINT1 to DPRINT, since it's massively spamming the log.
See CORE-9184
svn path=/trunk/; revision=66274
In NtGdiGetDIBitsInternal limit the size of what is being copied back to to usermode to the cjMaxInfo parameter. Fixes crash of Firefox when downloading files.
CORE-8895 #resolve
svn path=/trunk/; revision=66273
- magic_value--;
- Don't assign a desktop background colour by default. So that we can get the safe-mode background working (in safe mode), while having the default desktop background colours in normal situations.
Patch by Giannis.
svn path=/trunk/; revision=66271
Add #ifdef include guards to winnt.h. RC doesn't seem to support #pragma once and emits a redefinition warning, since with RC we first include winnt.h without STRICT defined, then again from windef.h with STRICT defined.
svn path=/trunk/; revision=66267
- Disable warning C4800: forcing value to bool 'true' or 'false' (performance warning). This is emitted when assigning an integer value to a C++ bool, which is always true (1) or false (0), so assigning an integer to it, will result in an implicit comparison against 0. But "fixing" this warning by adding an explicit comparison ("bool f = (i != 0);") will actually result in LESS efficient code (for whatever reasons). So this warning can be considered entirely useless and counter productive.
- Remove C4018 (signed/unsigned mismatch) from the TODO in the disable list. A comparison between an unsigned and a signed value will very likely result in wrong behavior and can easily cause hard to spot security bugs (e.g. when doing overflow checks). It is also often easy to fix.
svn path=/trunk/; revision=66266
NtfsMoonWalkID():
- Do not allow opening a file by ID if it's not in use any longer
- Do not attempt to create the full path, if an error occured during walk
svn path=/trunk/; revision=66265
Simplify the implementation of the "Open by ID" feature of our driver.
Instead of creating singleton FCB not linked to the rest of FS tree, just walk the whole path down, to recreate it.
This doesn't make nfi work properly though. Will investigate more.
CORE-8725
svn path=/trunk/; revision=66264
- Copy libwinpthread-1.dll if present instead of forcing the use of a specific set of GnuTLS binaries. Partially reverts r66110. Should fix testbot problems (mshtml_winetest:events in particular).
CORE-9167
svn path=/trunk/; revision=66257
Add the missing loop iterator in GetAdaptersAddresses().
This fixes infinite loop, and fixes Firefox 3.6 boot.
CORE-9051 #resolve #comment Fixed in r66253
svn path=/trunk/; revision=66253
- Reshuffle a bit some code.
- Never fail if the kill-COM-processes thread fails to be created.
- WlxLogoff GINA callback *must* be called *after* our logoff handling (with HandleLogoff). This is what happens on Windows (just add breakpoints on ExitWindowsEx and on WlxIsLogoffOk and WlxLogoff, and enable winlogon tracing).
[WIN32K]
Rename a flag to something more meaningful, and fix a flag filtering bug: lParams = wParam & something; ---> lParams = lParam & something; (the wParam is used for something else).
Part 12/X
CORE-8322
svn path=/trunk/; revision=66252
Add support for "module groups". These are meta targets that automatically include all targets using set_module_type() that are included between start_module_group(name) and end_module_group().
svn path=/trunk/; revision=66250
- Use a real timer for caret. This should cleanup message testing from those random system timer messages. See CORE-7447.
svn path=/trunk/; revision=66244
- Assert sanity of object reference counts in UserReferenceObject, UserDereferenceObject and UserDeleteObject. If you hit a cLockObj < 0x10000 assertion failure, you found yourself a use after free (RtlFreeHeap will put a LIST_ENTRY in this location, so a freed item has a kernel pointer there).
See CORE-8703 for an example.
svn path=/trunk/; revision=66243
- Implement KillComProcesses that just kills with force and without any notification back to winlogon, any remaining app that is still alive even if we asked before to kill apps (it's just the aim of this function, not more).
- Fix internal flags according to WinDbg sessions with Win2k3 + tracing checked build winlogon (testing logoff/shutdown/reboot from winlogon itself and when using the "shutdown" command).
- FIXME: Manage EWX_FORCE flag in winlogon...
[WINSRV]
Fix a DPRINT.
[WIN32K]
- Introduce a NotifyLogon function to manage winlogon notifications (when we shutdown and "end" shutdown steps, or cancel it).
- Fix some flags settings.
Part 11/X
CORE-8322
-------
This is a test:
!error !rot13 !reebe !ebg13 !error !rot13 !reebe !ebg13
svn path=/trunk/; revision=66240
- Fix the results from the new API CreateWindowEx tests. Message sequence and isolating each job Destroy and Free perform will come later. Refer to CORE-8703. This may not fix the crash while in wine test User32:msg.c.
- Dedicated to Thomas Faber.
- Fix build window list using threads. The link list works okay for locking but for tracking thread windows, use the snapshot method.
svn path=/trunk/; revision=66234
Partly sync find_value() with MESA 10.4.4. Fixes endless loop when GoogleEarth is started. GoogleEarth now loads and displays the earth, but it doesn't handle any input and makes the entire GUI hang.
svn path=/trunk/; revision=66232
