Commit graph

69028 commits

Author SHA1 Message Date
Giannis Adamopoulos
74cca4dd1e [WIN32K] -Use RtlStringCchCopyW instead of RtlStringCbCopyW in SubstituteFontRecurse as LF_FACESIZE is the number of characters of the buffer. Patch by Katayama Hirofumi MZ. CORE-13419, CORE-13416
svn path=/trunk/; revision=75026
2017-06-13 20:17:07 +00:00
Thomas Faber
eb3f29d2ad [WIN32K:NTUSER]
- Fail UserSetClipboardData in case of 0 format, as shown by user32:clipboard test

svn path=/trunk/; revision=75024
2017-06-13 14:11:26 +00:00
Thomas Faber
a41482aaa8 [USER32]
- Set last error on success in EnumClipboardFormats, as shown by user32:clipboard test

svn path=/trunk/; revision=75022
2017-06-13 13:40:55 +00:00
Thomas Faber
5e10767ccd [WIN32K:NTUSER]
- Close the clipboard when a thread is destroyed. Fixes 148 user32:clipboard tests
CORE-13414

svn path=/trunk/; revision=75021
2017-06-13 13:27:03 +00:00
Thomas Faber
d7fe3588b6 [WIN32K:NTUSER]
- Avoid crash on invalid format in UserEnumClipboardFormats. This is covered by user32_winetest but we currently fail that call before it can crash. The next commit will change that.
CORE-13414

svn path=/trunk/; revision=75020
2017-06-13 13:12:55 +00:00
Thomas Faber
1d4a0a6e30 [NTMARTA]
- Add support for CURRENT_USER trustee in AccpGetTrusteeSid. Fixes crash in advapi32_winetest:security
CORE-13420 #resolve

svn path=/trunk/; revision=75019
2017-06-13 10:10:57 +00:00
Thomas Faber
e953073b5f [BOOTDATA]
- Add Print context menu item for .rtf files. Patch by Nikolay Burshtyn.
CORE-13342 #resolve

svn path=/trunk/; revision=75018
2017-06-13 06:45:39 +00:00
Thomas Faber
82284116fa [KMTESTS]
- Add test for hidparse's descriptor parsing
CORE-11538

svn path=/trunk/; revision=75017
2017-06-13 05:48:28 +00:00
James Tabor
4d11c54f65 [GDI32|Metafile]
- Instead of debug breaking, use wine code anyway. Should fix CORE-12911.

svn path=/trunk/; revision=75016
2017-06-12 22:42:45 +00:00
Thomas Faber
07e4b2cd19 [HDAUDBUS]
- Initialize the correct variable in HDA_FDOQueryBusRelations. Should fix random crashes due to uninitialized value use.
CORE-12707 #resolve

svn path=/trunk/; revision=75015
2017-06-12 19:51:29 +00:00
Thomas Faber
c524a09a17 [WIN32K:NTUSER]
- Add a hack to avoid doubly freeing a DCE in IntDestroyClass. Since we don't implement W32PF_OWNDCCLEANUP and always free DCEs unconditionally in DceFreeDCE, it is not safe to access the class DCE here (and probably other places) since it could have been deleted by a dying thread.
CORE-13415 #resolve

svn path=/trunk/; revision=75014
2017-06-12 19:37:58 +00:00
Giannis Adamopoulos
40dcceff12 [SHELL32] -Add Comments as the 2nd column in CDesktopFolder, CDrivesFolder and CRegFolder. Add Type as the 3rd column in CRegFolder. This is not entirely correct. Our columns support is rudimentary, however we now show the comments stuff in the right place and the reg folder items have a type.
svn path=/trunk/; revision=75013
2017-06-12 18:38:26 +00:00
Giannis Adamopoulos
f6131fb8a9 Fix build.
svn path=/trunk/; revision=75012
2017-06-12 10:11:39 +00:00
Giannis Adamopoulos
f8555b75c4 [SHELL32]
- Rename the resource identifiers for column names to make sense. Get rid of one called File. This was renamed to Name but was the same in other languages, now it is replaced by Name for good. We also had two strings for a column called Comments and I think that in some languages one was singular and the other was plural. We only need the plural one. 
Note to translators: Please make sure that everything I changed makes sense. I had to edit all language files and there can be mistakes and typos.

svn path=/trunk/; revision=75011
2017-06-12 10:01:28 +00:00
Pierre Schweitzer
9805c2c7e7 [NTOSKRNL]
Implement SystemExtendedHandleInformation based on SystemHandleInformation.
To be improved...
Passes ntdll_winetest:info.

CORE-13368

svn path=/trunk/; revision=75006
2017-06-11 17:32:56 +00:00
Giannis Adamopoulos
2a0e4e58cf [SHELL32] -CDrivesFolder: Implement returning the appropriate type string in GetDetailsOf. Simplify GetDetailsOf and CDrivesExtractIcon_CreateInstance.
svn path=/trunk/; revision=75005
2017-06-11 14:02:14 +00:00
Mark Jansen
3a302c5330 [APPHELP_APITEST] Addendum to r74986, make the test work on win7. CORE-13284
svn path=/trunk/; revision=75004
2017-06-11 13:09:43 +00:00
Thomas Faber
3d3581bab1 [BUGCODES]
- Add DIRTY_NOWRITE_PAGES_CONGESTION and BUGCODE_USB_DRIVER

svn path=/trunk/; revision=75003
2017-06-11 12:46:15 +00:00
Thomas Faber
b8ed811f40 [PSDK]
- Fix C++ version of BM_REQUEST_TYPE without breaking the C version

svn path=/trunk/; revision=75002
2017-06-11 12:26:48 +00:00
Mark Jansen
b8ea78efa1 [WIN32NT_APITEST] Do not assert on a driver without DirectX support.
svn path=/trunk/; revision=75001
2017-06-11 11:47:41 +00:00
Thomas Faber
3779212db7 [NTOS:EX]
- Return STATUS_SUCCESS from the SystemExtendedHandleInformation stub to make Process Explorer happy. Fixes infinite loop on AHK bot.

svn path=/trunk/; revision=75000
2017-06-11 11:28:00 +00:00
Mark Jansen
27951d117b [WIN32K] Remove an unneeded check at GreGetDIBitsInternal. Patch by Victor Martinez Calvo. CORE-13413 CID 1411972
svn path=/trunk/; revision=74999
2017-06-11 11:18:57 +00:00
Mark Jansen
2366903f94 [COMCTL32_IMAGELIST] Prevent dereferencing a null pointer.
svn path=/trunk/; revision=74998
2017-06-11 11:08:32 +00:00
Mark Jansen
182d125bc0 [SHELL32] Do not fail CFSFolder::GetDisplayNameOf with a NULL pidl, preventing another crash in shell32:CFSFolder
svn path=/trunk/; revision=74997
2017-06-11 10:39:55 +00:00
Mark Jansen
7583b2b298 [WIN32KNT_APITEST] Do not assert on the result of an unimplemented function.
svn path=/trunk/; revision=74996
2017-06-11 08:51:36 +00:00
Mark Jansen
6c7fe2fb5f [SHELL32] Don't try to follow a null pointer inside CFSDropTarget, this fixes a crash in shell32:CFSFolder
svn path=/trunk/; revision=74995
2017-06-11 08:38:16 +00:00
Mark Jansen
178bc77a1f [SHELL32] Expose IID_CDefView in our CDefView implementation, this fixes a crash on shell32:shlview
svn path=/trunk/; revision=74994
2017-06-11 08:37:03 +00:00
Thomas Faber
16370e7605 [WIN32K:NTUSER]
Fix pool use after free during user32📋
- Rename IntIsFormatAvailable to IntGetFormatElement to better reflect what it does
- Introduce a new IntIsFormatAvailable that actually returns BOOL as implied by the name
- In IntAddSynthesizedFormats, call IntGetFormatElement right before its data is actually used, since IntAddFormatedData will invalidate the element pointer.
Thanks to Kamil for the initial investigation on this.
CORE-13408 #resolve

svn path=/trunk/; revision=74993
2017-06-11 08:33:36 +00:00
Pierre Schweitzer
1bde2edfcb [WS2_32]
Don't pass a null ptr at MSAFD to avoid dereference.
Fixes crash in ws2_32:sock

svn path=/trunk/; revision=74992
2017-06-11 07:56:18 +00:00
Thomas Faber
fbfe11f633 [WIN32K:NTUSER]
- Initialize BITMAPINFOHEADER::biSize before calling GreGetDIBitsInternal in IntSynthesizeDib. Fixes use of uninitialized memory and subsequent stack buffer overflow.
CORE-13408

svn path=/trunk/; revision=74991
2017-06-11 06:53:28 +00:00
Thomas Faber
ea1f78da72 [WIN32K:NTUSER]
- Include the CLIPBOARDDATA structure itself when calculating the size passed to UserCreateObject in IntSynthesizeDib. Fixes user heap corruption when running user32_winetest:clipboard.
CORE-13408

svn path=/trunk/; revision=74990
2017-06-11 06:05:42 +00:00
Pierre Schweitzer
f45315d051 [RDBSS]
Cosmetic fix

CID 1411968, 1411969

svn path=/trunk/; revision=74989
2017-06-10 20:58:22 +00:00
Pierre Schweitzer
fc8affc217 [RDBSS]
Fix reading parameters from registry

CID 1411973

svn path=/trunk/; revision=74987
2017-06-10 20:46:28 +00:00
Mark Jansen
be0666cf16 [APPHELP_APITEST] Add tests for ApphelpCheckRunApp[Ex], SdbGetMatchingExe, Sdb[Un]PackAppCompatData. CORE-13284
svn path=/trunk/; revision=74986
2017-06-10 20:31:58 +00:00
Pierre Schweitzer
50f668e4b3 [RXCE]
Misc. fixes.

CID 1411918, 1411929, 1411919

svn path=/trunk/; revision=74985
2017-06-10 20:28:25 +00:00
Mark Jansen
1b27b462ec [SHLWAPI_APITEST] Add PathFindOnPath tests. Patch by Katayama Hirofumi MZ. ROSTESTS-283 #comment Thanks!
svn path=/trunk/; revision=74984
2017-06-10 19:41:31 +00:00
Mark Jansen
d4db41b968 Addendum to r74982, remove some debugging code.
svn path=/trunk/; revision=74983
2017-06-10 17:47:56 +00:00
Mark Jansen
20cbe80c85 [SHELL32_APITEST] Add tests for PathResolve. Patch by Katayama Hirofumi MZ. CORE-12665 #comment Thanks!
svn path=/trunk/; revision=74982
2017-06-10 17:46:11 +00:00
Eric Kohl
d22bf76977 [SCHEDSVC]
Add a loop at the end of SchedServiceMain that will run until a stop event is signaled. This loop will be used to run the schduled jobs.

svn path=/trunk/; revision=74981
2017-06-10 10:51:49 +00:00
Thomas Faber
f5362e927f [NTOS:EX]
- Stub NtQuerySystemInformation:SystemExtendedHandleInformation. Avoids crashes in the upcoming ntdll_winetest sync.
CORE-13368 #resolve

svn path=/trunk/; revision=74980
2017-06-10 07:59:50 +00:00
Pierre Schweitzer
79a42b92f4 [UDFS]
Fix UDFS volume size computation.
Note that side effect of this is that free space computation is broken;
due to larger bitmap walk. To be fixed...

CORE-4375
CORE-13366

svn path=/trunk/; revision=74979
2017-06-10 05:45:26 +00:00
Amine Khaldi
071ff079a6 [PSDK] Add some missing definitions.
svn path=/trunk/; revision=74978
2017-06-09 23:13:23 +00:00
Thomas Faber
3fd5666e63 [WIN32K:NTUSER]
- Fix fmt range check in NtUserGetClipboardFormatName (see Wine commit 4bdcf512). Fixes new test failures (and resulting debug spam) in user32_winetest:clipboard
CORE-13402 #resolve

svn path=/trunk/; revision=74977
2017-06-09 21:36:15 +00:00
Mark Jansen
630bbc5421 [CALC] Explicitly link against comctl32. Patch by Carlo Bramini. CORE-10727
svn path=/trunk/; revision=74976
2017-06-09 18:21:54 +00:00
Thomas Faber
c16f5dc411 [USER32_WINETEST]
- Hackfix crash in user32:clipboard test due to NULL pointer returned from GetClipboardData.

svn path=/trunk/; revision=74974
2017-06-09 14:08:50 +00:00
Thomas Faber
3cbe1ae789 [GDI32]
- Check for lpResults == NULL in GetCharacterPlacementA. Patch by Doug Lyons. Fixes crash in gdi32_winetest:font
CORE-13401 #resolve

svn path=/trunk/; revision=74973
2017-06-09 11:14:11 +00:00
Giannis Adamopoulos
19dd22d422 [EXPLORER] -Use WM_POPUPSYSTEMMENU to open the system menu of a window. CORE-13400
svn path=/trunk/; revision=74972
2017-06-09 09:16:44 +00:00
Giannis Adamopoulos
e340056142 [EXPLORER] -Fix the return value in HandleShellHookMsg. Suggestion by Christoph.
svn path=/trunk/; revision=74971
2017-06-09 08:29:04 +00:00
Mark Jansen
8d15eb4dea [NTOS:MM] Do not queue debugger events after notifying process exit. CORE-13393
Patch suggested by Thomas.

svn path=/trunk/; revision=74969
2017-06-08 20:34:47 +00:00
Giannis Adamopoulos
8ad0eae687 [EXPLORER] -Revert a hack from r63304 that caused CORE-13388. This hid another bug and the correct way to fix this is to return MA_NOACTIVATE to WM_MOUSEACTIVATE.
svn path=/trunk/; revision=74968
2017-06-08 20:31:49 +00:00