- Fix possible buffer overflow: ExpandEnvironmentStrings wants character count size of a buffer, not byte sized. Spotted by Thomas Faber.
See issue #6053 for more details.
svn path=/trunk/; revision=56888
- Revert r56865, it duplicates same action (expanding the var), spotted by Thomas Faber.
See issue #6053 for more details.
svn path=/trunk/; revision=56887
- Fix uninitialized variable usage warning, based on a patch by Edijs Kolesnikovics.
See issue #6828 for more details.
svn path=/trunk/; revision=56886
- Hermes Belusca: Fix wrong definition of CMHIVE structure (defined only 3 FileHandles when 4 is needed).
See issue #7162 for more details.
svn path=/trunk/; revision=56884
* Improve the way DDKAPI, DDKCDECLAPI and DDKFASTAPI are defined. With that we don't need ReactOS specific defines anymore.
* Already sent upstream.
svn path=/trunk/; revision=56882
- Use COUNT_OF where appropriate. Miscellaneous code cleanup. Patch by Hermès Bélusca
See issue #7182 for more details.
svn path=/trunk/; revision=56876
* Fix Cookie for loader locking generation
Silences "LdrUnlockLoaderLock() called with an invalid cookie!" debug messages
svn path=/trunk/; revision=56874
* Track pixel format with window handle for device contexts
* Fix SetPixelFormat in case pixel format were already set
svn path=/trunk/; revision=56873
- Update Uniata to 41b5. Thanks to Alter for the great driver and Olaf Siejka for preparing the patch, getting our changes upstream and testing the updated version.
See issue #7148 for more details.
svn path=/trunk/; revision=56870
- Implement Import/Export of hive files. Patch by Hermes Belusca (German translation by me)
See issue #7180 for more details.
svn path=/trunk/; revision=56869
- Apply the "Refresh" command to the ListView in addition to the TreeView
- Use COUNT_OF where applicable; miscellaneous readability and consistency fixes
- Space fixes in resource files; French translation fixes
- Patch by Hermes Belusca
See issue #7180 for more details.
svn path=/trunk/; revision=56868
- Edijs Kolesnikovics: Expand environment strings during processing startup items in HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Run.
See issue #6053 for more details.
svn path=/trunk/; revision=56865
- Don't stop enumerating functions of a PCI device if current function returned invalid vendor id. Also add a check for returned data size. This fixes detection of some storage controllers, e.g. Intel ICH8, ICH9, ICH10 chipsets.
Thanks to Alter (UniATA author) for finding the problem and providing solution.
See issue #7147 for more details.
svn path=/trunk/; revision=56863
Correct comments and code error introduced in rev 56844.
Patch by Hermes Belusca.
I used a helper variable to determine whether or not ScmDeleteNamedPipeCriticalSection must be called. Changing the order in which functions are called could cause a deadlock.
See issue #7172 for more details.
svn path=/trunk/; revision=56861
Allocate the ARC_DISK_SIGNATURE structures from the heap instead of putting them into the initial loader block allocation, since the number of disks changes later. Fixes memory corrruption and boot breakage when 3 hdds are connected.
[NTOSKRNL]
Remove a hack that disabled unloading drivers, which didn't work because of memory corruption from freeldr. This works now, too.
See issue #7139 for more details.
svn path=/trunk/; revision=56860
- Make sure freeldr is not compiled with SSE instructions (default for VS 11+)
- Print trap number and instruction stream on bugcheck
- Fix assembly code for ML
svn path=/trunk/; revision=56857
- Implement SampGetObjectAttributeString to retrieve the size of a string, allocate a buffer and retrieve the string from the registry.
- Use SampGetObjectAttributeString to retrieve string attributes in SamrQueryInformationXxx functions.
- Add most missing cases to SamrQueryInformationUser.
- Fix a type mismatch in ntsam.h.
svn path=/trunk/; revision=56850
- Wine doesn't prepend \registry\ to any registry path, which is wrong. Fix that.
- Bring back previous implementation of GetGeoInfo & co.
- Fix GEO_OFFICIALLANGUAGES in the headers.
- Thanks to Kamil Hornicek and Samuel Serapion for finding the problem and creating patches.
See issue #6595 for more details.
svn path=/trunk/; revision=56849
Implement service database locking via RLockServiceDatabase / RUnlockServiceDatabase etc... and use this functionality.
Patch by Hermès Bélusca.
I did not rename the database lock functions because the functions names RLockServiceDatabase and RUnlockServiceDatabase are misleading. They do not lock any database but lock the service start function. The existing functions ScmLockDatabaseExclusive, ScmLockDatabaseShared and ScmUnlockDatabase do protect (lock) the service database (service, group and image lists) form concurrent access. That is also the reason for renaming the SC_LOCK_STRUCT to START_LOCK.
See issue #7131 for more details.
svn path=/trunk/; revision=56844
- Simplify AcquireRemoveRestorePrivilege. Improve clean-up & acquire privilege before unloading hive in CreateUserProfileW. Patch by Hermes Belusca
See issue #7160 for more details.
svn path=/trunk/; revision=56843
