- Improve the stub for MEM_RESET case of NtAllocateVirtualMemory.
Fixes infinite loop for gecko-based application (including firefox19 and ReactOS/wine mshtml implementation)
svn path=/trunk/; revision=59141
SamrDeleteAlias: Dereference the AliasHandle parameter properly. All SamrDelete functions use a pointer to the handle. The other SamrDelete functions do it right.
svn path=/trunk/; revision=59140
NetLocalGroupGetInfo: Fix a bug in the alias search code. The function should search the account domain if no alias was found in the builtin domain, instead of returning an error. Fail only if the desired alias can not be found in both domains.
svn path=/trunk/; revision=59138
- Implement SetConsoleCursor and ShowConsoleCursor (set the shape of the cursor, and show/hide it). It appears that SetConsoleCursor acts only on graphics screen buffers (tested on Windows).
I personnaly think it's a limitation we can suppress, but at the moment I keep it.
- Implement SetConsoleMaximumWindowSize which does nothing else than returning TRUE but doesn't give any constraint on the maximum size of the console window (tested on Windows Server 2003).
See http://undoc.airesoft.co.uk/kernel32.dll/SetConsoleCursor.php , http://undoc.airesoft.co.uk/kernel32.dll/ShowConsoleCursor.php and http://undoc.airesoft.co.uk/kernel32.dll/SetConsoleMaximumWindowSize.php for more details.
Useful for the NTVDM interface !
[CONSRV:Gui frontend]
- Fix "Select all" action.
- Enable or disable "Copy" and "Paste" commands in the edition menu.
svn path=/trunk/; revision=59135
- Do not dereference an unsafe ObjectAttributes pointer in IoCreateFile. Spotted by Aleksandar Andrejevic
(I'm removing the OriginalAttributes assignment completely because it's never used, and it generally makes no sense to copy this. ObOpenObjectByName already takes care of everything in attributes)
CORE-7167
svn path=/trunk/; revision=59134
* Properly fail when the read pointer is out of the file. Brought to you by Sergey Chernov.
CORE-7249 #resolve #comment Committed in r59133. Thanks !
svn path=/trunk/; revision=59133
COLOR builtin command of CMD does not format output color correctly.
When changing the color of the foreground of the console with the command "color 3" for instance,
the confirmation message "Color 3" appears whereas it should say "Color 03" as the number is output in 1-byte hexadecimal form.
Patch by Radek Liška
CORE-7246 #resolve #comment Committed in revision r59132. Thanks :)
svn path=/trunk/; revision=59132
... use Ninja by default for compiling ReactOS !!
Users now have to do:
./configure
to use Ninja for building ReactOS.
The old method (using makefiles) is available by doing:
./configure Makefiles
(or: ./configure makefiles )
Tested by Amine and Sylvain (blame them ;) )
svn path=/trunk/; revision=59129
- Handle case when device interface link is properly set
[WDMAUD]
- Implement timer routine, which issues a work item
- Implement querying sysaudio if the audio device count has changed. In that case reinitialize the mmixer library
- No reboot is now more required after installing audio devices.
svn path=/trunk/; revision=59121
- Emulate a return from _SEH2EnterHandleTrylevel/_SEH2EnterFrameAndHandleTrylevel rather than directly jumping to the handler in case of an exception. This prevents us from invalidating compiler assumptions. Thanks to Timo.
Should fix GCC 4.7 bug with PSEH2 (CORE-7240).
svn path=/trunk/; revision=59120
- Create the None (aka Users) group upon setup.
- Add all users as members of the Users group.
- Add the Guest user as a member of the Guests alias.
svn path=/trunk/; revision=59115
- Disable call to Direct3DCreate9 [HACK]
- Use the correct parent window handle when creating the system dialogs.
- Fix the next page button
- TODO: ReactOS needs to check whether a correct parent window handle was provided
- Fixes dxdiag tab problem
svn path=/trunk/; revision=59113
- Create shortcuts based on shortcuts.inf instead of hardcoding them
Note to translators: please make sure that all shortcut translations are correct. Several localized strings had to be copied by hand so there is the possibility that some errors exist
svn path=/trunk/; revision=59110
* Simplified the help system
* Removed an unnecessary check in the help system that listed the first help entry 'active' no matter what was entered into the help system, even if the word is not in the list.
* Removed exit_main and rem_main functions since it took a little extra processing time and made the code a bit harder to read. Now it determines if the given command is rem or exit first before looking through the entire function list.
* Converted WCHAR* to LPWSTR to make it a bit easier to read.
* Add a title to the program to make it easier for the user to determine the name of the application currently running, especially if a large script is being used.
Patch by Lee Schroeder.
Thanks!
CORE-7187 #resolve #comment Committed in r79104.
svn path=/trunk/; revision=59104
Fix some compilation warnings with MSVC.
[KERNEL32-CONSRV]
- Implement console graphics screen buffers, as described in http://blog.airesoft.co.uk/2012/10/things-ms-can-do-that-they-dont-tell-you-about-console-graphics/ .
The idea is that the console server creates a memory shared section to be shared with the client console application (it increases performance). A mutex is used to "say" to the console server that he can repaint the screen. The function InvalidateConsoleDIBits is implemented too. The definition of the structure CONSOLE_GRAPHICS_BUFFER_INFO comes directly from the site.
- CreateConsoleScreenBuffer was modified to be able to create such buffers.
This is needed for a working NTVDM-like application.
[CONSRV]
- Rework the console buffer structures so that text-mode buffers and graphics-mode buffers can "inherit" from an "abstract" structure, CONSOLE_SCREEN_BUFFER. Add few helper functions for manipulating them.
- Reorganize the output code in "graphics.c" and "text.c" files to separate text-mode only code from graphics-mode only code, both in the console server and in the GUI front-end.
Other fixes:
- Fix mouse handling (left and right clicks when one goes away from the "Selection" mode); do not handle mouse signal when we reactivate the GUI front-end window by a click.
- Fix GetLargestConsoleWindowSize API in console server side. Now pressing Alt+F9 in Far Manager to "change" the "video" mode works correctly.
Finally:
- Start to implement a (fake, i.e. not using directly a VGA driver) console fullscreen mode. Currently Alt-Enter key presses call a stub which just alternates DPRINTing between "switch to fullscreen mode" and "switch to windowed mode".
Images here:
- Example of an application (a 16-bit emulator by Mysoft) which uses the console graphics screen-buffer functionality: http://img577.imageshack.us/img577/1693/mysoftemulatorargon.png
- A potpourri of console applications which use graphics screen-buffers: http://img571.imageshack.us/img571/6526/consoledelirium.png
Enjoy :)
svn path=/trunk/; revision=59099
- Fix almost all of the (few) tests for uxtheme
- Do not allow opening or enumerating themes when the themes service is not running
svn path=/trunk/; revision=59098
- Add some missing 64 bit intrinsics
- Fix a warning in intsafe.h
- Use SAL2 annotations in sspi.h
- Fix some annotations
svn path=/trunk/; revision=59094