Timo Kreuzer
d1c55af4ea
[NTDLL] Ordinals -> @
2020-01-03 13:00:45 +01:00
Timo Kreuzer
6e80f4d037
[SPEC2DEF] Set ordinals explicitly in export def file
...
The reason is that dlltool orders the exports differently than MSVC builds (MSVC orders the exports by symbol name, rather than by export name), so we rely on sorting in the spec file, which was only respected, when ordinals were put into the def file.
On MSVC builds it is left to the linker to determine the correct order, which helps to get the differences between architectures right (different symbol decoration, difference between order for functions like NtLoadKey vs NtLoadKey2, which results from the stdcall decoration on x86, which is missing on other architectures.
TODO: To correctly handle non-x86 architectures with GCC builds, spec2def would need to reorder the export list based on symbol names, which would work for C functions, by taking the calling convention into account, but would require an extra c++-stdcall calling convention to be added to know the corresponding symbol starts with "?".
2020-01-03 13:00:45 +01:00
Timo Kreuzer
fb0ebac349
[NDK][XDK][RTL] Fix definition of RtlFillMemoryUlong on x64
2020-01-03 13:00:45 +01:00
Timo Kreuzer
e084a7ae83
[SETUP] Don't free a DLL that is still in use by a different thread
2020-01-03 11:32:07 +01:00
Thomas Faber
07de9d1da3
[NTOS:KE] In KiExitV86Mode, restore KTSS::Esp0 to its standard value. CORE-16531
...
The trap frame is in a random location on the stack, and setting Esp0 there
wastes significant amounts of space and may lead to unexpected stack overflows.
Also use a more descriptive expression for the V86 members of the KTRAP_FRAME.
2020-01-03 11:28:09 +01:00
Thomas Faber
5b83d86af5
[WIN32K:NTGDI] Add missing probe to NtGdiGetPath.
2020-01-03 11:21:24 +01:00
Thomas Faber
f0d2bd3852
[WIN32K:NTGDI] Avoid breakpoints in syscalls.
2020-01-03 11:21:21 +01:00
Eric Kohl
9538c3ccd7
[NTOS:IO] Fix indentation. No code changes!
2020-01-02 23:25:26 +01:00
Hermès Bélusca-Maïto
cf7981fe4e
[LSASRV] Add parameter validation in LsapSetLogonSessionData().
2020-01-02 22:17:03 +01:00
Hermès Bélusca-Maïto
8210396cb4
[MSV1_0] Extend parameter validation in LsaApLogonUserEx2() and MsvpChangePassword(); fix crash in LsaApLogonUserEx2() when LogonDomainName points to a NULL string.
2020-01-02 22:16:58 +01:00
Hermès Bélusca-Maïto
127fa1afc6
[RTL] Fix RtlValidateUnicodeString() regarding the tests and add some SAL annotations.
2020-01-02 21:11:28 +01:00
Hermès Bélusca-Maïto
ae8c9a1fa2
[NTDLL_APITEST] Add a test for RtlValidateUnicodeString().
2020-01-02 21:11:27 +01:00
Thomas Faber
0d745e0698
[DISK_NEW] Return correct info size in failure case of DiskIoctlGetPartitionInfoEx.
2020-01-02 16:36:15 +01:00
Thomas Faber
2fa7b1dcc1
[CDROM] Return the correct data length for IOCTL_DISK_GET_LENGTH_INFO. CORE-16607
2020-01-02 14:08:46 +01:00
Maxim Smirnov
06eb8cda99
[SHELL32] Fix extra fixme ( #1975 )
...
This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`
2020-01-02 13:35:32 +01:00
Oleg Dubinskiy
c8464e5717
[BOOTDATA] Add AppliedDPI registry value ( #1966 )
...
Add AppliedDPI DWORD registry value 0x00000060 (96 DPI) into HKCU\Control Panel\Desktop\WindowMetrics registry key. For now it does nothing, since saving DPI registry settings is not implemented yet. It's required only for ViStart 8 to be started successfully (with MS VB6 Runtime installed and wshom.ocx replaced). CORE-13877
2020-01-02 18:06:18 +09:00
Serge Gautherie
fa2e4e9537
[FREELDR] Update ACPI Extended Attributes support to 6.3 ( #1782 )
...
Update BIOS_MEMORY_MAP and PcMemGetBiosMemoryMap() from ACPI 6.2-A to ACPI 6.3.
Co-Authored-By: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2020-01-01 21:43:28 +01:00
Hermès Bélusca-Maïto
60fbf459c3
[FREELDR] Simplify the PrintText() and FrLdrBugCheckWithMessage() routines by using a new PrintTextV() helper.
2020-01-01 21:15:05 +01:00
Serge Gautherie
ad43210b41
[FREELDR] Reimplement i386PrintText(), adding line wrap handling. CORE-16268
...
Co-Authored-By: Stanislav Motylkov <x86corez@gmail.com>
2020-01-01 21:14:08 +01:00
Serge Gautherie
043307624f
[FREELDR] xboxcons.c, i386bug.c: Formatting and whitespace fixes.
...
Co-authored-by: Hermès Bélusca-Maïto <hermes.belusca-maito@reactos.org>
2020-01-01 21:12:24 +01:00
Stanislav Motylkov
fbf4660f46
[WS2_32_APITEST] Add some tests for GetAddrInfoW
...
Test results proves WSAStartup call should precede GetAddrInfoW calls.
2020-01-01 18:53:40 +02:00
Katayama Hirofumi MZ
1e83f8b5fd
[SDK][INCLUDE] Total refinement of Gdiplus headers ( #2223 )
...
Missing functions added. CORE-16585
2020-01-01 20:28:42 +09:00
Katayama Hirofumi MZ
265a890d7c
[SDK][INCLUDE] Improve gdiplusgraphics.h ( #2222 )
...
CORE-16585
2020-01-01 19:10:47 +09:00
Katayama Hirofumi MZ
91f3c8f81a
[SDK][INCLUDE] Improve gdiplusmetafile.h ( #2221 )
...
CORE-16585
2020-01-01 17:06:34 +09:00
Katayama Hirofumi MZ
f48a01324c
[SDK][INCLUDE] Improve gdiplusmatrix.h ( #2220 )
...
CORE-16585
2020-01-01 16:48:52 +09:00
Katayama Hirofumi MZ
cc60a2125a
[SDK][INCLUDE] Improve gdiplusstringformat.h ( #2219 )
...
CORE-16585
2020-01-01 15:40:46 +09:00
Katayama Hirofumi MZ
b35558b463
[SDK][INCLUDE] Improve gdipluspath.h ( #2218 )
...
CORE-16585
2020-01-01 15:40:05 +09:00
Katayama Hirofumi MZ
84de8c3f25
[SDK][INCLUDE] Refinement of Gdiplus headers ( #2217 )
...
Define getNat helper functions in gdiplusbase.h and use them. CORE-16585
2020-01-01 13:53:30 +09:00
Hermès Bélusca-Maïto
9ba5594599
Happy New Year 2020 to everyone!!
...
🎊 🎆 🍾 🥳
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
__, ,__) __, ,__) __, ,__) ░░▄████▄░▄███▄░▄████▄░▄███▄░░
(--|__| _ ,_ ,_ (--|\ | _ (--\ | _ _ ,_ ░░▀▀░▄██░██░██░▀▀░▄██░██░██░░
_| |(_||_)|_)(_| _| \|(/_(_|_) \|(/_(_|| ░░░▄██▀░░██░██░░▄██▀░░██░██░░
( | | ,_| ( (__| ░░██████░▀███▀░██████░▀███▀░░
.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:._.:*~*:.
███████████████████████████████████████████████████████████████████████████████
██████████████████▓▒▒▒▒▒▒▓▓█████████████████████████▓▓▒▒▒▒▒▒▓██████████████████
███████████████▒▒▒▒▓▓███▓▓▓▒▒░▒▓▓█████████████▓▒▒░▒▒▓▓████▓▓▒▒▒▓███████████████
█████████████▓░░░░░░░░░▒▒▓██████▓▒▒▒▓█████▓▒▒▒▓██████▓▒▒░░░░░░░░░▓█████████████
███████████▒▓░▒█████████▓▓▒░▒▓███▓▓▓▓▓▓▓▓▓▓▓▓████▒▒▒▒▓▓████████▓▒░▓▓███████████
██████████▒▒▓░▓██████████████▓▓▓▓▓█████▓▓▓▓▓▓▓▓▒▒███████████████▓░▓░▒██████████
█████████▓░▓█░▓██████████▓▒▒▒▒▓▓▓▓███████▓▓▓▓▓▓▓▓▓▒▒▓███████████▓░█▒░▓█████████
█████████▓▒██▒▒████████▒▒░░░░▒▒▓▓▓███████▓▓▓▓▓▓▓▓▓▓▓▒▒░█████████▒▒█▓▒▒█████████
█████████▓░██▓░▓█████▓▓▒▒░░░░▒▒▓▓▓▓████▓▓▓▓▓▓▓▓▒▒▓▓▓▓▓▒░░▓█████▓░▓█▓░▓█████████
██████████░▓██▒▒▓██▓▓▓▓▓▒▒▒▒▒▒▓▓▓▓██████▓▓▓▓▓▓▒▒▒▒▒▓▓▓▓▒▒░░███▓░▒██▒░██████████
██████████▒▒▓██▒▒▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓█████████▓▓▓▒▒▒▒▒▒▒▒▒▓▒▒▒▒░░▓█▒▒██▓░▓██████████
███████████▒▒███▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓████▓▓▓▓▓▓▒▒░▒▒▒▒▒▒▒▒▒░░░▒███▒▓███████████
████████████▒▒█▓▓▒░▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▒▒░░░░▒▒░░░▒▒▒░░░▓██▒▒████████████
█████████████▒▒▒▒▒▒░▒▓▓▓▓▓▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▓▓▓▓▒▒░░░░░░░░░░░░░▒▒▒▓▒▒█████████████
██████████████░░▒▒▒▒░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒▓▓▓▓▒▒▒▒▒░░░░░░░░░▒░░▒░▒██████████████
██████████████▓▒░▒▒▒▒▒░░▒▒░░░░░░░░░▒▒▒▒▒▒▒▒▒▒▒▒▒▒▒░░░░░░░░░░░░░▓███████████████
██████████████▓▒▓░░▒▒▒▒░░░░░░░░░░░░░░░░░▒▒▒▒▒▒░░░░░░░░░░▒░░░░░▓▒▓▓█████████████
███████████▓▒▓▓▓▒▒░░░░░▒▒░░░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░░▒▒▒█▒▒▓███████████
██████████▓▒▒█▓▓▒▒░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▓▒▒▒▒██▒▒▓██████████
█████████▓▒▓██▓▒▒▒▒░░▒░░░░░▒░░░░░░░░░░░░░░░░░░░░░░░▒░░░░░▒▒▒▒▒▒▓███▓▒▓█████████
████████▓▒▓███▓▒▒▒▒░░░▒░░░░░░▒░░░░░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▓▓▒▒▓▒▓██▓▒▓████████
███████▓▒▓███▒▓▓▒▒▒░░░░░▒░░░░░░▒░░░░░░░░░░░░░░░▓▒▒▒▒░▒▓▒▓▓▓▓▒▒██▓▒▓██▓▒████████
███████▒▒██▓▒▓█▓▓▒▒░░░░░░░▒░░░░░░▒░░░░░░░░░░░▓▒▒▒▒░▒▓▒▒▒▓▓▓▒▒▓███▓▒███▒▓███████
██████▓▒▓██▒▒███▓▒▒▒░░░░░░░░▒▒░░░░░▒▒░░░░░░░░▒▒░░▒▓▓▓▓▒▒▒▒▒▒▓█████▒▒██▓░▓██████
██████▒▒██▒▒█████▓▒▒▒░░░░░░░░░▒░░░░░░░▒░░░░▒▒░░▒▓▒▒▒▒▒▒▒▒▒▒████████▒▒██▒▒██████
██████▒▓██░▓██████▓▓▒▒▒░░░░░░░░░░▒░░░░░░░▒░░░░▒▒▒▒▒▒▒▓▓▒▒██████████▒░██▒▒██████
██████▒▒▓▓▒█████████▓▓▒▒▒░░░░░░░░░░▒▒░░░░▒▒▒▓░░░▒▒▒▒▒▓▓████████████▓▒▓▓░▒██████
██████▓░▒▒▒███████████▓▓▒▒░░░░▒▒▒░▒░▒▒▒▒░░▒▒▒▒▒▓▒░░▒▒██████████████▓░▒▒▒███████
███████▓▒░░▒█████████▓▒▒░░▒▓▓▒▒▒░░░░▒▒▒▓▒▓▒░░▒▒▓▓██▓▓▒░▒▒▓█████████▒░░▒████████
██████████▒░░░░░░░▒▒▓▓█████▓▓▒░░▒▓██▓▓████████▒░▒▒▓██████▓▓▒▒░░░░░░░▒██████████
███████████▓▒▒▒▓▓████▓▓▒▒▒░▒▒█████████████████████▒▒░▒▒▓▓▓███▓▓▒▒▒▒████████████
████████████████▓▓▓▓▓▓███████████████████████████████████▓▓▓▓▓▓████████████████
███████████████████████████████████████████████████████████████████████████████
███████████████████████████████████████████████████████████████████████████████
██████████████████████████████████████████████████████████▓░░▓████████░░░▓█████
███▒░░░░▒▓███████████████████████████████████████▒█████▓▒▒▓██▓▒▒▓████▓░█▓░▓████
███▒█████░▒███▓▒▒▒▒▒▓████▓▒▒▒▒▒▓█▓███▓▒▒▒▒▒▒▓██▓▒░▒▒▓▒▓█████████▓▒██▓▒█████████
███▒█████░▒█▓▒▒█████▒▒██▒▒▓████▓░▒██▒▒▓████▓▒▓██▓░▓██▓███████████▓▓██▓░░░▒█████
███▒█▓░░▒▓█▓▒▒▓▒░░▒▓▒░▒▓▒███████▒▒██▒████████████░███▓███████████▓▓██████░▒████
███▒██░▓███▓▒▓█████████▓▒███████▒▒██▒████████████░███▒▓██████████▓████████░▓███
███▒███░▒▓██▓▒▒████▓▒▓██▓▒▒▓██▓▒░▒██▓▒▒▓███▓▒▓███░████▓▒▒█████▒▒▓███▓▒▓██░▓████
███▒████▓░▓████▒▒▒▒▒██████▓▒▒▒▒▓█▓████▓▒▒▒▒▓█████▒███████▓▒▒▒▒▓███████▒▒▒▓█████
███████████████████████████████████████████████████████████████████████████████
2020-01-01 00:00:00 +01:00
Eric Kohl
5d3fe05505
[ADVAPI32] OpenSCManagerA/W: Set the last error even in case of success
...
This fixes a failure in the QueryServiceConfig2 api test.
2019-12-31 23:23:23 +01:00
Eric Kohl
17864b49e3
[LSASRV] LsarLookupSids: Return proper domain information for nameless domains
2019-12-31 17:59:10 +01:00
Stanislav Motylkov
96692636e4
[FREELDR] Obtain Xbox memory map via multiboot spec ( #1971 )
...
- Also obtain framebuffer memory size the same way.
References:
https://wiki.osdev.org/Detecting_Memory_(x86)#Memory_Map_Via_GRUB
https://www.gnu.org/software/grub/manual/multiboot/multiboot.html#Boot-information-format
CORE-16216 CORE-16300
2019-12-31 16:10:34 +01:00
Timo Kreuzer
7523a7b138
[NTOS:KE] Rename some locking functions to reflect the IRQL level changes
...
* KiAcquireApcLock -> KiAcquireApcLockRaiseToSynch
* KiAcquireApcLockAtDpcLevel -> KiAcquireApcLockAtSynchLevel
* KiReleaseApcLockFromDpcLevel -> KiReleaseApcLockFromSynchLevel
* KiAcquireApcLockAtApcLevel -> KiAcquireApcLockRaiseToDpc
* KiAcquireProcessLock -> KiAcquireProcessLockRaiseToSynch
* KiReleaseProcessLockFromDpcLevel -> KiReleaseProcessLockFromSynchLevel
* KiAcquireDispatcherLockAtDpcLevel -> KiAcquireDispatcherLockAtSynchLevel
* KiReleaseDispatcherLockFromDpcLevel -> KiReleaseDispatcherLockFromSynchLevel
* Add some ASSERTs
2019-12-31 15:30:27 +01:00
Thomas Faber
3b430eefdd
[NTDLL_APITEST] Add a test for NtUnloadDriver.
2019-12-31 15:18:59 +01:00
Thomas Faber
787b2c7660
[APITESTS] Centrally define AllocateGuarded/FreeGuarded instead of duplicating them.
2019-12-31 15:18:41 +01:00
Thomas Faber
c904983b49
[NTOS:IO] Use UNICODE_STRING operations in IopUnloadDriver.
...
Fixes several overflow vulnerabilities.
2019-12-31 15:18:17 +01:00
Thomas Faber
2a91ea855a
[NTOS] Make RtlFindCharInUnicodeString available in the kernel.
2019-12-31 15:17:59 +01:00
Thomas Faber
053510467f
[NDK] RtlFindCharInUnicodeString is only available in user mode.
2019-12-31 15:17:53 +01:00
Katayama Hirofumi MZ
a385451380
[SDK][INCLUDE] Rename Gdiplus::Region::region as nativeRegion ( #2212 )
...
CORE-16585
2019-12-31 23:14:52 +09:00
Katayama Hirofumi MZ
8968b14235
[SDK][INCLUDE] Improve Gdiplus::Graphics ( #2211 )
...
CORE-16585
2019-12-31 20:40:16 +09:00
Katayama Hirofumi MZ
8ecbb44463
[SDK][INCLUDE] Rename Gdiplus::Graphics::graphics as nativeGraphics ( #2210 )
...
Make it w32api-compatible. CORE-16585
2019-12-31 19:24:59 +09:00
Katayama Hirofumi MZ
1a3c77dc2f
[SDK][INCLUDE] Move Gdiplus::TextureBrush codes ( #2208 )
...
Move the code into the place it should be in. CORE-16585
2019-12-31 17:53:35 +09:00
Timo Kreuzer
f944f3a6cd
[NTOS] In KeWaitFor*Object(s) assert that the current IRQL is SYNCH_LEVEL. not DISPATCH_LEVEL, since acquiring the dispatcher lock raises to SYNCH_LEVEL, which is != DISPATCH_LEVEL on x64 and SMP builds.
2019-12-31 09:43:14 +01:00
Katayama Hirofumi MZ
ad2c15524d
[SDK][INCLUDE] Implement Gdiplus::Pen ( #2207 )
...
CORE-16585
2019-12-31 17:11:38 +09:00
Katayama Hirofumi MZ
e797499dee
[SDK][INCLUDE] Rename Gdiplus::Pen::pen as nativePen ( #2206 )
...
CORE-16585
2019-12-31 15:45:57 +09:00
Katayama Hirofumi MZ
9f4d733d1f
[SDK][INCLUDE] Implement Gdiplus::Brush ( #2205 )
...
CORE-16585
2019-12-31 14:54:41 +09:00
Katayama Hirofumi MZ
dcc512a245
[SDK][INCLUDE] Rename Gdiplus::Brush::brush as nativeBrush ( #2204 )
...
Make it w32api-compatible. CORE-16585
2019-12-31 12:36:08 +09:00
Katayama Hirofumi MZ
39eceedd89
[SDK][INCLUDE] Improve Gdiplus::FontCollection ( #2203 )
...
CORE-16585
2019-12-31 11:37:46 +09:00
Katayama Hirofumi MZ
094960e386
[SDK][INCLUDE] Implement Gdiplus::ImageAttributes ( #2202 )
...
CORE-16585
2019-12-31 11:34:28 +09:00
Katayama Hirofumi MZ
5cc4c9b24d
[SDK][INCLUDE] Implement Gdiplus::CustomLineCap ( #2201 )
...
Implement Gdiplus::CustomLineCap and Gdiplus::AdjustableArrowCap. CORE-16585
2019-12-31 11:30:12 +09:00