Commit graph

60051 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto d3b2696104 [USER32]
- Call GetThreadConsoleDesktop of CONSRV if needed, in GetThreadDesktop (in case the process is a console app).
- Introduce two last-error helpers UserSetLast(NT)Error which work the same as the (Base)SetLast(NT)Error of kernel32, needed for CSR status errors etc...

[WINSRV]
- Improve the stub of SrvGetThreadConsoleDesktop (it needs to success, and atm. it always zeroes-out the returned console desktop handle).

svn path=/trunk/; revision=65513
2014-11-28 20:34:16 +00:00
Amine Khaldi 0abf72fdee [KERNEL32_WINETEST] Addendum to r65511.
svn path=/trunk/; revision=65512
2014-11-28 19:22:34 +00:00
Amine Khaldi 3be4abc045 [RTL] Import Wine commit f87767b by Piotr Caban: Handle ACTCTX_FLAG_ASSEMBLY_DIRECTORY_VALID flag when opening manifest in RtlCreateActivationContext.
svn path=/trunk/; revision=65511
2014-11-28 19:20:39 +00:00
Giannis Adamopoulos 198dcf7d19 [EXPLORER]
* Move some definitions in precomp.h

svn path=/trunk/; revision=65510
2014-11-27 21:11:29 +00:00
Giannis Adamopoulos 5c6b27436a Attempt to fix build.
svn path=/trunk/; revision=65509
2014-11-27 20:32:38 +00:00
Pierre Schweitzer 3c6889480c [FASTFAT]
Properly handle shared accesses on volume open.
No need to add the support for this in cleanup, it was already there.

svn path=/trunk/; revision=65508
2014-11-27 20:28:50 +00:00
Giannis Adamopoulos 98669c13f1 [HEADERS]
- Move definitions for DrawCaptionTemp to userundoc.h as it shouldn't be defined in the psdk
- Add browseui_undoc.h and move there the undocumented definitions for browseui
- Add comctl32_undoc.h and move there the undocumented definitions for comctl32
- Move undocumented definitions for shlwapi to shlwapi_undoc.h
- Add shellutils.h to contain helper macros and definitions that are nor per se undocumented.
- Cleanup internal definitions of explorer. Remove several temporary hacks. They were added at a time that these features were not implemented at all.

svn path=/trunk/; revision=65507
2014-11-27 20:27:19 +00:00
Amine Khaldi 4f8f6087e3 [CMAKE]
* Simplify compiling some single-source-file tools.

svn path=/trunk/; revision=65506
2014-11-27 19:09:07 +00:00
Amine Khaldi 62e8524e6e * Addendum to r65503 (consistent formatting).
svn path=/trunk/; revision=65505
2014-11-27 18:59:19 +00:00
James Tabor c3543f4697 [NtUser]
- Fix code duplication.

svn path=/trunk/; revision=65504
2014-11-27 18:35:57 +00:00
Giannis Adamopoulos 39569fc498 [ADVAPI32]
- Stub ElfRegisterEventSourceW, ElfReportEventW and ElfDeregisterEventSource. These are needed by windows sxs.dll, and sxs.dll is needed by windows basesrv.dll.

svn path=/trunk/; revision=65503
2014-11-27 14:21:43 +00:00
Ged Murphy 7a8c45344a [DEVICE_MANAGER]
- Test whether a driver is hidden or not by checking its status instead of the old hack of hiding certain classes which we deemed should be hidden.
- Add support for hiding devices and problem overlays when showing by connection. 
- We now show and hide identical devices when run alongside the Win8 MS device manager in both by type and by connection.
- Update the radio buttons when selecting the menu type.
- Add a manifest and use Win7 arrows on the TreeView.

svn path=/trunk/; revision=65502
2014-11-27 13:47:49 +00:00
Pierre Schweitzer 267881ff71 [FASTFAT]
Set clean shutdown bit on dismount

svn path=/trunk/; revision=65501
2014-11-27 06:16:21 +00:00
Amine Khaldi 9cfe36c5ca [SHELL] Reapply r65477 (rename explorer-new to explorer).
svn path=/trunk/; revision=65500
2014-11-26 23:24:26 +00:00
Amine Khaldi e73c9fb02d [SHELL] Reapply r65476 (rename explorer to explorer-old).
svn path=/trunk/; revision=65499
2014-11-26 23:22:44 +00:00
Amine Khaldi 2a2210d52b [SETUP]
* Set 32bpp as default bit depth instead of 16bpp. Suggestion and patch provided by Ismael Ferreras Morezuelas (swyter).
CORE-8826 #resolve #comment Committed in r65498. Gracias!

svn path=/trunk/; revision=65498
2014-11-26 23:17:02 +00:00
Amine Khaldi 96cdf37afe [SHELL] Move shlguid_undoc.h, shlobj_undoc.h and shlwapi_undoc.h to our includes folder instead of the PSDK one.
CORE-7330

svn path=/trunk/; revision=65497
2014-11-26 23:03:06 +00:00
Amine Khaldi 5c1a8109c8 * The Shell.. for a long time we dreamed of having a compatible, properly working rewrite, but it's easier said than done. Over the years this effort has been split into tasks, and this branch was the biggest overall. Now it's time to merge it back to trunk!
* This merge is also a chance to thank every single person involved directly and indirectly in this epic work, among them: Martin Fuchs for ReactOS explorer which we are respectfully retiring now, as it served the project so well over all these years. Thomas Bluemel (Thomas Weidenmueller aka w3seek) for his brave work on the shell, mainly his explorer_new. Andrew Hill for advancing the shell bringup with some impressive work. David Quintana, Giannis Adamopoulos and Huw Campbell for working as a solid team on making this branch a huge success, allowing the shell rewrite dream to finally become a reality. Again, thank you all!
* Merging this branch is not the end.. it's the beginning of some serious bug fixing based hopefully on the Community's continuous feedback.
* Finally, here are *some* of the highlights of this branch (simply put):

[BROWSEUI] Halfplement the address bar. Mostly implement the Favorites menu. Implement handling most hotkeys that should be handled by CShellBrowser. Fix various bugs.

[EXPLORER_NEW] Convert to C++ and use several wtl-like classes to simplify it. Fix several bugs and implement misc missing features.

[FILEBROWSER] A small exe file that opens a new file browser window in its own process. Tested to work in windows. It can be used to test our browseui.dll in windows.

[FONTS] A new marlett font.

[MSGINA] Add a proper shutdown dialog that's used when the user selects shutdown from the start menu (this is how it's done in Windows).

[RSHELL] A temporary module that hosts the implementation of the following classes needed for the shell: CMenuBand, CMenuDeskBar, CMenuSite, CMergedFolder, CStartMenu. These were implemented and tested in windows and for that reason they are still there. Should be moved in shell32 in the future.

[SHELL32] Reorganize files to isolate the ones that are not yet forked from wine. Fix various problems. Simplify the implementation of some shell folders. Implement filling in the file menu in the file browser.

[STOBJECT] A shell extension responsible for misc taskbar notification icons. So far only the sound icon is implemented. Adding this is necessary as the old explorer had the sound icon built in and deprecating it needs a proper solution for these notification icons.

[WIN32K] Fix several bugs that prevented the new start menu (that was implemented and tested in Windows) from functioning properly in ReactOS, mostly due to focus issues. Fix several shell notifications to behave more like in Windows.

* Tonight! We shall feast!
* And tomorrow the US guys shall feast again, on turkey! :p

CORE-7330

svn path=/trunk/; revision=65496
2014-11-26 19:49:18 +00:00
Ged Murphy d006975972 [DEVICE_MANAGER]
- On refresh, recurse the tree and delete all the Device Ids attached to each node
- Fix SAL and a few missing comments

svn path=/trunk/; revision=65495
2014-11-26 19:46:26 +00:00
Amine Khaldi 0b09ff9f77 * Addendum to r65483.
svn path=/branches/shell-experiments/; revision=65494
2014-11-26 18:02:55 +00:00
Ged Murphy 552b2ba55c [DEVICE_MANAGER]
- Add a class for managing the device view, and a class for managing the device objects.
- Implement listing devices by type and by connection.
- Add support for showing hidden devices
- Add support for showing unknown devices with overlay icons.
- implement showing the device properties via dounle click or hitting enter
- Add support for both Win7/8 as well as XP
- Make the code much more readable and maintainable. and easier to move to an mmc snapin if we ever get one.

I forgot this existed until today. I had some spare time so I decided to have a quick go at finishing it. Stick with the original one for now though, I ran out of time....

svn path=/trunk/; revision=65493
2014-11-26 17:21:45 +00:00
Amine Khaldi 129e820c19 * Sync up to trunk head (r65491).
svn path=/branches/shell-experiments/; revision=65492
2014-11-26 16:49:31 +00:00
James Tabor 8da4894280 [Explorer]
- Restore the original four virtual window support. See CORE-6151.

svn path=/trunk/; revision=65491
2014-11-26 15:29:51 +00:00
Timo Kreuzer 556eadf871 [WIN32K]
- Implement FLOATOBJ_bConvertToLong inline function that converts a FLOATOBJ to a long or returns FALSE if the value would overflow a LONG
- Remove underscore prefixes from inline FLOATOBJ functions and use it only on those that already exist as non-inline versions.
- Remove duplicated FLOATOBJ defines for non-x86
- Fail on integer overflow in XFORMOBJ_bXformFixPoints to avoid creating bogus coordinates.

svn path=/trunk/; revision=65490
2014-11-25 23:44:59 +00:00
Hermès Bélusca-Maïto fc2043573c Forgot this include...
svn path=/trunk/; revision=65489
2014-11-25 23:36:56 +00:00
Hermès Bélusca-Maïto 8b95166d91 [LSASS][SERVICES][WINLOGON]: As CSRSS and SMSS already, those apps should be marked as critical for the system. See http://www.geoffchappell.com/studies/windows/win32/ntdll/api/rtl/peb/setprocessiscritical.htm for more details.
svn path=/trunk/; revision=65488
2014-11-25 23:34:14 +00:00
James Tabor d1f8d55254 [Win32k]
- Fixes wine win.c:test_SetParent last ShowWindow test after popup dies.

svn path=/trunk/; revision=65487
2014-11-25 23:03:43 +00:00
Pierre Schweitzer fb11517f41 [NTFS]
Make the bound check more consistent and more accurate

svn path=/trunk/; revision=65486
2014-11-25 21:03:17 +00:00
Timo Kreuzer 3b807b3629 [FREELDR]
Move down MEMORY_MARGIN to 0x9A00 to fix boot on BIOSes with even larger EBDAs (see also r64945 and r65127), still leaving 48KB for the DISKREADBUFFER
CORE-8830 #resolve

svn path=/trunk/; revision=65485
2014-11-25 20:21:16 +00:00
James Tabor 6cabec82f6 [Win32k]
- Fix wine win.c:test_mouse_input:WM_COMMAND tests.

svn path=/trunk/; revision=65484
2014-11-25 19:56:40 +00:00
Amine Khaldi 861d261971 [EXPLORER][EXPLORER_NEW]
* Revert the renames (r65476 => r65478).
* We'll do these after we merge.

svn path=/branches/shell-experiments/; revision=65483
2014-11-25 16:17:58 +00:00
Amine Khaldi 9bdc095371 * Sync up to trunk head (r65481).
svn path=/branches/shell-experiments/; revision=65482
2014-11-25 12:43:36 +00:00
Timo Kreuzer 2e4fc079dc [PSDK/XDK]
Add back definitions that go lost in the last commit.
winnt.h is autogenerated, please do not modify it directly, but instead modify the related file in XDK and regenerate the headers from XDK.

svn path=/trunk/; revision=65481
2014-11-25 09:46:18 +00:00
Timo Kreuzer c6f12ff6ba [PSDK]
When I wrote "the compiler can optimize this better" I was obviously referring to a sane compiler like MSVC. Optimize (U)Int32x32To64 on x86 GCC builds by using __emul(u), since the native math results in horribly inefficient code doing 3 multiplications and some shifts.

svn path=/trunk/; revision=65480
2014-11-25 09:08:34 +00:00
David Quintana e047c09545 [EXPLORER-NEW]
* Top-Level windows have no parent background so it makes no sense to try to draw it.

svn path=/branches/shell-experiments/; revision=65479
2014-11-25 01:19:32 +00:00
David Quintana fd5c4836ad Oops. My bad.
svn path=/branches/shell-experiments/; revision=65478
2014-11-24 23:53:28 +00:00
David Quintana ff807f43d0 [EXPLORER-NEW]
* Rename the new explorer to take the now-vacant folder name, to match the output filename. Change 2/2

svn path=/branches/shell-experiments/; revision=65477
2014-11-24 23:10:11 +00:00
David Quintana e0e308711a [EXPLORER-OLD]
* Although the output filename was changed for almost as long as this branch has existed, I never bothered to actually rename the folders to reflect the output name. Change 1/2

svn path=/branches/shell-experiments/; revision=65476
2014-11-24 23:08:50 +00:00
Pierre Schweitzer 10d2eaf33b [NTFS]
Add the reparse point attribute definition

svn path=/trunk/; revision=65475
2014-11-24 20:02:40 +00:00
Pierre Schweitzer f2e863d929 [NTFS]
Warn about unimplemented sub-node browsing while looking into a MFT directory stream.
Might likely explain why we cannnot enumerate all the files on a Win7 volume.

svn path=/trunk/; revision=65474
2014-11-24 20:01:34 +00:00
Pierre Schweitzer d23756ccb7 [NTFS]
ASSERT -> NT_VERIFY

Spotted by Thomas. Thanks :-)

svn path=/trunk/; revision=65473
2014-11-24 19:54:22 +00:00
James Tabor 620eec28ea [NtUser]
- Synchronize mouse messages. Part II
- Dedicated to Giannis Adamopoulos and Amine Khaldi.
- Additional fixes are added.
- This should be more accurate, based on "Hit Testing: Which HWND is the mouse over?":
http://blogs.msdn.com/b/dwayneneed/archive/2008/09/08/transparent-windows-in-wpf.aspx
- Note: Older FireFox menu item hilite select seem to work now, do not need to keep moving the mouse to keep it hilited to be selected.
- Test results: https://reactos.org/sites/all/modules/reactos/testman/compare.php?ids=33709,33710,33713

svn path=/trunk/; revision=65472
2014-11-24 02:50:18 +00:00
Hermès Bélusca-Maïto 398b0a3c4f [CONSRV]: Implement CREATE_NO_WINDOW support.
svn path=/trunk/; revision=65471
2014-11-23 23:04:45 +00:00
Pierre Schweitzer 1dc01e0746 [NTFS]
- Fix $FILENAME_ATTRIBUTE definition to allow reading reparse points tag
- Add missing file attribute (reparse point)

svn path=/trunk/; revision=65470
2014-11-23 20:52:59 +00:00
Hermès Bélusca-Maïto f43bb8d7df [TASKMGR]
- Show programs command line in taskmgr.
  Patch by Ismael Ferreras Morezuelas with minor modifications by me.
- int nMaxCount --> ULONG nMaxCount (that makes everything clearer and removes MSVC warnings).
CORE-5467 #resolve #comment Feature committed in revision 65469, cheers ;)

svn path=/trunk/; revision=65469
2014-11-23 20:10:15 +00:00
Pierre Schweitzer 4a61f5ee5b [NTFS]
- Implement NtfsGetPositionInformation(), NtfsGetBasicInformation()
- Add a fixme in NtfsGetStandardInformation() regarding the number of links

svn path=/trunk/; revision=65468
2014-11-23 19:53:16 +00:00
Hermès Bélusca-Maïto 2fb9a4573b Fixup a potential division by zero (that happens anyway in my tests).
svn path=/trunk/; revision=65467
2014-11-23 19:16:41 +00:00
Hermès Bélusca-Maïto 734795e23e [TASKMGR]
Improve formatting memory size usage in the status bar of Task Manager.
Patch by Ismael Ferreras Morezuelas (swyter).
CORE-8810 #resolve #comment Committed in r65466, thanks d:^D

svn path=/trunk/; revision=65466
2014-11-23 18:36:25 +00:00
Hermès Bélusca-Maïto 60205c7b0b [WIN32K]: Use the logon process ID instead of a full win32k process object, it simplifies code in some parts.
svn path=/trunk/; revision=65465
2014-11-23 16:09:00 +00:00
Hermès Bélusca-Maïto 72074af697 Whitespace fixes.
svn path=/trunk/; revision=65464
2014-11-23 15:57:13 +00:00