Commit graph

58423 commits

Author SHA1 Message Date
Thomas Faber a42c7bc31b [SHELL32]
- Fix ITEMIDLIST typing in IShellFolder/IShellFolder2 implementations
CORE-8441

svn path=/trunk/; revision=63889
2014-08-15 10:33:54 +00:00
Thomas Faber f46c30d548 [SHELL32]
- Don't fail on NULL array pointer if count is zero
CORE-8443 #resolve

svn path=/trunk/; revision=63887
2014-08-14 22:43:10 +00:00
Hermès Bélusca-Maïto 6a85d82141 Fourth partial merge of the condrv_restructure branch, with fonts improvements.
CORE-8439 #resolve #comment r63885 merged to trunk in r63886.

svn path=/trunk/; revision=63886
2014-08-14 20:23:03 +00:00
Hermès Bélusca-Maïto 21b5377d35 [KERNEL32]
OpenConsoleW was implemented :P

[CONSOLE.CPL][CONSRV]
Create all the fonts needed at console startup, and then just select what's needed when fonts attributes need to be changed at run-time.

[CONSOLE.CPL][CONSRV]
- HACKFIX: Temporary use FW_NORMAL instead of FW_DONTCARE as default font weight (in ReactOS, FW_DONTCARE makes fonts bold by default, instead of normal)
- Use bold fonts instead of the underlined ones for underlined fonts in the terminal.

Timo, FIX THE FONTS !!!!!!!!!! :P

CORE-8439 #comment Should be fixed in revision 63885.

svn path=/branches/condrv_restructure/; revision=63885
2014-08-14 20:10:00 +00:00
Thomas Faber 6acec73b44 [SHELL32]
- Correctly manage object lifetime in CDefaultContextMenu. Members of DEFCONTEXTMENU need to be referenced or cloned in order to keep them.
CORE-8430 #resolve

svn path=/trunk/; revision=63884
2014-08-14 19:47:45 +00:00
Thomas Faber ccacbf8050 [NPFS]
- Fix list walk in NpCancelWaiter -- we cannot access the list entry after using RemoveEntryList on it
- Make the logic in NpCancelWaiter more readable
CORE-8442 #resolve

svn path=/trunk/; revision=63883
2014-08-14 19:35:00 +00:00
Thomas Faber 124d892d48 [SHELL32]
- Use correct prototype for IFolderView::SelectAndPositionItems in CDefView

svn path=/trunk/; revision=63882
2014-08-14 13:26:02 +00:00
Thomas Faber b8b0cb9b6f [PSDK]
- Fix some ITEMIDLIST types in IShellFolder
CORE-8441

svn path=/trunk/; revision=63881
2014-08-14 13:21:32 +00:00
Thomas Faber 9ad857369a [WIN32K:NTUSER]
- Assert that the thread's sent message queue matches change bits in UserDbgAssertThreadInfo. Suggested by Giannis.
CORE-7013

svn path=/trunk/; revision=63880
2014-08-14 07:46:59 +00:00
Jérôme Gardou 3f1a4576dd [CMAKE]
- Properly serve reactos.cab dependencies - try 2
CORE-8435 #comment this should do it, please retest. Regarding the bot problem, touching boot/bootdata/packages/reactos.dff forces regenerating reactos.inf and reactos.cab

svn path=/trunk/; revision=63878
2014-08-13 16:30:52 +00:00
Hermès Bélusca-Maïto e8874e08eb Third partial merge of the condrv_restructure branch, including reverse video (rev.63865), underline (rev.63864), fonts changing (rev.63863) plus some resource fixes, RegisterConsoleVDM (rev.63849) and some code refactoring, plus WriteConsoleOutput fix (rev.63841) for Far Manager et al.
CORE-5006 CORE-6397 CORE-8424 #comment Fixes from the condrv_restructure branch (rev.63841) merged back to trunk in revision 63877.

svn path=/trunk/; revision=63877
2014-08-12 19:43:32 +00:00
Hermès Bélusca-Maïto de799f57dc Sync to trunk revision 63875.
svn path=/branches/condrv_restructure/; revision=63876
2014-08-12 18:49:17 +00:00
Thomas Faber c0d467161a [WIN32K:NTUSER]
- Clear appropriate message bits when removing a sent message in FindRemoveAsyncMsg. Thanks to Giannis.
- Fix list walk in FindRemoveAsyncMsg
CORE-7013 #resolve

svn path=/trunk/; revision=63875
2014-08-12 15:50:27 +00:00
Hermès Bélusca-Maïto 73cdd53b1d [CONSRV]: Still some code refactoring....
svn path=/branches/condrv_restructure/; revision=63874
2014-08-12 14:59:13 +00:00
Thomas Faber f6304a30dc [SPEC2DEF]
- In GCC builds, actually import by ordinal if -ordinal is specified. Found by Robert.

svn path=/trunk/; revision=63873
2014-08-12 13:21:38 +00:00
Giannis Adamopoulos 8094b5e493 [shell32]
- Marshall interface pointers between apartments correctly 
- Patch by Huw Campbell 

svn path=/trunk/; revision=63872
2014-08-12 10:29:40 +00:00
Thomas Faber e70cc781b3 [RPCRT4]
- Correctly check for in-buffer memory in PointerFree. Fixes invalid free e.g. when calling StartService without service arguments

svn path=/trunk/; revision=63871
2014-08-12 07:52:29 +00:00
Thomas Faber 42f34d3788 [KMTESTS:RTL]
- Fix a stack buffer overflow in the RtlMemory test

svn path=/trunk/; revision=63870
2014-08-12 07:47:08 +00:00
Hermès Bélusca-Maïto d9e86f8a78 [CONSRV]: Continuing 3/X, a small step for a brighter future, maybe!
svn path=/branches/condrv_restructure/; revision=63868
2014-08-11 20:55:50 +00:00
Hermès Bélusca-Maïto afd30b0e36 [CONSRV]: Continuing 2/X
svn path=/branches/condrv_restructure/; revision=63867
2014-08-11 20:39:06 +00:00
Hermès Bélusca-Maïto 991c1f0e88 [CONSRV]: Code refactoring 1/X (and move VDM support to where it belongs).
svn path=/branches/condrv_restructure/; revision=63866
2014-08-11 20:28:40 +00:00
Hermès Bélusca-Maïto 6671999847 [CONSRV]: Support reverse video bit COMMON_LVB_REVERSE_VIDEO
svn path=/branches/condrv_restructure/; revision=63865
2014-08-11 15:37:01 +00:00
Hermès Bélusca-Maïto 1581bcfc02 [CONSRV]: Support underline code COMMON_LVB_UNDERSCORE in the console via CreateFont* API.
svn path=/branches/condrv_restructure/; revision=63864
2014-08-11 14:38:07 +00:00
Hermès Bélusca-Maïto 23f16979ac [CONSOLE.CPL][CONSRV]
- Remove the unuseful UseRasterFonts member in console properties structure.
- Fix my FontSize.X / FontSize.Y mixing (X is width, Y is height) that I introduced in revision 63819.
- We are now able to change the console font via the console props control panel applet (work in progress, but it works!)

svn path=/branches/condrv_restructure/; revision=63863
2014-08-11 13:35:33 +00:00
Hermès Bélusca-Maïto 8e73c54f79 [CONSRV]: Some handle reworking commit, that might look like ridiculous at first, but is just the start of something bigger.
svn path=/branches/condrv_restructure/; revision=63862
2014-08-11 13:31:22 +00:00
Thomas Faber 29813c1b0b [SYSSETUP]
- Gracefully handle ConvertStringSidToSid failures in InstallBuiltinAccounts and InstallPrivileges. Fixes invalid frees in second stage.

svn path=/trunk/; revision=63861
2014-08-11 12:45:32 +00:00
Thomas Faber 0d5a8d0594 [CABMAN]
- Don't crash when a directory is specified instead of a file list (i.e. specified_files.root.normalized_name == NULL)

svn path=/trunk/; revision=63860
2014-08-11 08:05:33 +00:00
Thomas Faber a4d36a3511 [USETUP]
- Don't access next block if there is none in CabinetExtractFile.

svn path=/trunk/; revision=63859
2014-08-10 21:51:29 +00:00
Hermès Bélusca-Maïto e5b5525a8a Sync to trunk revision 63857.
svn path=/branches/condrv_restructure/; revision=63858
2014-08-10 21:33:21 +00:00
Hermès Bélusca-Maïto 0d0a2740eb [TRANSLATIONS]
Same remark as for revision 63856, but for "Button"!!

svn path=/trunk/; revision=63857
2014-08-10 21:19:34 +00:00
Hermès Bélusca-Maïto c4444b2e91 [TRANSLATIONS]
To Albanian translators!!
Be careful, the "Static" string in CONTROL resource controls, is the name of the control class, and as such must NOT be translated!! (see http://msdn.microsoft.com/en-us/library/windows/desktop/aa380911(v=vs.85).aspx )

svn path=/trunk/; revision=63856
2014-08-10 21:06:49 +00:00
Hermès Bélusca-Maïto 1f1f0f9d55 [CONSOLE.CPL]: Fix french resource.
svn path=/branches/condrv_restructure/; revision=63855
2014-08-10 20:52:36 +00:00
Thomas Faber c38a96f98b [SYSSETUP]
- Avoid logging the administrator password
CORE-8019 #resolve

svn path=/trunk/; revision=63854
2014-08-10 19:25:52 +00:00
Thomas Faber 6af1d6e6c8 [BROWSEUI]
- CComObject cannot be a class member and must be allocated using new. Fixes invalid free.

svn path=/trunk/; revision=63853
2014-08-10 18:39:05 +00:00
Thomas Faber faf7e3ec94 [KERNEL32]
- Fix an invalid free in DefineDosDeviceW, found by kernel32_apitest:dosdev

svn path=/trunk/; revision=63852
2014-08-10 16:23:05 +00:00
Thomas Faber 39f3c7d584 [KERNEL32]
- Fix some style issues in DefineDosDevice

svn path=/trunk/; revision=63851
2014-08-10 16:20:43 +00:00
Hermès Bélusca-Maïto 7a5ce23147 [CONSOLE.CPL]: Add LBS_HASSTRINGS to font listboxes.
svn path=/branches/condrv_restructure/; revision=63850
2014-08-10 15:27:24 +00:00
Hermès Bélusca-Maïto cc85bc57af [KERNEL32][CONSRV]: Implement a basic RegisterConsoleVDM (see revision 62371 for more details).
svn path=/branches/condrv_restructure/; revision=63849
2014-08-09 19:47:40 +00:00
Hermès Bélusca-Maïto a56fcb9ae3 [NTVDM]: Studying ntvdm, we can find the significance of some of the parameters. Others seem unused.
svn path=/trunk/; revision=63848
2014-08-09 18:48:31 +00:00
Aleksandar Andrejevic de7b63edc1 [SHELL32]
- Greatly optimize file icon retrieval by reducing the times we try to access the disk.
- Store icons in a binary tree in the shell icon cache for faster retrieval.
Patch by Huw Campbell committed at the request of Giannis Adamopoulos.


svn path=/trunk/; revision=63845
2014-08-09 13:40:13 +00:00
Hermès Bélusca-Maïto f9a6eb7bc4 [NTVDM]: Add a compile-time-defined switch to be able to use the RegisterConsoleVDM API of ReactOS/Windows, or an emulated one.
svn path=/trunk/; revision=63844
2014-08-09 13:22:50 +00:00
Hermès Bélusca-Maïto 3a6aa828e4 Fix a typo.
svn path=/trunk/; revision=63843
2014-08-09 10:51:22 +00:00
Aleksandar Andrejevic 9065679ba7 [NTVDM]
Start implementing mouse support.


svn path=/trunk/; revision=63842
2014-08-09 01:39:28 +00:00
Hermès Bélusca-Maïto 636d4cf0ce [KERNEL32][CONSRV]
For WriteConsoleOutput API only!! Diagnosed with ApiMonitor from Rohitab.

If one tries to write a too large buffer (>= 80*198 CHAR_INFO cells), the CsrAllocateCaptureBuffer API helper fails, because it uses the non-growable CSR port heap of fixed size 64kB.
Since many applications use the API with large buffers (for example, Far Manager <= 1.70, the Windows XTree app http://textmode.netne.net/Extreme.html , ...) and maybe NTVDM,
Windows (and hence ReactOS for compatibility reasons) allocates a buffer in the process' heap (and not in the CSR port heap via the CSR capture API), so that the big buffer allocation
should work. Then, to be able to access it, CSR needs to call NtReadVirtualMemory for capturing the buffer.

CORE-5006 CORE-6397 CORE-8424 #resolve

svn path=/branches/condrv_restructure/; revision=63841
2014-08-08 17:06:28 +00:00
Sylvain Petreolle 8a230af1a7 [WIN32SS]
Fix new cursoricon implementation build.
Dedicated to Jim and Jérome.


svn path=/trunk/; revision=63840
2014-08-08 16:14:38 +00:00
Sylvain Petreolle 2a1a26424e [WIN32SS]
Fix trace.

svn path=/trunk/; revision=63839
2014-08-08 16:12:23 +00:00
Sylvain Petreolle 5db0452e0a [WIN32K]
Formatting only.

svn path=/trunk/; revision=63838
2014-08-08 16:04:08 +00:00
Jérôme Gardou b51defb8ad [CMAKE]
- separate the custom target and the custom command generating reactos.cab, so that it isn't regenerated each time a bootcd is built
Note to make user: I tried a hack so that the sequence 'make module/fast reactos_cab/fast bootcd/fast' still works, but this is untested. Please use ninja if you really want fast dependency resolution.

svn path=/trunk/; revision=63837
2014-08-07 18:20:46 +00:00
Jérôme Gardou 16623e02fa [CHARMAP]
- Correctly include local header

svn path=/trunk/; revision=63835
2014-08-07 15:19:32 +00:00
Hermès Bélusca-Maïto fe54ef7132 Second partial merge of the condrv_restructure branch, including additions from revisions 63818, 63819, 63820 and 63831.
CORE-7931 #comment Second partial merge of the condrv_restructure branch in revision 63834.

svn path=/trunk/; revision=63834
2014-08-07 13:16:49 +00:00