- On Win2k3, the EXIT_(ROS)_EX csr message has 3 parameters, instead of 2 (as on win2k), and the dwReserved is in fact unused.
[USERSRV]
- Add CSR shutdown callback UserClientShutdown (stub).
[CONSRV|USERSRV]
- The CSR shutdown callbacks are just stubs currently.
Part 5/X
CORE-8322
svn path=/trunk/; revision=65528
- Add a flag to enable (or disable depends on your reading ;-)) the VPB swapout process for volume umount.
- By default, disable it for MSVC builds.
This *might* lolfix the MSVC builds.
Just for the record, we also have a bug in the GCC builds but it doesn't seem to show up.
The main issue is that after formatting, we close handle to the volume, and IRP_MJ_CLEANUP is properly received and initiates a bit of dismount.
But then, the IRP_MJ_CLOSE is never received (why????) and thus, dismount cannot properly end.
This is a real & serious issue.
svn path=/trunk/; revision=65527
Fix a FIXME in fastfat:
- Implement support for device buffers flush in VfatFlushVolume().
Unlike Windows SDK, we don't divert the current IRP to pass it to storage device. Here, we allocate a new IRP and call the device so that it flushes buffers.
svn path=/trunk/; revision=65526
If you decrease handles count on cleanup, don't forget to increase it on create.
This fixes sharing violation on ReactOS installation with IopParseDevice hack disabled.
svn path=/trunk/; revision=65525
* Make use of the resource IDs for all paths that need localizing. It was working in the past but was broken by re-synchronizing the code with WINE, which has unlocalized hardcoded strings instead.
This fixes the shortcuts not appearing in other languages.
* Fix the folder for Administrative tools in spanish language
[USERENV]
* Fix spanish folder names to match our shell32 and Windows.
TRANSLATORS: If your language is broken, ensure that the paths in userenv and shell32 resources match!
CORE-8834 #resolve #comment Should be fixed in trunk r65524, thanks for reporting. If this problem still happens, speak with your language's translator or provide your own patch.
svn path=/trunk/; revision=65524
* Brought to you by Ismael Ferreras Morezuelas (swyter) with consistency formatting changes by me.
CORE-8848 #resolve #comment Committed the changes in r65523. Gracias!
svn path=/trunk/; revision=65523
- Move to an appropriate file, and correctly implement (i.e. via CSR call to USERSRV) EndTask.
[USERSRV]
- Hackplement SrvEndTask using our old code.
Part 4/X
CORE-8322
svn path=/trunk/; revision=65521
So...
... first of all NtUserQueryInformationThread takes only 4 parameters in Win2k3 so do it as well...
... and since we claim at being compatible with Win2k3 (and not XP), one **MUST** review **ALL** our win32k exports, in win32ss/w32ksvc.db database first, and then in our w32kdll apitests !!!!!
But I won't do it !
svn path=/trunk/; revision=65519
- Revert 65431, it seems to be breaking more than it fixes. Process Explorer will break again, working on a better way to fix this. See CORE-7447.
svn path=/trunk/; revision=65514
- Call GetThreadConsoleDesktop of CONSRV if needed, in GetThreadDesktop (in case the process is a console app).
- Introduce two last-error helpers UserSetLast(NT)Error which work the same as the (Base)SetLast(NT)Error of kernel32, needed for CSR status errors etc...
[WINSRV]
- Improve the stub of SrvGetThreadConsoleDesktop (it needs to success, and atm. it always zeroes-out the returned console desktop handle).
svn path=/trunk/; revision=65513
- Move definitions for DrawCaptionTemp to userundoc.h as it shouldn't be defined in the psdk
- Add browseui_undoc.h and move there the undocumented definitions for browseui
- Add comctl32_undoc.h and move there the undocumented definitions for comctl32
- Move undocumented definitions for shlwapi to shlwapi_undoc.h
- Add shellutils.h to contain helper macros and definitions that are nor per se undocumented.
- Cleanup internal definitions of explorer. Remove several temporary hacks. They were added at a time that these features were not implemented at all.
svn path=/trunk/; revision=65507
- Stub ElfRegisterEventSourceW, ElfReportEventW and ElfDeregisterEventSource. These are needed by windows sxs.dll, and sxs.dll is needed by windows basesrv.dll.
svn path=/trunk/; revision=65503
- Test whether a driver is hidden or not by checking its status instead of the old hack of hiding certain classes which we deemed should be hidden.
- Add support for hiding devices and problem overlays when showing by connection.
- We now show and hide identical devices when run alongside the Win8 MS device manager in both by type and by connection.
- Update the radio buttons when selecting the menu type.
- Add a manifest and use Win7 arrows on the TreeView.
svn path=/trunk/; revision=65502
* Set 32bpp as default bit depth instead of 16bpp. Suggestion and patch provided by Ismael Ferreras Morezuelas (swyter).
CORE-8826 #resolve #comment Committed in r65498. Gracias!
svn path=/trunk/; revision=65498
* This merge is also a chance to thank every single person involved directly and indirectly in this epic work, among them: Martin Fuchs for ReactOS explorer which we are respectfully retiring now, as it served the project so well over all these years. Thomas Bluemel (Thomas Weidenmueller aka w3seek) for his brave work on the shell, mainly his explorer_new. Andrew Hill for advancing the shell bringup with some impressive work. David Quintana, Giannis Adamopoulos and Huw Campbell for working as a solid team on making this branch a huge success, allowing the shell rewrite dream to finally become a reality. Again, thank you all!
* Merging this branch is not the end.. it's the beginning of some serious bug fixing based hopefully on the Community's continuous feedback.
* Finally, here are *some* of the highlights of this branch (simply put):
[BROWSEUI] Halfplement the address bar. Mostly implement the Favorites menu. Implement handling most hotkeys that should be handled by CShellBrowser. Fix various bugs.
[EXPLORER_NEW] Convert to C++ and use several wtl-like classes to simplify it. Fix several bugs and implement misc missing features.
[FILEBROWSER] A small exe file that opens a new file browser window in its own process. Tested to work in windows. It can be used to test our browseui.dll in windows.
[FONTS] A new marlett font.
[MSGINA] Add a proper shutdown dialog that's used when the user selects shutdown from the start menu (this is how it's done in Windows).
[RSHELL] A temporary module that hosts the implementation of the following classes needed for the shell: CMenuBand, CMenuDeskBar, CMenuSite, CMergedFolder, CStartMenu. These were implemented and tested in windows and for that reason they are still there. Should be moved in shell32 in the future.
[SHELL32] Reorganize files to isolate the ones that are not yet forked from wine. Fix various problems. Simplify the implementation of some shell folders. Implement filling in the file menu in the file browser.
[STOBJECT] A shell extension responsible for misc taskbar notification icons. So far only the sound icon is implemented. Adding this is necessary as the old explorer had the sound icon built in and deprecating it needs a proper solution for these notification icons.
[WIN32K] Fix several bugs that prevented the new start menu (that was implemented and tested in Windows) from functioning properly in ReactOS, mostly due to focus issues. Fix several shell notifications to behave more like in Windows.
* Tonight! We shall feast!
* And tomorrow the US guys shall feast again, on turkey! :p
CORE-7330
svn path=/trunk/; revision=65496
- On refresh, recurse the tree and delete all the Device Ids attached to each node
- Fix SAL and a few missing comments
svn path=/trunk/; revision=65495
- Add a class for managing the device view, and a class for managing the device objects.
- Implement listing devices by type and by connection.
- Add support for showing hidden devices
- Add support for showing unknown devices with overlay icons.
- implement showing the device properties via dounle click or hitting enter
- Add support for both Win7/8 as well as XP
- Make the code much more readable and maintainable. and easier to move to an mmc snapin if we ever get one.
I forgot this existed until today. I had some spare time so I decided to have a quick go at finishing it. Stick with the original one for now though, I ran out of time....
svn path=/trunk/; revision=65493
- Implement FLOATOBJ_bConvertToLong inline function that converts a FLOATOBJ to a long or returns FALSE if the value would overflow a LONG
- Remove underscore prefixes from inline FLOATOBJ functions and use it only on those that already exist as non-inline versions.
- Remove duplicated FLOATOBJ defines for non-x86
- Fail on integer overflow in XFORMOBJ_bXformFixPoints to avoid creating bogus coordinates.
svn path=/trunk/; revision=65490
Move down MEMORY_MARGIN to 0x9A00 to fix boot on BIOSes with even larger EBDAs (see also r64945 and r65127), still leaving 48KB for the DISKREADBUFFER
CORE-8830 #resolve
svn path=/trunk/; revision=65485
Add back definitions that go lost in the last commit.
winnt.h is autogenerated, please do not modify it directly, but instead modify the related file in XDK and regenerate the headers from XDK.
svn path=/trunk/; revision=65481