Commit graph

65118 commits

Author SHA1 Message Date
Hermès Bélusca-Maïto e47d8784d4 [SHELL32]: Proper fix for CORE-9837 (see r68283): "Get run icon from shell32", including partial revert and code closer to Wine.
CORE-9837 #comment Proper fix in r70723

svn path=/trunk/; revision=70723
2016-02-13 00:16:19 +00:00
Hermès Bélusca-Maïto 992af1e421 [UNDOCSHELL]: Add descriptions for the RunFileDlg shell function (ripped off taskmgr's run.h file).
svn path=/trunk/; revision=70722
2016-02-12 23:50:33 +00:00
Hermès Bélusca-Maïto 445d808604 Whitespace fix only.
svn path=/trunk/; revision=70721
2016-02-12 23:46:14 +00:00
Hermès Bélusca-Maïto b4741c36f4 [WIN32K]: Since r7146 (12 years ago) we correctly set a small Close button for tool windows. WARNING: Please do NOT sync this piece of code with Wine! Ours behave better when one changes the values of SM_CXSMSIZE / SM_CYSMSIZE.
svn path=/trunk/; revision=70720
2016-02-12 23:10:59 +00:00
Hermès Bélusca-Maïto fe53065a4e [UXTHEME]
Temporarily disable the WS_EX_DLGMODALFRAME test whose presence broke opening the system menu when the user clicks on the window caption icon.
This half-broken DefWndNCHitTest comes from user32; see r70718 for more details.

svn path=/trunk/; revision=70719
2016-02-12 22:12:51 +00:00
Hermès Bélusca-Maïto e02c739f6d [WIN32K][USER32]
- Both functions UserGetInsideRectNC and NC_GetInsideRect are the same: remove the redundant code and keep only NC_GetInsideRect.
- Move default WM_NCHITTEST into kernel side, getting rid of half-broken DefWndNCHitTest in user32. Note that we use a DefWndNCHitTest version almost unmodified in uxtheme.dll.
  I did this move also because otherwise, we didn't correctly checked for the presence of the window system menu icon. On the contrary the function GetNCHitEx (obviously taken from Wine's NC_HandleNCHitTest) correctly checks for this.

James, please review!

svn path=/trunk/; revision=70718
2016-02-12 22:10:29 +00:00
Hermès Bélusca-Maïto 6bed745b3d [UXTHEME]: Use a similar working logic to display (or not) the icon (or the default one) to windows/dialogs, taking in particular their exstyle WS_EX_DLGMODALFRAME in particular.
Dedicated to Jared Smudde.
CORE-9635 #resolve #comment A better fix was committed in r70717 to match r70715

svn path=/trunk/; revision=70717
2016-02-12 19:07:29 +00:00
Hermès Bélusca-Maïto 492e14a055 This stuff should not have been committed.
svn path=/trunk/; revision=70716
2016-02-12 17:37:41 +00:00
Hermès Bélusca-Maïto c98d80baf0 [WIN32K]: Fix display of window title icon for dialogs having the WS_EX_DLGMODALFRAME style.
CORE-10850 #resolve
CORE-10437 #comment The real fix was committed in r70715.

svn path=/trunk/; revision=70715
2016-02-12 17:31:19 +00:00
Hermès Bélusca-Maïto ed391467a5 [SYSICON]: Whitespace fixes only.
svn path=/trunk/; revision=70714
2016-02-12 17:21:32 +00:00
Hermès Bélusca-Maïto 3a3ddebe62 [WIN32SS]
- Fix orthograph
- Mention in the code that some stuff are hacks & need to be fixed.
- Add parentheses around bit checks.

svn path=/trunk/; revision=70713
2016-02-12 16:40:36 +00:00
Hermès Bélusca-Maïto 921fdfd85b But do not compile by default those extra tests. Colin, it is curious that when rosautotest encounters a test EXE that it doesn't like, it just completely bails out the test session. This should be fixed/behaviour improved.
svn path=/trunk/; revision=70712
2016-02-12 15:24:30 +00:00
Hermès Bélusca-Maïto 6d2ccc456c I forgot this file.
svn path=/trunk/; revision=70711
2016-02-12 15:12:54 +00:00
Hermès Bélusca-Maïto 4d930e07e8 [ROSTESTS]: Add "sysicon" test back, and augment it.
svn path=/trunk/; revision=70710
2016-02-12 15:10:59 +00:00
Hermès Bélusca-Maïto 0455477600 [FREELDR]: Continue removing code not related to freeldr entry-point from entry.S, and adopt source file names for i386 architecture similar to those of amd64.
svn path=/trunk/; revision=70709
2016-02-11 22:33:03 +00:00
Eric Kohl 6c834bbca5 [USERINIT]
Make the language selection work as expected.

svn path=/trunk/; revision=70708
2016-02-11 20:00:46 +00:00
Hermès Bélusca-Maïto ba1d28dcc8 [CMLIB]: Implement CmpFreeSecurityDescriptor. See r70609.
CORE-10793 CORE-10796

svn path=/trunk/; revision=70707
2016-02-10 22:28:12 +00:00
Hermès Bélusca-Maïto 1eb1638e2e [CMLIB]
- Fix some comments.
- Simplify code.
- Add a missing check for hive exit nodes when deleting cells.

svn path=/trunk/; revision=70706
2016-02-10 22:18:20 +00:00
Hermès Bélusca-Maïto 4191c57d0f [CMLIB]: fix a typo in the constant name.
svn path=/trunk/; revision=70705
2016-02-10 22:04:57 +00:00
Robert Naumann ed74c8abe7 [EXPLORER] Yet another bitmap resource fix. By Jared Smudde. CORE-10781
svn path=/trunk/; revision=70704
2016-02-08 23:30:49 +00:00
Robert Naumann ccac5e7ee3 [EXPLORER] Stubplement Customize Notifications dialog. Patch by Jared Smudde. CORE-10725
svn path=/trunk/; revision=70703
2016-02-08 23:16:36 +00:00
Eric Kohl 84a8d432f8 Add missing newline!
svn path=/trunk/; revision=70702
2016-02-08 14:51:52 +00:00
Eric Kohl 8f032fb669 [REACTOS]
Add columns and column titles to the partition listview.

svn path=/trunk/; revision=70701
2016-02-08 14:41:09 +00:00
Eric Kohl b8c5994f8f [REACTOS]
Remove remaining groupboxes from wizard pages.

svn path=/trunk/; revision=70700
2016-02-07 21:06:31 +00:00
Eric Kohl 2104e66991 [USETUP]
Danish translation for usetup.
Patch by Lars Rasmussen.
CORE-10812 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=70699
2016-02-07 20:24:18 +00:00
Eric Kohl 6592d7d424 [WLANSVC]
Add the version information for the WLAN Service.
Patch by Lee Schroeder.
CORE-10836 #resolve #comment Thanks a lot!

svn path=/trunk/; revision=70698
2016-02-07 20:08:08 +00:00
Thomas Faber ba31c44d1e [KERNEL32]
- Hide STATUS_SXS_INVALID_ACTCTXDATA_FORMAT in BasepProbeForDllManifest and fake a manifest not found status instead. Windows's RtlCreateActivationContext will always return this code since we call it with a completely invalid structure. Should fix boot on VMware-Hybrid testbot.
CORE-10843

svn path=/trunk/; revision=70697
2016-02-07 09:38:47 +00:00
Thomas Faber cab26c80f1 [LWIP]
- Don't use the already over-used LWIP_TAG for lookaside list allocations

svn path=/trunk/; revision=70696
2016-02-06 22:11:03 +00:00
Hermès Bélusca-Maïto 9a5b681194 [FREELDR]
- Whitespace fixes only in the disk code.
- Fix the name of the EXT2 FS driver.
- Move I/O initialization after Mm init so that we can properly read disk data into the correct buffers if needed (and I will need that).

svn path=/trunk/; revision=70695
2016-02-05 23:47:35 +00:00
Hermès Bélusca-Maïto 1d42ae7dce Order of definitions is still important!
svn path=/trunk/; revision=70694
2016-02-05 21:15:25 +00:00
Hermès Bélusca-Maïto 7a8e098eb7 [FREELDR]: Add source file header to scsiport.c; move structure definitions together.
svn path=/trunk/; revision=70693
2016-02-05 21:12:53 +00:00
Hermès Bélusca-Maïto c62cd02730 [FREELDR]
Start splitting FreeLdr in the same spirit as our new UEFI boot manager/loader: split into a boot library, the boot manager code, and the NT loader.
- The boot library provides the basic support (read INI/INF files, memory management, debugging, ARC compatibility/emulation, ...).
- The boot manager code is FreeLdr proper.
- The NT loader is used for loading Windows or ReactOS. Because of that fact I rename its directory "windows" into "NTLDR" to underline the fact it can load NT-type OSes (more exactly version 5.x), to which both Windows 2k/XP/2k3 and ReactOS belong. The APIs will certainly be renamed "NtLdrXXX" instead of "WinLdrXXX".
- The general PE loader is put into the boot library since it is needed also by FreeLdr proper to be able to load SCSI drivers (on x86/64/... architectures; on ARC systems SCSI support is automatically provided).

svn path=/trunk/; revision=70692
2016-02-05 00:17:33 +00:00
Eric Kohl ee1d2a2874 Used a better check for the root item of the treeview. The listview, status bar and address bar should only get wiped when the user selects the root item of the treeview.
CORE-10803 #comment Retest please!

svn path=/trunk/; revision=70691
2016-02-04 23:50:36 +00:00
Hermès Bélusca-Maïto 10bff42ab6 Remove redundant extra terminating ';' in all of our C code.
svn path=/trunk/; revision=70690
2016-02-04 20:42:07 +00:00
Hermès Bélusca-Maïto 02e447d135 [CODE]: s/interupt/interrupt/
svn path=/trunk/; revision=70689
2016-02-04 20:27:44 +00:00
Hermès Bélusca-Maïto 8bc34bbe18 [FREELDR]: Export RtlAssert.
svn path=/trunk/; revision=70688
2016-02-03 22:56:17 +00:00
Hermès Bélusca-Maïto bc01b35fdf [FREELDR]
- The PE code can be built as an executable, it works as expected and nothing changes (the size of the generated code doesn't change).
- Export the Scsi functions also on x86 MSVC builds. Because of that, increase the number of expected PE sections in the FreeLdr image check function. Note that x64 MSVC build do not have the Scsi code ready yet, hence it doesn't export the corresponding functions.
- The spec2def command should have the name of the generated PE file.
- Remove one hardcoded value.

During my investigations I noticed that using a section alignment of 0x400 for freeldr MSVC builds (instead of the default 0x1000) made the MSVC builds *bigger*. Furthermore, using the default alignment of 0x1000 makes the freeldr MSVC builds unbootable. I don't understand why. Maybe a freeldr guru knows that?

svn path=/trunk/; revision=70687
2016-02-03 22:18:05 +00:00
Hermès Bélusca-Maïto 3f9bbc9a01 [BOOTMGR]
- Make BmMain stdcall as it's an entry point, the same way as ROSLOAD's OslMain.
[ROSLOAD]
- Fix a comment.
- Fix compilation on x64 and on GCC by specifying the entrypoint stack, exactly as what we do for KiSystemStartup in the kernel.

svn path=/trunk/; revision=70686
2016-02-03 19:12:34 +00:00
James Tabor 201e5c881a [User32]
- Patch by Manuel : Explorer not draw (16 bits) icons. See CORE-10789.

svn path=/trunk/; revision=70685
2016-02-03 16:39:28 +00:00
Hermès Bélusca-Maïto a346165f3c [FREELDR]: Move the (private) HAL Pci bus initialization calls to where they are needed: for SCSI initialization (see r46017).
svn path=/trunk/; revision=70684
2016-02-03 16:30:39 +00:00
Hermès Bélusca-Maïto 076441f3ce [FREELDR]
- Move the NTOS loader files that were scattered in many places into their own directory (now all that stuff is inside freeldr/windows).
- Split arch/arm/winldr.c into the real winldr code (going into freeldr/windows) and entry point code (going into arch/arm/entry.c).

svn path=/trunk/; revision=70683
2016-02-03 15:20:37 +00:00
Hermès Bélusca-Maïto 9f8022a2b3 [FREELDR]
- Move some code where it should better belong to.
- Add few source code file headers.
- Add missing partition IDs.

svn path=/trunk/; revision=70682
2016-02-03 14:07:18 +00:00
Hermès Bélusca-Maïto 7e33c2343e [i8042PRT]: Forgot this one, addendum to r70680.
svn path=/trunk/; revision=70681
2016-02-03 00:40:37 +00:00
Hermès Bélusca-Maïto 9cc0aedad7 [FREELDR][STREAM][NTOS]
Replace old bugzilla report IDs to their JIRA counterparts.

[LIBUSB]
The third parameter of IoRegisterDeviceInterface is a pointer (optional). Use NULL instead of 0.

svn path=/trunk/; revision=70680
2016-02-03 00:37:23 +00:00
Hermès Bélusca-Maïto fe52797f20 [FREELDR]: Remove deprecated code.
svn path=/trunk/; revision=70679
2016-02-03 00:04:05 +00:00
Hermès Bélusca-Maïto 4d428f4551 [NTOS:INBV]
- Initialize global variables to known default values.
- When Inbv initializes the display, reset the video mode *ONLY* if we do not have a custom boot logo (because otherwise we want to see our custom boot logo!). This also fixes the video mode used by ReactOS when booting it using Windows ntldr!

svn path=/trunk/; revision=70678
2016-02-02 23:28:45 +00:00
Sylvain Petreolle ecc5e30ce6 MSVC: Properly define debug functions for release builds.
svn path=/trunk/; revision=70677
2016-02-02 20:51:50 +00:00
Hermès Bélusca-Maïto 81e1b30067 [USETUP]: Enlarge some string buffers that hold localized printf-formatted strings.
svn path=/trunk/; revision=70676
2016-02-02 02:23:56 +00:00
Hermès Bélusca-Maïto f2f176a202 [USETUP]
- Use defines instead of hardcoded values for partition type IDs.
- Add some support for installing ReactOS on EXT2 partitions.
- Add few code that will be needed when we support NTFS installation.
- Refactor InstallFatBootcodeToPartition and its auxiliary functions. CORE-4870

svn path=/trunk/; revision=70675
2016-02-02 01:55:05 +00:00
Hermès Bélusca-Maïto f9e7ff40dc [CMLIB]: Demote the DPRINT1 saying that we leak the security block descriptor to a DPRINT. People (Alex & me) working on cmlib already know this. "Fixes" timeout problems of the testbots due to spamming this dprint.
svn path=/trunk/; revision=70674
2016-02-01 23:10:38 +00:00