Commit graph

54014 commits

Author SHA1 Message Date
Thomas Faber e713afc1f4 [NETSHELL]
- Fix warnings

svn path=/trunk/; revision=59532
2013-07-20 09:56:58 +00:00
Thomas Faber 4248694ae9 [PSDK]
- Fix PRINTPROVIDOR::fpAddPortEx prototype

svn path=/trunk/; revision=59531
2013-07-20 09:27:15 +00:00
Hermès Bélusca-Maïto 66fa5c8c6f [REGEDIT]
Fix the creation of empty REG_MULTI_SZ values (they have to contain only one NULL char, since a multi-string has the form:
str1\0str2\0...strN\0\0
where each strI\0 is a null-terminated string, and a multi-string is terminated by a null string.
And therefore an empty multi-string has only one null char, corresponding to the terminating null string.

svn path=/trunk/; revision=59529
2013-07-20 00:37:47 +00:00
Alex Ionescu 89bc3d9a83 [USBEHCI]: Straggler fix.
svn path=/trunk/; revision=59528
2013-07-20 00:13:59 +00:00
Alex Ionescu df2c8e140c [MISC]: Cleanup a bunch of unused variables, in cases where it was obvious these variables were left-overs from debug code, debug prints, or in some cases commented-out functionality (in which case the variables were commented out instead of removed). If you own ACLUI, CLASS2, USB, USER32, or EXT2LIB you may want to check that these changes are accurate (i.e.: such as the last commit where the variable was actually not being used due to a bug).
svn path=/trunk/; revision=59527
2013-07-20 00:10:31 +00:00
Alex Ionescu d27393f669 [USBCCGP]: FDO_HandleResetCyclePort should complete the pending IRPs, not the reset IRP. In fact, since the caller (FDO_HandleInternalDeviceControl) already completes the reset IRP, this was also causing double IRP completion. THIS IS WHY GCC 4.7 WARNINGS ARE IMPORTANT.
svn path=/trunk/; revision=59526
2013-07-19 23:51:01 +00:00
Amine Khaldi 7cf03fb58d [FBTUSB]
* Silence some warnings.

svn path=/trunk/; revision=59525
2013-07-19 23:44:47 +00:00
Amine Khaldi 92b4e8d9dd [WINMM_WINETEST]
* Silence some warnings.

svn path=/trunk/; revision=59524
2013-07-19 23:42:18 +00:00
Amine Khaldi b45f58ec79 [GLU32]
* Silence some warnings.

svn path=/trunk/; revision=59523
2013-07-19 23:40:04 +00:00
Amine Khaldi 5de235ee37 [UNIATA]
* Silence some warnings.

svn path=/trunk/; revision=59522
2013-07-19 23:36:38 +00:00
Amine Khaldi 4c7178ab1b [LIBXML2]
* Disable warnings.

svn path=/trunk/; revision=59521
2013-07-19 23:33:08 +00:00
Amine Khaldi 3b80e4b780 [CARDLIB]
* Silence some warnings.

svn path=/trunk/; revision=59520
2013-07-19 23:22:19 +00:00
Amine Khaldi d26a030683 [ADNS]
* Silence some warnings.

svn path=/trunk/; revision=59519
2013-07-19 23:20:17 +00:00
Hermès Bélusca-Maïto 3a79dade5f [SMSS]
- In the token parsing function SmpParseToken, just return success directly if the input string has zero length, instead of running code which does nothing at the end, because the length was zero...
- Give a default value for the "BootExecute" entry in the SMSS registry configuration table (this value is used when there is no BootExecute registry value inside HKLM\System\CurrentControlSet\Control\Session Manager) and precise that it is a multi-string value.
- Remove a redundant "Environment" entry in this table, too.

svn path=/trunk/; revision=59518
2013-07-19 22:32:34 +00:00
Hermès Bélusca-Maïto 2b4917ab72 [RTL]
- Fix a potential overflow bug.
- Don't hardcode the "/ 2" in indices computation (2 == sizeof(WCHAR))
- Fix a string enumeration bug when enumerating strings inside REG_MULTI_SZ values, in RtlQueryRegistryValues.

svn path=/trunk/; revision=59517
2013-07-19 22:22:49 +00:00
Alex Ionescu 485cd9ca16 [WIN32K]: Get rid of unused variables, fix all warnings on GCC 4.7
svn path=/trunk/; revision=59516
2013-07-19 17:06:14 +00:00
Hermès Bélusca-Maïto 2381e6ab77 Final fixes for the SYNCHRONIZE flag
CORE-7361 #resolve #comment Fixed in revisions 59512, 59514 and 59515.

svn path=/trunk/; revision=59515
2013-07-19 15:19:03 +00:00
Hermès Bélusca-Maïto 072209491b Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERIC_xxx (which should map to some FILE_GENERIC_xxx already containing the SYNCHRONIZE flag).
Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags...

Otherwise, when using FILE_GENERIC_(READ/WRITE) flags directly, there is no need to add the SYNCHRONIZE flag since it is already incorporated in it.

See CORE-7361 for more details.

svn path=/trunk/; revision=59514
2013-07-19 15:05:28 +00:00
Thomas Faber 29dcad6c4e [WIDL]
- Apply Wine commit "widl: Avoid short printf formats with int variables." (7ca08fee) by Alexandre Julliard. Fixes clang warnings

svn path=/trunk/; revision=59513
2013-07-19 14:24:22 +00:00
Hermès Bélusca-Maïto b15886585b Add the SYNCHRONIZE flag to the DesiredAccess parameter when using the flags FILE_SYNCHRONOUS_IO_(NON)ALERT in NtCreateFile or NtOpenFile, even if one uses DesiredAccess == GENERIC_xxx (which should map to some FILE_GENERIC_xxx already containing the SYNCHRONIZE flag).
Indeed, it appears after extended testing that, when calling from user-mode, Windows checks the real presence of the SYNCHRONIZE flag when using FILE_SYNCHRONOUS_IO_(NON)ALERT even if we pass any of the GENERIC_xxx access flags...

Part 1/X

svn path=/trunk/; revision=59512
2013-07-19 14:03:46 +00:00
Hermès Bélusca-Maïto d81b4016ce Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 4/4)
Everything fixed now \o/

svn path=/trunk/; revision=59511
2013-07-19 13:16:47 +00:00
Hermès Bélusca-Maïto a24ce168b5 Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 3/4)
NOTE: Fixing builds ;)

svn path=/trunk/; revision=59510
2013-07-19 13:11:25 +00:00
Hermès Bélusca-Maïto 1701110528 Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 2/X)
WARNING: Might break builds now.

svn path=/trunk/; revision=59509
2013-07-19 13:03:42 +00:00
Hermès Bélusca-Maïto b73890ea0d Fix ASSERTMSG definition and usage (which is: ASSERTMSG(Message, expression) and not the other way around, see http://msdn.microsoft.com/en-us/library/windows/hardware/ff542113(v=vs.85).aspx , http://www.osronline.com/DDKx/ddtools/debugfns_41yr.htm and google...) (Part 1/X)
svn path=/trunk/; revision=59508
2013-07-19 12:54:34 +00:00
Amine Khaldi 00b4f33ecd [DBGHELPHOST]
* Fix some warnings. Brought to you by Thomas Faber.

svn path=/trunk/; revision=59507
2013-07-19 00:11:08 +00:00
Thomas Faber 9830a11818 [WIDL]
- Fix some warnings

svn path=/trunk/; revision=59506
2013-07-18 21:55:32 +00:00
Amine Khaldi 4f0694e3af * Improve the way we create rossym debug info. The effort results in ~85% *smaller* build folder with ninja all with no code changes.
[DBGHELPHOST]
* Introduce a self-contained, static library version of dbghelp, in order to leverage its PE DWARF support. Thanks to Jerome Gardou for his work on the compatibility layer, and to Thomas Faber for helping me with the review/improvements.
* Unify the new host lib with the existing dll codebase using preprocessor conditions. This prevents code duplication.
* Skip as much unneeded functionality as possible when compiling dbghelphost to keep it light and straight to the point.
[RSYM]
* Introduce the required functions that allow parsing DWARF (using dbghelphost) and using it (along with coff symbols) to create the rossym debug info. Brought to you by Awesome Arty with some bugfixes from Jerome Gardou. Many thanks to Thomas Faber for assisting me with the testing/bug hunting.
[CMAKE/GCC]
* Introduce a combination of dwarf and debug emission flags that ensure the smallest debug info size among all the possible options we have.
* Introduce compressed debug sections that I already included the support for in RosBE 2.1. Thanks to the mingw-w64 folks (Kai Tietz) for the patch.
* Don't compress debug sections of C++ modules for now due to a bug in the toolchain that leads to spamming the build at link time with a warning.
* Don't run rsym on the RC shared libraries. Thanks to Thomas Faber for spotting this.
[DBGHELP]
* Update the ros diff to reflect the changes introduced by the dbghelphost unification.

svn path=/trunk/; revision=59505
2013-07-18 21:03:01 +00:00
Thomas Faber cc5e6fe6a6 [INFLIB]
- Avoid use of swprintf, which is blatantly incompatible with -fshort-wchar
CORE-6918 #resolve

svn path=/trunk/; revision=59504
2013-07-18 20:29:18 +00:00
Thomas Faber a937917f7f [UNICODE]
- Fix missing isdigit

svn path=/trunk/; revision=59503
2013-07-18 20:08:37 +00:00
Amine Khaldi 9d7768ed60 [RSYM]
* Formatting. No intended code changes.

svn path=/trunk/; revision=59496
2013-07-17 14:42:33 +00:00
Aleksey Bragin b666ebecda [NTOS]
- Fix CcMdlReadComplete2 prototype.
- Fix a bug in Dominique Cote's code: when performing FsRtlGetFileSize, the length of the buffer should be set accordingly to the information class asked for, that is - FILE_STANDARD_INFORMATION structure. Previous calculation formula makes no sense at all and leads to memory corruption (if filesystem driver is stupid enough) or inability to get file size (if filesystem driver is coded by good developers).

svn path=/trunk/; revision=59495
2013-07-16 22:37:01 +00:00
Aleksey Bragin ee87f2a4f6 [DDK]
- Fix ExAllocateFromZone. I understand it's deprecated, but it having a broken implementation which can't work at all because the one who coded this function failed to understand basic algorithms of linked lists is nonsense.

svn path=/trunk/; revision=59494
2013-07-16 19:57:12 +00:00
Aleksey Bragin 30d0129f75 [NTOS/EX]
- ExInitializeZone: Don't add to an uninitialized TotalSegmentSize value, set it instead.

svn path=/trunk/; revision=59493
2013-07-16 19:21:55 +00:00
Aleksey Bragin 5846967dd0 Dedicated to Timo.
svn path=/trunk/; revision=59492
2013-07-16 17:44:19 +00:00
Aleksey Bragin 1f8454cef1 [NTOS]
- Implement enabling Large Pages support if it is detected. The Page Size Extension (PSE) bit in CR4 is enabled when paging is disabled. To achieve that, a temporary virtual and physical identity mapping is created, which is discarded after PSE is enabled.

svn path=/trunk/; revision=59491
2013-07-16 13:49:03 +00:00
Thomas Faber 50b0c50023 [CMAKE]
- Add configure support for VS 2013
- Add a missing /nologo to assembler invocations
- Properly complain about old MSVC versions during configure instead of failing the build

svn path=/trunk/; revision=59488
2013-07-14 21:00:42 +00:00
Eric Kohl 98cef13e0f [SAMSRV]
Add security descriptors for the account and builtin domains.

svn path=/trunk/; revision=59487
2013-07-14 18:41:29 +00:00
Hermès Bélusca-Maïto 9ff782961b [KERNEL32]
Fix some broken logic: we can duplicate console handles only if both the source and the target processes are in fact the current process.

svn path=/trunk/; revision=59486
2013-07-14 16:57:26 +00:00
Hermès Bélusca-Maïto 542bb5560c [KERNEL32]
Fix parameters usage when calling NtDuplicateObject.

svn path=/trunk/; revision=59485
2013-07-14 14:52:39 +00:00
Eric Kohl 4a9c806d41 [SAMSRV]
Implement SamIFree_SAMPR_GET_MEMBERS_BUFFER.

svn path=/trunk/; revision=59484
2013-07-14 14:22:30 +00:00
Thomas Faber 19e0e8187c [BROWSEUI]
- This is not Wine source. Remove hacks accordingly

svn path=/trunk/; revision=59483
2013-07-14 13:18:32 +00:00
Thomas Faber f001f43b65 [IEFRAME][MSHTML_WINETEST]
- Use SHANDLE_PTR in IWebBrowserApp::get_HWND. Already sent to Wine.

svn path=/trunk/; revision=59482
2013-07-14 13:01:55 +00:00
Thomas Faber f76d810d43 [CMAKE]
- Do not allow add_delay_importlibs to be called on static libraries

svn path=/trunk/; revision=59481
2013-07-14 11:44:21 +00:00
Hermès Bélusca-Maïto 53dbf738e5 [WINSRV]
Fix a delayed-imports problem, catched by Timo and Thomas with a MSVC build. Caused by the fact that the static library consrv specified delayed imports for it, thinking that they will be added to the list of delayed imports of winsrv. In fact it doesn't work and those imports become real imports.

svn path=/trunk/; revision=59480
2013-07-14 11:33:26 +00:00
Thomas Faber d16e22b423 [MSHTML_WINETEST]
- Use winetest_interactive to disable tests

svn path=/trunk/; revision=59479
2013-07-14 10:11:45 +00:00
Pierre Schweitzer 25bc546159 [NTOSKRNL]
Fix return of MiProtectedPoolUnProtectLinks() which was always returning null, instead of returning
safe unprotected links when needed

svn path=/trunk/; revision=59478
2013-07-14 09:30:26 +00:00
Thomas Faber c97dc9fd31 [UUID]
- Remove unused file whose only purpose is to confuse people

svn path=/trunk/; revision=59477
2013-07-14 09:05:50 +00:00
Thomas Faber a73a5c7941 [PSDK]
- Reduce shdeprecated.idl differences to Wine. Fixes a few warnings

svn path=/trunk/; revision=59476
2013-07-14 07:12:59 +00:00
Thomas Faber 8e34f32ce6 [PSDK]
- Move some stuff around in shdeprecated.idl to reduce the difference with Wine
- Move TLENUMF to tlogstg.idl

svn path=/trunk/; revision=59475
2013-07-14 06:29:16 +00:00
Thomas Faber ac9bba8e47 [BROWSEUI][EXPLORER_NEW]
- Add missing includes aka fix build

svn path=/trunk/; revision=59474
2013-07-14 06:02:03 +00:00