Commit graph

73638 commits

Author SHA1 Message Date
Thomas Faber ec2f30da0d [0.4.11] [WIN32K:NTUSER] Avoid dereferencing a null pointer in NC_DoNCPaint.
Fixes BSODs CORE-15569, CORE-12963, CORE-13410

cherry picked from commit 0.4.12-dev-338-g
b2dcb8e0d8
2019-01-08 23:54:32 +01:00
Thomas Faber b5fef42955 [0.4.11] [WIN32K:NTUSER] Reference menus owned by a popup menu. CORE-15504
Fixes a BSOD mentioned in CORE-15504

cherry picked from commit 0.4.12-dev-218-g
e3c8002dfc
2018-12-30 18:22:52 +01:00
Mark Jansen 2522ec1b06 [0.4.11] [OLE32] Apply the proper Wine fix for CORE-14696
Don't free handles that are just copied in the inproc case.

This imports wine commit 25b136d40080a80c006b89e02708d2e248504a42,
by Huw Davies and Zebediah Figura

cherry picked from commit 0.4.12-dev-96-g
959994b67c
2018-12-17 22:25:15 +01:00
Joachim Henze b93990e7fb [0.4.11] [SHELL32] Revert the sraboy workaround CORE-14696
This reverts the workaround of 0.4.11-RC-2-g
7e9c37c58f
Because we got a proper ole32-fix from Wine that I will apply in next commit.
2018-12-17 22:22:16 +01:00
Joachim Henze 231daa48f7 [0.4.11] [DESK][SHELL32] Allow Desk.cpl to run standalone on WinXP/2003 again
CORE-15412

addendum to 0.4.10-dev-502-g
d559ca9c98

That copy-paste was done once intentionally to keep our imports similar to 2003.
It's worth reading the conversation in PR #748: Getequ seems to be ok with this.

The ideal solution most likely would be to instead *statically*
link against RegLoadMUIStringW() from advapi32_vista when WINNT=0x502.
For now the stuff runs again at least.
I left the func existing in advapi32_vista.dll.

cherry picked from commit 0.4.12-dev-99-g
6f8cb05cad
2018-12-17 22:06:17 +01:00
Joachim Henze 7fd1b51e8d [0.4.11] [BROWSEUI] Workaround regression CORE-15429 'unintended scrollbars'
Thanks to Doug Lyons for providing a temporary workaround quickly.
2018-12-17 20:11:12 +01:00
Katayama Hirofumi MZ 00a1f2214f [0.4.11] [SHELL32] 'Run' dialog box should accept URL (#1153)
Fix ShellExecCmdLine function. CORE-15455, CORE-11772
CORE-11772 mentioned it was a regression.

cherry picked from commit 0.4.12-dev-93-g
c94ca8128d
2018-12-17 18:59:50 +01:00
Joachim Henze 78cd6265d9 [0.4.11] Revert "[NTOSKRNL] Properly align VACB writes"
to avoid CORE-15384 "ros corrupts FAT16 partition"

This reverts commit 0.4.11-dev-210-g
2a80ae2bb6
2018-12-17 00:14:06 +01:00
Joachim Henze b906163dc1 [0.4.11] [COMCTL32] Fix regression CORE-14671 & CORE-14701
Fixes the icons on some buttons being flipped vertically.
Known affected apps: Lazarus IDE, Double Commander, Peazip.

Beside that it also fixes transparency regressions in DVDStyler 3.0.4 (CORE-14701).

Thanks to patches author Doug Lyons.

The patch has not been committed to master yet and has the known side-effect
of introducing flipped icons in the options-listview of Double-Commander
that are drawn correctly without the hackfix.

like in last release
(cherry picked from commit 9d758ae1cd)
2018-12-16 23:28:35 +01:00
Joachim Henze 5037a3a1bd [0.4.11] Avoid regression CORE-14955 "DDraw fullscreen crashes" part II
addendum to last commit.
We now additionally need to fix redefinition of ARRAY_SIZE macro
to make the revert compile.
Most likely its definition was moved since 0.4.10rls.
The result is capable to complete the DxDiag DDraw fullscreen test again.
2018-12-16 22:33:49 +01:00
Joachim Henze cf0c1ad7d5 [0.4.11] Avoid regression CORE-14955 "Ddraw fullscreen crashes"
This brings us back to before commit 0.4.10-dev-55-g
7af3969e9f

and therefore downgrades D3D8,D3D9,DDRAW,WINED3D from 3.9 to 3.3 for this rls.

This is same versions as we had in 0.4.10rls (I used same revert then)

Purpose of this revert is to fix crashes when Ddraw apps switch
into fullscreen with VBEMP and inbuilt Mesa.
I tested, before:
 DxDiag crashed when switching to fullscreen,
 Diablo II crashed immediately,
 Monster-Truck-Madness 2 demo crashed after main menu

Afterwards all of these apps do run.
DXTN does still work after that, even with VBEMP and inbuilt Mesa.

This will be the interim fix, which I will keep for rls at least
until someone manages to fix CORE-14955 properly in master with Wine 3.9.

analog to 0.4.10-RC-17-g
bb4c55d650
2018-12-16 21:07:39 +01:00
Katayama Hirofumi MZ 29f9c0433f [0.4.11] [SHELL32] Fix 'Run' dialog crash (#1117)
CORE-15431 (2 of 2)
Running "%SYSTEMROOT%" sometimes crashed. This will fix it.
cherry picked from commit 0.4.12-dev-36-g
472787ffea
2018-12-16 20:35:13 +01:00
Katayama Hirofumi MZ 5aea1c7118 [0.4.11] [SHELL32] Enable environment variables in 'Run' dialog (#1111)
CORE-15431 (1 of 2)
cherry picked from commit 0.4.12-dev-19-g
06d717e3bc
2018-12-16 20:34:22 +01:00
Joachim Henze 842671e219 [0.4.11] [NFSD] Apply a hack to avoid CORE-13498
Committing into rls was requested by Pierre.
The hack allows to startup nfsd even when getnameinfo() fails.
My personal release-tests will not cover NFSD.

like in last release
(cherry picked from commit 39f5e56a29)
2018-12-12 23:09:52 +01:00
Joachim Henze 26080d0c64 [0.4.11] [RDBSS] Avoid CORE-13938
Pierre recommended this hack-fix for 0.4.8rls before.
Avoids "GetVolumeInformation now fails on NFS volume"

I will not retest any RDBSS functionality myself in my tests,
maybe some other tester would be kind enough to retest this?

Please note that I replaced #if 0 with #if 1
as discussed with Pierre. That's different to the patch in ticket.

like in last release
(cherry picked from commit 1906186e83)
2018-12-12 23:07:49 +01:00
Timo Kreuzer 18837f1e33 [0.4.11] [CMAKE] Fix problem with __RELFILE__ not working when
compiler uses relative paths

done in context of CORE-14839 (2 of 2 commits)

This usually happens when the build dir is a subdir of the source dir.
It is now detected during runtime, using the length of the relative path
from the build dir to the source dir as the length of the prefix to skip,
if __FILE__ starts with a '.'.
Also fix the escaping of REACTOS_*_DIR defines. It was gracefully fixed up by
CMake, but resulted in broken syntax highliting.

CORE-14839 #resolve

cherry picked from commit 0.4.12-dev-29-g
3de04ccace
2018-12-11 22:16:37 +01:00
Timo Kreuzer 7cd586252f [0.4.11] Revert "[CMAKE] Use configured include files to define the
__RELFILE__ hack (#979)"

done in context of CORE-14839 (1 of 2 commits)

This reverts commit 0.4.11-dev-516-g
07bd6089ec.

cherry picked from commit 0.4.12-dev-28-g
05169a4987
2018-12-11 22:14:05 +01:00
Katayama Hirofumi MZ 7d0eadda9f [0.4.11] [WIN32SS][FONT] Check NULL of Face->style_name (#1113)
CORE-15433
cherry picked from commit 0.4.12-dev-20-g
43e2089476
2018-12-11 18:56:26 +01:00
Joachim Henze ba9846cda9 [0.4.11] revert [NTDLL/LDR] Overhaul sxs work
This reverts commit 0.4.8-dev-502-g
7000fe2340.

This reverts commit 0.4.8-dev-503-g
f318a25e10.

The two changes were done once to work towards better
shim-supporting APIs of newer Windows versions on demand
in the future. Luckily we do not depend on them yet.

Giannis already fixed most regressions of the 2 commits
before branching 0.4.8RC (e.g. 2nd stage theme-selector).

Unfortunately we still have issues atm with the existing mixture
of Wine comctl32 v5 vs v6.
The image-lists of both are not compatible as Giannis told us.

We revert both commits for this release to fix CORE-14433 & CORE-15118
(missing icons due to incompatible image-lists). We can not
simply add a manifest here, because 3rd party apps are affected.

I double-checked, all of those (formerly affected) apps
are working fine and show the icons after the revert:
2nd-stage-theme-selection, MS Excel Viewer 2007 open-dlg,
MSVCPP 6 installer open-dlg, FaxViewer save-dlg,
MS Word Viewer 2003 open-dlg & OCR CuneiForm 12 from CORE-15118

This revert also obsoletes works/fixes like
2f11904000.

like in last release
(cherry picked from commit 11bf8fa047)
2018-12-10 00:54:52 +01:00
Pierre Schweitzer 996250ef93 [0.4.11] [WIN32SS] Shhhhh! CORE-11944
This silences log-spam from recently added STUB-call of IntGoGhost()
which gets called very frequently currently, e.g. during
our currently pseudo-async network transfers

cherry picked from commit 0.4.12-dev-8-g
958ae44599
2018-12-09 22:23:37 +01:00
Joachim Henze a36ed7afc6 [0.4.11] [WINHTTP] Sledge-Hammer-Revert to SVN r75943 to fix regression CORE-13952
Our RCs were still affected by that regression.
The revert allows to run the current Online! setup
of Flash-Player 32.0.0.1 to download.
(I was able to watch a flash video in Opera 12.18 afterwards, before I was not)

same procedure as last releases
2018-12-09 19:14:38 +01:00
Joachim Henze 2fc468303c [0.4.11] [USP10] Apply unfinished patch to avoid CORE-14226
Thomas linked the patch in Wine Bug 44410
A very well-working patch, that I used to apply to every release since 0.4.8.
It avoids text rendering regressions in some setups like UltraISO
The bug is very wide-spread in unaddressed master.

like in last release
(cherry picked from commit 937c2615e6)
2018-12-09 18:30:30 +01:00
Joachim Henze 7e9c37c58f [0.4.11] [SHELL32] Avoid regression CORE-14696
"It was not longer possible to delete any file or folder via context menu"

By applying the workaround from Doug Lyons and sraboy, slightly adapted.
2018-12-09 18:02:29 +01:00
Thomas Faber bca25b10b4 [0.4.11] [WIN32SS] Mask WndProc exceptions to hide all tickets linked to CORE-11915
e.g. this allows using MsDepends
Unfortunately still necessary, luckily still effective

like in last release
(cherry picked from commit 9274859438)
2018-12-09 15:15:16 +01:00
Joachim Henze 5862081159 [0.4.11] Branch releases/0.4.11 & change KERNEL_VERSION_BUILD_TYPE "RC"
as first commit before! adding the git-tag
2018-12-09 14:42:40 +01:00
Pierre Schweitzer de7c959c4e
[NTDLL] Implement the Etw*Trace functions relying on EtwControlTrace 2018-12-09 10:29:02 +01:00
Pierre Schweitzer 53a313f456
[USER32] Complete French translation 2018-12-09 09:38:31 +01:00
Timo Kreuzer 431643b9b3 [NTOS:LPC] Add a number of DPRINTs on failure 2018-12-09 03:16:19 +01:00
Bișoc George 3493992e7a [OSK] Add the minimize button (#1102) 2018-12-08 23:44:42 +01:00
Stanislav Motylkov f851b82570 [USETUP] Update russian translation
Addendum to 03b7e13, 29ace9c and a5bcd95.
2018-12-08 23:36:06 +01:00
Stanislav Motylkov 6c7094acb8 [USER32] Update russian translation
Addendum to 6a944b5.
2018-12-08 23:36:06 +01:00
Stanislav Motylkov c60c4886d9 [NOTEPAD] Update russian translation
Addendum to 60e9fcc.
2018-12-08 23:36:06 +01:00
Hermès Bélusca-Maïto ca71813361
[NOTEPAD] Addendum to 60e9fcc (#610) 2018-12-08 20:11:26 +01:00
Pierre Schweitzer 182cc5c5ab
[NTOSKRNL] Don't dereference VACB when allocating its memory area fails
This avoids performing a double-free (even though that's hidden by the
fact we use lookaside allocations for VACB), and it avoids freeing
a memory address at an uninitialized address.
We don't care about references here, the VACB was just allocated, never
linked and we're its only user.

CORE-15413
2018-12-08 19:56:03 +01:00
Erdem Ersoy 60e9fcc8f0
[NOTEPAD] Improve the "About" dialog status. (#610)
- Remove the non-standard "About" dialog.
- Move the authors copyright info into the shell "About "dialog.
2018-12-08 19:35:16 +01:00
Ștefan Fulea b0ab61e6c3
[BOOTDATA][SETUPLIB] Setup the Romanian Stdandard Keyboard layout. (#861)
Adjust the miscellaneous files to activate the Romanian Standard
Keyboard layout in the OS and set it as default for Romanian.

CORE-15056
2018-12-08 18:53:18 +01:00
Ștefan Fulea 8a333e6845
[CPL:INPUT] Update Input's existing localized information. (#861)
Update the name of the Romanian Keyboard layout in localized
resources by renaming the existing one as legacy and adding
the new one as standard.

Use the same resource string ID as the one used in input.cpl from
later versions of Windows that do have kbdrost.
This improves the Windows binary compatibility of kbrost's setup.

CORE-15056
2018-12-08 18:52:56 +01:00
Ștefan Fulea e530bb36ed
[DLL:KEYBOARD] Add Romanian Standard Keyboard layout. (#861)
Define the Romanian Standard Keyboard layout, as defined by
Romanian Standards Association (ASRO). This also renders the
existing Romanian Keyboard layout as Legacy.

CORE-15056
2018-12-08 18:52:25 +01:00
Ștefan Fulea 3c82e46ef1
[DLL:KEYBOARD] Add a dead keys transformations collection. (#861)
It contains all the Unicode characters that can be formed with a
given dead key (i.e. combining character). Keyboard layouts with
dead keys may find these useful.

CORE-15056
2018-12-08 18:50:47 +01:00
Serge Gautherie b92f1f4cdf
[LOG2LINES] Free all memory on exit. 2018-12-08 17:38:24 +01:00
Serge Gautherie ca2bb9ee28
[LOG2LINES] Optimize malloc() calls. 2018-12-08 17:38:16 +01:00
Hermès Bélusca-Maïto dbaa875f05
[LOG2LINES] Fix indentation. 2018-12-08 17:38:03 +01:00
Serge Gautherie f5f515c17c
[LOG2LINES] Replace overkill malloc() usage.
NOTE: Since the 'cache_name' and 'tmp_name' pointers move inside the
corresponding cached strings, separate cache buffers are needed.
2018-12-08 17:34:18 +01:00
Serge Gautherie 5e8e654dfd
[DDRAW] Remove useless 'else's. 2018-12-08 17:10:36 +01:00
Serge Gautherie 166c6e2498
[DDRAW] Fix two duplicate DDSD_WIDTH uses.
Thanks to Kudratov Olimjon who reported this.
CORE-8545
2018-12-08 17:10:31 +01:00
Eric Kohl b9d4e2dae6 [USERENV] Move some functions around to make it look nicer. No code changes. 2018-12-08 16:41:17 +01:00
Eric Kohl d383d1c6b0 [PSDK] Add DeleteProfileA/W prototypes to userenv.h. 2018-12-08 15:23:04 +01:00
Pierre Schweitzer 01d56963f8
[MPR_WINETEST] Sync with Wine Staging 3.17. CORE-15127 2018-12-08 11:43:10 +01:00
Pierre Schweitzer e02f3356b1
[MPR] Sync with Wine Staging 3.17. CORE-15127 2018-12-08 11:42:23 +01:00
Pierre Schweitzer bcad6700ec
[MPR] Import Wine commit: 773ff2e83b0547540639c6d4aeb9f817b621fb2f
Implement support for deleting persistent connections.
2018-12-06 22:44:43 +01:00