Commit graph

11939 commits

Author SHA1 Message Date
Amine Khaldi 198d18e749 [AVIFIL32] Sync with Wine Staging 1.9.11. CORE-11368
svn path=/trunk/; revision=71538
2016-06-05 18:38:02 +00:00
Hermès Bélusca-Maïto 119d9c8f0b [SHELL32]: In some rare cases, pressing Alt-F4 in ReactOS when the desktop was on focus, just removed the desktop icons. The underlying "progman" window was indeed killed. Sending a WM_CLOSE message to it should not close it directly, but instead prompt the user with the Shutdown dialog. Tests on Windows show that it's indeed the case.
This fix completes r65557.
CORE-4351 CORE-8864

svn path=/trunk/; revision=71533
2016-06-05 14:10:14 +00:00
Hermès Bélusca-Maïto aa62271497 [SHELL32]: Experiments on Win2k3 reveal that the shell_defview window can be moved if the desktop workarea rectangle changes of size and origin.
svn path=/trunk/; revision=71532
2016-06-05 13:17:55 +00:00
Hermès Bélusca-Maïto b3a2e6dc2b [SHELL32]
- Use #ifdef __REACTOS__ instead of the #if (as done elsewhere in the code).
- The listview control hosted in a shelldll_defview has its caption named "FolderView".

svn path=/trunk/; revision=71531
2016-06-05 13:15:36 +00:00
Pierre Schweitzer 4322caeede |SHELL32]
Don't blindly delete notification item while there are still ongoing user APC.
To do so, we use reference count, and attempt to release in various places: after APC ended, and on notification unregistration.
This avoids race condition with item between usage and freeing and thus use-afree-free (leading to explorer crash) while browsing rapidly accross directories.

CORE-10941 #resolve

svn path=/trunk/; revision=71528
2016-06-05 09:26:00 +00:00
David Quintana 326b3d7e91 [SHELL32]
Sorry, I'm still half asleep. I did need functional changes.

svn path=/trunk/; revision=71527
2016-06-05 09:06:33 +00:00
David Quintana b4a3cb9acd [SHELL32]
Replace confusing usage of RECT with some actual variables. No functional changes.

svn path=/trunk/; revision=71526
2016-06-05 08:56:57 +00:00
Hermès Bélusca-Maïto 70fcffe67a [SHELL32]
- Pass indistinctly WM_SYSCOLORCHANGE and WM_SETTINGCHANGE messages sent to the shell progman window, down to its children windows (SHELLDLL_DefView and its associated ListView), as shown by tracking windows messages on Win2k3.
- If we receive a WM_SETTINGCHANGE with wParam == SPI_SETWORKAREA, i.e. the desktop working area was modified, we need to resize the underlying DefView, as shown by tracking windows messages on Win2k3. For the moment we implement support for only the primary monitor.
CORE-11375 #resolve
CORE-5618 #resolve
CORE-5620

svn path=/trunk/; revision=71525
2016-06-04 23:34:46 +00:00
Hermès Bélusca-Maïto d63c3a89ad [SHELL32]
- Minor stylistic whitespace changes.
- Use 'IDA_DESKBROWSER' instead of hardcoding its value.
- The shell progman window uses the COLOR_DESKTOP as its hbrBackground: partly revert r66271.
- Correctly initialize rcDesk structure before using it for a CreateWindowEx call.

svn path=/trunk/; revision=71524
2016-06-04 23:29:34 +00:00
Hermès Bélusca-Maïto 4e9504f015 [SHELL32]
- Whitespace fix.
- SHSetShellWindowEx really directly redirects to user32.SetShellWindowEx.

svn path=/trunk/; revision=71523
2016-06-04 22:58:53 +00:00
Giannis Adamopoulos 441ced48c3 [BROWSEUI]
- CExplorerBand: Navigate to the selected item when the selection changes.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=71510
2016-06-03 21:25:34 +00:00
Giannis Adamopoulos 5596ec9243 [SHELL32]
- HCR_GetClassName is not supposed to be specific for CLSID_MyDocuments
CORE-11363

svn path=/trunk/; revision=71509
2016-06-03 21:00:59 +00:00
Giannis Adamopoulos 25917dcb89 [BROWSEUI]
- CExplorerBand: Implement populating the treeview. You can navigate the shell namespace but clicking on an item doesn't do anything yet.
- Part of the work submitted by Sylvain Deverre. CExplorerBand::InsertItem was rewritten by me to be efficient.
CORE-10838

svn path=/trunk/; revision=71508
2016-06-03 19:35:33 +00:00
Hermès Bélusca-Maïto 0d6d9c18cc [NTDLL]
- In LdrpLoadImportModule, check for import module extension, and append it if not found.
- Fix LdrpLoadImportModule prototype.
CORE-11360

svn path=/trunk/; revision=71507
2016-06-03 19:02:46 +00:00
Robert Naumann fe0b048d53 [DEVMGMT]Remove a self assignment. CORE-11183
svn path=/trunk/; revision=71505
2016-06-03 08:47:03 +00:00
Mark Jansen 4847a35732 [APPHELP_APITEST][APPHELP] Add new tests showing that SdbWriteStringTag and SdbEndWriteListTag are incorrect, fix SdbEndWriteListTag CORE-10367
SdbWriteStringTag requires the database to keep track of written strings, and append a stringtable to a database.

svn path=/trunk/; revision=71501
2016-06-02 18:59:04 +00:00
Thomas Faber f5da7c7b8c [BROWSEUI]
- Avoid a double free in CComCatCachedCategory::CacheDSA. CComHeapPtr already takes care of this.

svn path=/trunk/; revision=71498
2016-06-02 12:19:56 +00:00
Amine Khaldi 31406b0c21 [MSI] Really silence DllRegisterServer MessageBoxes. Addendum to r71483. Spotted by Peter Hater. CORE-11244
svn path=/trunk/; revision=71497
2016-06-02 08:55:58 +00:00
Hermès Bélusca-Maïto 9afc56b93b [DESK.CPL]: Check properly if the StringCbCopy has been copied correctly just by moving the check block to where it belongs.
CID 1322244
Patch by Victor Martinez Calvo
CORE-11212 #resolve

svn path=/trunk/; revision=71493
2016-06-01 21:23:37 +00:00
Giannis Adamopoulos 91c6b947d3 [BROWSEUI]
- CExplorerBand: Implement IOleWindow, IDockingWindow, IDeskBand, IObjectWithSite, IInputObject and IPersist interfaces. This creates and shows an empty tree view control in the bar.
- CShellBrowser: Restore the hack to use the local CExplorerBand instead of the system one.

svn path=/trunk/; revision=71492
2016-06-01 21:12:17 +00:00
Giannis Adamopoulos c7a10e3a12 [BROWSEUI]
- Remove the proxy implementation of CExplorerBand. Add IDropTarget and IDropSource interfaces.

svn path=/trunk/; revision=71491
2016-06-01 20:13:27 +00:00
Mark Jansen aa9a01829c [APPHELP] Fix a possible out of bounds write.
svn path=/trunk/; revision=71489
2016-06-01 19:37:25 +00:00
Mark Jansen 271329164d [APPHELP] Remove all NT api usage from sdbwrite, split apphelp.h header out in preparation of xml2sdb CORE-11302
svn path=/trunk/; revision=71488
2016-06-01 19:10:19 +00:00
Christoph von Wittich b98bfa81af [MSI] silence DllRegisterServer MessageBoxes CORE-11244
svn path=/trunk/; revision=71483
2016-06-01 09:12:22 +00:00
Mark Jansen d37cb8f5ad [APPHELP][ACLAYER][APPSHIM_APITEST] Fix some WCHAR hack constructions that VS 2010 didn't like, as pointed out by Hermès
svn path=/trunk/; revision=71477
2016-05-31 18:02:54 +00:00
Mark Jansen 487956500e [SHELL32] Rename CShell to CShellDispatch CORE-6892
svn path=/trunk/; revision=71476
2016-05-31 17:40:44 +00:00
Giannis Adamopoulos a392e06a26 [BROWSEUI]
- Implement CShellBrowser::Navigate and CShellBrowser::Navigate2.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=71475
2016-05-31 14:57:05 +00:00
Giannis Adamopoulos 584260d6ae [BROWSEUI]
- Implement the toolbar that allows the user to close the band.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=71474
2016-05-31 14:52:18 +00:00
Giannis Adamopoulos 60b1d9b8d4 [BROWSEUI]
- CShellBrowser: Implement the Explrer bar menu. Implement checking if a band is already loaded. Destroy all bands while destroying the browser window. Misc changes.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=71473
2016-05-31 14:42:01 +00:00
Giannis Adamopoulos 1764bca67a [BROWSEUI]
- Fix a crash that can happen under weird circumstances.
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=71472
2016-05-31 14:02:58 +00:00
Giannis Adamopoulos 19ee935a70 [BROWSEUI]
- Implement SHEnumClassesOfCategories
- Part of the work submitted by Sylvain Deverre.
CORE-10838

svn path=/trunk/; revision=71471
2016-05-31 13:39:42 +00:00
Robert Naumann 49c56d1976 [IERNONCE]Add Chinese and Malay translations. Patch by Henry Tang Ih. CORE-11022
svn path=/trunk/; revision=71470
2016-05-31 11:15:25 +00:00
Robert Naumann c4e5821cb9 [SHIMGVW]Replacement for SHIMGVW control button bitmaps. Work by "dsp8195". CORE-11145
svn path=/trunk/; revision=71469
2016-05-31 10:59:04 +00:00
Robert Naumann 4f84951574 [COMCTL32][COMDLG32] Fix Esperanto localization. Patch by Mike Swanson. CORE-11264
svn path=/trunk/; revision=71468
2016-05-31 10:48:53 +00:00
Giannis Adamopoulos 8636217b7d [BROWSEUI]
- Implement most methods of IBandSite for CBaseBarSite.
- Part of the work submitted by Sylvain Deverre.
CORE-8814 and CORE-10838

svn path=/trunk/; revision=71465
2016-05-30 22:38:36 +00:00
Hermès Bélusca-Maïto c77272a3e6 [SHELL32]
It is enough to check the "ListviewShadow" registry setting for deciding whether or not the desktop icons should be transparent.
Now we also get transparent icons in safe mode with no wallpaper.
Thanks Jared Smudde for having pointing this out to me.

svn path=/trunk/; revision=71464
2016-05-30 21:30:25 +00:00
Giannis Adamopoulos 1c979e2bfb [BROWSEUI]
- Move the implementation of the search button from CInternetToolbar to CShellBrowser.
- Part of the work submitted by Sylvain Deverre.
CORE-8814 and CORE-10838

svn path=/trunk/; revision=71463
2016-05-30 20:52:05 +00:00
Giannis Adamopoulos 287a8f22f0 [BROWSEUI]
- Implement CBaseBar::ShowDW and CBaseBar::CloseDW.
- Simplify CBaseBar::SetClient.
- Implement resizing support for CBaseBar.

svn path=/trunk/; revision=71462
2016-05-30 20:37:40 +00:00
Giannis Adamopoulos 25f1b9eb0b [BROWSEUI]
- CBaseBar, CBaseBarSite: Implement IInputObject and IInputObjectSite interfaces
- Part of the work submitted by Sylvain Deverre. Simplified by me.
CORE-8814 and CORE-10838

svn path=/trunk/; revision=71461
2016-05-30 20:28:30 +00:00
Giannis Adamopoulos 9a118725bf [BROWSEUI]
- CBaseBar, CBaseBarSite: Add an initialization method in order to set the basebar and the basebar site as vertical.
- CShellBrowser: Create the basebar and the basebar site with the right orientation.
- Part of the work submitted by Sylvain Deverre.
CORE-8814 and CORE-10838

svn path=/trunk/; revision=71460
2016-05-30 20:02:45 +00:00
Giannis Adamopoulos 7e3d0a9bbd [BROWSEUI]
- Update the definition of SHEnumClassesOfCategories.
- Part of the work submitted by Sylvain Deverre.
CORE-8814 and CORE-10838

svn path=/trunk/; revision=71459
2016-05-30 19:47:09 +00:00
Hermès Bélusca-Maïto ee14b3c341 [SHELL32]: Correctly clear the listview transparent shadow text flag.
svn path=/trunk/; revision=71456
2016-05-29 14:55:29 +00:00
Pierre Schweitzer a8ebfc7774 [DNSAPI]
Don't attempt to dereference a null-ptr in case of DNS resolution failure.

svn path=/trunk/; revision=71454
2016-05-29 12:12:15 +00:00
Hermès Bélusca-Maïto 3e96c56d45 [DESK.CPL]
- Remove redundant UI elements in the "Advanced appearance" dialog.
- Add the possibility to modify the colors of inactive caption bar text and flat menu highlight (for XP/2k3+ only).

svn path=/trunk/; revision=71452
2016-05-29 00:57:31 +00:00
Hermès Bélusca-Maïto 9016ae61e6 [DESK.CPL]
- Fix french translation;
- Whitespace fix.

svn path=/trunk/; revision=71450
2016-05-28 22:05:48 +00:00
Hermès Bélusca-Maïto 2047efde02 [DESK.CPL]
- Only use the minimum required registry rights needed in RegOpenKeyEx and RegCreateKeyEx calls.
- Fix SetDesktopBackColor function where we tried to save the selected desktop background color in the registry only in the case where opening the corresponding registry key actually failed... >_>
  Now we do the right thing!

svn path=/trunk/; revision=71443
2016-05-28 19:12:14 +00:00
Mark Jansen cc1a5a5932 [APPHELP][APPHELP_APITEST] Implement various VersionLie shims. CORE-11299 #resolve
- Implement VersionLie shims
- Add tests for the VersionLie shims
- update get_host_winver prototype (thanks to Thomas for pointing out my err)

We cannot apply this shim yet, since a required part of the infrastructure is missing.

svn path=/trunk/; revision=71442
2016-05-28 17:55:56 +00:00
Hermès Bélusca-Maïto 15082cc9fc [SHELL32]: Always paint the desktop listview transparent. This allows explorer to display the default desktop background color set by win32k as well as the ReactOS version on the desktop.
See also r66271 and r66752.

svn path=/trunk/; revision=71441
2016-05-28 16:59:55 +00:00
Mark Jansen 605449d0fe [APPHELP] Register AppPatch directory with cmake, import SdbGetAppPatchDir implementation from Mislav Blažević CORE-10369
svn path=/trunk/; revision=71440
2016-05-28 16:47:39 +00:00
Mark Jansen b6d0f03c96 [APPHELP] Begin shimlib implementation. CORE-11329
Implement some macro's and functions that help when registering shims.
These are all written in C, so that wine can use the shim libraries as well.

svn path=/trunk/; revision=71439
2016-05-28 16:42:57 +00:00