Intravision/reactos

86313 commits 94 branches 276 tags 1 GiB

Author	SHA1	Message	Date
Adam Słaboń	20efea8fa4	[USBSTOR] Fix PdoHandleQueryInstanceId and increase serial number descriptor size to MAXIMUM_USB_STRING_LENGTH (#6413 ) Serial number on some USB devices might exceed the number of 100 characters (e.g. 120 characters on "SanDisk Ultra 3.2Gen1" pendrive) and cause buffer overflow, resulting in usbstor.sys crash. - Use pool allocation for instance ID generation. Fixes stack overflow on USB storage devices with large serial number. - Print the LUN number as a hexadecimal, not as a character. - Verify the serial number descriptor before using it. - Increase the max descriptor size for serial number to MAXIMUM_USB_STRING_LENGTH. This fixes serial number string truncation. Based on suggestions by disean and ThFabba. CORE-17625	2024-02-16 18:48:33 +03:00
Victor Perevertkin	d17d15ab6c	[FORMATTING][USBSTOR] Remove Captain Obvious and line-wasting comments. Now the driver conforms with our current Coding Style. No functional changes	2019-06-11 04:39:43 +03:00
Colin Finck	c2c66aff7d	Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.	2017-10-03 07:45:34 +00:00

Author

SHA1

Message

Date

Adam Słaboń

20efea8fa4

[USBSTOR] Fix PdoHandleQueryInstanceId and increase serial number descriptor size to MAXIMUM_USB_STRING_LENGTH (#6413 )

Serial number on some USB devices might exceed the number of 100 characters
(e.g. 120 characters on "SanDisk Ultra 3.2Gen1" pendrive) and cause buffer
overflow, resulting in usbstor.sys crash.

- Use pool allocation for instance ID generation.
  Fixes stack overflow on USB storage devices with large serial number.
- Print the LUN number as a hexadecimal, not as a character.
- Verify the serial number descriptor before using it.
- Increase the max descriptor size for serial number to
  MAXIMUM_USB_STRING_LENGTH. This fixes serial number string truncation.

Based on suggestions by disean and ThFabba.

CORE-17625

2024-02-16 18:48:33 +03:00

Victor Perevertkin

d17d15ab6c

[FORMATTING][USBSTOR] Remove Captain Obvious and line-wasting comments.

Now the driver conforms with our current Coding Style.
No functional changes

2019-06-11 04:39:43 +03:00

Colin Finck

c2c66aff7d

Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.

2017-10-03 07:45:34 +00:00

Renamed from reactos/drivers/usb/usbstor/descriptor.c (Browse further)

3 commits