Doug Lyons
1b3eed58ca
[SHELL32] Fix for shlexec.cpp regressions ( #5282 )
...
fixes CORE-18967 'Taskbar toolbar - Right click > Open folder fails'
by restoring the code-path we removed with the guilty
0.4.15-dev-3847-g /9b716539182864bc077e362febcda74da50287ed
and add test_sei_lpIDList to shell32:ShellExecuteEx apitest test to protect
that functionality on future attempts to simplify.
2023-09-24 20:35:28 +00:00
Jose Carlos Jesus
f691efefc2
[SHLWAPI] No need extension to execute '.bat' files CORE-17612 ( #4932 )
...
When no extension is provided, add default extension with correct precedence using PathFileExistsDefExtW.
- Use PathFindOnPathExW when searching in current directory and PATH environment variable.
- Fix Width String terminator to UNICODE_NULL.
- Fix all failed tests on PathFindPathExW KVM test.
CORE-17612
2023-02-11 00:05:11 +09:00
Ratin Gao
5c22ce3742
[SHELL32] Remove unused flag SEE_MASK_UNICODE ( #5033 )
...
SEE_MASK_UNICODE does nothing, so we needn't mark it as "unsupported flag" and output FIXME
2023-02-10 23:56:13 +09:00
Katayama Hirofumi MZ
140aa11c36
[SHELL32] shlexec: Initial support of App Paths ( #4850 )
...
- Fix SHELL_TryAppPathW helper function by using SHRegQueryValueExW function.
- Fix SHRegQueryValueExA/W functions.
CORE-11335
2022-11-08 09:23:06 +09:00
Mark Jansen
d82185f104
[SDK] Define CCoInit in shellutils
2022-11-01 21:24:14 +01:00
Alex Miccolis
9b71653918
[SHELL32] Stop SHELL_execute from always executing files ( #4363 )
...
CORE-18038
Add a check (PathIsExeW) to SHELL_execute to prevent it from executing non-exe files.
2022-02-16 00:54:20 +01:00
Mark Jansen
ce306b83db
[SHELL32] Rename functions to fix ambiguity
2022-02-07 20:56:46 +01:00
Mark Jansen
93fac5533d
[SHELL32] ShellExecute: Retry after searching for the file in the SEE_MASK_INVOKEIDLIST case
...
CORE-18035
2022-02-07 20:56:46 +01:00
Mark Jansen
f6f5490ab4
[SHELL32] ShellExecute: Implement SEE_MASK_INVOKEIDLIST
...
CORE-18035
Also simplify some error handling by using smart pointers
2022-02-07 20:56:21 +01:00
Hermès Bélusca-Maïto
83be315abf
[SHELL32] Use wide char string literals.
...
Import parts of Wine commit b215536852dc5a132108db92c90a41c70b738e50
shell32: Use wide char string literals.
Signed-off-by: Alexandre Julliard <julliard@winehq.org>
2022-01-09 22:39:29 +01:00
Hermès Bélusca-Maïto
9393fc320e
[FORMATTING] Remove trailing whitespace. Addendum to 34593d93.
...
Excluded: 3rd-party code (incl. wine) and most of the win32ss.
2021-09-13 03:52:22 +02:00
Katayama Hirofumi MZ
d32858413d
[SHELL32] Command 'start C:' should open 'C:\' ( #2642 )
...
Based on JIRA user amaneureka's idea.
In SHELL_execute function, add a backslash for Drive "C:", "D:" or "E:" etc.
CORE-16384
2020-04-25 11:01:20 +09:00
Katayama Hirofumi MZ
fc11cf78ca
[SHELL32] Improve ShellExecCmdLine in path resolving ( #2397 )
...
Fix and improve private function shell32!ShellExecCmdLine to improve Run Dialog behavior. CORE-14409
2020-03-01 19:32:33 +09:00
Doug Lyons
4e721f780e
[SHELL32] Fix unneeded error Popup with Git for Windows. ( #1854 )
...
* Fix unnecessary error popup when installing Git for Windows.
* Add reasons for return value of 42.
2020-02-23 17:47:48 +01:00
Maxim Smirnov
06eb8cda99
[SHELL32] Fix extra fixme ( #1975 )
...
This patch removes this line from the log:
`fixme:(dll\win32\shell32\shlexec.cpp:1810) flags ignored: 0x00000004`
2020-01-02 13:35:32 +01:00
Katayama Hirofumi MZ
90c63d12a1
[SHELL32][BOOTDATA] Implement Command Prompt here ( #2029 )
...
Add "Command Prompt here" menu item to the Right-click menu of normal folders and drives. Currently, this menu item doesn't work correctly because of the bug of pushd. CORE-12150
2019-11-14 23:25:21 +09:00
Joachim Henze
0f16d44b66
[SHELL32] Improve ShellExecute
...
This fixes regression CORE-6412 and also fixes CORE-12927
by bringing us a bit closer to Wine implementation.
Thanks to patches author Doug Lyons.
The removed code looks like historic workaround code.
Automated tests do improve as well
VBox https://reactos.org/testman/compare.php?ids=68662,68696
KVM https://reactos.org/testman/compare.php?ids=68663,68697
I intend to merge this back into 0.4.12RC.
2019-08-06 20:24:55 +02:00
Katayama Hirofumi MZ
932a812c66
[SHELL32] Add backslash if path was like C: ( #1152 )
...
CORE-15434
2018-12-17 22:42:18 +09:00
Katayama Hirofumi MZ
c94ca8128d
[SHELL32] 'Run' dialog box should accept URL ( #1153 )
...
Fix ShellExecCmdLine function. CORE-15455, CORE-11772
2018-12-17 22:37:51 +09:00
Katayama Hirofumi MZ
db13b422b3
[SHELL32] Fix a careless mistake of ShellExecCmdLine ( #737 )
...
CORE-14886
2018-08-10 13:25:50 +02:00
Katayama Hirofumi MZ
bfcbda227f
[SHELL32] Fix handling of multiple parameters in the 'Run' dialog ( #665 )
...
The "Run" dialog failed when multiple parameters wee specified.
We use instead a newly-created ShellExecCmdLine() helper function to fix the problem (as found via API-tracing on Windows).
Note that ShellExecCmdLine() starts to be exported with Vista+.
- Implement ShellExecCmdLine() function in shell32.
- Add URL support.
- Fix RunDlgProc function in shell32.
- Add a testcase for ShellExecCmdLine() function.
CORE-14790
2018-08-05 13:39:17 +02:00
Katayama Hirofumi MZ
e018ccea4b
[SHELL32] lpDirectory must have priority in ShellExecuteEx ( #681 )
...
Based on a patch by Mark Jansen.
CORE-14469
2018-07-12 17:45:43 +02:00
Mark Jansen
3904fd6257
[SHELL32] Ensure OpenAs_RunDLL does not loop to infinity and beyond.
...
This should fix a timeout on the apitests.
2018-07-06 21:51:24 +02:00
Katayama Hirofumi MZ
cc8b2717ae
[SHELL32] Implement OpenAs_RunDLLA/W ( #628 )
...
CORE-14751
2018-06-24 19:46:06 +02:00
Colin Finck
c2c66aff7d
Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.
2017-10-03 07:45:34 +00:00
