Intravision/reactos

Fork 0

mirror of https://github.com/reactos/reactos.git synced 2024-08-06 11:24:58 +00:00

Commit graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Colin Finck	54a9cc5964	[0.4.7][PRINTING] Squashed 2 commits to fix regression CORE-14072 Symptom CORE-14072: '1C: Enterprise 8.2 Educational Edititon can't launch anymore due to "not enough memory" error' It regressed by SVN r74513 == git `5b6e082869` Actually the most important part of this fix are just the changes in win32ss/printing/base/winspool/printers.c func GetPrinterW() But I felt more safe when porting back the whole 2 fix-commits including the tests: --------------------------- [PRINTING] Fix GetPrinterW, add tests for it and GetDefaultPrinterA/W, and add a proper stub for GetPrinterDriverDirectoryA. * Pass the correct handle to _RpcGetPrinter in GetPrinterW. * Pass an empty string instead of a NULL pointer as wszComputerName to the GetPrinterLevel* functions, because this variable is later used as source for StringCbCopyExW. * Don't check for GetLastError() == ERROR_SUCCESS in tests. Windows apparently only sets the last error in case of failure. The Printing code should probably be changed similarly in a future commit. Should fix CORE-14072 fix picked from commit 0.4.8-dev-314-g `3a69fd4e96` ---------------------------- [WINSPOOL] Convert the returned Unicode string back to ANSI in GetDefaultPrinterA. Thanks to Mark for the hint in CORE-14072! fix picked from commit 0.4.8-dev-300-g `45b9b5c1ef`	2020-11-12 01:47:59 +01:00
Hermès Bélusca-Maïto	acdf04bad2	Add .keep guard files in order to restore lost but empty directories we had with SVN. Note that when you start populating these directories, you can remove the associated .keep guard file(s)!	2017-10-04 10:28:36 +02:00
Colin Finck	c2c66aff7d	Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys.	2017-10-03 07:45:34 +00:00

Colin Finck

54a9cc5964

[0.4.7][PRINTING] Squashed 2 commits to fix regression CORE-14072

Symptom CORE-14072: '1C: Enterprise 8.2 Educational Edititon can't launch anymore due to "not enough memory" error'

It regressed by SVN r74513 == git 5b6e082869
Actually the most important part of this fix are just the changes in win32ss/printing/base/winspool/printers.c func GetPrinterW()
But I felt more safe when porting back the whole 2 fix-commits including the tests:
---------------------------

[PRINTING] Fix GetPrinterW, add tests for it and GetDefaultPrinterA/W, and add a proper stub for GetPrinterDriverDirectoryA.

* Pass the correct handle to _RpcGetPrinter in GetPrinterW.
* Pass an empty string instead of a NULL pointer as wszComputerName to the GetPrinterLevel* functions, because this variable is later used as source for StringCbCopyExW.
* Don't check for GetLastError() == ERROR_SUCCESS in tests. Windows apparently only sets the last error in case of failure.
  The Printing code should probably be changed similarly in a future commit.

Should fix CORE-14072

fix picked from commit 0.4.8-dev-314-g
3a69fd4e96
----------------------------
[WINSPOOL] Convert the returned Unicode string back to ANSI in GetDefaultPrinterA.

Thanks to Mark for the hint in CORE-14072!

fix picked from commit 0.4.8-dev-300-g
45b9b5c1ef

2020-11-12 01:47:59 +01:00

Hermès Bélusca-Maïto

acdf04bad2

Add .keep guard files in order to restore lost but empty directories we had with SVN.

Note that when you start populating these directories, you can remove the associated .keep guard file(s)!

2017-10-04 10:28:36 +02:00

Colin Finck c2c66aff7d Git conversion: Make reactos the root directory, move rosapps, rostests, wallpapers into modules, and delete rossubsys. 2017-10-03 07:45:34 +00:00

3 commits