Commit graph

3064 commits

Author SHA1 Message Date
Jeff Smith
c8ef276778 [COMDLG32] Set background to transparent for font dialog sample text
Import Wine commit wine-5.19-325-g4273004e65a:
4273004e65

CORE-18588
2022-11-05 02:42:13 +03:00
Mark Jansen
2567a66399
[SHELL32] Fix CDefView UAF 2022-11-04 23:01:31 +01:00
Katayama Hirofumi MZ
1a1a8a8303
[SHELL32][INCLUDE] Fix PathResolve for double-backslash (#4833)
Co-authored-by: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito@reactos.org>

Fix shell32!PathResolve and shell32!PathQualifyExW functions for double-backslash. However it doesn't fix CORE-15204.
CORE-18080, CORE-15204
2022-11-04 21:44:46 +09:00
Hermès Bélusca-Maïto
25958a7c3d
[KERNEL32] Spec file: GetCurrencyFormatW takes wide strings in parameters. 2022-11-03 02:50:23 +01:00
Hermès Bélusca-Maïto
9f938ea3bb
[KERNEL32] Reformat K32CreateDBMonMutex(). 2022-11-03 02:50:20 +01:00
Mark Jansen
d82185f104
[SDK] Define CCoInit in shellutils 2022-11-01 21:24:14 +01:00
Artyom Ovsyannikov
b1854d7cad
[TRANSLATION] Minor Russian (ru-RU) translation fixes (#4835)
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
2022-11-01 17:22:18 +03:00
Hermès Bélusca-Maïto
d8cc88ca80
[KERNEL32][BASESRV] Fix interoperability with Win2k3 regarding NLS section security. (#4828)
Partially revert some aspects of commits 5696e4ba4 and bf40c7a31.
(See PR #4340.)

In order for Win2k3 kernel32.dll to operate with our basesrv.dll (or our
kernel32.dll to operate with Win2k3 basesrv.dll), we need in particular
to have the CreateNlsSecurityDescriptor() helper to exactly take the
expected parameters. Namely, a pointer to a **user-allocated**
SECURITY_DESCRIPTOR buffer, its size (and an access mask).

The function expects its caller to provide all this, and the caller expects
the function to initialize the security descriptor buffer. Note that the
function does *NOT* allocate a new descriptor buffer to be returned!

Indeed, with the way it currently is in master, using Win2k3 kernel32
with our basesrv is now failing with the errors:
```
NLSAPI: Could NOT Create ACL - c0000023.
(subsystems/win/basesrv/nls.c:279) NLS: CreateNlsSecurityDescriptor FAILED!: c0000023
NLSAPI: Could NOT initialize Server - c0000023.
(dll/ntdll/ldr/ldrinit.c:867) LDR: DLL_PROCESS_ATTACH for dll "kernel32.dll" (InitRoutine: 77E40D95) failed
```
(and, if we ever attempted to increase the so-claimed "dummy parameter"
descriptor size in the basesrv call, we would end up with its stack
corrupted and a crash).
Conversely, using our kernel32 with Win2k3 basesrv, would end up with
basesrv receiving a wrongly-initialized descriptor that would not work
(the buffer not being initialized with the contents of a descriptor, but
instead receiving some address to a descriptor allocated somewhere else).
2022-11-01 02:34:04 +01:00
Hermès Bélusca-Maïto
5bf0c00ddc
[KERNEL32] Minor code style changes + add documentation for BasepMoveFileDelayed().
+ cut the too long lines; don't hardcode types in sizeofs; correctly specify COPY_FILE_FAIL_IF_EXISTS flag.
2022-11-01 02:29:24 +01:00
Mark Jansen
a06f10d0c0
[BROWSEUI] Fix CAutoComplete use after free
CORE-18395
2022-10-27 23:45:18 +02:00
Justin Miller
98b90e7394
[DBGHELP] Add ARM64 definitions into compat.h (#4810)
This fixes ARM64 build in preparation for PR #4809.
CORE-18200
2022-10-27 18:14:10 +03:00
Mark Jansen
a0b1a01c59
[MSI] Add jira ticket to debug logging 2022-10-26 20:19:31 +02:00
Mark Jansen
21e68b0dba
[SHELL32] Fix empty 'Send to' menu
CORE-18517
2022-10-26 20:18:40 +02:00
Robert Naumann
b544640c29
[SHELL32] Update German (de-DE) translation (#4808)
Reviewed-by: Joachim Henze <joachim.henze@reactos.org>
2022-10-26 19:48:27 +03:00
Konrad Dybcio
b55658b396
[WININET] Update Polish (pl-PL) translation (#4811)
Reviewed-by: Adam Słaboń <asaillen@protonmail.com>
Reviewed-by: Stanislav Motylkov <x86corez@gmail.com>
2022-10-26 18:30:39 +03:00
Konrad Dybcio
97a61654c5
[BROWSEUI] Update Polish (pl-PL) translation (#4813) 2022-10-26 16:22:56 +03:00
Konrad Dybcio
e15490a2b8
[RASDLG] Fix typos in Polish (pl-PL) translation (#4812)
`tą` and `tę` are very often mistaken for each other by native speakers.
2022-10-26 16:22:05 +03:00
Katayama Hirofumi MZ
e1df4f2d8f
[IMM32] Add reasoning for tracing (#4807)
Follow-up of c2a9436 (#4798).
Improve trace messages.
CORE-11700
2022-10-26 12:01:33 +09:00
Katayama Hirofumi MZ
a65014e3a0 [IMM32] Add UNEXPECTED() macro for detailed debugging
CORE-11700
2022-10-23 12:49:37 +09:00
Katayama Hirofumi MZ
c2a943653e
[IMM32] Improve debuggability at all (#4798)
- Strengthen tracing.
- Introduce IS_NULL_UNEXPECTEDLY, IS_ZERO_UNEXPECTEDLY etc. macros to manage tracing.
CORE-11700
2022-10-23 09:51:24 +09:00
Joachim Henze
e6fb0e0c25
[SHELL32] Delete old unused implementation of OLD_SHAppBarMessage() (#4800)
SHAppBarMessage() was reimplemented at a different place by
0.4.14-dev-1209-g 10d1afea18
That was a reimport from Wine.
2022-10-22 21:48:11 +02:00
Katayama Hirofumi MZ
5166ffa447 [SHELL32] Improve Japanese translation (ja-JP) 2022-10-21 23:20:50 +09:00
Katayama Hirofumi MZ
5462d4adad [IMM32] Imm32InternalLockIMC: Unlock hIC on failure
CORE-11700
2022-10-21 16:40:25 +09:00
Katayama Hirofumi MZ
143ed5e72d [IMM32] Improve ImmSetCompositionFontA/W
CORE-11700
2022-10-21 16:37:59 +09:00
Katayama Hirofumi MZ
6585803681 [IMM32] Add uCodePage parameter to Imm32WideFromAnsi/Imm32AnsiFromWide
This needs for multiple codepage support.
CORE-11700
2022-10-21 16:04:59 +09:00
Katayama Hirofumi MZ
e1d3a7d08c [IMM32] Improve ImmGetCandidateWindow
CORE-11700
2022-10-21 15:22:06 +09:00
Katayama Hirofumi MZ
633ed86af2 [IMM32][INCLUDE] s/CLIENTIMC_UNKNOWN5/CLIENTIMC_ACTIVE/
CORE-11700
2022-10-21 13:21:02 +09:00
Katayama Hirofumi MZ
962c4557b5 [IMM32] Fix ImmSetActiveContext
CORE-11700
2022-10-21 13:08:49 +09:00
Katayama Hirofumi MZ
2865423abe [IMM32] Minor fix of ImmSetCompositionWindow
CORE-11700
2022-10-21 11:29:47 +09:00
Katayama Hirofumi MZ
b086f910d8 [IMM32] Fix and improve Imm32SelectInputContext
CORE-11700
2022-10-21 11:23:34 +09:00
Katayama Hirofumi MZ
edbeaa3c87 [IMM32] Move CtfImmTIMCreateInputContext calls
CORE-11700
2022-10-21 10:52:43 +09:00
Katayama Hirofumi MZ
db16a1f783 [IMM32] ImmGetImeInfoEx minor fix
CORE-11700
2022-10-21 10:40:38 +09:00
Katayama Hirofumi MZ
1f1dc9d84a [IMM32] s/ImmNt3Trans/WINNLSTranslateMessage/
CORE-11700
2022-10-21 10:32:33 +09:00
Katayama Hirofumi MZ
8f0e22ac23 [IMM32] Simplify Imm32WriteImeLayout
CORE-11700
2022-10-21 10:11:59 +09:00
Stanislav Motylkov
a8ee11e0ff
[HHCTRL.OCX] Fix toolbar icons order
In `hhtoolbar.bmp` the "Expand" icon comes first, then "Collapse".

Import Wine commit wine-7.19-39-g4f4b342ad44:
4f4b342ad4

CORE-12198
2022-10-20 21:20:36 +03:00
Katayama Hirofumi MZ
4572aad16a [IMM32][INCLUDE] s/IMEDPI_FLAG_UNKNOWN/IMEDPI_FLAG_UNLOADED/
CORE-11700
2022-10-20 13:50:37 +09:00
Katayama Hirofumi MZ
27cc079d90 [IMM32] Fix ImeDpi_Escape by adding !IS_16BIT_MODE()
CORE-11700
2022-10-20 13:48:11 +09:00
Katayama Hirofumi MZ
91e3d06cdb [IMM32] Fix and improve Imm32InquireIme
CORE-11700
2022-10-20 12:47:15 +09:00
Katayama Hirofumi MZ
72c56c2f1f [IMM32] Improve ImmAssociateContext readability
CORE-11700
2022-10-20 12:32:45 +09:00
Katayama Hirofumi MZ
f9b2b1a6cd [IMM32] Use UNICODE_NULL for null characters
CORE-11700
2022-10-20 12:29:29 +09:00
Katayama Hirofumi MZ
378d0e814c [IMM32] ImmTranslateMessage: Minor fix
CORE-11700
2022-10-20 11:32:23 +09:00
Katayama Hirofumi MZ
4af3372c23 [IMM32] s/Imm32PostMessages/ImmPostMessages/
CORE-11700
2022-10-20 11:29:33 +09:00
Stanislav Motylkov
43ecf7e4e4
[SHELL32] Add missing strings for desktop icons
Reuse existing translations where possible.

CORE-8427
2022-10-19 21:00:22 +03:00
Mark Jansen
0452d3415a
[SHELL32] Fix 'Paste' command in context menu not working
Bug found by Rosen Iliev
2022-10-19 19:38:33 +02:00
Mark Jansen
5bd86b8487
[SHELL32] Fix menu item handling
This restores the 'properties' functionality on the desktop
Bug found by Hervé Poussineau
2022-10-19 19:37:41 +02:00
Mark Jansen
7b33915adc
[SYSSETUP] Add support for shortcut arguments 2022-10-19 19:36:26 +02:00
Mark Jansen
b448fbdf59
[SHELL32] Fix using the wrong context menu 2022-10-15 11:09:25 +02:00
Mark Jansen
57d0e1d207
[SHELL32] Remove unused function 2022-10-15 00:01:45 +02:00
Mark Jansen
6a9696f10b
[SHELL32] CFolderItemVerb: Zero-initialize output parameters 2022-10-14 21:04:19 +02:00
Mark Jansen
9efa7cc498
[SHELL32] Fix CDefaultContextMenu DFM_MERGECONTEXTMENU handling 2022-10-14 21:04:19 +02:00