From fe141a8bf24473b8276bbb9c4a601f50cf7acbc6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herm=C3=A8s=20B=C3=A9lusca-Ma=C3=AFto?=
 <hermes.belusca-maito@reactos.org>
Date: Wed, 13 Dec 2023 19:06:38 +0100
Subject: [PATCH] ** WIP ** SETUPAPI: Improve do_file_copyW: Generate a
 temporary file path based on the target path (thus, ensured to be writable)

Needed because we may run setupapi to extract and copy files to a
writable target directory, from a read-only ReactOS installation
(e.g. livecd)
---
 dll/win32/setupapi/queue.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/dll/win32/setupapi/queue.c b/dll/win32/setupapi/queue.c
index d908c92a0ef..ca554fcaefa 100644
--- a/dll/win32/setupapi/queue.c
+++ b/dll/win32/setupapi/queue.c
@@ -1237,6 +1237,7 @@ static BOOL do_file_copyW( LPCWSTR source, LPCWSTR target, DWORD style,
 #ifdef __REACTOS__
     INT hSource, hTemp;
     OFSTRUCT OfStruct;
+    PWSTR pTmpFile;
     WCHAR TempPath[MAX_PATH];
     WCHAR TempFile[MAX_PATH];
     LONG lRes;
@@ -1246,22 +1247,21 @@ static BOOL do_file_copyW( LPCWSTR source, LPCWSTR target, DWORD style,
     TRACE("copy %s to %s style 0x%lx\n",debugstr_w(source),debugstr_w(target),style);
 
 #ifdef __REACTOS__
-    /* Get a temp file name */
-    if (!GetTempPathW(ARRAYSIZE(TempPath), TempPath))
-    {
-        ERR("GetTempPathW error\n");
-        return FALSE;
-    }
+    /* Generate a temporary file path and name based on the target path */
+    wcsncpy(TempPath, target, ARRAYSIZE(TempPath));
+    TempPath[ARRAYSIZE(TempPath) - 1] = UNICODE_NULL;
+    pTmpFile = (PWSTR)pSetupGetFileTitle(TempPath); // Remove the file name
+    *pTmpFile = UNICODE_NULL;
 
     /* Try to open the source file */
     hSource = LZOpenFileW((LPWSTR)source, &OfStruct, OF_READ);
     if (hSource < 0)
     {
-        TRACE("LZOpenFileW(1) error %d %s\n", (int)hSource, debugstr_w(source));
+        TRACE("LZOpenFileW(1) error %d (%s)\n", hSource, debugstr_w(source));
         return FALSE;
     }
 
-    if (!GetTempFileNameW(TempPath, L"", 0, TempFile))
+    if (!GetTempFileNameW(TempPath, L"SET", 0, TempFile))
     {
         dwLastError = GetLastError();
 
@@ -1282,7 +1282,7 @@ static BOOL do_file_copyW( LPCWSTR source, LPCWSTR target, DWORD style,
     {
         dwLastError = GetLastError();
 
-        ERR("LZOpenFileW(2) error %d %s\n", (int)hTemp, debugstr_w(TempFile));
+        ERR("LZOpenFileW(2) error %d (%s)\n", hTemp, debugstr_w(TempFile));
 
         /* Close the source handle */
         LZClose(hSource);
@@ -1305,7 +1305,7 @@ static BOOL do_file_copyW( LPCWSTR source, LPCWSTR target, DWORD style,
 
     if (lRes < 0)
     {
-        ERR("LZCopy error %d (%s, %s)\n", (int)lRes, debugstr_w(source), debugstr_w(TempFile));
+        ERR("LZCopy error %d (%s, %s)\n", lRes, debugstr_w(source), debugstr_w(TempFile));
 
         /* Delete temp file if copy was not successful */
         DeleteFileW(TempFile);