Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2025-02-23 08:55:19 +00:00
Code Issues Projects Releases Packages Wiki Activity

[NTOSKRNL] Use better locking for private cache map in CcRosReleaseFileCache().

Browse source 
Suggested by Thomas
This commit is contained in:
Pierre Schweitzer 2018-02-09 11:05:15 +01:00
parent c5139563db
commit fc4744da5f
No known key found for this signature in database
GPG key ID: 7545556C3D585B0B
1 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
ntoskrnl/cc/view.c
View file

@ -1171,6 +1171,8 @@ CcRosReleaseFileCache (
* has been closed. * has been closed.
*/ */
{ {
KIRQL OldIrql;
PPRIVATE_CACHE_MAP PrivateMap;
PROS_SHARED_CACHE_MAP SharedCacheMap; PROS_SHARED_CACHE_MAP SharedCacheMap;
KeAcquireGuardedMutex(&ViewLock); KeAcquireGuardedMutex(&ViewLock);
@ -1178,27 +1180,25 @@ CcRosReleaseFileCache (
if (FileObject->SectionObjectPointer->SharedCacheMap != NULL) if (FileObject->SectionObjectPointer->SharedCacheMap != NULL)
{ {
SharedCacheMap = FileObject->SectionObjectPointer->SharedCacheMap; SharedCacheMap = FileObject->SectionObjectPointer->SharedCacheMap;
if (FileObject->PrivateCacheMap != NULL)
/* Closing the handle, so kill the private cache map
* Before you event try to remove it from FO, always
* lock the master lock, to be sure not to race
* with a potential read ahead ongoing!
*/
OldIrql = KeAcquireQueuedSpinLock(LockQueueMasterLock);
PrivateMap = FileObject->PrivateCacheMap;
FileObject->PrivateCacheMap = NULL;
KeReleaseQueuedSpinLock(LockQueueMasterLock, OldIrql);
if (PrivateMap != NULL)
{ {
KIRQL OldIrql;
PPRIVATE_CACHE_MAP PrivateMap;
/* Closing the handle, so kill the private cache map */
PrivateMap = FileObject->PrivateCacheMap;
/* Remove it from the file */ /* Remove it from the file */
KeAcquireSpinLock(&SharedCacheMap->CacheMapLock, &OldIrql); KeAcquireSpinLock(&SharedCacheMap->CacheMapLock, &OldIrql);
RemoveEntryList(&PrivateMap->PrivateLinks); RemoveEntryList(&PrivateMap->PrivateLinks);
KeReleaseSpinLock(&SharedCacheMap->CacheMapLock, OldIrql); KeReleaseSpinLock(&SharedCacheMap->CacheMapLock, OldIrql);
/* And free it. /* And free it. */
* Before you event try to remove it from FO, always
* lock the master lock, to be sure not to race
* with a potential read ahead ongoing!
*/
OldIrql = KeAcquireQueuedSpinLock(LockQueueMasterLock);
FileObject->PrivateCacheMap = NULL;
KeReleaseQueuedSpinLock(LockQueueMasterLock, OldIrql);
ExFreePoolWithTag(PrivateMap, TAG_PRIVATE_CACHE_MAP); ExFreePoolWithTag(PrivateMap, TAG_PRIVATE_CACHE_MAP);
if (SharedCacheMap->OpenCount > 0) if (SharedCacheMap->OpenCount > 0)