Intravision/reactos
1
0
Fork 0
mirror of https://github.com/reactos/reactos.git synced 2024-06-28 08:51:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CMAKE]

Browse source 
We have a zero-warnings policy in trunk, accordingly:
- Disable overflow warnings in mciwave
- Remove all -Wno-error directives
- Remove all allow_warnings invocations
- Make allow_warnings defunct, it needs to be reworked, e.g. according to CORE-6959.

svn path=/trunk/; revision=67291
This commit is contained in:
Thomas Faber 2015-04-19 08:39:58 +00:00
parent 5e3f9799d4
commit f5a19bfe31
9 changed files with 7 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
reactos/cmake/gcc.cmake
View file

@ -116,11 +116,8 @@ add_compile_flags("-Wno-char-subscripts -Wno-multichar -Wno-unused-value")
if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
add_compile_flags("-Wno-maybe-uninitialized")
add_compile_flags("-Wno-error=unused-but-set-variable")
endif()
add_compile_flags("-Wno-error=type-limits")
if(ARCH STREQUAL "amd64")
add_compile_flags("-Wno-format")
elseif(ARCH STREQUAL "arm")
@ -427,7 +424,8 @@ function(CreateBootSectorTarget _target_name _asm_file _binary_file _base_addres
endfunction()
function(allow_warnings __module)
add_target_compile_flags(${__module} "-Wno-error")
# We don't allow warnings in trunk, this needs to be reworked. See CORE-6959.
#add_target_compile_flags(${__module} "-Wno-error")
endfunction()
macro(add_asm_files _target)

1
reactos/dll/3rdparty/libtiff/CMakeLists.txt vendored
View file

@ -59,7 +59,6 @@ add_pch(libtiff precomp.h SOURCE)
add_cd_file(TARGET libtiff DESTINATION reactos/system32 FOR all)
if(NOT MSVC)
allow_warnings(libtiff)
if(NOT CMAKE_C_COMPILER_ID STREQUAL "Clang")
add_target_compile_flags(libtiff "-Wno-unused-but-set-variable")
endif()

1
reactos/dll/opengl/mesa/main/CMakeLists.txt
View file

@ -73,6 +73,5 @@ add_library(mesa_main STATIC ${SOURCE})
add_pch(mesa_main precomp.h SOURCE)
if(NOT MSVC)
allow_warnings(mesa_main)
add_target_compile_flags(mesa_main "-Wno-type-limits")
endif()

1
reactos/dll/opengl/mesa/swrast/CMakeLists.txt
View file

@ -32,5 +32,4 @@ add_pch(mesa_swrast precomp.h SOURCE)
if(NOT MSVC)
add_target_compile_flags(mesa_swrast "-Wno-unused-variable")
allow_warnings(mesa_swrast)
endif()

2
reactos/dll/win32/mciwave/CMakeLists.txt
View file

@ -17,5 +17,5 @@ add_importlibs(mciwave user32 winmm msvcrt kernel32 ntdll)
add_cd_file(TARGET mciwave DESTINATION reactos/system32 FOR all)
if(NOT MSVC)
add_target_compile_flags(mciwave "-Wno-error=overflow")
add_target_compile_flags(mciwave "-Wno-overflow")
endif()

4
reactos/drivers/storage/class/disk_new/CMakeLists.txt
View file

@ -16,8 +16,8 @@ target_link_libraries(disk_new libcntpr wdmguid)
if((ARCH STREQUAL "i386") AND (NOT MSVC))
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
#add_target_compile_flags(disk_new "-Wno-error -Wno-format -Wno-pointer-sign")
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error -Wno-format -Wno-pointer-sign")
#add_target_compile_flags(disk_new "-Wno-format -Wno-pointer-sign")
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-format -Wno-pointer-sign")
endif()
set_module_type(disk_new kernelmodedriver)

5
reactos/drivers/storage/classpnp/CMakeLists.txt
View file

@ -33,11 +33,6 @@ add_library(classpnp SHARED
class.rc
${CMAKE_CURRENT_BINARY_DIR}/classpnp.def)
if((ARCH STREQUAL "i386") AND (NOT MSVC))
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-error=unused-but-set-variable -Wno-error=unused-variable -Wno-error=switch")
endif()
add_pch(classpnp classp.h SOURCE)
target_link_libraries(classpnp ${PSEH_LIB} libcntpr)
set_module_type(classpnp kernelmodedriver)

5
reactos/drivers/wdm/audio/drivers/CMIDriver/CMakeLists.txt
View file

@ -26,9 +26,8 @@ add_importlibs(cmipci portcls hal ntoskrnl)
if(NOT MSVC)
# FIXME: http://www.cmake.org/Bug/view.php?id=12998
#add_target_compile_flags(portcls "-Wno-write-strings -Wno-switch")
#allow_warnings(portcls)
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-write-strings -Wno-switch -Wno-error")
#add_target_compile_flags(cmipci "-Wno-write-strings -Wno-switch")
set_source_files_properties(${SOURCE} PROPERTIES COMPILE_FLAGS "-Wno-write-strings -Wno-switch")
endif()
add_pch(cmipci precomp.h SOURCE)

1
rostests/winetests/ntdll/CMakeLists.txt
View file

@ -34,6 +34,5 @@ add_importlibs(ntdll_winetest user32 msvcrt kernel32 ntdll)
add_cd_file(TARGET ntdll_winetest DESTINATION reactos/bin FOR all)
if(NOT MSVC)
allow_warnings(ntdll_winetest)
add_target_compile_flags(ntdll_winetest "-Wno-format")
endif()